<Swing Dev> Integrated: 8049301: Suspicious use of string identity checks in JComponent.setUIProperty

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Fri Jul 30 15:43:33 UTC 2021


On Fri, 30 Jul 2021 06:04:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> JComponent.setUIProperty method uses string identity check (==) rather than string equality checks (.equals) when comparing against the property name. This is suspicious since string identity and equality and equivalent only for interned strings. 
> Rectified to use String.equals() check.

This pull request has now been integrated.

Changeset: baf7797b
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/baf7797b092704d7dc9401db8b3dda19b91be303
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8049301: Suspicious use of string identity checks in JComponent.setUIProperty

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.java.net/jdk/pull/4943


More information about the swing-dev mailing list