<Swing Dev> RFR: 8268087: Update documentation of the JPasswordField

Phil Race prr at openjdk.java.net
Thu Jun 3 00:48:37 UTC 2021


On Thu, 3 Jun 2021 00:31:22 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
>> 
>>> 62:  * <p>
>>> 63:  * <strong>Warning:</strong> The text entered in {@code JPasswordField} displays
>>> 64:  * something that was typed and does not show the original characters. This
>> 
>> "something that was typed" ? That reads to me as if it displays the characters you typed which isn't what you mean
>> 
>> the whole sentence is weird
>> 
>> Let's change this to
>> Although the text displayed in {@code JPasswordField} does not show the actual password characters typed,  this does not prevent ...
>
> The "something was typed" text is used already in the description of the JPasswordField, in the first sentence.
> 
> Not sure that the word "text" in the "Although the text displayed" is the correct one. It is not necessary a "text" but "something"

The previous text you refer to is presumably
"where the view indicates  something was typed,"

that is fine. Your text is trying to say something else AND you added the word that which means you are referring to the specific thing .. 

So you can't just copy and edit that.

And "text" in my version is fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4296


More information about the swing-dev mailing list