<Swing Dev> RFR: 6251901: BasicTextUI: installDefaults method are contrary to the documentation

[Alexey Ivanov]

On Tue, 9 Mar 2021 13:34:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> BasicTextUI: installDefaults javadoc specifies only font, foreground and background properties are set  if their current value is either null or a UIResource
>> and other properties are set if the current value is null
>> but in reality all properties such as font, foreground, background, caret color, selection color, selected text color, disabled text color, and border color are set if their current value is either null or a UIResource.
>> Fixed the javadoc to specify the same.
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 306:
> 
>> 304:      * Initializes component properties, such as font, foreground,
>> 305:      * background, caret color, selection color, selected text color,
>> 306:      * disabled text color, and border color.  All properties are set
> 
> This method is also affects a margin, but it is does not mentioned in the javadoc.

Does the list of properties listed in the javadoc have to be comprehensive? However, `margin` seems to be the only property omitted from the list.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2888