<Swing Dev> RFR: 6251901: BasicTextUI: installDefaults method are contrary to the documentation [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Wed Mar 10 12:16:09 UTC 2021
On Wed, 10 Mar 2021 11:49:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> copyright change
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 306:
>
>> 304: * Initializes component properties, such as font, foreground,
>> 305: * background, caret color, selection color, selected text color,
>> 306: * disabled text color, border and margin. Each property is set
>
> Suggestion:
>
> * disabled text color, border, and margin. Each property is set
> I suggest keeping the command before “and” as it was before.
I think these are nouns and as per I know, we shouldn't place comma before "and" when we are simply listing the items.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2888
More information about the swing-dev
mailing list