<Swing Dev> RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing [v2]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Mon Mar 15 04:23:27 UTC 2021


On Fri, 12 Mar 2021 21:36:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> src/java.desktop/share/classes/javax/swing/JComponent.java line 659:
> 
>> 657: 
>> 658:     /**
>> 659:      * Resets the UI property to a value from the current look and feel.
> 
> Shall it rather use plural?
> Suggestion:
> 
>      * Resets the UI properties to values from the current look and feel.
> There are usually several properties that get updated, *all the properties* in fact.

I see that all subclass of JComponent implementing updateUI() cites this sentence so changing only here may not be proper unless we change it everywhere, so I guess let it be as it is.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2955


More information about the swing-dev mailing list