<Swing Dev> RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing [v2]

Alexey Ivanov aivanov at openjdk.java.net
Mon Mar 15 18:09:20 UTC 2021


On Mon, 15 Mar 2021 17:37:07 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> src/java.desktop/share/classes/javax/swing/JComponent.java line 660:
> 
>> 658:     /**
>> 659:      * Resets the UI property to a value from the current look and feel.
>> 660:      * Since the default implementation of this method doesn't do anything,
> 
> The reason why this method should be overridden is that the subclasses only can implement it properly, and it is not because the current method is empty.
> 
> Probably we can move the new text to the @implnote tag?

Yet specifying that this method is empty implies overridden methods do not need to call `super.updateUI()`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2955


More information about the swing-dev mailing list