<Swing Dev> RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing [v3]

Alexey Ivanov aivanov at openjdk.java.net
Tue Mar 16 12:14:09 UTC 2021


On Tue, 16 Mar 2021 04:22:27 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It's unclear from the spec that the original implementation of the method JComponent.updateUI() does nothing which needs to be explicitly stated in the javadoc.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added @implnote

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JComponent.java line 660:

> 658:     /**
> 659:      * Resets the UI property to a value from the current look and feel.
> 660:      * @implnote Since the default implementation of this method doesn't do anything,

Suggestion:

     * @implNote Since the default implementation of this method doesn't do anything,
The correct tag is `@implNote` with capital N.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2955


More information about the swing-dev mailing list