<Swing Dev> RFR: 8263472: Specification of JComponent::updateUI doesn't mention that the original implementaiton does nothing [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Tue Mar 16 12:43:06 UTC 2021


On Tue, 16 Mar 2021 12:26:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It was suggested to use @implnote tag and I saw that couple of places in jdk repo, we used that in Unsafe.java and TrayIcon.java so I used that, although in majority of places, @implNote is used, so I thought maybe both can be used at our discretion.
>> Anyway, will change to @implNote.
>
> I understand it. I just built the docs to see how it looks and the text after `@implnote` was missing — it's absolutely wrong this way. With `@implNote`, the text is displayed below *Implementation Note:* sub-heading.

I can remove `Since` and have "@implNote The default implementation of this method doesn't do anything.
leaving other sentence `<code>JComponent</code> subclasses must override this method` separate. I guess that will keep the spec same as before and also keep the submitter satisfied.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2955


More information about the swing-dev mailing list