<Swing Dev> RFR: 8263768: JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() spec doesn't mention what the default impls return and what does it mean [v2]

[Alexey Ivanov]

On Fri, 19 Mar 2021 08:59:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Default implementation of JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() returns null but it is not mentioned in the spec.
>> It is now explicitly mentioned in the spec by @impNote tag.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @implNote change

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JFormattedTextField.java line 1089:

> 1087: 
> 1088:         /**
> 1089:          * Subclass must override if you wish to provide a

It think the original text was correct: Subclass was used as a verb in imperative. You have to *subclass* before you can override.

src/java.desktop/share/classes/javax/swing/JFormattedTextField.java line 1108:

> 1106:          * the <code>JFormattedTextField</code>.
> 1107:          *
> 1108:          * @implNote The default implementation returns <code>null</code>

Suggestion:

         * @implNote The default implementation returns <code>null</code>.
Full stop for consistency.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3064