<Swing Dev> RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

Alexander Zvegintsev azvegint at openjdk.java.net
Tue Mar 23 14:55:58 UTC 2021


> Looks like the original idea was to set `fallbacktext` on strings containing only spaces.
> 
> I decided to remove the `trim()` call to keep the same behavior and to allows to set such meaningless space only titles/tooltips(same as on other platforms, maybe someone want empty label for some reason).

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  allow empty text

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3136/files
  - new: https://git.openjdk.java.net/jdk/pull/3136/files/06c5322d..9e4f2a35

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3136&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3136&range=00-01

  Stats: 8 lines in 1 file changed: 0 ins; 2 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3136.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3136/head:pull/3136

PR: https://git.openjdk.java.net/jdk/pull/3136


More information about the swing-dev mailing list