<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v4]
Alexander Zuev
kizune at openjdk.java.net
Sat May 8 00:19:24 UTC 2021
On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
>>
>>> 62: }
>>> 63:
>>> 64: if (icon.getIconWidth() != size) {
>>
>> Does it make sense to check that the icon is a multi-resolution image with the expected sizes?
>> We know for sure `explorer.exe` contains the entire set of icons.
>
> Since the test always expects a multi-resolution image, does it make sense to assert `icon instanceof MultiResolutionImage` at the very least?
Ok, added testing for multiresolution icon.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2875
More information about the swing-dev
mailing list