<Swing Dev> RFR: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS [v2]

Sat May 8 16:07:01 UTC 2021

On Sat, 8 May 2021 06:43:44 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> I will still urge to bring the frame to middle to be more safe.

Ok, not that it makes any difference so there you go.

> BTW, greenFrame and redFrame screencapture are needed only in failure case so I guess those should be called if compare fails.

Well, when comparison fails it is kind of too late to get "Before" and "After" screenshots, because "Before" is no longer there and "After" can also not be the same. And i'm saving these screenshots only if comparison fails so the performance impact is negligible.

> Also, dispose should be called in EDT same way we are doing a little bit afterwards..

Ok, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3844