<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v3]

[Alexey Ivanov]

On Fri, 7 May 2021 17:30:15 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java line 213:
>> 
>>> 211:      * Returns the icon of the specified size used to display this shell folder.
>>> 212:      *
>>> 213:      * @param size size of the icon > 0 (Valid range: 1 to 256)
>> 
>> I'm unsure the valid range of 1 to 256 makes sense provided the icon smaller than 16×16 is never returned (on Windows at least).
>
> Well, user still can request 1x1 icon - we will return the multiresolution image with minimal (1x1) icon inside that will be scaled every time the actual painting occurs. The size will define the layout of the component with the icon and can be auto-generated from the user code so i do not see why we should limit the lowest requested size - especially in the shared instance that not only specific for Windows platform.

Even though 1×1 icon doesn't make much sense, you're right imposing a limitation is no good either.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875