<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v4]

[Alexander Zuev]

On Tue, 11 May 2021 10:07:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Small fixes
>>    Added testing for MultiResolutionImage
>>  - Merge remote-tracking branch 'origin/master' into JDK-8182043
>>  - Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>>    
>>    Select one icon at a time.
>>    
>>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>>  - Small fixes
>>    Remived size parameter from makeIcon
>>    Removed useVGAColors usage as irrelevant since it is ignored on all
>>    supported platforms now
>>  - 8182043: Access to Windows Large Icons
>>    Fix updated based on the previous review.
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 267:
> 
>> 265:     * returned will be a multi-resolution icon image,
>> 266:     * which will allow better scaling with different
>> 267:     * scaling factors.
> 
> “…which will allow better support for High DPI environments with different scaling factors.” — does it look better?
> “scaling with … scaling factors” doesn't sound good to me.

Yes, much better. I updated the wording and once the PR is approved i will fix it in CSR too.

> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1098:
> 
>> 1096:                                         imageCache = getLargeIcon ? smallSystemImages : largeSystemImages;
>> 1097:                                     }
>> 1098:                                     newIcon2 = imageCache.get(Integer.valueOf(index));
> 
> Probably, explicit boxing is unnecessary.

Removed.

> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 929:
> 
>> 927:     }
>> 928:     HRESULT hres;
>> 929:     IExtractIconW* pIcon;
> 
> `pIcon->Release()` must be called before returning as done in `extractIcon`.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875