<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v6]

Alexander Zuev kizune at openjdk.java.net
Fri May 14 18:47:42 UTC 2021


On Fri, 14 May 2021 13:30:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make getShell32Icon method return multi-resolition image in case of
>>   requested icon size and actual icon size mismatch.
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 266:
> 
>> 264:     * {@code ShellFolder} class. Whenever possible, the icon
>> 265:     * returned will be a multi-resolution icon image,
>> 266:     * which will allow better support for High DPI environments
> 
> I'm not sure but probably “…which allows better…” is more grammatical, as well as in the line above: “the icon returned is a multi-resolution”.
> 
> Phil or Joe could correct this.

Agree.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875


More information about the swing-dev mailing list