<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v10]

[Sergey Bylokhov]

On Thu, 20 May 2021 07:30:00 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty <p> tag before @implSpec causes warning during javadoc generation

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 272:

> 270:     * returned is a multi-resolution icon image,
> 271:     * which allows better support for High DPI environments
> 272:     * with different scaling factors.

Is the above text correct on all platforms? If it is not always MRI then how the user should use the icon? instanceof+cast? BTW an example does not show how to solve the bug itself, on how to access the "large icons".

Need to clarify: the implSpec is a part of the specification so can we point the non public "ShellFolder" class?

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 275:

> 273:     *
> 274:     * @param f a {@code File} object
> 275:     * @param size width and height of the icon in virtual pixels

What are the "virtual pixels"? I remember we refer to something similar by the point in the "user space coordinate system" Or probably we use the virtual pixels somewhere?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875