<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v10]

[Alexander Zuev]

On Thu, 20 May 2021 08:25:25 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The @implSpec is part of the specification, it is different from the @implNote, no?
> https://bugs.openjdk.java.net/browse/JDK-8266541?focusedCommentId=14419988&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14419988
> 
> If we will specify this method in a way that will require support on all platforms we will get tck-red immediately after this push.

Not exactly. The implNote is a note for future maintainers or people who will extend the functionality of the method. There will be no tck-red because the method is working and we did noted that we are taking into consideration the icon size and whenever technical possible we should return the multiresolution icon. So, for example, on Linux code
`        FileSystemView fsv = FileSystemView.getFileSystemView();

        Icon icon = fsv.getSystemIcon(new File("."));
        Icon icon2 = fsv.getSystemIcon(new File("."), 16);
        System.out.println("icon = " + icon);
        System.out.println("icon2 = " + icon2);
`
will get icon and icon2 as the same single-resolution icon - but that will change when underlying implementation will be fixed. Right now it is not technical possible to return multi-resolution icon - we do not do it on Linux. Implementing the underlaying code for different system, as i said, is outside of the scope of this change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875