<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v10]
Sergey Bylokhov
serb at openjdk.java.net
Thu May 20 22:41:51 UTC 2021
On Thu, 20 May 2021 19:25:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
>> Here I am not talking about specification, I am talking about the usage of it, is the instanceof+cast is helpful? It does not look good, why we cannot always return MRI?
>
>> Here I am not talking about specification, I am talking about the usage of it, is the instanceof+cast is helpful?
>
> It is necessary until all the consequences of always returning of MRI is extensively tested on all the supported platforms and it does not cause any serious regression or visual degradations. So for now i would not enforce MRI usage in this method which means use base image class instead and do the cast later.
I did not get how you will be able to force use MRI later since this method is implemented as a return icon. So this choice should be made before integration.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2875
More information about the swing-dev
mailing list