<Swing Dev> RFR: 8182043: Access to Windows Large Icons [v7]

[Alexander Zuev]

On Fri, 21 May 2021 03:21:19 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The JFileChooser supports the libraries since it allows navigation inside them. It is done via ShellFolder which extends the file class. The FileSystemView feeds the JFileChooser by the data, so it may returns "non-file" objects.
>> For example the FileSystemView.getRoots() on WIndows will return "new Win32ShellFolder2(DESKTOP)".
>> 
>> Usually, when the FileSystemView gets a file object it checks that the file is "instance ShellFolder".
>> For example, in the newly added method the line "sf = ShellFolder.getShellFolder(f);" will check that the file is ShellFolder and return it as-is without checking of file existence, and really that path may not exist. but if it is a plain file it will check that.
>> 
>> This is why I have asked about virtual folders, do we test them or we can consider them as "not existed"?
>
> Maybe we can test this case by just reusing this method where the "sf.getIcon(largeicon)" previously used in the WindowsPlacesBar class? That old method has the special code for "folder.isLibrary()" so I assume it supported the Libraries. And if we will start to use the new method then all old tests for the JFileChooser will start to test it.

What is the library a collection folder such as Recent Items or Documents?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2875