<Swing Dev> RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled

[Prasanta Sadhukhan]

On Thu, 2 Sep 2021 04:46:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> In MenuArrowIcon, the arrow icon is drawn there itself using drawPolygon but in Aqua, it is drawn via imageicon image so it will be a change in design and will make it more complex and it might introduce bug in hidpi/retina. I will like to keep it simple following the current design in aqua.
>
> On windows it is painted via skin, I guess in GTK as well. But it really does not matter how it is drawn, the important part is that the icon itself knows how to draw proper appearance.

In other L&Fs, it creates their own icon 
for ex, MetalLookAndFeel
"MenuItem.arrowIcon",(LazyValue) t -> MetalIconFactory.getMenuItemArrowIcon(),
and WindowsLookAndFeel
"MenuItem.arrowIcon", menuItemArrowIcon,

but for AquaL&F it does not create it's own factory icon and rely on BasicIconFactory$MenuItemArrowIcon, so tweaking aqua arrow icon inline with how other do will cause design change, so I think this fix caters to the problem in view of this aqua limitation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5310