<Swing Dev> RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]

Pankaj Bansal pbansal at openjdk.java.net
Sat Sep 4 13:04:48 UTC 2021


On Mon, 23 Aug 2021 17:05:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Comments
>
>> > I wonder how the other components handle that. For example, the JComboBox in Aqua L&F is a "compound" element and it contains a text field and button, what does the "getComponentCount" return in that case, wIll we hide internal data from the user?
>> 
>> I just ran the following test for JComboBox for all L&Fs on my Mac. It fails for everyone of them. The test and output is as below. Looks like this test is not being run for all components for all L&Fs. It should give lot of failures I guess.
> 
> Yep not unexpected which is why I said this needed to be documented at least as high up as JComponent.
> And FWIW since nothing said that JComponents are created with no children it is a very weak bug/complaint to begin with !

Gentle Reminder to the reviewers @prrace @mrserb

-------------

PR: https://git.openjdk.java.net/jdk/pull/5121


More information about the swing-dev mailing list