<Swing Dev> RFR: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable

[Jayathirth D V]

On Mon, 23 Aug 2021 12:32:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> It is seen that  if a JTabbedPane is unfocused, it's title is painted with **white** text on grey background 
> as opposed to **black** text on grey background in unfoucsed native app on macOSX Catalina
> and is somewhat not legible. 
> This can be seen with SwingSet2 demo with InternalFrame or JTabbedPane demo and any native app, making focus toggle between the two.
> 
> Issue was TabbedPane always draw with "selectedTabTitleNormalColor" which is white. Although Aqua L&F defined selectedTabTitleDisabledColor but it is not used as TabbedPane does not check if focus is there in current frame and draw accordingly, which native app does.
> 
> Proposed fix is to check for frame is active or not and draw text color accordingly. 
> Since it is not affecting BigSur (where even if native app active or not text is always drawn in same color), it is only restricted to Catalina and lower.

Code change looks good to me. Any reason why we dont have regression test for this change? I think we can add simple TabbedPane scenario for non BigSur use case and read pixel data. Also there is no "noreg-*" label in JBS.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5217