<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Prasanta,<div class=""><br class=""></div><div class="">Thanks for the review. Here is the updated webrev: <a href="http://cr.openjdk.java.net/~kaddepalli/8218674/webrev01/" class="">http://cr.openjdk.java.net/~kaddepalli/8218674/webrev01/</a></div><div class=""><br class=""></div><div class="">The check (newWidth>0) && (newHeight > 0) is done in adjustWidthHeight function.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Krishna<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 04-Mar-2019, at 1:29 PM, Prasanta Sadhukhan <<a href="mailto:prasanta.sadhukhan@oracle.com" class="">prasanta.sadhukhan@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""><p class="">Hi Krishna,<br class="">
</p><p class="">You can reuse existing method <span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">getLoadsSynchronously() instead of checking for </span><span style="display: inline !important; float: none; background-color: transparent; color: rgb(0, 0, 255); font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant: normal; font-weight: 700; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px;" class="">(state & SYNC_LOAD_FLAG) != 0)</span></p>
BTW, do we not have to check <span style="float: none; background-color: transparent; font-family: Consolas; font-size: 13.33px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-decoration: none; text-indent: 0px; text-transform: none; -webkit-text-stroke-width: 0px; white-space: pre; word-spacing: 0px; display: inline !important;" class="">if (newWidth > 0) & newHeight >0 before changing the newstate @l797?
The copyright year in testcase should be changed to 2019.
Regards
Prasanta
</span>
<div class="moz-cite-prefix">On 01-Mar-19 12:10 PM, Krishna
Addepalli wrote:<br class="">
</div>
<blockquote type="cite" cite="mid:97E0E21C-4FA9-4837-8404-FBDCDBF13A5E@oracle.com" class="">
<pre wrap="" class="">Thanks for the review Sergey.
Can I have one more review? Prasanta maybe?
Thanks,
Krishna
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">On 01-Mar-2019, at 3:40 AM, Sergey Bylokhov <a class="moz-txt-link-rfc2396E" href="mailto:Sergey.Bylokhov@oracle.com"><Sergey.Bylokhov@oracle.com></a> wrote:
Looks fine.
On 21/02/2019 08:44, Sergey Bylokhov wrote:
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">On 20/02/2019 22:21, Krishna Addepalli wrote:
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">Hi Sergey,
I have fixed the issue. Could you check now?
</pre>
</blockquote>
<pre wrap="" class="">Yes, it works now, I look to the fix.
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">Thanks,
Krishna
-----Original Message-----
From: Sergey Bylokhov
Sent: Thursday, February 21, 2019 3:54 AM
To: Krishna Addepalli <a class="moz-txt-link-rfc2396E" href="mailto:krishna.addepalli@oracle.com"><krishna.addepalli@oracle.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a>
Subject: Re: <Swing Dev> [13] RFR: JDK-8218674 - HTML Tooltip with "img=src" on component doesn't show
Hi, Krishna.
Some links have wrong file permissions, "403 - Forbidden":
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/raw_files/new/test/jdk/javax/swing/text/html/8218674/circle.png">http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/raw_files/new/test/jdk/javax/swing/text/html/8218674/circle.png</a>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/raw_files/new/test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java">http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/raw_files/new/test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java</a>
On 20/02/2019 03:57, Krishna Addepalli wrote:
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">Hi All,
Please review a fix for the bug JDK-8218674: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8218674">https://bugs.openjdk.java.net/browse/JDK-8218674</a>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/">http://cr.openjdk.java.net/~kaddepalli/8218674/webrev00/</a>
This is a regression introduced due to fix for JDK-8208638. The default behaviour for ImageView is to load an image asynchronously. Hence, it uses the ImageHandler::imageUpdate to get the updates to the image being loaded. That will set the width and height of the image view. ImageView::updateImageSize does not alter the width and height in this case. When a JToolTip is created and html text set as tooltip, internally, the image is requested to be loaded synchronously, and in this case, ImageView::updateImageSize is the only way to calculate the image size. Since the width and height were not specified in the tooltip, the image was not being drawn.
The fix is to check if the image is requested to be loaded synchronously, and if so, then do the same calculation as for the fix for JDK-8208638, which will provide valid image width and height, additionally also taking care of the scaling issues fixed for JDK-8208638.
I have tested the fix on Windows, Linux(Ubuntu) and Mac, and found that it is working. I have also run all the jtreg tests under the test/jdk/javax/swing/text/html, and found no new failures.
Thanks,
Krishna
</pre>
</blockquote>
<pre wrap="" class="">
</pre>
</blockquote>
</blockquote>
<pre wrap="" class="">
--
Best regards, Sergey.
</pre>
</blockquote>
<pre wrap="" class=""></pre>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></div></body></html>