<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thanks for making the test really standalone as discussed but you
can also remove <br>
</p>
<pre>30 * @library /test/lib
and
46 import jdk.test.lib.Platform;</pre>
since you do not need them now. Rest looks ok.<br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 18-Mar-19 6:10 PM, Manajit Halder
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:3A037F41-3F3C-471A-A1F0-79E6BE04925D@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
Thanks Prasanta, I have corrected the indentation issue. Also
removed use of <span style="background-color: rgb(238, 238, 238);"
class="">@build jdk.test.lib.Platform</span> and replaced <span
style="background-color: rgb(238, 238, 238);" class="">Platform.isOSX() </span>with <span
style="background-color: rgb(238, 238, 238);" class="">System.getProperty.</span>
<div>Please review the updated webrev.</div>
<div><a
href="http://cr.openjdk.java.net/%7Emhalder/8216971/webrev.03/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8216971/webrev.03/</a></div>
<div><br class="">
</div>
<div>Regards,</div>
<div>Manajit</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 18-Mar-2019, at 4:25 PM, Prasanta Sadhukhan
<<a href="mailto:prasanta.sadhukhan@oracle.com" class=""
moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<p class="">Still <br class="">
</p>
<pre class="">74 } finally {</pre>
in testcase not fixed. Please fix it before pushing...No
need to send webrev.<br class="">
<br class="">
Regards<br class="">
Prasanta<br class="">
<div class="moz-cite-prefix">On 18-Mar-19 4:12 PM, Manajit
Halder wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:7B778B0E-8394-4BDB-92B2-9AD329C020CD@oracle.com"
class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
Thanks Prasanta for the review. I have corrected the
indentation problem. Please review the updated webrev.
<div class=""><a
href="http://cr.openjdk.java.net/%7Emhalder/8216971/webrev.02/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8216971/webrev.02/</a></div>
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
<div class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 18-Mar-2019, at 11:21 AM,
Prasanta Sadhukhan <<a
href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type"
content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<p class="">I guess l94-111 indentation in
CMenuItem.m and l69 Robot robot = new
Robot(); in testcase<br class="">
</p>
<p class="">is still not fixed.<br class="">
</p>
Regards<br class="">
Prasanta<br class="">
<div class="moz-cite-prefix">On 15-Mar-19 4:51
PM, Manajit Halder wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:B2E988C8-F452-4688-9702-895C9E0CF471@oracle.com"
class="">
<meta http-equiv="Content-Type"
content="text/html; charset=utf-8"
class="">
Thanks Prasanta,
<div class=""><br class="">
</div>
<div class="">I have corrected the
indentation issue in both files. Please
review the modified webrev.</div>
<div class=""><a
href="http://cr.openjdk.java.net/%7Emhalder/8216971/webrev.01/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8216971/webrev.01/</a></div>
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
<div class=""><br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 15-Mar-2019, at 11:32
AM, Prasanta Sadhukhan <<a
href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type"
content="text/html; charset=utf-8"
class="">
<div text="#000000"
bgcolor="#FFFFFF" class="">
<p class="">fix looks fine to me
but there are indentation issue
both in fix and in testcase.
Please rectify it.<br class="">
</p>
Regards<br class="">
Prasanta<br class="">
<div class="moz-cite-prefix">On
12-Mar-19 6:46 PM, Krishna
Addepalli wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:740B7C3D-A720-4F1D-B59E-03F85C183543@oracle.com"
class="">
<meta http-equiv="Content-Type"
content="text/html;
charset=utf-8" class="">
Hi Manajit,
<div class=""><br class="">
<div class="">Thanks for the
clarification. The fix looks
ok to me.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Krishna<br
class="">
<div class=""><br class="">
<blockquote type="cite"
class="">
<div class="">On
12-Mar-2019, at 3:36
PM, Manajit Halder
<<a
href="mailto:manajit.halder@oracle.com"
class=""
moz-do-not-send="true">manajit.halder@oracle.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta
http-equiv="Content-Type"
content="text/html;
charset=utf-8"
class="">
<div style="word-wrap:
break-word;
-webkit-nbsp-mode:
space; line-break:
after-white-space;"
class="">Lines 74 to
82 explains why we
need to ignore this
call. This method
should be ignored if
it is called as a
result of user
pressing a shortcut
and the window
containing the menu
is not minimized.
<div class=""><br
class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
<div class=""><br
class="">
<div class=""><br
class="">
<blockquote
type="cite"
class="">
<div class="">On
12-Mar-2019,
at 3:16 PM,
Krishna
Addepalli <<a
href="mailto:krishna.addepalli@oracle.com" class=""
moz-do-not-send="true">krishna.addepalli@oracle.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta
http-equiv="Content-Type"
content="text/html; charset=utf-8" class="">
<div
style="word-wrap:
break-word;
-webkit-nbsp-mode:
space;
line-break:
after-white-space;"
class="">Hi
Manajit,
<div class=""><br
class="">
</div>
<div class="">Thanks
for the
clarification.
I think you
should add
some more
comments
around the
statement at
line86, to
explain in
more detail,
about why to
ignore this
call.</div>
<div class=""><br
class="">
</div>
<div class="">Thanks,</div>
<div class="">Krishna<br
class="">
<div class=""><br
class="">
<blockquote
type="cite"
class="">
<div class="">On
11-Mar-2019,
at 2:25 PM,
Manajit Halder
<<a
href="mailto:manajit.halder@oracle.com"
class=""
moz-do-not-send="true">manajit.halder@oracle.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta
http-equiv="Content-Type"
content="text/html; charset=utf-8" class="">
<div
style="word-wrap:
break-word;
-webkit-nbsp-mode:
space;
line-break:
after-white-space;"
class="">Hi
Krishna,
<div class=""><br
class="">
</div>
<div class="">Thanks
for the review
comment. </div>
<div class=""><br
class="">
</div>
<div class="">The
key mapping is
done by
method <span
style="font-family:
Menlo;
background-color:
rgb(255, 255,
255);"
class="">setKeyEquivalent
on </span><span
style="font-family: Menlo; background-color: rgb(255, 255, 255);"
class="">fMenuItem
(object of the
NSMenuItem) in
the same file.</span></div>
<div class=""><br
class="">
</div>
<div class="">As
discussed with
you, the
second key
event is the
problem here,
and is caused
only when
System
property “<span
style="background-color: rgb(255, 255, 255);" class=""><font class=""
face="Menlo"><span
style="font-size: 11px;" class="">apple.laf.useScreenMenuBar” is set to
true.</span></font></span> The
extra event is
generated in
the
handleAction
method and my
proposed fix
is solving
this issue.
The difference
with other
look and feel
setting or
when “<span
style="background-color:
rgb(255, 255,
255);"
class=""><font
class=""
face="Menlo"><span
style="font-size: 11px;" class="">apple.laf.useScreenMenuBar” </span></font></span>is
set to “false”
is that
handleAction
method is not
called. I have
verified and
found that
the META_MASK
and CTRL_MASK
are only set
when “<span
style="background-color:
rgb(255, 255,
255);"
class=""><font
class=""
face="Menlo"><span
style="font-size: 11px;" class="">apple.laf.useScreenMenuBar” is set to
true</span></font></span> and
not in case of
it is false.
Also verified
with “metal”
look and feel
and found the
MASKS are not
set and
handleAction
method is not
called and
hence the
extra key
event is not
generated.</div>
<div class=""><br
class="">
</div>
<div class="">Please
let me know if
you have any
other query.</div>
<div class=""><br
class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
<div class=""><br
class="">
</div>
<div class=""><br
class="">
</div>
<div class="">
<div class=""><br
class="">
<blockquote
type="cite"
class="">
<div class="">On
05-Mar-2019,
at 4:52 PM,
Krishna
Addepalli <<a
href="mailto:krishna.addepalli@oracle.com" class=""
moz-do-not-send="true">krishna.addepalli@oracle.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta
http-equiv="Content-Type"
content="text/html; charset=utf-8" class="">
<div
style="word-wrap:
break-word;
-webkit-nbsp-mode:
space;
line-break:
after-white-space;"
class="">Hi
Manajit,
<div class=""><br
class="">
<div class="">Per
our
discussion,
The cause of
the problem is
: 1), Key
Event being
sent from the
OS to the
application -
which the Java
layer
processes it
correctly</div>
<div class="">2)
The Mac OS
calling the
handleAction
function
directly on
the
NSMenutItem -
although as
per your
description,
there is no
code which
maps the hot
key to this
widget in the
native layer.</div>
<div class="">Ideally,
since the OS
is recognising
the key
combination,
that key event
should not be
delivered
again to the
application.
Or, it should
be that the
key event is
not recognised
and hence
delivered to
the
application.</div>
<div class=""><br
class="">
</div>
<div class="">Can
you check why
in this case,
we are getting
the key event
as well as the
handleAction
from the OS?</div>
<div class=""><br
class="">
</div>
<div class="">Thanks,</div>
<div class="">Krishna<br
class="">
<div class=""><br
class="">
<blockquote
type="cite"
class="">
<div class="">On
23-Feb-2019,
at 9:14 PM,
Manajit Halder
<<a
href="mailto:manajit.halder@oracle.com"
class=""
moz-do-not-send="true">manajit.halder@oracle.com</a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta
http-equiv="Content-Type"
content="text/html; charset=utf-8" class="">
<div
style="word-wrap:
break-word;
-webkit-nbsp-mode:
space;
line-break:
after-white-space;"
class="">
<div class="">Hi
All,</div>
<div class=""><br
class="">
</div>
<div class="">Please
review the fix
for JDK13.</div>
<div class=""><br
class="">
</div>
<div class="">Bug:</div>
<div class=""><a
href="https://bugs.openjdk.java.net/browse/JDK-8216971" class=""
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8216971</a></div>
<div class=""><br
class="">
</div>
<div class="">Webrev:</div>
<div class=""><a
href="http://cr.openjdk.java.net/%7Emhalder/8216971/webrev.00/" class=""
moz-do-not-send="true">http://cr.openjdk.java.net/~mhalder/8216971/webrev.00/</a></div>
<div class=""><br
class="">
</div>
<div class="">Fix:</div>
<div class="">actionPerformed()
was called
twice due to
wrong handling
of key down
event in
method
handleAction,
which is
corrected with
this fix. </div>
<div class="">This
change was
added during
fix of issue
JDK-8152492.
Apart from the
changes
required to
fix the
problem, code
related to
finding out </div>
<div class="">eventKey
is removed as
eventKey is no
more used
now. </div>
<div class=""><br
class="">
</div>
<div class="">Note:</div>
<div class="">This
issue is
regression of
bug 8152492,
which was
introduced in
JDK release
9b120.</div>
<div class=""><br
class="">
</div>
<div class="">Regards,</div>
<div class="">Manajit</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
</body>
</html>