[threeten-dev] some makefile and test update

[Stephen Colebourne]

In my opinion, we should exclude those IDs that are pretty useless from TZDB
We use africa antarctica asia australasia backward etcetera europe
northamerica southamerica
We exclude solar and pacificnew.

There will be cases where you cannot convert a TimeZone to a ZoneId
anyway (such as user defined zones) so having some additional ones
doesn't seem like a big deal. A bit of a clear up is part of 310's
mission.

Stephen


On 7 December 2012 01:47, Xueming Shen <xueming.shen at oracle.com> wrote:
> Any reason that can not be in? since the plan is to migrate the jdk existing
> tzdb code
> to use/share the tzdb.jar date, probaby vis StandardZoneRules (I did the
> prototype
> early this year). So the tzdb.jar will need all  data jdk currently supports
> for compatibility
> reason. Though I'm not sure those solar files really matter or not.
>
>
> On 12/6/12 4:38 PM, Stephen Colebourne wrote:
>
> Looks like the TZDB generation includes solar files and maybe others that
> 310 was deliberately omitting.
> Stephen
>
> On Dec 6, 2012 8:18 PM, "Xueming Shen" <xueming.shen at oracle.com> wrote:
>>
>> This is proposed changeset is to
>>
>> (1) move the tzdb "build" stuff from the make/tool/tzcompiler +
>> make/sun/javazic
>> into make/javax/time/Makefile. For two reason
>>     - make the new build infra" stuff to work
>>     -the tzdb.jar actually has the dependency on those zone impl, so it's
>> more
>>      reasonable to update the tzdb.jar if those imples updated.
>>
>> (2) move the TestNG def from the top test properties file
>> TEST.ROOT into the "local" test/javax/time/TEST.properties.
>>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbbuild_test
>>
>> -Sherman
>
>