[threeten-dev] ZoneTextPrinterParser.print(...)

[Xueming Shen]

On 12/8/12 1:50 AM, Stephen Colebourne wrote:
> On 8 December 2012 08:02, Xueming Shen <xueming.shen at oracle.com> wrote:
>> Opinion?
>>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_printer
> To obtain the instant from the DateTimeAccessor I would do this:
>   Instant.from(accessor)
> rather than specifically looking for the two types.

Good point.  webrev has been updated as suggested (also changed the enum 
to int).

I also updated the j.u.formatter as well. How is the ZoneOffset & ZoneId 
conclusion?
It's good to do as well? :-)

http://cr.openjdk.java.net/~sherman/jdk8_threeten/juf/

-Sherman
>
> I'm not sure I would bother with the Type enum. Would an int suffice
> here? If the enum is kept, I'd use upper case constant names.
>
> Stephen
>
>> Naoto "promised" to have the cache mechanism somewhere in resource handling
>> place, so the "cache" will be gone.
>>
>> The test take 14s+ on my old linux machine, but consider it's a
>> 160 locales x 569 timezones x 100 run, it probably is not too bad. It may
>> not be
>> necessary to go over all them...
>>
>> The test failed on "ROC" and "Etc/GMT", it appears TimeZone is doing
>> something special
>> for these zones. I'm excluding them out for now.
>>
>> -Sherman