[threeten-dev] [threeten-develop] Webrev to fix #175 Remove Offset* classes int-based factory methods

Douglas Surber douglas.surber at oracle.com
Tue Dec 18 08:32:49 PST 2012


Main disadvantage is that it requires a JDBC programmer to import 
LocalDate/Time and ZoneOffset in order to use OffsetDate/Time. With 
the int factory methods one can write

   OffsetDateTime odt = OffsetDateTime.of(year, month, day, hour, 
minute, second, nano,
        offsetHhours, offsetMinutes);

But without those methods one has to import and think about 
LocalDateTime and ZoneOffset.

   LocalDateTime ldt = LocalDateTime.of(year, month, day, hour, 
minute, second, nano);
   ZoneOffset zq = ZoneOffset(offsetHour, offsetMinute);
   OffsetDateTime odt = OffsetDateTime(ldt, zo);

I'm not a fan of the long arg list but nor am I a fan of having to 
introduce two additional types in order to construct the thing I 
actually care about.

I would vote to leave them in.

Douglas

At 07:00 AM 12/18/2012, Roger Riggs wrote:
>Hi,
>
>#175 Remove Offset* classes int-based factory methods
>
>See: http://cr.openjdk.java.net/~rriggs/webrev-factory/
>
>Comments?
>
>Roger
>
>
>------------------------------------------------------------------------------
>LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
>Remotely access PCs and mobile devices and provide instant support
>Improve your efficiency, and focus on delivering more value-add 
>services
>Discover what IT Professionals Know. Rescue delivers
>http://p.sf.net/sfu/logmein_12329d2d
>_______________________________________________
>threeten-develop mailing list
>threeten-develop at lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/threeten-develop



More information about the threeten-dev mailing list