[threeten-dev] Interface hierarchy

[Xueming Shen]

I guess I always "pay attention" to the "all implemented interfaces" section.

Anyway, what are the "as needed" now for these 3 classes? TAccessor as well?
and WithAdjuster for LDT and LD?

ZDT implements Temporal, TemporalAccessor, ChronoZDT, Serialiable
LDT implements Temporal, WithAdjuster, TemporalAccessor, ChronoLDT, Serialiable
LD   implements Temporal, WithAdjuster, TemporalAccessor, ChronoLD, Serialiable

-Sherman

On 12/18/2012 10:53 AM, Roger Riggs wrote:
> Hi Sherman,
>
> The javadoc lists the interfaces twice, once in the "All Implemented interfaces" section
> (alphabetically) and again below the <hr> line;  the one below the line is in declaration order.
>
> Consistently I would  put Temporal first and include the others as needed.
>
> Roger
>
>
> On 12/18/2012 1:46 PM, Xueming Shen wrote:
>> On 12/18/2012 10:28 AM, Stephen Colebourne wrote:
>>> It changes both. The Javadoc and the source code readers.
>>
>> The Temporal and their relatives will still be listed as they declares
>> now in the current version.
>>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/javadoc/
>>
>> But if you want to list the Temporal explicitly as the first, you will have
>> probably to explicitly put it first.
>>
>> ZDT now only has Temporal, the rest two have Temporal and WithAdjuster,
>> kinda inconsistent. You want Temporal only or two?
>>
>> While make LD/LT/LDT/ZDT as adjuster is kinda of cool and sometime might
>> be convenient, but personally I guess they might cause more confusion for
>> the beginner, than the benefit they might bring in.
>>
>> -Sherman
>>
>>> I agree with Roger - Temporal first.
>>>
>>> Stephen
>>>
>>>
>>> On 18 December 2012 18:28, Xueming Shen<xueming.shen at oracle.com>  wrote:
>>>> What did you guys mean here? I believe removing the explicit/redundant
>>>> declaration from the code will not change the javadoc output...you still get
>>>> all the interfaces listed, the same way. Or guy meant those "developers"
>>>> that who peek into the source code?
>>>>
>>>> -Sherman
>>>>
>>>>
>>>> On 12/18/2012 10:15 AM, Stephen Colebourne wrote:
>>>>> I guess not. It does mean more developers will look at the Chrono
>>>>> interface though to see the inheritence, which isn't a good thing.
>>>>>
>>>>> Stephen
>>>>>
>>>>>
>>>>> On 18 December 2012 17:49, Xueming Shen<xueming.shen at oracle.com>   wrote:
>>>>>> Given their interface hierarchy, it appears there is no reason why
>>>>>> LD, LDT and ZDT still need to declare Temporal, WithAdjuster and
>>>>>> Accessor explicitly?
>>>>>>
>>>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/if_redundant
>>>>>>
>>>>>> -Sherman
>>>>>>
>>>>>>
>>
>