TZDATA_VER in javazip/Makefile

[Xueming Shen]

Do tzupdater and corresponding regression tests use the 
make/sun/javazip/Makefile in
jdk repository. I don't see the passed in version string get stored in 
anywhere by the
tool in jdk. Need doublecheck, I might be wrong...In face the 
`$(GREP...` does not work
in my linux env, it simply assigns "/bin/grep ..." into TZDATA_VER. I'm 
not sure if it is
my env or the gnumake on linux needs to use the more formal $(shell...). 
Anyway if
there is jdk tests that depend on the passed version number, I will not 
update the
TZDATA_VER directly for now. "will need to fix ALL the affected 
programs..." sounds
too scary :-)

-Sherman




On 11/12/12 6:21 PM, Masayoshi Okutsu wrote:
> Hi Sherman,
>
> javazic uses whatever given as a version string, but there are some 
> programs which assume the "tzdata" prefix, such as the tzupdater tool 
> and some regression tests. OK to change it, but you will need to fix 
> all the affected programs...
>
> Masayoshi
>
> On 11/13/2012 3:20 AM, Xueming Shen wrote:
>> Okutsu-san
>>
>> It appears the variable
>> TZDATA_VER = `$(GREP) '^tzdata' $(TZDATA)VERSION`
>>
>> in javazip/Makefile does not get evaluated correctly in bash here.
>>
>> I replaced it with
>> TZDATA_VER := $(subst tzdata,,$(shell $(GREP) '^tzdata' $(TZDATA)VERSION))
>> to get the correct version string and also remove the
>> the prefix "tzdata". I don't see the javazic really uses
>> this version info, so guess the removal of "tzdata" should
>> be OK. Let me know if I'm wrong.
>>
>> Here is the webrev for this change.
>>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/javazic/webrev/
>>
>> -Sherman
>