[threeten-dev] TestNG for JTreg

[Stephen Colebourne]

For example, this webrev has some TCK tests that should be altered,
and some non-TCK tests that should NOT be altered.

The non-TCK tests must stay in the same package hierarchy as the
classes they test, so that they CAN use package scoped methods.

Stephen


On 21 November 2012 23:07, Stephen Colebourne <scolebourne at joda.org> wrote:
> On 21 November 2012 22:12, Xueming Shen <xueming.shen at oracle.com> wrote:
>> The proposed change is to remove the tests on package-private
>> classes/constructors/methods
>> from the zone area.
>
> Its fine to remove package-scoped tests from the tck tests. but we
> should still have those tests in the OpenJDK. Package scoped tests are
> fine and normal for the OpenJDK case.
>
> I'm unclear as to whether this change achieves that.
>
> Stephen
>
>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/test_tz
>>
>> All tests now can be run smoothly and are passed under JTreg+TestNG, except
>> those
>> for the "format" packages.
>>
>> The directory structure under test/javax/time need to be re-orged to exactly
>> as their
>> package hierarchy, for example, if we change the package hierarchy as
>>
>> javax.time                  ->   javaxtime
>> javax.time.zone          ->   javaxtime.zone
>> javax.time.calendrical ->   javaxtime.calendrical
>> javax.time.format       ->   javaxtime.format
>>     tck/javax.time         ->   javaxtime.tck
>>     tck/javax.time.zone ->   javaxtime.tck.zone
>> ...
>>
>> The directory structure under test/javax/time needs to be
>>
>> javaxtime
>>          zone
>>          calendrical
>>          format
>>          tck
>>               zone
>>               format
>>               calendrical
>>               chrono
>> ...
>>
>> I have a simple script to update the package/import lines for the tests.
>>
>> So after push the changes showed in above webrev, we can figure out
>> the package names for the tests, if "javaxtime" is not good enough for
>> you guys.
>>
>> -Sherman