[threeten-dev] DateTimeFormatSymbols review

[Stephen Colebourne]

Looks good to me
Stephen

On 15 April 2013 19:28, roger riggs <roger.riggs at oracle.com> wrote:
> Hi,
>
> Updates method names as suggested,  edited javadoc to replace
> or qualify use of 'symbols' with DecimalStyle.
> Changed the return type of DecimalStyle.getAvailableLocales() to
> Set<Locale>.
>
> Webrev:
>
>         http://cr.openjdk.java.net/~rriggs/webrev-formatsymbols-114/
>
> Roger
>
>
> On 4/15/2013 12:36 PM, Stephen Colebourne wrote:
>>
>> We're agreed on the name.
>>
>> The methods currently named getSymbols() should also be altered. I
>> guess to getDecimalStyle()/withDecimalStyle(). Affects DTFormatter
>> DTPrintContext, DTParseContext.
>>
>> The Locale[] method should not return an array as you say. Should be
>> Set<Locale> to fit with Chronology and ZoneId.
>>
>> thanks
>> Stephen
>>
>>
>> On 15 April 2013 17:25, roger riggs <roger.riggs at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> The name DecimalStyle would be consistent with the other
>>> styling types and is conveniently short.
>>>
>>> Updated webrev:
>>>
>>>    http://cr.openjdk.java.net/~rriggs/webrev-formatsymbols-114/
>>>
>>> BTW, the DecimalStyle.getAvailableLocales method returns a Locale[];
>>> I remember a comment against using array returns.
>>>
>>> Thanks, Roger
>>>
>>>
>>>
>>>
>>> On 4/13/2013 5:05 AM, Stephen Colebourne wrote:
>>>>
>>>> On 12 April 2013 22:38, roger riggs <roger.riggs at oracle.com> wrote:
>>>>>
>>>>> Following up on issue #114 Determine if DateTimeFormatSymbols provides
>>>>> correct localization
>>>>> In the attempt to disambiguate the class name it has become very long.
>>>>>
>>>>> Perhaps instead of DateTimeDecimalFormatSymbols it could be simply
>>>>> 'DecimalSymbols'.  Many of the other classes have similarly long names
>>>>> that
>>>>> are unwieldy to use.
>>>>
>>>> Other controlling elements in the package end in "Style". Maybe this
>>>> should be DecimalStyle.
>>>>
>>>> Stephen
>>>
>>>
>