[threeten-dev] Add method to get localized date and time pattern

[Stephen Colebourne]

In addition to Michael's point:
- All static methods should be located before the constructor within a file
- The method should have the parameter order (style, style, chrono,
locale) to fit in with general use of locale (so a parallel method or
future default param could drop the locale in favour of the default
locale.

thanks
Stephen


On 19 April 2013 22:37, Michael Nascimento <misterm at gmail.com> wrote:
> Hi Roger,
>
> +        Objects.requireNonNull(locale, "locale");
> +        Objects.requireNonNull(chrono, "chrono");
> +        if (locale == null && chrono == null) {
> +            throw new IllegalArgumentException("Either dateStyle or
> timeStyle must be non-null");
> +        }
>
> I guess this is a leftover of your attempts to implement it.... Which
> one the two is right?
>
> Regards,
> Michael
>
> On Fri, Apr 19, 2013 at 6:33 PM, roger riggs <roger.riggs at oracle.com> wrote:
>> As requested in #305 Add getLocalePattern(datestyle, timestyle) method
>> <https://github.com/ThreeTen/threeten/issues/305>
>>
>> Webrev:
>>
>>     http://cr.openjdk.java.net/~rriggs/localized-pattern-305/
>>
>> Please review
>>
>> Thanks, Roger
>>