[threeten-dev] Add method to get localized date and time pattern

roger riggs roger.riggs at oracle.com
Sat Apr 20 08:24:40 PDT 2013


Thanks Michael,

It was supposed to be checking dateStyle and timeStyle,
they can't both be null.  (And the test  is missing for IAE).

Roger

On 4/19/2013 5:37 PM, Michael Nascimento wrote:
> Hi Roger,
>
> +        Objects.requireNonNull(locale, "locale");
> +        Objects.requireNonNull(chrono, "chrono");
> +        if (locale == null && chrono == null) {
> +            throw new IllegalArgumentException("Either dateStyle or
> timeStyle must be non-null");
> +        }
>
> I guess this is a leftover of your attempts to implement it.... Which
> one the two is right?
>
> Regards,
> Michael
>
> On Fri, Apr 19, 2013 at 6:33 PM, roger riggs <roger.riggs at oracle.com> wrote:
>> As requested in #305 Add getLocalePattern(datestyle, timestyle) method
>> <https://github.com/ThreeTen/threeten/issues/305>
>>
>> Webrev:
>>
>>      http://cr.openjdk.java.net/~rriggs/localized-pattern-305/
>>
>> Please review
>>
>> Thanks, Roger
>>



More information about the threeten-dev mailing list