[threeten-dev] Please help to review new test cases for java.time.chrono.JapaneseChronology, HijrahChronology and ThaiBuddhistChronology

Patrick Zhang patrick.zhang at oracle.com
Sat Apr 27 20:35:12 PDT 2013


Hi Team,

The new added webrev is similar with 
|http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/MinguoChronology/webrev/ 
<http://cr.openjdk.java.net/%7Epzhang/JSR310/java/time/chrono/MinguoChronology/webrev/>, 
which is only for MinguoChronology.

In the new webrev we add test cases for below similar function in 
JapaneseChronology, HijrahChronology and ThaiBuddhistChronology

|1. check new factory method. |*
date*(Era era, int yearOfEra, int month, int dayOfMonth)
||*dateYearDay*(Era era, int yearOfEra, int dayOfYear)|
2. check now() related function in MinguoChronology and MinguoDate.
|*dateNow*()|
|*dateNow*(Clock clock)|
|*dateNow*(ZoneId zone)|

webrev:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/JapaneseChronology/webrev/

test result:
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/JapaneseChronology/TCKHijrahChronology.jtr
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/JapaneseChronology/TCKJapaneseChronology.jtr
http://cr.openjdk.java.net/~pzhang/JSR310/java/time/chrono/JapaneseChronology/TCKThaiBuddhistChronology.jtr

Regards
Patrick

|

|


More information about the threeten-dev mailing list