[threeten-dev] [threeten-develop] Reconsidering generics on Chrono classes

Stephen Colebourne scolebourne at joda.org
Mon Feb 4 14:40:08 PST 2013


On 4 February 2013 20:48, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Updated; please review:
> javadoc:
>      http://cr.openjdk.java.net/~rriggs/javadoc-chrono-generics-191/
> webrev:
>      http://cr.openjdk.java.net/~rriggs/webrev-chrono-generics-191/
>
> If this is close, I'll merge with the other pending changes
> and move the calendars to java.time.chrono.
>
> Then we can put it out for review and only do fine tuning until the
> push early next week.

It looks pretty good to me. Issues I saw were Javadoc based, notably
the method reference example in the from(TemporalAccessor) methods.

The strategy of pushing and then fixing seems OK.

Stephen


More information about the threeten-dev mailing list