[threeten-dev] [threeten-develop] Reconsidering generics on Chrono classes

[Stephen Colebourne]

+1 to push
Stephen

On 4 February 2013 23:19, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> ok,  the cumulative webrevs and javadoc have been updated.
>
> javadoc:
>      http://cr.openjdk.java.net/~rriggs/javadoc-chrono-generics-191/
> webrev:
>      http://cr.openjdk.java.net/~rriggs/webrev-chrono-generics-191/
>
> I'll push as soon as the more complete jdk tests complete.
>
> Thanks, Roger
>
>
>
> On 2/4/2013 5:40 PM, Stephen Colebourne wrote:
>
> On 4 February 2013 20:48, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Updated; please review:
> javadoc:
>      http://cr.openjdk.java.net/~rriggs/javadoc-chrono-generics-191/
> webrev:
>      http://cr.openjdk.java.net/~rriggs/webrev-chrono-generics-191/
>
> If this is close, I'll merge with the other pending changes
> and move the calendars to java.time.chrono.
>
> Then we can put it out for review and only do fine tuning until the
> push early next week.
>
> It looks pretty good to me. Issues I saw were Javadoc based, notably
> the method reference example in the from(TemporalAccessor) methods.
>
> The strategy of pushing and then fixing seems OK.
>
> Stephen
>
>
>
>
>
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> threeten-develop mailing list
> threeten-develop at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>