[threeten-dev] Review request for changes to support Hijrah variants
roger riggs
roger.riggs at oracle.com
Fri Feb 15 13:16:23 PST 2013
Hi,
Please review the changes to support multiple Islamic calendar variants:
- Only the Umm alQura variant is supported so far and is supported by
limited
placeholder data until the full data can be acquired and validated.
- Tests have been updated to work with the updated API and available data
- The use of Locale 'ca' and 'cv' values has been added to
Chronology.ofLocale
- Properties are added to lib/calendars.properties to identify the
variants
by calendar type and to identify the resource containing the
calendar data.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-variants/
Javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-hijrah-variants/
Note: there are several related issues to be addressed after this change:
- The API for Era.date(xxx) does not lend itself to support of calendars
with multiple variants; Eras do not have any knowledge of a specific
chronology
- Performance of initialization at startup
- Enumerations of Eras
--
Thanks, Roger
Oracle Java Platform Group
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
More information about the threeten-dev
mailing list