[threeten-dev] Please help to review new test code for	java.time.Instant
    Stephen Colebourne 
    scolebourne at joda.org
       
    Tue Feb 19 02:51:26 PST 2013
    
    
  
The adjustInto() tests shoud also cover OffsetDateTime and
ZonedDateTime. which are both valid targets.
The with(TemporalField,long) should test some other fields, like
SECOND_OF_MINUTE, to ensure they throw an exception.
The tests should be located in the file at about line 439, before truncatedTo()
(so they match the file order of the main Instant class)
thanks
Stephen
On 19 February 2013 09:34, Patrick Zhang <patrick.zhang at oracle.com> wrote:
> Hi Team,
>
>
> New test code are added to cover below 3 missed methods in
> java.time.Instant.
>
> adjustInto(Temporal)
> with(TemporalAdjuster)
> with(TemporalField, long)
>
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/TCKInstant.jtr
>
> Regards
> Patrick
    
    
More information about the threeten-dev
mailing list