[threeten-dev] [threeten-develop] Review request for changes to support Hijrah variants

[Stephen Colebourne]

On 19 February 2013 18:48, roger riggs <roger.riggs at oracle.com> wrote:
> public ValueRange range(ChronoField field) is incorrect wrt retaining
> the BEFORE era
>
> Please recheck, updated to include the full range of Year in the smallest
> min and greatest max to allow for different calendars.
> (Unless I misunderstand).

I think your original range from getMinYear() to getMaxYear() was
correct. My point was that the range doesn't vary based on the
temporal, so it only needs to be defined in the chronology. Plus my
second point was that the defined range is only accurate once the
BEFORE ERA is removed.

 case YEAR:
 case YEAR_OF_ERA:
   return ValueRange.of(getMinimumYear(), getMaximumYear());

I do note that many Hijrah variants are just algorithmic, so I'm not
certain that the file format you are using (specifying every known
year) will be practical for the algorithmic variants.

Stephen