[threeten-dev] Please help to review new test code for java.time.Instant

[Patrick Zhang]

Hi Stephen,

Do you think the updated webrev is ok?

Regards
Patrick

On 2/19/13 8:08 PM, Patrick Zhang wrote:
> Hi Stephen,
>
> It has been updated.
> 1. Move new added test code to correct location.
> 2. Add ZonedDateTime and OffsetDateTime into adjustInto data provider. 
> And confirm offset is kept unchanged after "adjustInto"
> 3. Add some invalid chronoField to with(field, value) and make sure it 
> throws DateTimeException
>
> webrev:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/webrev/
>
> test result:
> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/TCKInstant.jtr 
>
>
> Regards
> Patrick
>
> On 2/19/13 6:51 PM, Stephen Colebourne wrote:
>> The adjustInto() tests shoud also cover OffsetDateTime and
>> ZonedDateTime. which are both valid targets.
>>
>> The with(TemporalField,long) should test some other fields, like
>> SECOND_OF_MINUTE, to ensure they throw an exception.
>>
>> The tests should be located in the file at about line 439, before 
>> truncatedTo()
>> (so they match the file order of the main Instant class)
>>
>> thanks
>> Stephen
>>
>> On 19 February 2013 09:34, Patrick Zhang<patrick.zhang at oracle.com>  
>> wrote:
>>> Hi Team,
>>>
>>>
>>> New test code are added to cover below 3 missed methods in
>>> java.time.Instant.
>>>
>>> adjustInto(Temporal)
>>> with(TemporalAdjuster)
>>> with(TemporalField, long)
>>>
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/webrev/
>>>
>>> test result:
>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/Instant/TCKInstant.jtr 
>>>
>>>
>>> Regards
>>> Patrick