[threeten-dev] Request for review: Chronology name support

[Stephen Colebourne]

I'm happy with this change
Stephen

On 26 February 2013 09:06, Masayoshi Okutsu <masayoshi.okutsu at oracle.com> wrote:
> Updated the fix to address Stephen's comments. I've split
> getChronologyName() to be prepared for field names support.
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/310/chronotext/webrev.01/
>
> Thanks,
> Masayoshi
>
>
> On 2/15/2013 8:51 AM, Stephen Colebourne wrote:
>>
>> On 14 February 2013 23:31, Masayoshi Okutsu <masayoshi.okutsu at oracle.com>
>> wrote:
>>>
>>> On 2/15/2013 3:30 AM, Stephen Colebourne wrote:
>>>>
>>>> - I think the getChronlogyName method should be located within the
>>>> ChronoPrinterParser class.
>>>
>>> I put the method outside of ChronoPrinterParser because I thought there
>>> would be field name support in 310, like ChronoField.MONTH -> "Month".
>>> But I
>>> couldn't find a method to return a field name. So there's no plan to
>>> support
>>> field names?
>>
>> This was an RFE. I'd be happy to see the feature added, but its
>> Oracle's call not mine.
>>
>> Stephen
>
>