[threeten-dev] [threeten-develop] Draft of new UnsupportedTemporalTypeException update

[roger riggs]

Thanks, I'll fix those and push.

Roger

On 2/26/2013 2:54 PM, Stephen Colebourne wrote:
> Missing @throws in Javadoc:
> Instant.range
> Instant.minus
> LocalDate.get
> LocalDate.getLong
> LocalDate.minus
> LDT.plus
> LDT.minus
> LDT.truncatedTo
> Month.range
> Month.get
> ChronoLocalDate.with
> ChronoLocalDate.plus
>
> IsoChronology refers to ISOEra, not IsoEra
>
> JapaneseDate should be CCE, not UTTE
>
> otherwise OK,
> thanks
> Stephen
>
>
> On 26 February 2013 18:18, roger riggs <roger.riggs at oracle.com> wrote:
>> Hi Stephen,
>>
>> Thanks for the review, all of the comments have been addressed.
>>
>> javadoc:
>> http://cr.openjdk.java.net/~rriggs/javadoc-temporaltypeexception-245/
>> webrev: http://cr.openjdk.java.net/~rriggs/webrev-temporaltypeexception-245/
>>
>> On 2/25/2013 5:39 PM, Stephen Colebourne wrote:
>>> On 25 February 2013 19:51, roger riggs <roger.riggs at oracle.com> wrote:
>>>> javadoc:
>>>> http://cr.openjdk.java.net/~rriggs/javadoc-temporaltypeexception-245/
>>>> webrev: http://cr.openjdk.java.net/~rriggs/webrev-temporaltypeexception-245/
>>> Much closer to what I was expecting ;-)
>>>
>>> LocalDateTime almost certainly wants some Javadoc additions of UTTE.
>> Added @throws UTTE for methods with ChronoField arguments.
>>> None of the changes in HijrahChronology look right to me.
>> Only the exception for Era must be HijrahEra remains.
>>> The check for era is FooEra should not be UTTE as UTTE needs to be
>>> strictly scoped. (comment applies to all chronos) If you are desparate
>>> to use a JDK exception, then ClassCastException would be OK there.
>> ok
>>> HijrahEra/IsoEra/MinguoEra has an import but no references to it.
>> removed
>>> In general, such as on TemporalAmount, DateTimeException should be
>>> phrased in the general "throws DTE if unable to obtain the foo",
>>> whereas UTTE is more specific "throws UTTE if the field/unit is
>>> unsupported"
>> ok, TemporalAmount.get now reads:
>>         DateTimeException if a value for the unit cannot be obtained
>>> CopticDate/CopticEra still have too many UTTE.
>> Oops, gone now.
>>
>> Thanks, Roger
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_feb
>> _______________________________________________
>> threeten-develop mailing list
>> threeten-develop at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/threeten-develop

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment