From scolebourne at joda.org Tue Jan 1 15:16:30 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 01 Jan 2013 23:16:30 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 9 new changesets Message-ID: <20130101231842.DE6EA47491@hg.openjdk.java.net> Changeset: 5c91bb01149b Author: scolebourne Date: 2012-12-31 23:08 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5c91bb01149b Enhance temporal tests ! test/javax/time/tck/javax/time/TCKDayOfWeek.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/TCKMonth.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKMonthDay.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java ! test/javax/time/tck/javax/time/temporal/TCKYear.java ! test/javax/time/tck/javax/time/temporal/TCKYearMonth.java ! test/javax/time/test/javax/time/AbstractDateTimeTest.java Changeset: 50abe639dc98 Author: scolebourne Date: 2013-01-01 00:47 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/50abe639dc98 Enhance tests, better mapping TCK vs non-TCK ! src/share/classes/javax/time/ZonedDateTime.java ! test/javax/time/tck/javax/time/AbstractDateTimeTest.java < test/javax/time/test/javax/time/AbstractDateTimeTest.java ! test/javax/time/tck/javax/time/TCKDayOfWeek.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/TCKMonth.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKMonthDay.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java ! test/javax/time/tck/javax/time/temporal/TCKYear.java ! test/javax/time/tck/javax/time/temporal/TCKYearMonth.java ! test/javax/time/test/javax/time/AbstractTest.java - test/javax/time/test/javax/time/TestDayOfWeek.java ! test/javax/time/test/javax/time/TestDuration.java + test/javax/time/test/javax/time/TestInstant.java ! test/javax/time/test/javax/time/TestLocalDate.java ! test/javax/time/test/javax/time/TestLocalDateTime.java ! test/javax/time/test/javax/time/TestLocalTime.java - test/javax/time/test/javax/time/TestMonth.java ! test/javax/time/test/javax/time/TestPeriod.java ! test/javax/time/test/javax/time/TestZoneOffset.java + test/javax/time/test/javax/time/TestZonedDateTime.java ! test/javax/time/test/javax/time/temporal/TestDateTimeValueRange.java ! test/javax/time/test/javax/time/temporal/TestMonthDay.java + test/javax/time/test/javax/time/temporal/TestOffsetDate.java ! test/javax/time/test/javax/time/temporal/TestOffsetDateTime.java + test/javax/time/test/javax/time/temporal/TestOffsetTime.java ! test/javax/time/test/javax/time/temporal/TestYear.java ! test/javax/time/test/javax/time/temporal/TestYearMonth.java Changeset: 9fd57c4d6d9c Author: scolebourne Date: 2013-01-01 08:58 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9fd57c4d6d9c Add MIN_MAX constants for Offset classes ! src/share/classes/javax/time/LocalDate.java ! src/share/classes/javax/time/LocalDateTime.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java ! src/share/classes/javax/time/temporal/Year.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java Changeset: 1963bf8aac91 Author: scolebourne Date: 2013-01-01 09:31 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1963bf8aac91 Define and add code for case insensitive parsing ! src/share/classes/javax/time/format/DateTimeFormatters.java Changeset: ddca95afdc14 Author: scolebourne Date: 2013-01-01 10:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ddca95afdc14 Better tests for LocalDateTime instant factory ! test/javax/time/tck/javax/time/TCKLocalDateTime.java Changeset: b9acce376920 Author: scolebourne Date: 2013-01-01 10:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b9acce376920 Use MIN and MAX for constants Shorter and more consistent ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalDate.java ! src/share/classes/javax/time/LocalDateTime.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/ZoneOffset.java ! src/share/classes/javax/time/calendar/JapaneseEra.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java ! src/share/classes/javax/time/zone/ZoneRulesBuilder.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/calendar/TestChronoLocalDateTime.java ! test/javax/time/tck/javax/time/calendar/TestHijrahChrono.java ! test/javax/time/tck/javax/time/calendar/TestJapaneseChrono.java ! test/javax/time/tck/javax/time/calendar/TestMinguoChrono.java ! test/javax/time/tck/javax/time/calendar/TestThaiBuddhistChrono.java ! test/javax/time/tck/javax/time/temporal/TCKJulianFields.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java ! test/javax/time/tck/javax/time/temporal/TestChronoLocalDateTime.java ! test/javax/time/tck/javax/time/temporal/TestChronoZonedDateTime.java ! test/javax/time/tck/javax/time/temporal/TestISOChrono.java ! test/javax/time/test/javax/time/TestLocalTime.java ! test/javax/time/test/javax/time/temporal/TestJapaneseChronoImpl.java Changeset: 9eefc92b3847 Author: scolebourne Date: 2013-01-01 17:19 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9eefc92b3847 Implement printing of an instant over the full range of values See #81 ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/tck/javax/time/TCKInstant.java Changeset: 15f29fd62bd8 Author: scolebourne Date: 2013-01-01 18:18 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/15f29fd62bd8 Implement parsing of an instant over the full range of values See #81 ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/tck/javax/time/TCKInstant.java Changeset: 7322b35881b9 Author: scolebourne Date: 2013-01-01 23:15 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7322b35881b9 Reduce the valid range of instants See #194 ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/tck/javax/time/TCKDuration.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java From scolebourne at joda.org Tue Jan 1 16:11:49 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 02 Jan 2013 00:11:49 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Change enum to class to avoid accidental serialization Message-ID: <20130102001200.E6B3A47496@hg.openjdk.java.net> Changeset: ab05a2aa9994 Author: scolebourne Date: 2013-01-02 00:11 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ab05a2aa9994 Change enum to class to avoid accidental serialization Enhance Javadoc Fixes #158 ! src/share/classes/javax/time/temporal/Adjusters.java From scolebourne at joda.org Tue Jan 1 16:59:36 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 02 Jan 2013 00:59:36 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Move queries from TemporalQuery to Queries Message-ID: <20130102005948.920D347497@hg.openjdk.java.net> Changeset: 161f95507c14 Author: scolebourne Date: 2013-01-02 00:56 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/161f95507c14 Move queries from TemporalQuery to Queries Hope to put them back as static methods (on interface) See #172 ! src/share/classes/javax/time/DayOfWeek.java ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/Month.java ! src/share/classes/javax/time/ZoneId.java ! src/share/classes/javax/time/ZoneOffset.java ! src/share/classes/javax/time/format/DateTimeBuilder.java ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! src/share/classes/javax/time/format/DateTimePrintContext.java ! src/share/classes/javax/time/temporal/Chrono.java ! src/share/classes/javax/time/temporal/ChronoLocalDate.java ! src/share/classes/javax/time/temporal/ChronoLocalDateTime.java ! src/share/classes/javax/time/temporal/ChronoZonedDateTime.java ! src/share/classes/javax/time/temporal/Era.java ! src/share/classes/javax/time/temporal/MonthDay.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java + src/share/classes/javax/time/temporal/Queries.java ! src/share/classes/javax/time/temporal/TemporalAccessor.java ! src/share/classes/javax/time/temporal/TemporalQuery.java ! src/share/classes/javax/time/temporal/Year.java ! src/share/classes/javax/time/temporal/YearMonth.java ! test/javax/time/tck/javax/time/TCKDayOfWeek.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/TCKMonth.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/format/TCKDateTimeFormatters.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java ! test/javax/time/test/javax/time/TestZoneId.java From Roger.Riggs at Oracle.com Tue Jan 1 19:14:17 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Tue, 01 Jan 2013 22:14:17 -0500 Subject: [threeten-dev] hg: threeten/threeten/jdk: Move queries from TemporalQuery to Queries In-Reply-To: <20130102005948.920D347497@hg.openjdk.java.net> References: <20130102005948.920D347497@hg.openjdk.java.net> Message-ID: <50E3A609.5080600@Oracle.com> Hi Stephen, This change broke the build of the JDK due to the references to Queries in the java/util/Formatter.java:4157 that were not updated in sync. It is not difficult or time consuming to build the jdk with the new build infrastructure; and catching these problems before they cause other developers problems and delays. Thanks, Roger On 01/01/2013 07:59 PM, scolebourne at joda.org wrote: > Changeset: 161f95507c14 > Author: scolebourne > Date: 2013-01-02 00:56 +0000 > URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/161f95507c14 > > Move queries from TemporalQuery to Queries > > Hope to put them back as static methods (on interface) > See #172 > > ! src/share/classes/javax/time/DayOfWeek.java > ! src/share/classes/javax/time/Instant.java > ! src/share/classes/javax/time/LocalTime.java > ! src/share/classes/javax/time/Month.java > ! src/share/classes/javax/time/ZoneId.java > ! src/share/classes/javax/time/ZoneOffset.java > ! src/share/classes/javax/time/format/DateTimeBuilder.java > ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java > ! src/share/classes/javax/time/format/DateTimePrintContext.java > ! src/share/classes/javax/time/temporal/Chrono.java > ! src/share/classes/javax/time/temporal/ChronoLocalDate.java > ! src/share/classes/javax/time/temporal/ChronoLocalDateTime.java > ! src/share/classes/javax/time/temporal/ChronoZonedDateTime.java > ! src/share/classes/javax/time/temporal/Era.java > ! src/share/classes/javax/time/temporal/MonthDay.java > ! src/share/classes/javax/time/temporal/OffsetDate.java > ! src/share/classes/javax/time/temporal/OffsetDateTime.java > ! src/share/classes/javax/time/temporal/OffsetTime.java > + src/share/classes/javax/time/temporal/Queries.java > ! src/share/classes/javax/time/temporal/TemporalAccessor.java > ! src/share/classes/javax/time/temporal/TemporalQuery.java > ! src/share/classes/javax/time/temporal/Year.java > ! src/share/classes/javax/time/temporal/YearMonth.java > ! test/javax/time/tck/javax/time/TCKDayOfWeek.java > ! test/javax/time/tck/javax/time/TCKInstant.java > ! test/javax/time/tck/javax/time/TCKLocalDate.java > ! test/javax/time/tck/javax/time/TCKLocalDateTime.java > ! test/javax/time/tck/javax/time/TCKLocalTime.java > ! test/javax/time/tck/javax/time/TCKMonth.java > ! test/javax/time/tck/javax/time/TCKZoneOffset.java > ! test/javax/time/tck/javax/time/TCKZonedDateTime.java > ! test/javax/time/tck/javax/time/format/TCKDateTimeFormatters.java > ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java > ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java > ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java > ! test/javax/time/test/javax/time/TestZoneId.java > From xueming.shen at oracle.com Tue Jan 1 22:04:37 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 02 Jan 2013 06:04:37 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated j.u.Formatter for Queries Message-ID: <20130102060458.2ECEE474AB@hg.openjdk.java.net> Changeset: ef7c3c8ee410 Author: sherman Date: 2013-01-01 22:13 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ef7c3c8ee410 Updated j.u.Formatter for Queries ! src/share/classes/java/util/Formatter.java From scolebourne at joda.org Wed Jan 2 10:08:19 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 02 Jan 2013 18:08:19 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130102180924.753F7474B9@hg.openjdk.java.net> Changeset: f3f233b85543 Author: scolebourne Date: 2013-01-02 17:36 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f3f233b85543 Replace bin test files with code ! src/share/classes/javax/time/Ser.java - test/javax/time/resources/Duration.bin - test/javax/time/resources/Instant.bin - test/javax/time/resources/LocalDate.bin - test/javax/time/resources/LocalDateTime.bin - test/javax/time/resources/LocalTime.bin - test/javax/time/resources/MonthDay.bin - test/javax/time/resources/OffsetDate.bin - test/javax/time/resources/OffsetDateTime.bin - test/javax/time/resources/OffsetTime.bin - test/javax/time/resources/SimplePeriod.bin - test/javax/time/resources/Year.bin - test/javax/time/resources/YearMonth.bin - test/javax/time/resources/ZoneId.bin - test/javax/time/resources/ZoneOffset.bin - test/javax/time/resources/ZoneOffsetTransition.bin - test/javax/time/resources/ZoneOffsetTransitionRule.bin - test/javax/time/resources/ZonedDateTime.bin ! test/javax/time/tck/javax/time/AbstractDateTimeTest.java ! test/javax/time/tck/javax/time/AbstractTCKTest.java ! test/javax/time/tck/javax/time/TCKDuration.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java + test/javax/time/tck/javax/time/TCKZoneId.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKMonthDay.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java ! test/javax/time/tck/javax/time/temporal/TCKSimplePeriod.java ! test/javax/time/tck/javax/time/temporal/TCKYear.java ! test/javax/time/tck/javax/time/temporal/TCKYearMonth.java ! test/javax/time/tck/javax/time/zone/TCKZoneOffsetTransition.java ! test/javax/time/tck/javax/time/zone/TCKZoneOffsetTransitionRule.java ! test/javax/time/test/javax/time/AbstractTest.java ! test/javax/time/test/javax/time/TestDuration.java ! test/javax/time/test/javax/time/TestZoneId.java Changeset: 8417f8eb5afe Author: scolebourne Date: 2013-01-02 17:50 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8417f8eb5afe Optimise serialization of LocalTime This reduces bytes from 7 if no fractional second It is backwards compatible with the previous approach ! src/share/classes/javax/time/LocalTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java Changeset: c975ef3518bb Author: scolebourne Date: 2013-01-02 18:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c975ef3518bb Defend against malicious streams in deserialization ! src/share/classes/javax/time/Duration.java ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalDate.java ! src/share/classes/javax/time/LocalDateTime.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/ZoneOffset.java ! src/share/classes/javax/time/ZoneRegion.java ! src/share/classes/javax/time/ZonedDateTime.java ! src/share/classes/javax/time/temporal/Chrono.java ! src/share/classes/javax/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/javax/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/javax/time/temporal/MonthDay.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java ! src/share/classes/javax/time/temporal/SimplePeriod.java ! src/share/classes/javax/time/temporal/Year.java ! src/share/classes/javax/time/temporal/YearMonth.java From xueming.shen at oracle.com Wed Jan 2 10:32:09 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 02 Jan 2013 18:32:09 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated j.u.Formatter to use Queries.zone() Message-ID: <20130102183221.A921D474BA@hg.openjdk.java.net> Changeset: d9c4b6e9dbeb Author: sherman Date: 2013-01-02 10:41 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d9c4b6e9dbeb Updated j.u.Formatter to use Queries.zone() ! src/share/classes/java/util/Formatter.java From Roger.Riggs at oracle.com Wed Jan 2 12:30:31 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 02 Jan 2013 15:30:31 -0500 Subject: [threeten-dev] Review fixes for issue #192 Message-ID: <50E498E7.2050305@oracle.com> Please review fixes for https://github.com/ThreeTen/threeten/issues/192 Added minimal javadoc to trigger the inclusion of the @throws javadoc in classes that inherit documentation from interfaces. Fixed a couple of typos, missing @Overrides and added TODO's about missing spec's for what fields are needed to make some computations work. http://cr.openjdk.java.net/~rriggs/webrev-exceptions/ -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From misterm at gmail.com Wed Jan 2 12:49:17 2013 From: misterm at gmail.com (Michael Nascimento) Date: Wed, 2 Jan 2013 18:49:17 -0200 Subject: [threeten-dev] Review fixes for issue #192 In-Reply-To: <50E498E7.2050305@oracle.com> References: <50E498E7.2050305@oracle.com> Message-ID: LGTM. Unrelated style question: why do we use public for default methods in interfaces but don't use public for non-default ones? Regards, Michael On Wed, Jan 2, 2013 at 6:30 PM, Roger Riggs wrote: > Please review fixes for https://github.com/ThreeTen/threeten/issues/192 > > Added minimal javadoc to trigger the inclusion of the @throws javadoc > in classes that inherit documentation from interfaces. > > Fixed a couple of typos, missing @Overrides and added TODO's about > missing spec's for what fields are needed to make some computations work. > > http://cr.openjdk.java.net/~rriggs/webrev-exceptions/ > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > From Roger.Riggs at oracle.com Wed Jan 2 12:55:01 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 02 Jan 2013 15:55:01 -0500 Subject: [threeten-dev] Review fixes for issue #192 In-Reply-To: References: <50E498E7.2050305@oracle.com> Message-ID: <50E49EA5.1060207@oracle.com> The style hasn't settled yet, but to me the declaration looks out of place if it just starts "default void foo() {}". I'm of the view that would retain the "public" qualifier even if it was not strictly necessary. I think it is easier to parse/visualize if a few fixed visual clues are present so that that the variable parts are easier to identify. Some cleanup will be needed when a style is settled on. Roger On 1/2/2013 3:49 PM, Michael Nascimento wrote: > LGTM. > > Unrelated style question: why do we use public for default methods in > interfaces but don't use public for non-default ones? > > Regards, > Michael > > On Wed, Jan 2, 2013 at 6:30 PM, Roger Riggs wrote: >> Please review fixes for https://github.com/ThreeTen/threeten/issues/192 >> >> Added minimal javadoc to trigger the inclusion of the @throws javadoc >> in classes that inherit documentation from interfaces. >> >> Fixed a couple of typos, missing @Overrides and added TODO's about >> missing spec's for what fields are needed to make some computations work. >> >> http://cr.openjdk.java.net/~rriggs/webrev-exceptions/ >> >> -- >> Thanks, Roger >> >> Oracle Java Platform Group >> >> Green Oracle Oracle is committed to >> developing practices and products that help protect the environment >> -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From roger.riggs at oracle.com Wed Jan 2 17:31:13 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 03 Jan 2013 01:31:13 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130103013145.B322A474D3@hg.openjdk.java.net> Changeset: b86525e72989 Author: rriggs Date: 2013-01-02 20:29 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b86525e72989 Added minimal javadoc to trigger inheriting of jvadoc for @throws. addresses issues raised in #192 ! src/share/classes/javax/time/DayOfWeek.java ! src/share/classes/javax/time/Duration.java ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalDate.java ! src/share/classes/javax/time/LocalDateTime.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/Month.java ! src/share/classes/javax/time/ZoneOffset.java ! src/share/classes/javax/time/ZonedDateTime.java ! src/share/classes/javax/time/calendar/ChronoDateImpl.java ! src/share/classes/javax/time/calendar/HijrahChrono.java ! src/share/classes/javax/time/temporal/ChronoLocalDate.java ! src/share/classes/javax/time/temporal/ChronoLocalDateTime.java ! src/share/classes/javax/time/temporal/ChronoZonedDateTime.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java ! src/share/classes/javax/time/temporal/TemporalAccessor.java ! src/share/classes/javax/time/temporal/Year.java ! src/share/classes/javax/time/temporal/YearMonth.java Changeset: b5bc63335475 Author: rriggs Date: 2013-01-02 20:30 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b5bc63335475 Merge ! src/share/classes/javax/time/Duration.java ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalDate.java ! src/share/classes/javax/time/LocalDateTime.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/ZoneOffset.java ! src/share/classes/javax/time/ZonedDateTime.java ! src/share/classes/javax/time/temporal/OffsetDate.java ! src/share/classes/javax/time/temporal/OffsetDateTime.java ! src/share/classes/javax/time/temporal/OffsetTime.java ! src/share/classes/javax/time/temporal/Year.java ! src/share/classes/javax/time/temporal/YearMonth.java - test/javax/time/resources/Duration.bin - test/javax/time/resources/Instant.bin - test/javax/time/resources/LocalDate.bin - test/javax/time/resources/LocalDateTime.bin - test/javax/time/resources/LocalTime.bin - test/javax/time/resources/MonthDay.bin - test/javax/time/resources/OffsetDate.bin - test/javax/time/resources/OffsetDateTime.bin - test/javax/time/resources/OffsetTime.bin - test/javax/time/resources/SimplePeriod.bin - test/javax/time/resources/Year.bin - test/javax/time/resources/YearMonth.bin - test/javax/time/resources/ZoneId.bin - test/javax/time/resources/ZoneOffset.bin - test/javax/time/resources/ZoneOffsetTransition.bin - test/javax/time/resources/ZoneOffsetTransitionRule.bin - test/javax/time/resources/ZonedDateTime.bin From scolebourne at joda.org Wed Jan 2 17:39:44 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 03 Jan 2013 01:39:44 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130103014007.05D24474D4@hg.openjdk.java.net> Changeset: 6e42e511b9f9 Author: scolebourne Date: 2013-01-03 01:37 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6e42e511b9f9 Implement lenient minWidth for parsing of numbers Also improve sign style code ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! src/share/classes/javax/time/format/SignStyle.java ! test/javax/time/test/javax/time/format/TestNumberParser.java Changeset: 44f31078283c Author: scolebourne Date: 2013-01-03 01:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/44f31078283c Merge From scolebourne at joda.org Wed Jan 2 18:24:49 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 03 Jan 2013 02:24:49 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Correct implementation of lenient minWidth Message-ID: <20130103022501.8FB8E474D5@hg.openjdk.java.net> Changeset: 205c2c28b43a Author: scolebourne Date: 2013-01-03 02:24 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/205c2c28b43a Correct implementation of lenient minWidth Fixed width restriction only applies if adjacent parsing mode actually in use ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/test/javax/time/format/TestNumberParser.java From scolebourne at joda.org Thu Jan 3 09:13:01 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 03 Jan 2013 17:13:01 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130103171344.BFCD6474FA@hg.openjdk.java.net> Changeset: edb270887dc7 Author: scolebourne Date: 2013-01-03 17:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/edb270887dc7 Exemplar Javadoc for DayOfWeek/Month Other classes can derive from these ! src/share/classes/javax/time/DayOfWeek.java ! src/share/classes/javax/time/Month.java ! src/share/classes/javax/time/temporal/Queries.java ! src/share/classes/javax/time/temporal/Temporal.java ! src/share/classes/javax/time/temporal/TemporalAccessor.java ! src/share/classes/javax/time/temporal/TemporalAdjuster.java ! src/share/classes/javax/time/temporal/TemporalQuery.java Changeset: f2aa2ac3b200 Author: scolebourne Date: 2013-01-03 17:10 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f2aa2ac3b200 Merge ! src/share/classes/javax/time/DayOfWeek.java ! src/share/classes/javax/time/Month.java ! src/share/classes/javax/time/temporal/TemporalAccessor.java From scolebourne at joda.org Thu Jan 3 11:55:21 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 03 Jan 2013 19:55:21 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130103195554.C31A0474FD@hg.openjdk.java.net> Changeset: 159e7649c33a Author: scolebourne Date: 2013-01-03 19:12 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/159e7649c33a Enhance spec/Javadoc of Query/Adjuster ! src/share/classes/javax/time/temporal/TemporalAdjuster.java ! src/share/classes/javax/time/temporal/TemporalQuery.java Changeset: a5e535dac368 Author: scolebourne Date: 2013-01-03 19:48 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a5e535dac368 Rename doQuery() to queryFrom() Finally devised a way to handle the "special" queries well As such, the "do" prefix no longer makes sense ! src/share/classes/javax/time/DayOfWeek.java ! src/share/classes/javax/time/Instant.java ! src/share/classes/javax/time/LocalTime.java ! src/share/classes/javax/time/Month.java ! src/share/classes/javax/time/format/DateTimePrintContext.java ! src/share/classes/javax/time/temporal/ChronoLocalDate.java ! src/share/classes/javax/time/temporal/ChronoLocalDateTime.java ! src/share/classes/javax/time/temporal/ChronoZonedDateTime.java ! src/share/classes/javax/time/temporal/Queries.java ! src/share/classes/javax/time/temporal/TemporalAccessor.java ! src/share/classes/javax/time/temporal/TemporalQuery.java ! test/javax/time/tck/javax/time/AbstractDateTimeTest.java From xueming.shen at oracle.com Thu Jan 3 12:59:30 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 03 Jan 2013 12:59:30 -0800 Subject: [threeten-dev] zidtext parser Message-ID: <50E5F132.7000302@oracle.com> Here is the first try of adding the zidtext parser http://cr.openjdk.java.net/~sherman/jdk8_threeten/zidtext_parse It appears the zoneid parser works as expected. But I'm not sure what the best way is to handle the "general" zone names, such as "Mountain Standard Time", "Western European Time". We have m:1 mapping when printing, what should we do for the 1:m parsing? Pick a "representable" zid and hardcode the mapping? -Sherman From roger.riggs at oracle.com Thu Jan 3 14:34:24 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 03 Jan 2013 22:34:24 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added OpenJDK Copyright boilerplate Message-ID: <20130103223451.6F43747514@hg.openjdk.java.net> Changeset: ef33378f12bb Author: rriggs Date: 2013-01-03 17:32 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ef33378f12bb Added OpenJDK Copyright boilerplate ! src/share/classes/javax/time/Ser.java ! src/share/classes/javax/time/ZoneRegion.java ! src/share/classes/javax/time/calendar/ChronoDateImpl.java ! src/share/classes/javax/time/calendar/HijrahChrono.java ! src/share/classes/javax/time/calendar/HijrahDate.java ! src/share/classes/javax/time/calendar/HijrahDeviationReader.java ! src/share/classes/javax/time/calendar/HijrahEra.java ! src/share/classes/javax/time/calendar/JapaneseChrono.java ! src/share/classes/javax/time/calendar/JapaneseDate.java ! src/share/classes/javax/time/calendar/JapaneseEra.java ! src/share/classes/javax/time/calendar/MinguoChrono.java ! src/share/classes/javax/time/calendar/MinguoDate.java ! src/share/classes/javax/time/calendar/MinguoEra.java ! src/share/classes/javax/time/calendar/Ser.java ! src/share/classes/javax/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/javax/time/calendar/ThaiBuddhistDate.java ! src/share/classes/javax/time/calendar/ThaiBuddhistEra.java ! src/share/classes/javax/time/temporal/ChronoField.java ! src/share/classes/javax/time/temporal/ChronoUnit.java ! src/share/classes/javax/time/temporal/ISOFields.java ! src/share/classes/javax/time/temporal/Ser.java ! src/share/classes/javax/time/zone/TzdbZoneRulesCompiler.java ! src/share/classes/javax/time/zone/ZoneRulesException.java ! test/javax/time/tck/javax/time/AbstractTCKTest.java ! test/javax/time/tck/javax/time/calendar/TestChronoLocalDate.java ! test/javax/time/tck/javax/time/calendar/TestChronoLocalDateTime.java ! test/javax/time/tck/javax/time/calendar/TestHijrahChrono.java ! test/javax/time/tck/javax/time/calendar/TestJapaneseChrono.java ! test/javax/time/tck/javax/time/calendar/TestMinguoChrono.java ! test/javax/time/tck/javax/time/calendar/TestThaiBuddhistChrono.java ! test/javax/time/tck/javax/time/temporal/TCKISOFields.java ! test/javax/time/tck/javax/time/temporal/TCKWeekFields.java ! test/javax/time/tck/javax/time/temporal/TestChronoLocalDate.java ! test/javax/time/tck/javax/time/temporal/TestChronoLocalDateTime.java ! test/javax/time/tck/javax/time/temporal/TestChronoZonedDateTime.java ! test/javax/time/test/javax/time/temporal/TestChronoUnit.java ! test/javax/time/test/javax/time/temporal/TestISOChronoImpl.java ! test/javax/time/test/javax/time/temporal/TestJapaneseChronoImpl.java ! test/javax/time/test/javax/time/temporal/TestThaiBuddhistChronoImpl.java From xueming.shen at oracle.com Thu Jan 3 20:12:41 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 04 Jan 2013 04:12:41 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: To use PrefixTree for zoneid parser, with case insensitive support Message-ID: <20130104041303.5A01447522@hg.openjdk.java.net> Changeset: b2274bc59393 Author: sherman Date: 2013-01-03 20:12 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b2274bc59393 To use PrefixTree for zoneid parser, with case insensitive support ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/test/javax/time/format/TestZoneIdParser.java From xueming.shen at oracle.com Thu Jan 3 20:15:07 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 03 Jan 2013 20:15:07 -0800 Subject: [threeten-dev] hg: threeten/threeten/jdk: To use PrefixTree for zoneid parser, with case insensitive support In-Reply-To: <20130104041303.5A01447522@hg.openjdk.java.net> References: <20130104041303.5A01447522@hg.openjdk.java.net> Message-ID: <50E6574B.5000808@oracle.com> I separated the ZoneText and ZoneId parsing support and checked in the ZoneId part first, which works. http://cr.openjdk.java.net/~sherman/jdk8_threeten/zid_parser2/ -Sherman On 1/3/2013 8:12 PM, xueming.shen at oracle.com wrote: > Changeset: b2274bc59393 > Author: sherman > Date: 2013-01-03 20:12 -0800 > URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b2274bc59393 > > To use PrefixTree for zoneid parser, with case insensitive support > > ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java > ! test/javax/time/test/javax/time/format/TestZoneIdParser.java > From scolebourne at joda.org Fri Jan 4 02:32:03 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 4 Jan 2013 10:32:03 +0000 Subject: [threeten-dev] zidtext parser In-Reply-To: <50E5F132.7000302@oracle.com> References: <50E5F132.7000302@oracle.com> Message-ID: On 3 January 2013 20:59, Xueming Shen wrote: > Here is the first try of adding the zidtext parser > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/zidtext_parse In the test, you should use Queries.zoneId() instead of Queries.zone() as it is stricter and a better test. I committed a change for this. > But I'm not sure what the best way is to handle the "general" zone > names, such as "Mountain Standard Time", "Western European Time". > We have m:1 mapping when printing, what should we do for the > 1:m parsing? Pick a "representable" zid and hardcode the mapping? Realy, we should implement the rules described in CLDR, as they seem to have thought about it: http://www.unicode.org/reports/tr35/#Time_Zone_Fallback Stephen From scolebourne at joda.org Fri Jan 4 03:15:18 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 04 Jan 2013 11:15:18 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Tweak last commit Message-ID: <20130104111551.E547F47550@hg.openjdk.java.net> Changeset: 89eb2f19c80d Author: scolebourne Date: 2013-01-04 11:09 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/89eb2f19c80d Tweak last commit zoneId() query is stricter than zone() so more appropriate here ! src/share/classes/javax/time/format/DateTimeFormatterBuilder.java ! test/javax/time/test/javax/time/format/TestZoneIdParser.java From scolebourne at joda.org Fri Jan 4 04:30:11 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 04 Jan 2013 12:30:11 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Complete change to queries allowing invoke in either direction Message-ID: <20130104123042.A2E3147554@hg.openjdk.java.net> Changeset: cb004b9af1fb Author: scolebourne Date: 2013-01-04 12:29 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cb004b9af1fb Complete change to queries allowing invoke in either direction ! src/share/classes/javax/time/temporal/Queries.java ! test/javax/time/tck/javax/time/TCKDayOfWeek.java ! test/javax/time/tck/javax/time/TCKInstant.java ! test/javax/time/tck/javax/time/TCKLocalDate.java ! test/javax/time/tck/javax/time/TCKLocalDateTime.java ! test/javax/time/tck/javax/time/TCKLocalTime.java ! test/javax/time/tck/javax/time/TCKMonth.java ! test/javax/time/tck/javax/time/TCKZoneOffset.java ! test/javax/time/tck/javax/time/TCKZonedDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java ! test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java From Roger.Riggs at oracle.com Fri Jan 4 06:47:48 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 04 Jan 2013 09:47:48 -0500 Subject: [threeten-dev] Freezing the API for M6 Message-ID: <50E6EB94.1070100@oracle.com> Hi, To enable the 310 API to be included in the M6 JDK build [1] the API must be stable and frozen in its near final form for a couple of weeks. The javax.time packages will be renamed to java.time.* and cleanup of the javadoc and build mechanisms will be done. After the change, developers will need to use the JDK build mechanism or adapt their toolchains to mimic the JDK build. The new build-Infra build system is quite quick on incremental updates. The javadoc will be generated for the reviews necessary before OpenJDK integration. As of Jan 6th, API changes will need to be deferred for a couple of weeks and finding and fixing bugs in the implementation is encouraged. Specification (javadoc) changes to remove erroneous material are encouraged or to clarify the behavior. Please file issues [2] to track changes or problems. Thanks, Roger [1] OpenJDK Build schedule http://openjdk.java.net/projects/jdk8/builds [2] Threeten Issue Tracker https://github.com/ThreeTen/threeten/issues From xueming.shen at oracle.com Fri Jan 4 09:03:26 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 04 Jan 2013 09:03:26 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> Message-ID: <50E70B5E.1050904@oracle.com> On 1/4/13 2:32 AM, Stephen Colebourne wrote: > Realy, we should implement the rules described in CLDR, as they seem > to have thought about it: > http://www.unicode.org/reports/tr35/#Time_Zone_Fallback we need pull in more cldr data... > Stephen From scolebourne at joda.org Fri Jan 4 09:07:58 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 4 Jan 2013 17:07:58 +0000 Subject: [threeten-dev] zidtext parser In-Reply-To: <50E70B5E.1050904@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> Message-ID: For this release or JDK 9? We need to ensure that we don't do anything that prevents implementing the full CLDR strategy if we are not doing it now. Stephen On 4 January 2013 17:03, Xueming Shen wrote: > On 1/4/13 2:32 AM, Stephen Colebourne wrote: >> >> Realy, we should implement the rules described in CLDR, as they seem >> to have thought about it: >> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback > > > we need pull in more cldr data... > > >> Stephen > > From xueming.shen at oracle.com Fri Jan 4 09:22:22 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 04 Jan 2013 09:22:22 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> Message-ID: <50E70FCE.70402@oracle.com> Let's try for this release. It's not good to have an unsupported operation exception there:-) On 1/4/13 9:07 AM, Stephen Colebourne wrote: > For this release or JDK 9? > We need to ensure that we don't do anything that prevents implementing > the full CLDR strategy if we are not doing it now. > Stephen > > On 4 January 2013 17:03, Xueming Shen wrote: >> On 1/4/13 2:32 AM, Stephen Colebourne wrote: >>> Realy, we should implement the rules described in CLDR, as they seem >>> to have thought about it: >>> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback >> >> we need pull in more cldr data... >> >> >>> Stephen >> From xueming.shen at oracle.com Fri Jan 4 12:39:47 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 04 Jan 2013 12:39:47 -0800 Subject: [threeten-dev] [threeten-develop] Move tzdb compiler out of j.t.z In-Reply-To: <50DC68E0.2040200@oracle.com> References: <50D6BE4D.1040008@oracle.com> <50DC68E0.2040200@oracle.com> Message-ID: <50E73E13.4010805@oracle.com> Stephen, Here is the webrev of planB, with a copycat sun.tools.tzdb.ZoneRules (need to access to the internal state of zonerules which is not currently exposed by public apis. may need a better alternative for the name) http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzcompiler -Sherman On 12/27/2012 07:27 AM, Xueming Shen wrote: > Due to the lack of access to ZoneRules' serialization form directly. The "form" is actually > inside ZoneRules now. Outsourcing (the plan B) is an alternative. I guess the performance > will be indeed a concern, if you actually have all the historical zone date inside one tzdb.jar. > But I still don't understand why you want to do that:-) Given the nature of how the > tzdb database is organized, all the historical data are all included in the latest version. > I can guess, it may be useful, if you want to recover from an invalid zdt (created early with > an earlier version of "latest" rules" at certain point, but do you really need such an > "infrastructure" to support such kind of "rare" case. And given the current spec and impl > of zdt, most developer should be happy to be able to recover simply from the ldt and > offset info (based on what they really mean of "zdt" in their use case). > > We will go with plan B. > > -Sherman > > On 12/27/2012 9:58 AM, Stephen Colebourne wrote: >> On 23 December 2012 08:18, Xueming Shen wrote: >>> Here is the webrev for moving the tzdb compiler out of j.t.z package. >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzc/ >>> >>> The approach here appears to cause a slower startup compared to the >>> existing one, as it uses ObjectOutput/InputStream directly to write out and >>> read in zrules, instead of the DateOutput/InputStream, in which the existing >>> impl can take advantage of the direct access to Ser to write out/read in >>> "byte[]" of the zrules, so the TzdbZoneRuleProvider can do lazy-init. The >>> compiler can't do it now because the Ser is package private. >> Is the slow down due to ObjectInputStream, or the lack of access to Ser? >> >> My preference would be to duplicate the logic from Ser into the >> builder (or possibly move it to a sun package helper class). More like >> plan B. >> >> Performance reading large tzdb files has been a problem in the past, >> which is why the format is structured as it is, and the loader >> carefully caches byte arrays. (Used to take over 30 seconds to start). >> >> It is important to test and ensure that a tzdb file with a large >> number of versions of the database also loads quickly (I'm aware that >> Oracle may not like this scenario, but the API supports historic >> versions and the tool should provide a mechanism to create a file that >> has those historic versions). >> >> Stephen >> >> >>> The plan-B is to externalize the Ser.write/read to somewhere, so the byte[] >>> of the zrules' serialization form can be shared by the tzdb compiler (output >>> side) and the tzdb provider (input side). Given we are talking about 600+ >>> zone (the rules number is bigger) and a total< 40k data here, I took the >>> simple, but slow, approach. We can revisit the start-up issue later, if it >>> indeed >>> is a concern. Let me know if you have concern of this approach, we can go >>> Plan-B. >>> >>> I brought back the test for the ZoneRulesBuilder, as promised. But it >>> appears >>> there is a test failure at line#805. I have not looked into the detail yet. >>> Just >>> wonder if you have any idea. >>> >>> The changes in ZoneRulesBuilder are to workaround the >>> beforeOffset==afterOffset issue. The old implementation creates the trans >>> even two offsets are the same (use that package private constructor which >>> does not do sanity check), but then throw it away. The code now does the >>> sanity check before creating the trans. >>> >>> -Sherman >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122712 >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop From Roger.Riggs at oracle.com Sun Jan 6 14:13:06 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Sun, 06 Jan 2013 17:13:06 -0500 Subject: [threeten-dev] Review of package renaming Message-ID: <50E9F6F2.5070204@oracle.com> Hi, Here's a webrev for the renaming of the packages from javax.time to java.time and the corresponding update to various make files. The javadoc has been generated with the new package names. A tag/jsr310-prem6 /has been created for the revision just before the rename. Any comments before the commit? -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From misterm at gmail.com Mon Jan 7 02:45:08 2013 From: misterm at gmail.com (Michael Nascimento) Date: Mon, 7 Jan 2013 08:45:08 -0200 Subject: [threeten-dev] Review of package renaming In-Reply-To: <50E9F6F2.5070204@oracle.com> References: <50E9F6F2.5070204@oracle.com> Message-ID: Besides copyright not being updated to 2013, LGTM. Regards, Michael On Sun, Jan 6, 2013 at 8:13 PM, Roger Riggs wrote: > Hi, > > Here's a webrev for the renaming > of the packages > from javax.time to java.time > and the corresponding update to various make files. > > The javadoc has been > generated with the new package names. > > A tag/jsr310-prem6 /has been created for the revision just before the > rename. > > Any comments before the commit? > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > From Roger.Riggs at oracle.com Mon Jan 7 06:15:01 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 07 Jan 2013 09:15:01 -0500 Subject: [threeten-dev] Webrev for renames of WeekDefinition and JulianDayFields In-Reply-To: References: <50D2945D.4030707@Oracle.com> Message-ID: <50EAD865.1010404@oracle.com> ok, will fix copyrights shortly; probably as a separate push. On 12/20/2012 4:06 AM, Stephen Colebourne wrote: > +1 > > On 20 December 2012 04:30, Roger Riggs wrote: >> Hi, >> >> Please review these changes to rename WeekDefinition to WeekFields and >> JulianDayField to JulianFields. >> >> http://cr.openjdk.java.net/~rriggs/webrev-renames/ >> >> Thanks, Roger >> -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From roger.riggs at oracle.com Mon Jan 7 10:11:14 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Mon, 07 Jan 2013 18:11:14 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 4 new changesets Message-ID: <20130107181232.BD482470B8@hg.openjdk.java.net> Changeset: 443b01db80c6 Author: rriggs Date: 2013-01-06 16:29 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/443b01db80c6 Last changeset before rename to java.* package ! .hgtags Changeset: 955a4efd3934 Author: rriggs Date: 2013-01-06 16:31 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/955a4efd3934 Removed tag pre-package-renames ! .hgtags Changeset: 70888b11ccac Author: rriggs Date: 2013-01-06 16:32 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/70888b11ccac Last changeset before rename to java.* package for M6 integration ! .hgtags Changeset: 4eb4ff0abd73 Author: rriggs Date: 2013-01-06 16:54 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4eb4ff0abd73 Rename javax.time packages to java.time; update makefiles, javadoc, builds, etc ! make/docs/CORE_PKGS.gmk + make/java/time/Makefile - make/javax/time/Makefile ! make/netbeans/threeten/build.xml ! makefiles/CompileTimeZoneData.gmk + src/share/classes/java/time/Clock.java + src/share/classes/java/time/DateTimeException.java + src/share/classes/java/time/DayOfWeek.java + src/share/classes/java/time/Duration.java + src/share/classes/java/time/Instant.java + src/share/classes/java/time/LocalDate.java + src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/LocalTime.java + src/share/classes/java/time/Month.java + src/share/classes/java/time/Period.java + src/share/classes/java/time/PeriodParser.java + src/share/classes/java/time/Ser.java + src/share/classes/java/time/ZoneId.java + src/share/classes/java/time/ZoneOffset.java + src/share/classes/java/time/ZoneRegion.java + src/share/classes/java/time/ZonedDateTime.java + src/share/classes/java/time/calendar/ChronoDateImpl.java + src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahDate.java + src/share/classes/java/time/calendar/HijrahDeviationReader.java + src/share/classes/java/time/calendar/HijrahEra.java + src/share/classes/java/time/calendar/JapaneseChrono.java + src/share/classes/java/time/calendar/JapaneseDate.java + src/share/classes/java/time/calendar/JapaneseEra.java + src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoDate.java + src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendar/Ser.java + src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistDate.java + src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package.html + src/share/classes/java/time/format/DateTimeBuilder.java + src/share/classes/java/time/format/DateTimeFormatStyleProvider.java + src/share/classes/java/time/format/DateTimeFormatSymbols.java + src/share/classes/java/time/format/DateTimeFormatter.java + src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/DateTimeFormatters.java + src/share/classes/java/time/format/DateTimeParseContext.java + src/share/classes/java/time/format/DateTimeParseException.java + src/share/classes/java/time/format/DateTimePrintContext.java + src/share/classes/java/time/format/DateTimePrintException.java + src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/SignStyle.java + src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package.html + src/share/classes/java/time/overview.html + src/share/classes/java/time/package.html + src/share/classes/java/time/temporal/Adjusters.java + src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/temporal/ChronoField.java + src/share/classes/java/time/temporal/ChronoLocalDate.java + src/share/classes/java/time/temporal/ChronoLocalDateTime.java + src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/temporal/ChronoUnit.java + src/share/classes/java/time/temporal/ChronoZonedDateTime.java + src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/temporal/Era.java + src/share/classes/java/time/temporal/ISOChrono.java + src/share/classes/java/time/temporal/ISOEra.java + src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/JulianFields.java + src/share/classes/java/time/temporal/MonthDay.java + src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/temporal/OffsetDateTime.java + src/share/classes/java/time/temporal/OffsetTime.java + src/share/classes/java/time/temporal/Queries.java + src/share/classes/java/time/temporal/Ser.java + src/share/classes/java/time/temporal/SimplePeriod.java + src/share/classes/java/time/temporal/Temporal.java + src/share/classes/java/time/temporal/TemporalAccessor.java + src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalField.java + src/share/classes/java/time/temporal/TemporalQuery.java + src/share/classes/java/time/temporal/TemporalSubtractor.java + src/share/classes/java/time/temporal/TemporalUnit.java + src/share/classes/java/time/temporal/ValueRange.java + src/share/classes/java/time/temporal/WeekFields.java + src/share/classes/java/time/temporal/Year.java + src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package.html + src/share/classes/java/time/zone/Ser.java + src/share/classes/java/time/zone/TzdbZoneRulesCompiler.java + src/share/classes/java/time/zone/TzdbZoneRulesProvider.java + src/share/classes/java/time/zone/ZoneOffsetTransition.java + src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java + src/share/classes/java/time/zone/ZoneRules.java + src/share/classes/java/time/zone/ZoneRulesBuilder.java + src/share/classes/java/time/zone/ZoneRulesException.java + src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package.html ! src/share/classes/java/util/Formatter.java - src/share/classes/javax/time/Clock.java - src/share/classes/javax/time/DateTimeException.java - src/share/classes/javax/time/DayOfWeek.java - src/share/classes/javax/time/Duration.java - src/share/classes/javax/time/Instant.java - src/share/classes/javax/time/LocalDate.java - src/share/classes/javax/time/LocalDateTime.java - src/share/classes/javax/time/LocalTime.java - src/share/classes/javax/time/Month.java - src/share/classes/javax/time/Period.java - src/share/classes/javax/time/PeriodParser.java - src/share/classes/javax/time/Ser.java - src/share/classes/javax/time/ZoneId.java - src/share/classes/javax/time/ZoneOffset.java - src/share/classes/javax/time/ZoneRegion.java - src/share/classes/javax/time/ZonedDateTime.java - src/share/classes/javax/time/calendar/ChronoDateImpl.java - src/share/classes/javax/time/calendar/HijrahChrono.java - src/share/classes/javax/time/calendar/HijrahDate.java - src/share/classes/javax/time/calendar/HijrahDeviationReader.java - src/share/classes/javax/time/calendar/HijrahEra.java - src/share/classes/javax/time/calendar/JapaneseChrono.java - src/share/classes/javax/time/calendar/JapaneseDate.java - src/share/classes/javax/time/calendar/JapaneseEra.java - src/share/classes/javax/time/calendar/MinguoChrono.java - src/share/classes/javax/time/calendar/MinguoDate.java - src/share/classes/javax/time/calendar/MinguoEra.java - src/share/classes/javax/time/calendar/Ser.java - src/share/classes/javax/time/calendar/ThaiBuddhistChrono.java - src/share/classes/javax/time/calendar/ThaiBuddhistDate.java - src/share/classes/javax/time/calendar/ThaiBuddhistEra.java - src/share/classes/javax/time/calendar/package.html - src/share/classes/javax/time/format/DateTimeBuilder.java - src/share/classes/javax/time/format/DateTimeFormatStyleProvider.java - src/share/classes/javax/time/format/DateTimeFormatSymbols.java - src/share/classes/javax/time/format/DateTimeFormatter.java - src/share/classes/javax/time/format/DateTimeFormatterBuilder.java - src/share/classes/javax/time/format/DateTimeFormatters.java - src/share/classes/javax/time/format/DateTimeParseContext.java - src/share/classes/javax/time/format/DateTimeParseException.java - src/share/classes/javax/time/format/DateTimePrintContext.java - src/share/classes/javax/time/format/DateTimePrintException.java - src/share/classes/javax/time/format/DateTimeTextProvider.java - src/share/classes/javax/time/format/FormatStyle.java - src/share/classes/javax/time/format/SignStyle.java - src/share/classes/javax/time/format/TextStyle.java - src/share/classes/javax/time/format/package.html - src/share/classes/javax/time/overview.html - src/share/classes/javax/time/package.html - src/share/classes/javax/time/temporal/Adjusters.java - src/share/classes/javax/time/temporal/Chrono.java - src/share/classes/javax/time/temporal/ChronoField.java - src/share/classes/javax/time/temporal/ChronoLocalDate.java - src/share/classes/javax/time/temporal/ChronoLocalDateTime.java - src/share/classes/javax/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/javax/time/temporal/ChronoUnit.java - src/share/classes/javax/time/temporal/ChronoZonedDateTime.java - src/share/classes/javax/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/javax/time/temporal/Era.java - src/share/classes/javax/time/temporal/ISOChrono.java - src/share/classes/javax/time/temporal/ISOEra.java - src/share/classes/javax/time/temporal/ISOFields.java - src/share/classes/javax/time/temporal/JulianFields.java - src/share/classes/javax/time/temporal/MonthDay.java - src/share/classes/javax/time/temporal/OffsetDate.java - src/share/classes/javax/time/temporal/OffsetDateTime.java - src/share/classes/javax/time/temporal/OffsetTime.java - src/share/classes/javax/time/temporal/Queries.java - src/share/classes/javax/time/temporal/Ser.java - src/share/classes/javax/time/temporal/SimplePeriod.java - src/share/classes/javax/time/temporal/Temporal.java - src/share/classes/javax/time/temporal/TemporalAccessor.java - src/share/classes/javax/time/temporal/TemporalAdder.java - src/share/classes/javax/time/temporal/TemporalAdjuster.java - src/share/classes/javax/time/temporal/TemporalField.java - src/share/classes/javax/time/temporal/TemporalQuery.java - src/share/classes/javax/time/temporal/TemporalSubtractor.java - src/share/classes/javax/time/temporal/TemporalUnit.java - src/share/classes/javax/time/temporal/ValueRange.java - src/share/classes/javax/time/temporal/WeekFields.java - src/share/classes/javax/time/temporal/Year.java - src/share/classes/javax/time/temporal/YearMonth.java - src/share/classes/javax/time/temporal/package.html - src/share/classes/javax/time/zone/Ser.java - src/share/classes/javax/time/zone/TzdbZoneRulesCompiler.java - src/share/classes/javax/time/zone/TzdbZoneRulesProvider.java - src/share/classes/javax/time/zone/ZoneOffsetTransition.java - src/share/classes/javax/time/zone/ZoneOffsetTransitionRule.java - src/share/classes/javax/time/zone/ZoneRules.java - src/share/classes/javax/time/zone/ZoneRulesBuilder.java - src/share/classes/javax/time/zone/ZoneRulesException.java - src/share/classes/javax/time/zone/ZoneRulesProvider.java - src/share/classes/javax/time/zone/package.html ! test/Makefile + test/java/time/TEST.properties + test/java/time/tck/java/time/AbstractDateTimeTest.java + test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_System.java + test/java/time/tck/java/time/TCKClock_SystemImplementation.java + test/java/time/tck/java/time/TCKDayOfWeek.java + test/java/time/tck/java/time/TCKDuration.java + test/java/time/tck/java/time/TCKInstant.java + test/java/time/tck/java/time/TCKLocalDate.java + test/java/time/tck/java/time/TCKLocalDateTime.java + test/java/time/tck/java/time/TCKLocalTime.java + test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKZoneId.java + test/java/time/tck/java/time/TCKZoneOffset.java + test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/calendar/TestChronoLocalDate.java + test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java + test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java + test/java/time/tck/java/time/format/TCKDateTimeFormatter.java + test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKDateTimeFormatters.java + test/java/time/tck/java/time/format/TCKDateTimePrintException.java + test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java + test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java + test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java + test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/TCKMonthDay.java + test/java/time/tck/java/time/temporal/TCKOffsetDate.java + test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/temporal/TCKOffsetTime.java + test/java/time/tck/java/time/temporal/TCKSimplePeriod.java + test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/TCKYear.java + test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/tck/java/time/temporal/TestChrono.java + test/java/time/tck/java/time/temporal/TestChronoLocalDate.java + test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java + test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java + test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/zone/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java + test/java/time/test/java/time/AbstractTest.java + test/java/time/test/java/time/MockSimplePeriod.java + test/java/time/test/java/time/TestClock_Fixed.java + test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_SystemImplementation.java + test/java/time/test/java/time/TestClock_Tick.java + test/java/time/test/java/time/TestDuration.java + test/java/time/test/java/time/TestInstant.java + test/java/time/test/java/time/TestLocalDate.java + test/java/time/test/java/time/TestLocalDateTime.java + test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/TestZoneOffset.java + test/java/time/test/java/time/TestZonedDateTime.java + test/java/time/test/java/time/format/AbstractTestPrinterParser.java + test/java/time/test/java/time/format/MockIOExceptionAppendable.java + test/java/time/test/java/time/format/TestCharLiteralParser.java + test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java + test/java/time/test/java/time/format/TestDateTimeFormatter.java + test/java/time/test/java/time/format/TestDateTimeFormatters.java + test/java/time/test/java/time/format/TestDateTimePrintException.java + test/java/time/test/java/time/format/TestDateTimeTextProvider.java + test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNumberParser.java + test/java/time/test/java/time/format/TestNumberPrinter.java + test/java/time/test/java/time/format/TestPadParserDecorator.java + test/java/time/test/java/time/format/TestPadPrinterDecorator.java + test/java/time/test/java/time/format/TestReducedParser.java + test/java/time/test/java/time/format/TestReducedPrinter.java + test/java/time/test/java/time/format/TestSettingsParser.java + test/java/time/test/java/time/format/TestStringLiteralParser.java + test/java/time/test/java/time/format/TestStringLiteralPrinter.java + test/java/time/test/java/time/format/TestTextParser.java + test/java/time/test/java/time/format/TestTextPrinter.java + test/java/time/test/java/time/format/TestZoneIdParser.java + test/java/time/test/java/time/format/TestZoneOffsetParser.java + test/java/time/test/java/time/format/TestZoneOffsetPrinter.java + test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/temporal/MockFieldNoValue.java + test/java/time/test/java/time/temporal/MockFieldValue.java + test/java/time/test/java/time/temporal/TestChronoUnit.java + test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java + test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java + test/java/time/test/java/time/temporal/TestDateTimeValueRange.java + test/java/time/test/java/time/temporal/TestISOChronoImpl.java + test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestMonthDay.java + test/java/time/test/java/time/temporal/TestOffsetDate.java + test/java/time/test/java/time/temporal/TestOffsetDateTime.java + test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java + test/java/time/test/java/time/temporal/TestOffsetTime.java + test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java + test/java/time/test/java/time/temporal/TestYear.java + test/java/time/test/java/time/temporal/TestYearMonth.java + test/java/time/test/java/time/zone/TestFixedZoneRules.java + test/java/time/test/java/util/TestFormatter.java - test/javax/time/TEST.properties - test/javax/time/tck/javax/time/AbstractDateTimeTest.java - test/javax/time/tck/javax/time/AbstractTCKTest.java - test/javax/time/tck/javax/time/TCKClock.java - test/javax/time/tck/javax/time/TCKClock_System.java - test/javax/time/tck/javax/time/TCKClock_SystemImplementation.java - test/javax/time/tck/javax/time/TCKDayOfWeek.java - test/javax/time/tck/javax/time/TCKDuration.java - test/javax/time/tck/javax/time/TCKInstant.java - test/javax/time/tck/javax/time/TCKLocalDate.java - test/javax/time/tck/javax/time/TCKLocalDateTime.java - test/javax/time/tck/javax/time/TCKLocalTime.java - test/javax/time/tck/javax/time/TCKMonth.java - test/javax/time/tck/javax/time/TCKZoneId.java - test/javax/time/tck/javax/time/TCKZoneOffset.java - test/javax/time/tck/javax/time/TCKZonedDateTime.java - test/javax/time/tck/javax/time/calendar/TestChronoLocalDate.java - test/javax/time/tck/javax/time/calendar/TestChronoLocalDateTime.java - test/javax/time/tck/javax/time/calendar/TestHijrahChrono.java - test/javax/time/tck/javax/time/calendar/TestJapaneseChrono.java - test/javax/time/tck/javax/time/calendar/TestMinguoChrono.java - test/javax/time/tck/javax/time/calendar/TestThaiBuddhistChrono.java - test/javax/time/tck/javax/time/format/TCKDateTimeFormatSymbols.java - test/javax/time/tck/javax/time/format/TCKDateTimeFormatter.java - test/javax/time/tck/javax/time/format/TCKDateTimeFormatterBuilder.java - test/javax/time/tck/javax/time/format/TCKDateTimeFormatters.java - test/javax/time/tck/javax/time/format/TCKDateTimePrintException.java - test/javax/time/tck/javax/time/format/TCKDateTimeTextPrinting.java - test/javax/time/tck/javax/time/format/TCKLocalizedFieldParser.java - test/javax/time/tck/javax/time/format/TCKLocalizedFieldPrinter.java - test/javax/time/tck/javax/time/temporal/TCKDateTimeAdjusters.java - test/javax/time/tck/javax/time/temporal/TCKISOFields.java - test/javax/time/tck/javax/time/temporal/TCKJulianFields.java - test/javax/time/tck/javax/time/temporal/TCKMonthDay.java - test/javax/time/tck/javax/time/temporal/TCKOffsetDate.java - test/javax/time/tck/javax/time/temporal/TCKOffsetDateTime.java - test/javax/time/tck/javax/time/temporal/TCKOffsetTime.java - test/javax/time/tck/javax/time/temporal/TCKSimplePeriod.java - test/javax/time/tck/javax/time/temporal/TCKWeekFields.java - test/javax/time/tck/javax/time/temporal/TCKYear.java - test/javax/time/tck/javax/time/temporal/TCKYearMonth.java - test/javax/time/tck/javax/time/temporal/TestChrono.java - test/javax/time/tck/javax/time/temporal/TestChronoLocalDate.java - test/javax/time/tck/javax/time/temporal/TestChronoLocalDateTime.java - test/javax/time/tck/javax/time/temporal/TestChronoZonedDateTime.java - test/javax/time/tck/javax/time/temporal/TestISOChrono.java - test/javax/time/tck/javax/time/zone/TCKFixedZoneRules.java - test/javax/time/tck/javax/time/zone/TCKZoneOffsetTransition.java - test/javax/time/tck/javax/time/zone/TCKZoneOffsetTransitionRule.java - test/javax/time/tck/javax/time/zone/TCKZoneRules.java - test/javax/time/tck/javax/time/zone/TCKZoneRulesProvider.java - test/javax/time/test/java/util/TestFormatter.java - test/javax/time/test/javax/time/AbstractTest.java - test/javax/time/test/javax/time/MockSimplePeriod.java - test/javax/time/test/javax/time/TestClock_Fixed.java - test/javax/time/test/javax/time/TestClock_Offset.java - test/javax/time/test/javax/time/TestClock_SystemImplementation.java - test/javax/time/test/javax/time/TestClock_Tick.java - test/javax/time/test/javax/time/TestDuration.java - test/javax/time/test/javax/time/TestInstant.java - test/javax/time/test/javax/time/TestLocalDate.java - test/javax/time/test/javax/time/TestLocalDateTime.java - test/javax/time/test/javax/time/TestLocalTime.java - test/javax/time/test/javax/time/TestPeriod.java - test/javax/time/test/javax/time/TestPeriodParser.java - test/javax/time/test/javax/time/TestZoneId.java - test/javax/time/test/javax/time/TestZoneOffset.java - test/javax/time/test/javax/time/TestZonedDateTime.java - test/javax/time/test/javax/time/format/AbstractTestPrinterParser.java - test/javax/time/test/javax/time/format/MockIOExceptionAppendable.java - test/javax/time/test/javax/time/format/TestCharLiteralParser.java - test/javax/time/test/javax/time/format/TestCharLiteralPrinter.java - test/javax/time/test/javax/time/format/TestDateTimeFormatSymbols.java - test/javax/time/test/javax/time/format/TestDateTimeFormatter.java - test/javax/time/test/javax/time/format/TestDateTimeFormatters.java - test/javax/time/test/javax/time/format/TestDateTimePrintException.java - test/javax/time/test/javax/time/format/TestDateTimeTextProvider.java - test/javax/time/test/javax/time/format/TestFractionPrinterParser.java - test/javax/time/test/javax/time/format/TestNumberParser.java - test/javax/time/test/javax/time/format/TestNumberPrinter.java - test/javax/time/test/javax/time/format/TestPadParserDecorator.java - test/javax/time/test/javax/time/format/TestPadPrinterDecorator.java - test/javax/time/test/javax/time/format/TestReducedParser.java - test/javax/time/test/javax/time/format/TestReducedPrinter.java - test/javax/time/test/javax/time/format/TestSettingsParser.java - test/javax/time/test/javax/time/format/TestStringLiteralParser.java - test/javax/time/test/javax/time/format/TestStringLiteralPrinter.java - test/javax/time/test/javax/time/format/TestTextParser.java - test/javax/time/test/javax/time/format/TestTextPrinter.java - test/javax/time/test/javax/time/format/TestZoneIdParser.java - test/javax/time/test/javax/time/format/TestZoneOffsetParser.java - test/javax/time/test/javax/time/format/TestZoneOffsetPrinter.java - test/javax/time/test/javax/time/format/TestZoneTextPrinterParser.java - test/javax/time/test/javax/time/temporal/MockFieldNoValue.java - test/javax/time/test/javax/time/temporal/MockFieldValue.java - test/javax/time/test/javax/time/temporal/TestChronoUnit.java - test/javax/time/test/javax/time/temporal/TestDateTimeAdjusters.java - test/javax/time/test/javax/time/temporal/TestDateTimeBuilderCombinations.java - test/javax/time/test/javax/time/temporal/TestDateTimeValueRange.java - test/javax/time/test/javax/time/temporal/TestISOChronoImpl.java - test/javax/time/test/javax/time/temporal/TestJapaneseChronoImpl.java - test/javax/time/test/javax/time/temporal/TestMonthDay.java - test/javax/time/test/javax/time/temporal/TestOffsetDate.java - test/javax/time/test/javax/time/temporal/TestOffsetDateTime.java - test/javax/time/test/javax/time/temporal/TestOffsetDateTime_instants.java - test/javax/time/test/javax/time/temporal/TestOffsetTime.java - test/javax/time/test/javax/time/temporal/TestThaiBuddhistChronoImpl.java - test/javax/time/test/javax/time/temporal/TestYear.java - test/javax/time/test/javax/time/temporal/TestYearMonth.java - test/javax/time/test/javax/time/zone/TestFixedZoneRules.java From Roger.Riggs at oracle.com Mon Jan 7 12:26:48 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 07 Jan 2013 15:26:48 -0500 Subject: [threeten-dev] Building threeten In-Reply-To: References: <50E6EB94.1070100@oracle.com> Message-ID: <50EB2F88.4050305@oracle.com> Hi, I've been using the new Build-infra build (on linux so far) since it is quicker than the conventional one. http://openjdk.java.net/projects/build-infra/guide.html It relies on Cygwin as a Linux lookalike shell and tools. I'm will try out a Windows build to see if there are any kinks. Roger On 1/7/2013 3:08 PM, Stephen Colebourne wrote: > > Are there any recommended build instructions now for Windows? > Stephen > > On Jan 4, 2013 2:48 PM, "Roger Riggs" > wrote: > > Hi, > > To enable the 310 API to be included in the M6 JDK build [1] the > API must > be stable and frozen in its near final form for a couple of weeks. > > The javax.time packages will be renamed to java.time.* and cleanup > of the javadoc and build mechanisms will be done. After the change, > developers will need to use the JDK build mechanism or adapt their > toolchains to mimic the JDK build. The new build-Infra build > system is > quite quick on incremental updates. > > The javadoc will be generated for the reviews necessary before OpenJDK > integration. > > As of Jan 6th, API changes will need to be deferred for a couple > of weeks and > finding and fixing bugs in the implementation is encouraged. > Specification (javadoc) > changes to remove erroneous material are encouraged or to clarify > the behavior. > Please file issues [2] to track changes or problems. > > Thanks, Roger > > [1] OpenJDK Build schedule > http://openjdk.java.net/projects/jdk8/builds > [2] Threeten Issue Tracker https://github.com/ThreeTen/threeten/issues > > > ------------------------------------------------------------------------------ > Master HTML5, CSS3, ASP.NET , MVC, AJAX, > Knockout.js, Web API and > much more. Get web development skills now with LearnDevNow - > 350+ hours of step-by-step video tutorials by Microsoft MVPs and > experts. > SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122812 > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/threeten-develop > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122412 > > > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From xueming.shen at oracle.com Mon Jan 7 12:37:40 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 07 Jan 2013 12:37:40 -0800 Subject: [threeten-dev] [threeten-develop] Move tzdb compiler out of j.t.z In-Reply-To: <50E73E13.4010805@oracle.com> References: <50D6BE4D.1040008@oracle.com> <50DC68E0.2040200@oracle.com> <50E73E13.4010805@oracle.com> Message-ID: <50EB3214.407@oracle.com> webrev has been updated to work with the java/time world. http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzcompiler/ -Sherman On 01/04/2013 12:39 PM, Xueming Shen wrote: > Stephen, > > Here is the webrev of planB, with a copycat sun.tools.tzdb.ZoneRules (need > to access to the internal state of zonerules which is not currently exposed by > public apis. may need a better alternative for the name) > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzcompiler > > -Sherman > > On 12/27/2012 07:27 AM, Xueming Shen wrote: >> Due to the lack of access to ZoneRules' serialization form directly. The "form" is actually >> inside ZoneRules now. Outsourcing (the plan B) is an alternative. I guess the performance >> will be indeed a concern, if you actually have all the historical zone date inside one tzdb.jar. >> But I still don't understand why you want to do that:-) Given the nature of how the >> tzdb database is organized, all the historical data are all included in the latest version. >> I can guess, it may be useful, if you want to recover from an invalid zdt (created early with >> an earlier version of "latest" rules" at certain point, but do you really need such an >> "infrastructure" to support such kind of "rare" case. And given the current spec and impl >> of zdt, most developer should be happy to be able to recover simply from the ldt and >> offset info (based on what they really mean of "zdt" in their use case). >> >> We will go with plan B. >> >> -Sherman >> >> On 12/27/2012 9:58 AM, Stephen Colebourne wrote: >>> On 23 December 2012 08:18, Xueming Shen wrote: >>>> Here is the webrev for moving the tzdb compiler out of j.t.z package. >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzc/ >>>> >>>> The approach here appears to cause a slower startup compared to the >>>> existing one, as it uses ObjectOutput/InputStream directly to write out and >>>> read in zrules, instead of the DateOutput/InputStream, in which the existing >>>> impl can take advantage of the direct access to Ser to write out/read in >>>> "byte[]" of the zrules, so the TzdbZoneRuleProvider can do lazy-init. The >>>> compiler can't do it now because the Ser is package private. >>> Is the slow down due to ObjectInputStream, or the lack of access to Ser? >>> >>> My preference would be to duplicate the logic from Ser into the >>> builder (or possibly move it to a sun package helper class). More like >>> plan B. >>> >>> Performance reading large tzdb files has been a problem in the past, >>> which is why the format is structured as it is, and the loader >>> carefully caches byte arrays. (Used to take over 30 seconds to start). >>> >>> It is important to test and ensure that a tzdb file with a large >>> number of versions of the database also loads quickly (I'm aware that >>> Oracle may not like this scenario, but the API supports historic >>> versions and the tool should provide a mechanism to create a file that >>> has those historic versions). >>> >>> Stephen >>> >>> >>>> The plan-B is to externalize the Ser.write/read to somewhere, so the byte[] >>>> of the zrules' serialization form can be shared by the tzdb compiler (output >>>> side) and the tzdb provider (input side). Given we are talking about 600+ >>>> zone (the rules number is bigger) and a total< 40k data here, I took the >>>> simple, but slow, approach. We can revisit the start-up issue later, if it >>>> indeed >>>> is a concern. Let me know if you have concern of this approach, we can go >>>> Plan-B. >>>> >>>> I brought back the test for the ZoneRulesBuilder, as promised. But it >>>> appears >>>> there is a test failure at line#805. I have not looked into the detail yet. >>>> Just >>>> wonder if you have any idea. >>>> >>>> The changes in ZoneRulesBuilder are to workaround the >>>> beforeOffset==afterOffset issue. The old implementation creates the trans >>>> even two offsets are the same (use that package private constructor which >>>> does not do sanity check), but then throw it away. The code now does the >>>> sanity check before creating the trans. >>>> >>>> -Sherman >>> ------------------------------------------------------------------------------ >>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >>> MVPs and experts. ON SALE this month only -- learn more at: >>> http://p.sf.net/sfu/learnmore_122712 >>> _______________________________________________ >>> threeten-develop mailing list >>> threeten-develop at lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/threeten-develop > From xueming.shen at oracle.com Mon Jan 7 13:47:18 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 07 Jan 2013 21:47:18 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Moved TzdbZoneRulesCompiler to its own package Message-ID: <20130107214744.93C57470C9@hg.openjdk.java.net> Changeset: b1626a53f867 Author: sherman Date: 2013-01-07 13:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b1626a53f867 Moved TzdbZoneRulesCompiler to its own package removed "time" from javax.time.Makefile ! make/java/time/Makefile ! make/javax/Makefile + make/sun/tzdb/Makefile ! makefiles/CompileTimeZoneData.gmk - src/share/classes/java/time/zone/TzdbZoneRulesCompiler.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java - src/share/classes/java/time/zone/ZoneRulesBuilder.java + src/share/classes/sun/tools/tzdb/TzdbZoneRulesCompiler.java + src/share/classes/sun/tools/tzdb/ZoneRules.java + src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java + test/java/time/test/sun/tools/tzdb/TestZoneRulesBuilder.java From roger.riggs at oracle.com Mon Jan 7 14:23:59 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Mon, 07 Jan 2013 22:23:59 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130107222423.B6ED5470D0@hg.openjdk.java.net> Changeset: a4788d880c4a Author: rriggs Date: 2013-01-07 16:59 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a4788d880c4a Added Oracle copyrights to OpenJDK boilerplate ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/PeriodParser.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/calendar/package.html ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package.html ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package.html ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package.html ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesCompiler.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesBuilder.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/time/zone/package.html ! test/java/time/tck/java/time/AbstractDateTimeTest.java ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/TCKClock.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_SystemImplementation.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendar/TestHijrahChrono.java ! test/java/time/tck/java/time/calendar/TestJapaneseChrono.java ! test/java/time/tck/java/time/calendar/TestMinguoChrono.java ! test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimePrintException.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java ! test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java ! test/java/time/tck/java/time/temporal/TCKISOFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java ! test/java/time/tck/java/time/temporal/TCKMonthDay.java ! test/java/time/tck/java/time/temporal/TCKOffsetDate.java ! test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java ! test/java/time/tck/java/time/temporal/TCKOffsetTime.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/tck/java/time/temporal/TCKYear.java ! test/java/time/tck/java/time/temporal/TCKYearMonth.java ! test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/tck/java/time/temporal/TestISOChrono.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java ! test/java/time/test/java/time/AbstractTest.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/TestClock_Fixed.java ! test/java/time/test/java/time/TestClock_Offset.java ! test/java/time/test/java/time/TestClock_SystemImplementation.java ! test/java/time/test/java/time/TestClock_Tick.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/TestInstant.java ! test/java/time/test/java/time/TestLocalDate.java ! test/java/time/test/java/time/TestLocalDateTime.java ! test/java/time/test/java/time/TestLocalTime.java ! test/java/time/test/java/time/TestPeriod.java ! test/java/time/test/java/time/TestPeriodParser.java ! test/java/time/test/java/time/TestZoneId.java ! test/java/time/test/java/time/TestZoneOffset.java ! test/java/time/test/java/time/TestZonedDateTime.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java ! test/java/time/test/java/time/format/MockIOExceptionAppendable.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestCharLiteralPrinter.java ! test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeFormatters.java ! test/java/time/test/java/time/format/TestDateTimePrintException.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestStringLiteralPrinter.java ! test/java/time/test/java/time/format/TestTextParser.java ! test/java/time/test/java/time/format/TestTextPrinter.java ! test/java/time/test/java/time/format/TestZoneIdParser.java ! test/java/time/test/java/time/format/TestZoneOffsetParser.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java ! test/java/time/test/java/time/temporal/TestChronoUnit.java ! test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java ! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java ! test/java/time/test/java/time/temporal/TestISOChronoImpl.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/temporal/TestMonthDay.java ! test/java/time/test/java/time/temporal/TestOffsetDate.java ! test/java/time/test/java/time/temporal/TestOffsetDateTime.java ! test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java ! test/java/time/test/java/time/temporal/TestOffsetTime.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java ! test/java/time/test/java/time/temporal/TestYear.java ! test/java/time/test/java/time/temporal/TestYearMonth.java ! test/java/time/test/java/time/zone/TestFixedZoneRules.java Changeset: 9fdcdea8213b Author: rriggs Date: 2013-01-07 17:18 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9fdcdea8213b Merge - src/share/classes/java/time/zone/TzdbZoneRulesCompiler.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java - src/share/classes/java/time/zone/ZoneRulesBuilder.java + test/java/time/test/sun/tools/tzdb/TestZoneRulesBuilder.java From xueming.shen at oracle.com Tue Jan 8 10:12:24 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:12:24 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 67 new changesets Message-ID: <20130108182525.7EA2847100@hg.openjdk.java.net> Changeset: 4ea0ac8e02d2 Author: erikj Date: 2012-12-19 09:46 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4ea0ac8e02d2 8004803: build-infra: Cannot use icedtea as boot for closed build. Summary: Set bootclasspath to javac and not the running jvm Reviewed-by: ohair ! makefiles/CreateJars.gmk Changeset: a8012d8d7e9c Author: katleman Date: 2012-12-19 13:38 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a8012d8d7e9c Merge Changeset: 4d5db5c038b4 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4d5db5c038b4 Added tag jdk8-b69 for changeset a8012d8d7e9c ! .hgtags Changeset: ad6097d547e1 Author: kvn Date: 2012-12-18 17:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ad6097d547e1 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/classes/sun/misc/Unsafe.java Changeset: 12fa4d7ecaf5 Author: twisti Date: 2012-12-20 11:16 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/12fa4d7ecaf5 8005345: JSR 292: JDK performance tweaks Reviewed-by: kvn, jrose ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/sun/invoke/util/ValueConversions.java Changeset: 8cf5b18488d1 Author: dl Date: 2012-12-20 12:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8cf5b18488d1 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Add Unsafe addAndGet() methods which have intrinsics in Hotspot (7023898) Reviewed-by: alanb, kvn ! src/share/classes/sun/misc/Unsafe.java Changeset: 6b41b40526c6 Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6b41b40526c6 Merge Changeset: 1ad29569d6e9 Author: erikj Date: 2012-12-20 13:05 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1ad29569d6e9 8005178: build-infra: Dependency on libfdlibm on mac is broken Reviewed-by: tbell, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: a68090f0dc1a Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a68090f0dc1a 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/macosx/native/sun/font/CCharToGlyphMapper.m ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Block.java ! src/share/classes/java/util/function/DoubleBlock.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBlock.java ! src/share/classes/java/util/function/LongBlock.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/sun/java2d/pipe/ParallelogramPipe.java ! src/share/classes/sun/tools/jcmd/JCmd.java ! src/share/native/java/util/zip/zlib-1.2.5/gzlib.c ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/sun/tools/attach/BsdVirtualMachine.c ! src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/windows/native/common/jdk_util_md.h ! test/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI/7089914/bug7089914.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/TextArea/DisposeTest/TestDispose.java ! test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java ! test/java/awt/TextField/DisposeTest/TestDispose.java ! test/java/lang/Integer/Unsigned.java ! test/java/lang/Long/Unsigned.java ! test/java/lang/Math/CubeRootTests.java ! test/java/lang/Math/Expm1Tests.java ! test/java/lang/Math/HyperbolicTests.java ! test/java/lang/Math/Log10Tests.java ! test/java/lang/Math/Log1pTests.java ! test/java/lang/Math/Tests.java ! test/java/lang/StringBuffer/TestSynchronization.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/math/BigDecimal/FloatDoubleValueTests.java ! test/java/math/BigDecimal/StrippingZerosTest.java ! test/java/net/Inet4Address/PingThis.java ! test/java/net/ProxySelector/MultiThreadedSystemProxies.java ! test/java/security/Signature/VerifyRangeCheckOverflow.java ! test/java/util/AbstractCollection/ToArrayTest.java ! test/java/util/Map/EntryHashCode.java ! test/java/util/concurrent/FutureTask/DoneTimedGetLoops.java ! test/java/util/logging/LoggerResourceBundleRace.java ! test/java/util/logging/LoggingDeadlock2.java ! test/java/util/logging/LoggingDeadlock3.java ! test/java/util/logging/SimpleFormatterFormat.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml ! test/javax/swing/JComponent/7154030/bug7154030.java ! test/javax/swing/JTabbedPane/4310381/bug4310381.java ! test/javax/swing/JTable/4235420/bug4235420.java ! test/javax/swing/JTable/6788484/bug6788484.java ! test/javax/swing/JTable/7055065/bug7055065.java ! test/javax/swing/JTable/7188612/JTableAccessibleGetLocationOnScreen.java ! test/javax/swing/JTextArea/7049024/bug7049024.java ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/DefaultCaret/6938583/bug6938583.java ! test/sun/management/AgentCMETest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/nio/ch/SelProvider.java ! test/sun/rmi/rmic/classpath/RMICClassPathTest.java ! test/sun/security/krb5/auto/ReplayCache.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java ! test/sun/tools/jps/jps-V_2.sh ! test/tools/jar/JarBackSlash.java ! test/tools/launcher/UnicodeTest.java Changeset: 9dc1990c7d90 Author: yhuang Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9dc1990c7d90 7195759: ISO 4217 Amendment 154 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/java/util/LocaleISOData.java ! src/share/classes/sun/util/resources/CurrencyNames.properties ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cbf255324369 Author: yhuang Date: 2012-12-23 19:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cbf255324369 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: a996b57e5541 Author: katleman Date: 2012-12-26 14:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a996b57e5541 Merge Changeset: 8d7651351cfe Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8d7651351cfe Added tag jdk8-b70 for changeset a996b57e5541 ! .hgtags Changeset: a988c23b8553 Author: jgodinez Date: 2012-12-20 14:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a988c23b8553 7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt Reviewed-by: bae, prr ! src/windows/native/sun/windows/awt_Debug.cpp Changeset: 2cf07dbdee64 Author: bae Date: 2012-12-24 14:03 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2cf07dbdee64 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244,244,0 Reviewed-by: prr ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c + test/sun/java2d/cmm/ColorConvertOp/GrayTest.java Changeset: 3c1c0b7abe51 Author: bae Date: 2012-12-24 14:22 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3c1c0b7abe51 8005402: Need to provide benchmarks for color management Reviewed-by: jgodinez, prr ! src/share/demo/java2d/J2DBench/build.xml ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/CMMTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConvertOpTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/DataConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ProfileTests.java Changeset: 1316d6d0900e Author: lana Date: 2012-12-28 18:28 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1316d6d0900e Merge Changeset: c25ea633b4de Author: malenkov Date: 2012-12-17 16:58 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c25ea633b4de 8005065: [findbugs] reference to mutable array in JavaBeans Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/Statement.java + test/java/beans/Introspector/Test8005065.java Changeset: a78cb3c5d434 Author: neugens Date: 2012-12-17 17:43 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a78cb3c5d434 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Summary: Don't consider extraenous bits when checking button mask, so that grabWindowRef on the window is not confused and released correctly Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java Changeset: 985b523712c8 Author: kshefov Date: 2012-12-18 15:17 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/985b523712c8 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Reviewed-by: yan, alexsch + test/javax/swing/JFrame/4962534/bug4962534.html + test/javax/swing/JFrame/4962534/bug4962534.java Changeset: 90ad9e922042 Author: lana Date: 2012-12-18 16:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/90ad9e922042 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: 7082a96c02d2 Author: alexp Date: 2012-12-21 19:11 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7082a96c02d2 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Reviewed-by: anthony, alexsch ! test/javax/swing/AncestorNotifier/7193219/bug7193219.java Changeset: 14269f504837 Author: dcherepanov Date: 2012-12-27 16:08 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/14269f504837 8001161: mac: EmbeddedFrame doesn't become active window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: cf2bcb293f0b Author: lana Date: 2012-12-28 18:30 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cf2bcb293f0b Merge Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e515956879cd Merge Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ac5e29b62288 Merge Changeset: 2a5af0f766d0 Author: lana Date: 2012-12-28 18:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2a5af0f766d0 Merge - make/jdk/asm/Makefile ! makefiles/CreateJars.gmk ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 32a57e645e01 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/32a57e645e01 Added tag jdk8-b71 for changeset 2a5af0f766d0 ! .hgtags Changeset: 1f10692a27c1 Author: sherman Date: 2013-01-08 10:10 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1f10692a27c1 Merge ! .hgtags - make/jdk/asm/Makefile From xueming.shen at oracle.com Tue Jan 8 10:29:49 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:29:49 +0000 Subject: [threeten-dev] hg: threeten/threeten/langtools: 24 new changesets Message-ID: <20130108183049.1305947101@hg.openjdk.java.net> Changeset: 2001991b1b40 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/2001991b1b40 Added tag jdk8-b69 for changeset d7360bf35ee1 ! .hgtags Changeset: 7d34e91f66bb Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7d34e91f66bb 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! make/Makefile-classic ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! test/tools/javac/StringsInSwitch/StringSwitches.java ! test/tools/javac/api/T6395981.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/diags/examples/DuplicateAnnotation.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 47f71d7c124f Author: katleman Date: 2012-12-26 14:25 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/47f71d7c124f Merge Changeset: 7d5032c2d747 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7d5032c2d747 Added tag jdk8-b70 for changeset 47f71d7c124f ! .hgtags Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f72dc656a306 Merge Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/573b38691a74 Merge Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java Changeset: 467e4d9281bc Author: lana Date: 2012-12-28 18:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/467e4d9281bc Merge ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 6f0986ed9b7e Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/6f0986ed9b7e Added tag jdk8-b71 for changeset 467e4d9281bc ! .hgtags From xueming.shen at oracle.com Tue Jan 8 10:32:25 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:32:25 +0000 Subject: [threeten-dev] hg: threeten/threeten/hotspot: 48 new changesets Message-ID: <20130108183411.5140047102@hg.openjdk.java.net> Changeset: 4a2ed49abd51 Author: amurillo Date: 2012-12-07 10:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4a2ed49abd51 8004724: new hotspot build - hs25-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 442f942757c0 Author: johnc Date: 2012-10-01 09:28 -0700 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/442f942757c0 8000244: G1: Ergonomically set MarkStackSize and use virtual space for global marking stack Summary: Set the value of MarkStackSize to a value based on the number of parallel marking threads with a reasonable minimum. Expand the marking stack if we have to restart marking due to an overflow up to a reasonable maximum. Allocate the underlying space for the marking stack from virtual memory. Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: a14c5698a162 Author: johnc Date: 2012-12-07 16:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a14c5698a162 Merge Changeset: 2aa953165ade Author: brutisso Date: 2012-12-13 10:09 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2aa953165ade 8004661: Comment and function name java_lang_String::toHash is wrong Summary: renamed to hash_code Reviewed-by: dholmes, coleenp, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp Changeset: db8a7163c682 Author: stefank Date: 2012-12-13 09:28 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/db8a7163c682 8004674: Add necessary .inline.hpp files to fix non-PCH build Reviewed-by: stefank, coleenp Contributed-by: volker.simonis at gmail.com ! src/share/vm/gc_implementation/parallelScavenge/adjoiningVirtualSpaces.cpp ! src/share/vm/gc_implementation/shared/gcStats.cpp Changeset: 4459ef2189f5 Author: stefank Date: 2012-12-13 09:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4459ef2189f5 Merge Changeset: fd74228fd5ca Author: jiangli Date: 2012-12-11 12:41 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/fd74228fd5ca 8004076: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Summary: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Reviewed-by: coleenp, minqi, jrose ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 807f1d348f7b Author: collins Date: 2012-12-14 11:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/807f1d348f7b Merge Changeset: b6c9c0109a60 Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b6c9c0109a60 Merge Changeset: cb8a4e04bc8c Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/cb8a4e04bc8c Added tag hs25-b13 for changeset b6c9c0109a60 ! .hgtags Changeset: 8b4810c80f5d Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/8b4810c80f5d Added tag jdk8-b69 for changeset cb8a4e04bc8c ! .hgtags Changeset: 1f323009c3ea Author: amurillo Date: 2012-12-14 14:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1f323009c3ea 8005036: new hotspot build - hs25-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 892acf0431ef Author: dcubed Date: 2012-12-14 10:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/892acf0431ef 7153050: remove crufty '_g' support from HotSpot repo makefiles Summary: Phase 1 is removing '_g' support from the Makefiles. Reviewed-by: dcubed, sspitsyn, coleenp, tbell Contributed-by: ron.durbin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/debug.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jsig.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/optimized.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/saproc.make ! make/bsd/makefiles/vm.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/debug.make ! make/linux/makefiles/fastdebug.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/jvmg.make ! make/linux/makefiles/optimized.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/projectfiles/compiler2/ADLCompiler.dsp ! make/windows/projectfiles/tiered/ADLCompiler.dsp Changeset: 30866cd626b0 Author: coleenp Date: 2012-12-12 11:39 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/30866cd626b0 8004883: NPG: clean up anonymous class fix Summary: Add klass_holder() to return either mirror or class_loader depending on if the class is anonymous or not. Reviewed-by: stefank, jrose ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp Changeset: 18712b1caf7a Author: rkennke Date: 2012-12-12 21:40 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/18712b1caf7a 8004898: library_call.cpp build error after 7172640 with GCC 4.7.2 Summary: fix opto/library_call.cpp compilation errors Reviewed-by: twisti, coleenp ! src/share/vm/opto/library_call.cpp Changeset: 8580f22db905 Author: coleenp Date: 2012-12-14 16:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/8580f22db905 Merge Changeset: 3f84e17b6bca Author: zgu Date: 2012-12-17 13:14 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/3f84e17b6bca 8004802: jcmd VM.native_memory baseline=false crashes VM Summary: NMT has to check option's value also to determine which command to execute Reviewed-by: acorn, coleenp, hseigel ! src/share/vm/services/nmtDCmd.cpp Changeset: 805aa223d540 Author: zgu Date: 2012-12-17 10:40 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/805aa223d540 Merge Changeset: 594b9b2119ed Author: minqi Date: 2012-12-19 16:10 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/594b9b2119ed Merge Changeset: 0c535211ef13 Author: bharadwaj Date: 2012-12-07 18:13 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0c535211ef13 8004668: Build failure for Zero target Summary: fixed build failure for Zero target Reviewed-by: twisti, kvn ! src/cpu/zero/vm/assembler_zero.cpp Changeset: a70c88896791 Author: kvn Date: 2012-12-13 17:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a70c88896791 8004713: Stackoverflowerror thrown when thread stack straddles 0x80000000 Summary: use unsigned comparison when checking for stack overflow Reviewed-by: kvn, twisti Contributed-by: paul.nauman at oracle.com ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp Changeset: 1b1e16471e46 Author: stefank Date: 2012-12-12 22:41 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1b1e16471e46 8005002: Crash because of a raw oop in ClassLoaderData::add_dependency Summary: Move the handelization of 'last' to a point before the GC might enter. Reviewed-by: dholmes, sspitsyn, coleenp ! src/share/vm/classfile/classLoaderData.cpp Changeset: 5c0931d15474 Author: twisti Date: 2012-12-14 12:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/5c0931d15474 8003238: JSR 292: intermittent exception failure with java/lang/invoke/CallSiteTest.java Reviewed-by: jrose, kvn ! src/share/vm/prims/methodHandles.cpp Changeset: 3c433d080bae Author: twisti Date: 2012-12-14 12:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/3c433d080bae Merge Changeset: 18d56ca3e901 Author: twisti Date: 2012-12-17 11:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/18d56ca3e901 8004548: remove unused AbstractAssembler::print(Label&) Reviewed-by: kvn, twisti Contributed-by: Bharadwaj Yadavalli ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: ad5dd04754ee Author: roland Date: 2012-12-18 14:55 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ad5dd04754ee 8005031: Some cleanup in c2 to prepare for incremental inlining support Summary: collection of small changes to prepare for incremental inlining. Reviewed-by: twisti, kvn ! src/share/vm/ci/ciField.cpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp Changeset: eb409f2f146e Author: vlivanov Date: 2012-12-18 06:52 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/eb409f2f146e 8003135: HotSpot inlines and hoists the Thread.currentThread().isInterrupted() out of the loop Summary: Make the load of TLS._osthread._interrupted flag in Thread.isInterrupted(Z)Z intrinsic effectively volatile. Reviewed-by: kvn, jrose ! src/share/vm/opto/library_call.cpp Changeset: 620e502e3f47 Author: vlivanov Date: 2012-12-18 08:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/620e502e3f47 Merge ! src/share/vm/opto/library_call.cpp Changeset: c4bd2eccea46 Author: twisti Date: 2012-12-18 10:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c4bd2eccea46 8004536: replace AbstractAssembler emit_word with emit_int16 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 1e41b0bc58a0 Author: kvn Date: 2012-12-18 17:37 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1e41b0bc58a0 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 65c8342f726a Author: twisti Date: 2012-12-19 14:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/65c8342f726a 8005033: clear high word for integer pop count on SPARC Reviewed-by: kvn, twisti Contributed-by: Richard Reingruber ! src/cpu/sparc/vm/sparc.ad + test/compiler/8005033/Test8005033.java Changeset: 2c7f594145dc Author: kvn Date: 2012-12-19 15:40 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2c7f594145dc 8004835: Improve AES intrinsics on x86 Summary: Enable AES intrinsics on non-AVX cpus, group together aes instructions in crypto stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! test/compiler/7184394/TestAESBase.java ! test/compiler/7184394/TestAESMain.java Changeset: 2d6c433b1f38 Author: kvn Date: 2012-12-19 19:21 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2d6c433b1f38 8004741: Missing compiled exception handle table entry for multidimensional array allocation Summary: Added missing exception path for multidimensional array allocation and use Throwable type instead of OutOfMemoryError for allocation's exception. Reviewed-by: twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp + test/compiler/8004741/Test8004741.java Changeset: a46457045d66 Author: kvn Date: 2012-12-20 14:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a46457045d66 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Fix java names for getAndSet intrinsics Reviewed-by: kvn Contributed-by: aleksey.shipilev at oracle.com ! src/share/vm/classfile/vmSymbols.hpp Changeset: d02120b7a34f Author: twisti Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d02120b7a34f 8004250: replace AbstractAssembler a_byte/a_long with emit_int8/emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: c52660592f37 Author: roland Date: 2012-12-21 01:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c52660592f37 Merge ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/opto/library_call.cpp Changeset: 0b3d19153cc6 Author: johnc Date: 2012-12-12 12:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0b3d19153cc6 8001028: Improve GC option handling Summary: If there are not enough native resources to create the ReferenceHandler or Finalizer Java threads, the VM will attempt to throw an OOME before the java.lang.Class class has been initialized. This can result in assertion failures and other crashes. Move the initialization of the java.lang.Class class to just before the initialization of the java.lang.ref.Finalizer class. Reviewed-by: jwilhelm, dholmes, coleenp ! src/share/vm/runtime/thread.cpp Changeset: 730cc4ddd550 Author: brutisso Date: 2012-12-17 08:49 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/730cc4ddd550 7173959: Jvm crashed during coherence exabus (tmb) testing Summary: Mapping of aligned memory needs to be MT safe. Also reviewed by: vitalyd at gmail.com Reviewed-by: dholmes, coleenp, zgu ! src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 32164d89fe9c Author: brutisso Date: 2012-12-17 15:25 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/32164d89fe9c 8004845: Catch incorrect usage of new and delete during compile time for value objects and stack objects Summary: Makes the "new" and "delete" operator of _ValueObj and StackObj private Reviewed-by: dholmes, coleenp Contributed-by: erik.helin at oracle.com ! src/share/vm/memory/allocation.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: c71879335291 Author: stefank Date: 2012-12-18 10:40 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c71879335291 8005108: NPG: MetaspaceAux::used_in_bytes(), capacity_in_bytes() and reserved_in_bytes() return inconsistent numbers Summary: Reverted the changes to these functions from JDK-8000662 Reviewed-by: brutisso, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 345bd97a77be Author: brutisso Date: 2012-12-20 05:31 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/345bd97a77be 8004691: Add a jtreg test that exercises the ExecuteInternalVMTests flag Reviewed-by: stefank, brutisso, kvn, ctornqvi Contributed-by: erik.helin at oracle.com + test/sanity/ExecuteInternalVMTests.java Changeset: 69627aa9ab10 Author: jwilhelm Date: 2012-12-21 16:33 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/69627aa9ab10 Merge ! src/share/vm/runtime/thread.cpp Changeset: 990bbd393c23 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/990bbd393c23 Merge Changeset: 6a1fc440b396 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/6a1fc440b396 Added tag hs25-b14 for changeset 990bbd393c23 ! .hgtags Changeset: 79f492f184d0 Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/79f492f184d0 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMetadata.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java ! agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java ! agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java ! agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java ! agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! agent/src/share/native/sadis.c ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/runtime/os_ext.hpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! test/runtime/7158804/Test7158804.sh Changeset: e94068d4ff52 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e94068d4ff52 Merge ! src/share/vm/classfile/classLoaderData.hpp Changeset: 0847210f8548 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0847210f8548 Added tag jdk8-b70 for changeset e94068d4ff52 ! .hgtags Changeset: d5cb5830f570 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d5cb5830f570 Added tag jdk8-b71 for changeset 0847210f8548 ! .hgtags From xueming.shen at oracle.com Tue Jan 8 10:35:53 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:35:53 +0000 Subject: [threeten-dev] hg: threeten/threeten/corba: 3 new changesets Message-ID: <20130108183556.0DB3A47104@hg.openjdk.java.net> Changeset: 603cceb495c8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/603cceb495c8 Added tag jdk8-b69 for changeset 22ddcac208a8 ! .hgtags Changeset: 8171d23e914d Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/8171d23e914d Added tag jdk8-b70 for changeset 603cceb495c8 ! .hgtags Changeset: cb40427f4714 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/cb40427f4714 Added tag jdk8-b71 for changeset 8171d23e914d ! .hgtags From xueming.shen at oracle.com Tue Jan 8 10:36:46 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:36:46 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxp: 10 new changesets Message-ID: <20130108183713.2E42547105@hg.openjdk.java.net> Changeset: 27421008f050 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/27421008f050 Added tag jdk8-b69 for changeset 789a855de959 ! .hgtags Changeset: a72c8391cdd6 Author: katleman Date: 2012-12-20 16:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/a72c8391cdd6 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/FactoryImpl.java Changeset: 6ec9edffc286 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/6ec9edffc286 Merge Changeset: 63815efd132f Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/63815efd132f Added tag jdk8-b70 for changeset 6ec9edffc286 ! .hgtags Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/8a20e948b806 Merge Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 499be952a291 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/499be952a291 Merge Changeset: bdf2af722a6b Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/bdf2af722a6b Added tag jdk8-b71 for changeset 499be952a291 ! .hgtags From xueming.shen at oracle.com Tue Jan 8 10:37:48 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 18:37:48 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxws: 3 new changesets Message-ID: <20130108183757.40D8547106@hg.openjdk.java.net> Changeset: 3b1c2733d47e Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/3b1c2733d47e Added tag jdk8-b69 for changeset 756323c99011 ! .hgtags Changeset: f577a39c9fb3 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/f577a39c9fb3 Added tag jdk8-b70 for changeset 3b1c2733d47e ! .hgtags Changeset: d9707230294d Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/d9707230294d Added tag jdk8-b71 for changeset f577a39c9fb3 ! .hgtags From xueming.shen at oracle.com Tue Jan 8 11:26:30 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 Jan 2013 19:26:30 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated the makefiles to repair the "broken" old build system Message-ID: <20130108192651.3768847108@hg.openjdk.java.net> Changeset: 213020c2bf55 Author: sherman Date: 2013-01-08 11:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/213020c2bf55 Updated the makefiles to repair the "broken" old build system ! make/java/Makefile ! make/sun/Makefile From Roger.Riggs at oracle.com Wed Jan 9 09:03:18 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 09 Jan 2013 12:03:18 -0500 Subject: [threeten-dev] Review for #198 Chrono Initialization and Service Loader Message-ID: <50EDA2D6.9050007@oracle.com> Please review this fix for the issue with Chronology initialization and the ServiceLoader. http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ The initialization of the lists of Chronologies is deferred until it is needed for the list of available Chronologies or to get a Chronology by name. The change exposed an issue with caching calendars that may be thread context specific which is not yet resolved. To support extended Calendars from application specific classloaders, caching should be limited to those in the bootclassloader. Additional code will be needed in the Chrono.of() and Chrono.getAvailableChronologies() methods to use the Thread's context and look for additional Chronologies. For client runtimes, this may be not necessary or useful but for server use the application server runtime may need to be able to support application specific calendar implementations. Tests for the serviceloader and extensible calendars have been added using the Coptic calendar as a test calendar. Opinions? -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From xueming.shen at oracle.com Wed Jan 9 09:34:15 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 09 Jan 2013 09:34:15 -0800 Subject: [threeten-dev] Review for #198 Chrono Initialization and Service Loader In-Reply-To: <50EDA2D6.9050007@oracle.com> References: <50EDA2D6.9050007@oracle.com> Message-ID: <50EDAA17.4050909@oracle.com> It appears the spec does not specify clearly whether or not the getAvailableChronologies() and this class support dynamically lookup, means new chronology can be added dynamically during the lifetime of jvm via the service loader. Is it intended that the of(String id) to be case sensitive when it's "id"? It may be worth specifying it explicitly, even it is specified in LDML (I'm not sure about this) The implementation note uses "This interface..." -Sherman On 01/09/2013 09:03 AM, Roger Riggs wrote: > Please review this fix for the issue with Chronology initialization and the ServiceLoader. > > http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ > > The initialization of the lists of Chronologies is deferred until it is needed > for the list of available Chronologies or to get a Chronology by name. > > The change exposed an issue with caching calendars that may be thread context > specific which is not yet resolved. To support extended Calendars from application specific > classloaders, caching should be limited to those in the bootclassloader. > Additional code will be needed in the Chrono.of() and Chrono.getAvailableChronologies() > methods to use the Thread's context and look for additional Chronologies. > For client runtimes, this may be not necessary or useful but for server use > the application server runtime may need to be able to support application specific > calendar implementations. > > Tests for the serviceloader and extensible calendars have been added using the > Coptic calendar as a test calendar. > > Opinions? > From Roger.Riggs at oracle.com Wed Jan 9 10:42:07 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 09 Jan 2013 13:42:07 -0500 Subject: [threeten-dev] [threeten-develop] Review for #198 Chrono Initialization and Service Loader In-Reply-To: References: <50EDA2D6.9050007@oracle.com> Message-ID: <50EDB9FF.5090000@oracle.com> ok, I'll use the ServiceLoader for all but ISOChrono so the profiles/modularity work is easier. Roger On 1/9/2013 12:12 PM, Stephen Colebourne wrote: > You are hard coding the registration of alternate calendar systems, > but surely that won't work in an embeded environment? > > I would write the constructors with no code as having {} on two lines. > > Stephen > > > > On 9 January 2013 17:03, Roger Riggs > wrote: > > Please review this fix for the issue with Chronology > initialization and the ServiceLoader. > > http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ > > > The initialization of the lists of Chronologies is deferred until > it is needed > for the list of available Chronologies or to get a Chronology by name. > > The change exposed an issue with caching calendars that may be > thread context > specific which is not yet resolved. To support extended Calendars > from application specific > classloaders, caching should be limited to those in the > bootclassloader. > Additional code will be needed in the Chrono.of() and > Chrono.getAvailableChronologies() > methods to use the Thread's context and look for additional > Chronologies. > For client runtimes, this may be not necessary or useful but for > server use > the application server runtime may need to be able to support > application specific > calendar implementations. > > Tests for the serviceloader and extensible calendars have been > added using the > Coptic calendar as a test calendar. > > Opinions? > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is > committed to developing practices and products that help protect > the environment > > > ------------------------------------------------------------------------------ > Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, > jQuery > and much more. Keep your Java skills current with LearnJavaNow - > 200+ hours of step-by-step video tutorials by Java experts. > SALE $49.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122612 > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/threeten-develop > > > > > ------------------------------------------------------------------------------ > Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery > and much more. Keep your Java skills current with LearnJavaNow - > 200+ hours of step-by-step video tutorials by Java experts. > SALE $49.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122612 > > > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From Roger.Riggs at oracle.com Wed Jan 9 11:37:46 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 09 Jan 2013 14:37:46 -0500 Subject: [threeten-dev] Integration of the Threeten/JSR 310 into JDK M6 Message-ID: <50EDC70A.2090004@oracle.com> The Threeten project [1] is planned to be integrated into OpenJDK with the M6 milestone. The javadoc [2] (aka JSR 310 specification) for the new Java Time packages is available for review. Comments can be sent to the threeten-dev email list [3] or entered in the issue tracker [4]. When Threeten is incorporated in M6, the regular jdk8 build can be used by developers to provide feedback based on concrete experience. The Threeten API will continue to be refined. Feedback will be evaluated for inclusion in the public review of JSR 310 and subsequent JDK builds. [1] http://openjdk.java.net/projects/threeten/ [2] http://cr.openjdk.java.net/~rriggs/threeten-javadoc/ [3] threeten-dev @ openjdk.java.net [4] https://github.com/ThreeTen/threeten/issues From Roger.Riggs at Oracle.com Wed Jan 9 18:07:02 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Wed, 09 Jan 2013 21:07:02 -0500 Subject: [threeten-dev] Extra Cygwin setup info Message-ID: <50EE2246.7000101@Oracle.com> Hi, Here's a bit of supplemental information about getting Cygwin setup to build the threeten repository. The list of Cygwin commands that need to be installed may be useful. Roger From misterm at gmail.com Thu Jan 10 01:30:46 2013 From: misterm at gmail.com (Michael Nascimento) Date: Thu, 10 Jan 2013 07:30:46 -0200 Subject: [threeten-dev] Extra Cygwin setup info In-Reply-To: <50EE2246.7000101@Oracle.com> References: <50EE2246.7000101@Oracle.com> Message-ID: Roger, The actual information is missing. Regards, Michael From scolebourne at joda.org Thu Jan 10 02:52:46 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 10 Jan 2013 10:52:46 +0000 Subject: [threeten-dev] Extra Cygwin setup info In-Reply-To: References: <50EE2246.7000101@Oracle.com> Message-ID: There is a list here, along with full instructions: http://java.net/projects/adoptopenjdk/pages/BuildWindows Stephen On 10 January 2013 09:30, Michael Nascimento wrote: > Roger, > > The actual information is missing. > > Regards, > Michael From Roger.Riggs at Oracle.com Thu Jan 10 05:56:52 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Thu, 10 Jan 2013 08:56:52 -0500 Subject: [threeten-dev] Extra Cygwin setup info In-Reply-To: References: <50EE2246.7000101@Oracle.com> Message-ID: <50EEC8A4.6030104@Oracle.com> Sorry, I forgot that openjdk mailing lists delete attachments. Roger Inline ------------------------------------------------------------------------ This document describes the steps to build OpenJdk on Windows with the new build system, which is much faster than the existing build. Prerequisites * Visual Studio Install Visual Studio 2010 Professional, Only VC++ is required. * Cygwin Install Cygwin and related packages. Binary Name Category Package Description ar.exe Devel binutils The GNU assembler, linker and binary utilities make.exe Devel make The GNU version of the 'make' utility built for CYGWIN m4.exe Interpreters m4 GNU implementation of the traditional Unix macro processor cpio.exe Utils cpio A program to manage archives of files gawk.exe Base gawk Pattern-directed scanning and processing language file.exe Utils file Determines file type using 'magic' numbers zip.exe Archive zip Package and compress (archive) files unzip.exe Archive unzip Extract compressed files in a ZIP archive free.exe System procps Display amount of free and used memory in the system * Mercurial Install Mercurial and forest extension. * External Libraries The only external library needed on Windows is *freetype*. As there is no default directory for it, you must specify it explicitly in the configuration using option, --with-freetype. Be sure to get the 64-bit version if building the 64-bit jdk (64-bit is the default). Getting Source Code |> hg fclone http:| |//hg.openjdk.java.net/jdk8/tl jdk8| Configuration Useful Options * --help Display help information. * --with-freetype Specify the path for the freetype2 package. (*Must* in Windows) * --with-boot-jdk Specify the path to Boot jdk. * --enable-debug Example Compilation Useful Targets * make help Display help information * make images Create complete j2sdk and j2re images, like the old build produced * make clean Remove all files generated by make, but not those generated by configure * make dist-clean Remove all files generated by both make and configure (basically killing the configuration) Note * Don't use ~ in the path, instead use absolute path to make uncygdrive.exe work properly. For example, ~/dev/Jdk/jdk8 should be changed to /cygdrive/c/cygwin/home/danxu/dev/Jdk/jdk8. * Please refer to http://openjdk.java.net/projects/build-infra/guide.html for more details. On 01/10/2013 04:30 AM, Michael Nascimento wrote: > Roger, > > The actual information is missing. > > Regards, > Michael From Roger.Riggs at oracle.com Thu Jan 10 11:16:30 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 10 Jan 2013 14:16:30 -0500 Subject: [threeten-dev] Review for #198 Chrono Initialization and Service Loader In-Reply-To: <50EDB9FF.5090000@oracle.com> References: <50EDA2D6.9050007@oracle.com> <50EDB9FF.5090000@oracle.com> Message-ID: <50EF138E.60904@oracle.com> The Webrev has been updated: http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ The choice about whether the extra calendars are loaded with the ServiceLoader is not yet resolved. For now, the code treats the calendars as built-in. We can switch later when the choice has been made. Roger On 1/9/2013 1:42 PM, Roger Riggs wrote: > ok, I'll use the ServiceLoader for all but ISOChrono so the > profiles/modularity work is easier. > > Roger > > > On 1/9/2013 12:12 PM, Stephen Colebourne wrote: >> You are hard coding the registration of alternate calendar systems, >> but surely that won't work in an embeded environment? >> >> I would write the constructors with no code as having {} on two lines. >> >> Stephen >> >> >> >> On 9 January 2013 17:03, Roger Riggs > > wrote: >> >> Please review this fix for the issue with Chronology >> initialization and the ServiceLoader. >> >> http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ >> >> >> The initialization of the lists of Chronologies is deferred until >> it is needed >> for the list of available Chronologies or to get a Chronology by >> name. >> >> The change exposed an issue with caching calendars that may be >> thread context >> specific which is not yet resolved. To support extended Calendars >> from application specific >> classloaders, caching should be limited to those in the >> bootclassloader. >> Additional code will be needed in the Chrono.of() and >> Chrono.getAvailableChronologies() >> methods to use the Thread's context and look for additional >> Chronologies. >> For client runtimes, this may be not necessary or useful but for >> server use >> the application server runtime may need to be able to support >> application specific >> calendar implementations. >> >> Tests for the serviceloader and extensible calendars have been >> added using the >> Coptic calendar as a test calendar. >> >> Opinions? >> >> -- >> Thanks, Roger >> >> Oracle Java Platform Group >> >> Green Oracle Oracle is >> committed to developing practices and products that help protect >> the environment >> >> >> ------------------------------------------------------------------------------ >> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, >> jQuery >> and much more. Keep your Java skills current with LearnJavaNow - >> 200+ hours of step-by-step video tutorials by Java experts. >> SALE $49.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122612 >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> >> https://lists.sourceforge.net/lists/listinfo/threeten-develop >> >> >> >> >> ------------------------------------------------------------------------------ >> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery >> and much more. Keep your Java skills current with LearnJavaNow - >> 200+ hours of step-by-step video tutorials by Java experts. >> SALE $49.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122612 >> >> >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From scolebourne at joda.org Thu Jan 10 11:49:30 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 10 Jan 2013 19:49:30 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Better spec/Javadoc Message-ID: <20130110195009.85C1A47190@hg.openjdk.java.net> Changeset: ed3691ff949c Author: scolebourne Date: 2013-01-10 19:42 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ed3691ff949c Better spec/Javadoc ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java From yoshito_umaoka at us.ibm.com Thu Jan 10 12:45:49 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Thu, 10 Jan 2013 15:45:49 -0500 Subject: [threeten-dev] Possible addition of pattern letters in CLDR In-Reply-To: <50D37356.1060709@oracle.com> References: <50C8ACE8.2060907@oracle.com> <50CA6014.3080209@oracle.com> <50CAA45D.6090000@oracle.com> <50D24A58.4030303@oracle.com> <50D37356.1060709@oracle.com> Message-ID: I'm working on date format pattern letters on CLDR side. Below is the current status. [Time Zone Patterns] Design document: http://cldr.unicode.org/development/development-process/design-proposals/time-zone-offset-patterns 1) Letter 'X' - ISO 8601 difference between local time and UTC format, or UTC designator CLDR TC agreed to add letter 'X'. This is mostly compatible with Java 7 + JSR-310 enhancement. There are several minor differences from Java 7/JSR-310 Pattern "X" is used for 'shortest' ISO 8601 'difference between local time and UTC' basic format, or "Z" when offset is 0. This is slightly different from the current Java SimpleDateFormat/JSR-310 specification in next two cases. - Minutes field might be appended when the field is not 0 - for example, "+0530". - "Z" (UTC designator) is used when both offset hours and minutes are 0, even seconds field is not 0. So it will never return "+00" or "-00". Pattern "XX" and "XXX" is used for ISO 8601 'difference between local time and UTC' format ("XX" basic format / "XXX" extended format) including minutes, or "Z" when offset is 0. These are also slightly different from the current Java SimpleDateFormat. - "Z" (UTC designator) is used when both offset hours and minutes are 0, even seconds field is not 0. So it will never return "+0000", "-0000", "+00:00". Pattern "XXXX" and "XXXXX" is used for ISO 8601 'difference between local time and UTC' style format, or "Z" when offset is 0. These are equivalent to the patterns currently defined in JSR-310 javax.time.format.DateFormatters. Note that the format including offset seconds is illegal in ISO 8601. "XXXX" or "XXXXX" might be only used when time zone offset must be preserved including non zero seconds field. 2) Letter 'x' - ISO 8601 difference between local time and UTC format CLDR TC agreed to add letter 'x' in parallel to 'X' above. This is not available in Java 7 / JSR-310. The design goal of the 'x' patterns is to provide ISO 8601 difference between local time and UTC format, without special case "Z" (UTC designator). - Pattern 'xx' is equivalent to "Z" and "ZZ" in Java, "Z"/"ZZ"/"ZZZ" in the current LDML specification - Pattern 'xxx' is equivalent to "ZZZ" or longer in Java. 3) Letter 'O' - Localized GMT format This is also accepted. 'O' patterns are used for LDML's "localized GMT format". "O" is used for short format and "OOOO" is used for long format (equivalent to "ZZZZ" in the current LDML specification). This format is similar to GMTOffsetTimeZone format in Java's SimpleDateFormat, but message pattern, field separator and digits can be localized. 4) Time Zone Identifier I proposed letter 'I' that is compatible with the current JSR-310 specification, but I got some comments against this. - Do not want to waste a new pattern letter just for this. This pattern probably does not need any variants ("II", "III"...) - I is easily confused with l I was suggested to look for other patterns without a new letter. There are some candidates in my mind - "zzzzz" (Cons: collision with Java SimpleDateFormat), "V" (Cons: LDML spec backward compatibility problem - although the patter is technically deprecated), "VV" (Cons: looks awkward in Java, without supporting "V"). We may still end up to "I", but need some more discussion in CLDR TC. [Fractional Seconds] I created a new CLDR ticket [http://unicode.org/cldr/trac/ticket/5556]. We discussed about this briefly, but I need a little bit more investigation for a couple of things - 1) whether if we need to consider 0 as the length of minimum decimal fractions. 2) backward compatibility problem - letter '#' is not reserved for the current syntax, although it is unlikely used practically. [Nano Seconds] 'n' and 'N' are not discussed in the CLDR TC yet. I'm a little bit worrying about 'X' and 'x'. If you have any comments, please let me know. At this point, if I did not get any pushbacks from JSR-310 community, 'X' / 'x' / 'O' will be added to LDMLR specification for CLDR 23 release (March). Thanks, Yoshito From yoshito_umaoka at us.ibm.com Thu Jan 10 13:04:03 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Thu, 10 Jan 2013 16:04:03 -0500 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: <50D10DC9.9080505@oracle.com> References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> Message-ID: > - CLDR type "islamic" is used for religious calendar now. Although > actual date may vary, it is probably not worth adding variations. > > - CLDR type "islamicc" is used for arithmetical calendar now. This > type could be separated into multiple different variations. > > I'm wondering if you can create a CLDR ticket with proposed types? > I can add my comment and bring this to a CLDR meeting. > > Ticket #5525 opened: > http://unicode.org/cldr/trac/ticket/5525 > > At the moment (for JDK8), we are only interested in the Saudi Arabia > government's official sighting and Umm Al-Qura calendar only. > However, I think it would be adequate to make it possible to add > other variants as needed by users or in a future release. > > Regards, > -Dan We had a discussion about this in the CLDR TC meeting. Our tentative consensus is supporting calendar variations with a new extension. Although CLDR defines two types "islamic" and "islamicc", CLDR only has one set of formatting data. From formatting aspect, the difference in date calculation between them is not important. Our current plan is: 1. Add a new extension "cv" (calendar algorithm variant - tentative). 2. Investigate necessary types from experts, based on some references including your ticket above. 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be determined later). Note that the type value is limited to 8 characters because of BCP 47 definition. We also considered multi-segment calendar type like islamic-umalqura as you suggested in the ticket, but it will require a bunch of duplicated references in CLDR data formatting data. For this reason, we are in favor of separating minor algorithm differences in a separate extension. -Yoshito From scolebourne at joda.org Thu Jan 10 17:20:00 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 11 Jan 2013 01:20:00 +0000 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> Message-ID: On 10 January 2013 21:04, wrote: > We had a discussion about this in the CLDR TC meeting. > Our tentative consensus is supporting calendar variations with a new > extension. > > Although CLDR defines two types "islamic" and "islamicc", CLDR only has > one set of formatting data. From formatting aspect, the difference in date > calculation between them is not important. Our current plan is: > > 1. Add a new extension "cv" (calendar algorithm variant - tentative). > 2. Investigate necessary types from experts, based on some references > including your ticket above. > 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be > determined later). > > Note that the type value is limited to 8 characters because of BCP 47 > definition. We also considered multi-segment calendar type like > islamic-umalqura as you suggested in the ticket, but it will require a > bunch of duplicated references in CLDR data formatting data. For this > reason, we are in favor of separating minor algorithm differences in a > separate extension. FWIW, I like the "cv" variant concept as it makes logical sense. It will be harder to integrate into JSR-310 (where our methods take a single String). The lookup from a Locale object will of course pose no problem to adapt. Stephen From xueming.shen at oracle.com Thu Jan 10 18:44:01 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 10 Jan 2013 18:44:01 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> Message-ID: <50EF7C71.4020508@oracle.com> Hi, One helper class ZoneName, which is based on the metazone data info from metaZone.xml [1] and the zone aliase info from the Link entries of all the tzdb data files, is added to help implement the parsing logic suggested by cldr. The reason we have to have the the zone alias info is that it appears metaZone.xml uses both old name and new name in different places. For each zid/zname candidate the implementation now looks up the metazone table to see if it has a metazone specified for it, if yes, it tries to see if there is a preferred zid defined for a particular locale/region, if yes and if this locale/region matches parser's locale, that preferred zid is used, otherwise, the default/001 zid for the meta zone is returned. The webrev is at http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser The zid->metazone->zid lookup tables is hard coded now in ZoneName. Those mapping tables are generated from the link[2] (which is a result of grep "Link" of all tzdb files), metaZone.xml[1] via the hacky tool MetaZone.java[3]. If this approach is good, I would expect we will get these info from Naoto's TimeZoneUtilities "someday" (I think we are parsing metaZones.xml in cldr tool already, probably for those generic name? we just need to go a little further) The test currently does not fail if the parsed result is not the "expected" one (round trip). The test simply prints out those diff for manual check. If you take a close look at output "result" [4], which shows "zid", "input text", "parsed result" and "expected", it appears all the parsed result is correct/reasonable, I guess the reason those result is not the "expected" is mainly because those zids are not in metaZone.xml. The result[4] shows the parsing works reasonably well for "full" style, but we have lots of "missing/ambiguous" result for those "short" style names. Given the nature of those short names and the limited info (the "locale"), It maybe reasonable to not support those ambiguous short names in parsing? An alternative is to "specify" the mapping table in spec, but it's not going to make every one happy either. Opinion? -Sherman [1] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/metaZones [2] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/link [3] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/MetaZone.java [4] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/result On 01/04/2013 09:07 AM, Stephen Colebourne wrote: > For this release or JDK 9? > We need to ensure that we don't do anything that prevents implementing > the full CLDR strategy if we are not doing it now. > Stephen > > On 4 January 2013 17:03, Xueming Shen wrote: >> On 1/4/13 2:32 AM, Stephen Colebourne wrote: >>> Realy, we should implement the rules described in CLDR, as they seem >>> to have thought about it: >>> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback >> >> we need pull in more cldr data... >> >> >>> Stephen >> From patrick.zhang at oracle.com Fri Jan 11 00:27:34 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Fri, 11 Jan 2013 16:27:34 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.Instant Message-ID: <50EFCCF6.50300@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ In current test code, Instant.minus(TemporalSubtractor substractor) has been included but Instant.minus(long amountToSubtract, TemporalUnit unit) is missed. So below 3 methods are added to cover it: ================== minus_TemporalUnit() minus_TemporalUnit_overflowTooSmall() minus_TemporalUnit_overflowTooBig() ================== Actually the logic is same with existing minus_Duration(), minus_Duration_overflowTooSmall() and minus_Duration_overflowTooBig(). I just use Instant.minus(long amountToSubtract, TemporalUnit unit) to replace Instant.minus(TemporalSubtractor substractor). Test result is here: http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr Regards Patrick From scolebourne at joda.org Fri Jan 11 03:11:19 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 11 Jan 2013 11:11:19 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.Instant In-Reply-To: <50EFCCF6.50300@oracle.com> References: <50EFCCF6.50300@oracle.com> Message-ID: The tests themselves are fine, however, they should be grouped in source code as a set of three after the minus_Duration() tests. The method names should also be changed to include "long"; "minus_TemporalUnit" -> "minus_longTemporalUnit" The same additional three tests should be added for plus. thanks Stephen On 11 January 2013 08:27, Patrick Zhang wrote: > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ > > In current test code, Instant.minus(TemporalSubtractor substractor) has been > included but Instant.minus(long amountToSubtract, TemporalUnit unit) is > missed. > > So below 3 methods are added to cover it: > ================== > minus_TemporalUnit() > minus_TemporalUnit_overflowTooSmall() > minus_TemporalUnit_overflowTooBig() > ================== > > Actually the logic is same with existing minus_Duration(), > minus_Duration_overflowTooSmall() and minus_Duration_overflowTooBig(). I > just use Instant.minus(long amountToSubtract, TemporalUnit unit) to replace > Instant.minus(TemporalSubtractor substractor). > > Test result is here: > http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr > > Regards > Patrick > From roger.riggs at oracle.com Fri Jan 11 06:56:20 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 11 Jan 2013 14:56:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130111145717.280D6471EC@hg.openjdk.java.net> Changeset: 767fa64d0330 Author: rriggs Date: 2013-01-11 09:46 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/767fa64d0330 #198 Service Loader; fixed to cache only system Chronologies; changed jdk_time test to use othervm; serviceloader tests failed with agentvm ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ISOChrono.java ! test/Makefile + test/java/time/META-INF/services/java.time.temporal.Chrono + test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticDate.java + test/java/time/tck/java/time/calendar/CopticEra.java + test/java/time/tck/java/time/calendar/TestServiceLoader.java ! test/java/time/tck/java/time/temporal/TestChrono.java Changeset: 8e21836db7e3 Author: rriggs Date: 2013-01-11 09:53 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8e21836db7e3 Merge From scolebourne at joda.org Fri Jan 11 10:49:30 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 11 Jan 2013 18:49:30 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130111185026.193DD471FD@hg.openjdk.java.net> Changeset: 06c996583459 Author: scolebourne Date: 2013-01-11 11:29 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/06c996583459 Better test method names ! test/java/time/tck/java/time/AbstractDateTimeTest.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TCKOffsetDate.java ! test/java/time/tck/java/time/temporal/TCKOffsetTime.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java Changeset: 2a7f3ddaa67f Author: scolebourne Date: 2013-01-11 18:46 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2a7f3ddaa67f Fix spec, implementation and tests for Clocks ! src/share/classes/java/time/Clock.java ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_Fixed.java + test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java - test/java/time/tck/java/time/TCKClock_SystemImplementation.java + test/java/time/tck/java/time/TCKClock_Tick.java ! test/java/time/test/java/time/TestClock_Fixed.java ! test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_System.java - test/java/time/test/java/time/TestClock_SystemImplementation.java ! test/java/time/test/java/time/TestClock_Tick.java Changeset: fbdbabb4b632 Author: scolebourne Date: 2013-01-11 18:49 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/fbdbabb4b632 Merge From dan.chiba at oracle.com Fri Jan 11 12:49:00 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Fri, 11 Jan 2013 12:49:00 -0800 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> Message-ID: <50F07ABC.6010600@oracle.com> Thank you very much Yoshito-san. Stephen, can the single string be "ca-islamic-cv-???"? Then all we need to do may be define the ???s? Regards, -Dan On 1/10/2013 5:20 PM, Stephen Colebourne wrote: > On 10 January 2013 21:04, wrote: >> We had a discussion about this in the CLDR TC meeting. >> Our tentative consensus is supporting calendar variations with a new >> extension. >> >> Although CLDR defines two types "islamic" and "islamicc", CLDR only has >> one set of formatting data. From formatting aspect, the difference in date >> calculation between them is not important. Our current plan is: >> >> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >> 2. Investigate necessary types from experts, based on some references >> including your ticket above. >> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >> determined later). >> >> Note that the type value is limited to 8 characters because of BCP 47 >> definition. We also considered multi-segment calendar type like >> islamic-umalqura as you suggested in the ticket, but it will require a >> bunch of duplicated references in CLDR data formatting data. For this >> reason, we are in favor of separating minor algorithm differences in a >> separate extension. > FWIW, I like the "cv" variant concept as it makes logical sense. It > will be harder to integrate into JSR-310 (where our methods take a > single String). The lookup from a Locale object will of course pose no > problem to adapt. > > Stephen From scolebourne at joda.org Fri Jan 11 14:01:11 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 11 Jan 2013 22:01:11 +0000 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: <50F07ABC.6010600@oracle.com> References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> Message-ID: The string can be anything you want, as its more of an Oracle requirement than mine. Personally, I would recommend that Oracle chooses a default Islamic calendar variant, so the string "islamic" maps to one of the variants. I would then have the other variants as "islamic-xxx". The ca and cv parts in the 310 calendar system id are not really relevant. Stephen On 11 January 2013 20:49, Dan Chiba wrote: > Thank you very much Yoshito-san. > > Stephen, can the single string be "ca-islamic-cv-???"? Then all we need to > do may be define the ???s? > > Regards, > -Dan > > > On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >> >> On 10 January 2013 21:04, wrote: >>> >>> We had a discussion about this in the CLDR TC meeting. >>> Our tentative consensus is supporting calendar variations with a new >>> extension. >>> >>> Although CLDR defines two types "islamic" and "islamicc", CLDR only has >>> one set of formatting data. From formatting aspect, the difference in >>> date >>> calculation between them is not important. Our current plan is: >>> >>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>> 2. Investigate necessary types from experts, based on some references >>> including your ticket above. >>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>> determined later). >>> >>> Note that the type value is limited to 8 characters because of BCP 47 >>> definition. We also considered multi-segment calendar type like >>> islamic-umalqura as you suggested in the ticket, but it will require a >>> bunch of duplicated references in CLDR data formatting data. For this >>> reason, we are in favor of separating minor algorithm differences in a >>> separate extension. >> >> FWIW, I like the "cv" variant concept as it makes logical sense. It >> will be harder to integrate into JSR-310 (where our methods take a >> single String). The lookup from a Locale object will of course pose no >> problem to adapt. >> >> Stephen From xueming.shen at oracle.com Fri Jan 11 14:13:40 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 11 Jan 2013 14:13:40 -0800 Subject: [threeten-dev] To format the weekday in narrow Message-ID: <50F08E94.3080408@oracle.com> Hi, Here is the change to support the narrow weekday formatting. I also switch to use the j.u.s.CalendarNameProvider directly, instead of bridging via DateFormatSymbols http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmt_narrow Sherman From scolebourne at joda.org Fri Jan 11 14:16:14 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 11 Jan 2013 22:16:14 +0000 Subject: [threeten-dev] To format the weekday in narrow In-Reply-To: <50F08E94.3080408@oracle.com> References: <50F08E94.3080408@oracle.com> Message-ID: Looks good to me Stephen On 11 January 2013 22:13, Xueming Shen wrote: > Hi, > > Here is the change to support the narrow weekday formatting. > I also switch to use the j.u.s.CalendarNameProvider directly, > instead of bridging via DateFormatSymbols > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmt_narrow > > Sherman From xueming.shen at oracle.com Fri Jan 11 14:24:28 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 11 Jan 2013 22:24:28 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added narrow style formatting support for dayofweek Message-ID: <20130111222451.2708F4720C@hg.openjdk.java.net> Changeset: 8864fbfa81f6 Author: sherman Date: 2013-01-11 14:26 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8864fbfa81f6 Added narrow style formatting support for dayofweek ! src/share/classes/java/time/format/DateTimeTextProvider.java ! test/java/time/test/java/time/format/TestTextPrinter.java From xueming.shen at oracle.com Fri Jan 11 15:46:15 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 11 Jan 2013 15:46:15 -0800 Subject: [threeten-dev] doc typo Message-ID: <50F0A447.4070908@oracle.com> http://cr.openjdk.java.net/~sherman/jdk8_threeten/small_docs/ From scolebourne at joda.org Fri Jan 11 17:25:19 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sat, 12 Jan 2013 01:25:19 +0000 Subject: [threeten-dev] doc typo In-Reply-To: <50F0A447.4070908@oracle.com> References: <50F0A447.4070908@oracle.com> Message-ID: +1 Stephen On 11 January 2013 23:46, Xueming Shen wrote: > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/small_docs/ From scolebourne at joda.org Fri Jan 11 17:24:18 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Sat, 12 Jan 2013 01:24:18 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130112012452.0BF2D47211@hg.openjdk.java.net> Changeset: 1fbb6fb6413b Author: scolebourne Date: 2013-01-12 00:36 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1fbb6fb6413b Spec/Javadoc enhancements ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java Changeset: b1087caeb525 Author: scolebourne Date: 2013-01-12 01:23 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b1087caeb525 Merge ! src/share/classes/java/time/format/DateTimeTextProvider.java From dan.chiba at oracle.com Fri Jan 11 17:35:42 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Fri, 11 Jan 2013 17:35:42 -0800 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> Message-ID: <50F0BDEE.7040808@oracle.com> Hi Stephen, Yoshito, For 310, we like the approach to use "islamic" for the primary variant and using "islamic-xxx" for others. We would like to propose a few details to fit to the CLDR ca/cv separation as follows: 310 CLDR Description ------------- -------------------- --------------------------------- islamic ca-islamic-cv-uaq Umm Al-Qura islamic-sa ca-islamic-cv-sa Saudi Arabia Sighting islamic-??? ca-islamic-cv-??? "???" denotes a specific variant. * Chronology.of() takes a 310 string. In JDK8 "islamic" and "islamic-sa" are the only defined variants. * Chronology.ofLocale() creates the specified variant if the locale has the CLDR designation inside. * The variant identifier must be in lowerecase and can be 2 to 8 letters long. * The IANA region codes are reserved. A region other than "sa" may have a variant. * 310 and CLDR plan to identify the common variants. (e.g. "kuwaiti" may be in high demand and become the next defined variant. The list may grow.) * Users who need a user defined variant may use a custom ID at their own risk. They are encouraged to request getting the ID registered. * 310 could have "islamic-uaq" as an alias of "islamicc" to match the defaulting for deprecation in CLDR. * 310 could have "islamic-uaq" as an alias of "islamic" to help achieve consistent mapping from CLDR to 310. * The registration/maintenance process is TBD. May I ask if this looks something we can settle this with? Regards, -Dan On 1/11/2013 2:01 PM, Stephen Colebourne wrote: > The string can be anything you want, as its more of an Oracle > requirement than mine. > > Personally, I would recommend that Oracle chooses a default Islamic > calendar variant, so the string "islamic" maps to one of the variants. > I would then have the other variants as "islamic-xxx". The ca and cv > parts in the 310 calendar system id are not really relevant. > > Stephen > > > On 11 January 2013 20:49, Dan Chiba wrote: >> Thank you very much Yoshito-san. >> >> Stephen, can the single string be "ca-islamic-cv-???"? Then all we need to >> do may be define the ???s? >> >> Regards, >> -Dan >> >> >> On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >>> On 10 January 2013 21:04, wrote: >>>> We had a discussion about this in the CLDR TC meeting. >>>> Our tentative consensus is supporting calendar variations with a new >>>> extension. >>>> >>>> Although CLDR defines two types "islamic" and "islamicc", CLDR only has >>>> one set of formatting data. From formatting aspect, the difference in >>>> date >>>> calculation between them is not important. Our current plan is: >>>> >>>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>>> 2. Investigate necessary types from experts, based on some references >>>> including your ticket above. >>>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>>> determined later). >>>> >>>> Note that the type value is limited to 8 characters because of BCP 47 >>>> definition. We also considered multi-segment calendar type like >>>> islamic-umalqura as you suggested in the ticket, but it will require a >>>> bunch of duplicated references in CLDR data formatting data. For this >>>> reason, we are in favor of separating minor algorithm differences in a >>>> separate extension. >>> FWIW, I like the "cv" variant concept as it makes logical sense. It >>> will be harder to integrate into JSR-310 (where our methods take a >>> single String). The lookup from a Locale object will of course pose no >>> problem to adapt. >>> >>> Stephen From xueming.shen at oracle.com Fri Jan 11 19:04:28 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sat, 12 Jan 2013 03:04:28 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Fixed doc typos Message-ID: <20130112030441.4637E4721B@hg.openjdk.java.net> Changeset: 27a9274a806d Author: sherman Date: 2013-01-11 19:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/27a9274a806d Fixed doc typos ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/Year.java From xueming.shen at oracle.com Sun Jan 13 11:54:49 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sun, 13 Jan 2013 19:54:49 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added narrow month support with cal.narrow_standalone style Message-ID: <20130113195525.C1A4F47233@hg.openjdk.java.net> Changeset: 1df6d1a9d291 Author: sherman Date: 2013-01-13 11:57 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1df6d1a9d291 Added narrow month support with cal.narrow_standalone style ! src/share/classes/java/time/format/DateTimeTextProvider.java From xueming.shen at oracle.com Sun Jan 13 12:29:17 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sun, 13 Jan 2013 20:29:17 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Put DateTimeTextProvider back to package private Message-ID: <20130113202930.D3BA747234@hg.openjdk.java.net> Changeset: 70862fe48823 Author: sherman Date: 2013-01-13 12:32 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/70862fe48823 Put DateTimeTextProvider back to package private ! src/share/classes/java/time/format/DateTimeTextProvider.java From scolebourne at joda.org Sun Jan 13 14:50:08 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 13 Jan 2013 22:50:08 +0000 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: <50F0BDEE.7040808@oracle.com> References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> <50F0BDEE.7040808@oracle.com> Message-ID: This plan looks fine to me, There is a separate discussion around what the chronology ID will be, currently "Hijrah" (the strings in your email are the calendar system ID). I do think that it is important that if the Locale has a ca code, but not a cv code, then it should map to something sensible. Stephen On 12 January 2013 01:35, Dan Chiba wrote: > For 310, we like the approach to use "islamic" for the primary variant and > using "islamic-xxx" for others. > We would like to propose a few details to fit to the CLDR ca/cv separation > as follows: > > 310 CLDR Description > ------------- -------------------- --------------------------------- > islamic ca-islamic-cv-uaq Umm Al-Qura > islamic-sa ca-islamic-cv-sa Saudi Arabia Sighting > islamic-??? ca-islamic-cv-??? "???" denotes a specific variant. > > > * Chronology.of() takes a 310 string. In JDK8 "islamic" and "islamic-sa" are > the only defined variants. > * Chronology.ofLocale() creates the specified variant if the locale has the > CLDR designation inside. > * The variant identifier must be in lowerecase and can be 2 to 8 letters > long. > * The IANA region codes are reserved. A region other than "sa" may have a > variant. > * 310 and CLDR plan to identify the common variants. > (e.g. "kuwaiti" may be in high demand and become the next defined variant. > The list may grow.) > * Users who need a user defined variant may use a custom ID at their own > risk. > They are encouraged to request getting the ID registered. > * 310 could have "islamic-uaq" as an alias of "islamicc" to match the > defaulting for deprecation in CLDR. > * 310 could have "islamic-uaq" as an alias of "islamic" to help achieve > consistent mapping from CLDR to 310. > * The registration/maintenance process is TBD. > > May I ask if this looks something we can settle this with? > > Regards, > -Dan > > > On 1/11/2013 2:01 PM, Stephen Colebourne wrote: >> >> The string can be anything you want, as its more of an Oracle >> requirement than mine. >> >> Personally, I would recommend that Oracle chooses a default Islamic >> calendar variant, so the string "islamic" maps to one of the variants. >> I would then have the other variants as "islamic-xxx". The ca and cv >> parts in the 310 calendar system id are not really relevant. >> >> Stephen >> >> >> On 11 January 2013 20:49, Dan Chiba wrote: >>> >>> Thank you very much Yoshito-san. >>> >>> Stephen, can the single string be "ca-islamic-cv-???"? Then all we need >>> to >>> do may be define the ???s? >>> >>> Regards, >>> -Dan >>> >>> >>> On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >>>> >>>> On 10 January 2013 21:04, wrote: >>>>> >>>>> We had a discussion about this in the CLDR TC meeting. >>>>> Our tentative consensus is supporting calendar variations with a new >>>>> extension. >>>>> >>>>> Although CLDR defines two types "islamic" and "islamicc", CLDR only has >>>>> one set of formatting data. From formatting aspect, the difference in >>>>> date >>>>> calculation between them is not important. Our current plan is: >>>>> >>>>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>>>> 2. Investigate necessary types from experts, based on some references >>>>> including your ticket above. >>>>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>>>> determined later). >>>>> >>>>> Note that the type value is limited to 8 characters because of BCP 47 >>>>> definition. We also considered multi-segment calendar type like >>>>> islamic-umalqura as you suggested in the ticket, but it will require a >>>>> bunch of duplicated references in CLDR data formatting data. For this >>>>> reason, we are in favor of separating minor algorithm differences in a >>>>> separate extension. >>>> >>>> FWIW, I like the "cv" variant concept as it makes logical sense. It >>>> will be harder to integrate into JSR-310 (where our methods take a >>>> single String). The lookup from a Locale object will of course pose no >>>> problem to adapt. >>>> >>>> Stephen From xueming.shen at oracle.com Sun Jan 13 15:00:42 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 13 Jan 2013 15:00:42 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: <50EF7C71.4020508@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> Message-ID: <50F33C9A.10909@oracle.com> Opinions, comments? Should we check this in for M6? webrev has been updated recently to more reasonable. http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser -Sherman On 1/10/13 6:44 PM, Xueming Shen wrote: > Hi, > > One helper class ZoneName, which is based on the metazone data > info from metaZone.xml [1] and the zone aliase info from the Link > entries of all the tzdb data files, is added to help implement the > parsing logic suggested by cldr. The reason we have to have the > the zone alias info is that it appears metaZone.xml uses both old > name and new name in different places. > > For each zid/zname candidate the implementation now looks up > the metazone table to see if it has a metazone specified for it, if > yes, it tries to see if there is a preferred zid defined for a particular > locale/region, if yes and if this locale/region matches parser's locale, > that preferred zid is used, otherwise, the default/001 zid for the meta > zone is returned. > > The webrev is at > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser > > The zid->metazone->zid lookup tables is hard coded now in > ZoneName. Those mapping tables are generated from the link[2] > (which is a result of grep "Link" of all tzdb files), metaZone.xml[1] > via the hacky tool MetaZone.java[3]. If this approach is good, I > would expect we will get these info from Naoto's TimeZoneUtilities > "someday" (I think we are parsing metaZones.xml in cldr tool already, > probably for those generic name? we just need to go a little further) > > The test currently does not fail if the parsed result is not the > "expected" one (round trip). The test simply prints out those diff > for manual check. If you take a close look at output "result" [4], > which shows "zid", "input text", "parsed result" and "expected", it > appears all the parsed result is correct/reasonable, I guess the > reason those result is not the "expected" is mainly because those > zids are not in metaZone.xml. > > The result[4] shows the parsing works reasonably well for "full" > style, but we have lots of "missing/ambiguous" result for those > "short" style names. Given the nature of those short names and > the limited info (the "locale"), It maybe reasonable to not support > those ambiguous short names in parsing? An alternative is to > "specify" the mapping table in spec, but it's not going to make > every one happy either. > > Opinion? > > -Sherman > > [1] > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/metaZones > [2] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/link > [3] > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/MetaZone.java > [4] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/result > > On 01/04/2013 09:07 AM, Stephen Colebourne wrote: >> For this release or JDK 9? >> We need to ensure that we don't do anything that prevents implementing >> the full CLDR strategy if we are not doing it now. >> Stephen >> >> On 4 January 2013 17:03, Xueming Shen wrote: >>> On 1/4/13 2:32 AM, Stephen Colebourne wrote: >>>> Realy, we should implement the rules described in CLDR, as they seem >>>> to have thought about it: >>>> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback >>> >>> we need pull in more cldr data... >>> >>> >>>> Stephen >>> > From scolebourne at joda.org Sun Jan 13 15:02:29 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 13 Jan 2013 23:02:29 +0000 Subject: [threeten-dev] zidtext parser In-Reply-To: <50EF7C71.4020508@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> Message-ID: Reading through the whole of http://www.unicode.org/reports/tr35/#Time_Zone_Fallback (Parsing section) is a big job that I'm struggling to find time for. One thought is whether the metazone concept should be exposed to users in the future, but I don't think it affects the API now. A second thought is how does this work for new zone IDs added between JDK releases (as you are hard coding the metazone info - should metazones be in TZDB.jar?) A brief read of the CLDR document suggests that we should accept "UT" as well as "UTC" and "GMT" as prefixes for the offset-based IDs. We should also accept a number without + as a positive number. Not sure how you will specify this, or whether it can be left open enough to expand in the future. Stephen On 11 January 2013 02:44, Xueming Shen wrote: > Hi, > > One helper class ZoneName, which is based on the metazone data > info from metaZone.xml [1] and the zone aliase info from the Link > entries of all the tzdb data files, is added to help implement the > parsing logic suggested by cldr. The reason we have to have the > the zone alias info is that it appears metaZone.xml uses both old > name and new name in different places. > > For each zid/zname candidate the implementation now looks up > the metazone table to see if it has a metazone specified for it, if > yes, it tries to see if there is a preferred zid defined for a particular > locale/region, if yes and if this locale/region matches parser's locale, > that preferred zid is used, otherwise, the default/001 zid for the meta > zone is returned. > > The webrev is at > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser > > The zid->metazone->zid lookup tables is hard coded now in > ZoneName. Those mapping tables are generated from the link[2] > (which is a result of grep "Link" of all tzdb files), metaZone.xml[1] > via the hacky tool MetaZone.java[3]. If this approach is good, I > would expect we will get these info from Naoto's TimeZoneUtilities > "someday" (I think we are parsing metaZones.xml in cldr tool already, > probably for those generic name? we just need to go a little further) > > The test currently does not fail if the parsed result is not the > "expected" one (round trip). The test simply prints out those diff > for manual check. If you take a close look at output "result" [4], > which shows "zid", "input text", "parsed result" and "expected", it > appears all the parsed result is correct/reasonable, I guess the > reason those result is not the "expected" is mainly because those > zids are not in metaZone.xml. > > The result[4] shows the parsing works reasonably well for "full" > style, but we have lots of "missing/ambiguous" result for those > "short" style names. Given the nature of those short names and > the limited info (the "locale"), It maybe reasonable to not support > those ambiguous short names in parsing? An alternative is to > "specify" the mapping table in spec, but it's not going to make > every one happy either. > > Opinion? > > -Sherman > > [1] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/metaZones > [2] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/link > [3] > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/MetaZone.java > [4] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/result > > > On 01/04/2013 09:07 AM, Stephen Colebourne wrote: >> >> For this release or JDK 9? >> We need to ensure that we don't do anything that prevents implementing >> the full CLDR strategy if we are not doing it now. >> Stephen >> >> On 4 January 2013 17:03, Xueming Shen wrote: >>> >>> On 1/4/13 2:32 AM, Stephen Colebourne wrote: >>>> >>>> Realy, we should implement the rules described in CLDR, as they seem >>>> to have thought about it: >>>> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback >>> >>> >>> we need pull in more cldr data... >>> >>> >>>> Stephen >>> >>> > From xueming.shen at oracle.com Sun Jan 13 16:36:59 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 13 Jan 2013 16:36:59 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> Message-ID: <50F3532B.90807@oracle.com> On 1/13/13 3:02 PM, Stephen Colebourne wrote: > Reading through the whole of > http://www.unicode.org/reports/tr35/#Time_Zone_Fallback (Parsing > section) is a big job that I'm struggling to find time for. > > One thought is whether the metazone concept should be exposed to users > in the future, but I don't think it affects the API now. A second > thought is how does this work for new zone IDs added between JDK > releases (as you are hard coding the metazone info - should metazones > be in TZDB.jar?) I don't see the necessity of exposing the metazone info to the users, at least for now. It's a combination of the alias/link from the tzdb and the metazone from the cldr. I would expect we will/should get the metazone from the utility class we currently get those zone name info (the jdk cldr code currently reads metaZone.xml already, just need to read a little more). It's hard coded for now simply because I can't get it from those utilities. It's tricky to handle the alias/link info. It's in the tzdb already, just need a way to access it via the provider. Another issue is getAvailableZoneId(). We are not using the "size" to decide whether or not there is no ids installed. Does it have to return a "modified" map? It just appears to be too expensive to invoke this method everything we need to parse a zoneid. > > A brief read of the CLDR document suggests that we should accept "UT" > as well as "UTC" and "GMT" as prefixes for the offset-based IDs. We > should also accept a number without + as a positive number. > > Not sure how you will specify this, or whether it can be left open > enough to expand in the future. This can just be added if needed. I don't think it's an issue if a future release accepts form that currently being rejected. -Sherman > Stephen > > > > On 11 January 2013 02:44, Xueming Shen wrote: >> Hi, >> >> One helper class ZoneName, which is based on the metazone data >> info from metaZone.xml [1] and the zone aliase info from the Link >> entries of all the tzdb data files, is added to help implement the >> parsing logic suggested by cldr. The reason we have to have the >> the zone alias info is that it appears metaZone.xml uses both old >> name and new name in different places. >> >> For each zid/zname candidate the implementation now looks up >> the metazone table to see if it has a metazone specified for it, if >> yes, it tries to see if there is a preferred zid defined for a particular >> locale/region, if yes and if this locale/region matches parser's locale, >> that preferred zid is used, otherwise, the default/001 zid for the meta >> zone is returned. >> >> The webrev is at >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser >> >> The zid->metazone->zid lookup tables is hard coded now in >> ZoneName. Those mapping tables are generated from the link[2] >> (which is a result of grep "Link" of all tzdb files), metaZone.xml[1] >> via the hacky tool MetaZone.java[3]. If this approach is good, I >> would expect we will get these info from Naoto's TimeZoneUtilities >> "someday" (I think we are parsing metaZones.xml in cldr tool already, >> probably for those generic name? we just need to go a little further) >> >> The test currently does not fail if the parsed result is not the >> "expected" one (round trip). The test simply prints out those diff >> for manual check. If you take a close look at output "result" [4], >> which shows "zid", "input text", "parsed result" and "expected", it >> appears all the parsed result is correct/reasonable, I guess the >> reason those result is not the "expected" is mainly because those >> zids are not in metaZone.xml. >> >> The result[4] shows the parsing works reasonably well for "full" >> style, but we have lots of "missing/ambiguous" result for those >> "short" style names. Given the nature of those short names and >> the limited info (the "locale"), It maybe reasonable to not support >> those ambiguous short names in parsing? An alternative is to >> "specify" the mapping table in spec, but it's not going to make >> every one happy either. >> >> Opinion? >> >> -Sherman >> >> [1] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/metaZones >> [2] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/link >> [3] >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/MetaZone.java >> [4] http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/result >> >> >> On 01/04/2013 09:07 AM, Stephen Colebourne wrote: >>> For this release or JDK 9? >>> We need to ensure that we don't do anything that prevents implementing >>> the full CLDR strategy if we are not doing it now. >>> Stephen >>> >>> On 4 January 2013 17:03, Xueming Shen wrote: >>>> On 1/4/13 2:32 AM, Stephen Colebourne wrote: >>>>> Realy, we should implement the rules described in CLDR, as they seem >>>>> to have thought about it: >>>>> http://www.unicode.org/reports/tr35/#Time_Zone_Fallback >>>> >>>> we need pull in more cldr data... >>>> >>>> >>>>> Stephen >>>> From patrick.zhang at oracle.com Mon Jan 14 00:57:58 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Mon, 14 Jan 2013 16:57:58 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.Instant In-Reply-To: References: <50EFCCF6.50300@oracle.com> Message-ID: <50F3C896.6050503@oracle.com> Hi Stephen, It has been updated as below: https://dl.dropbox.com/u/5812451/ppz/webrev/index.html Test result: https://dl.dropbox.com/u/5812451/ppz/result/TCKInstant.jtr Regards Patrick On 1/11/13 7:11 PM, Stephen Colebourne wrote: > The tests themselves are fine, however, they should be grouped in > source code as a set of three after the minus_Duration() tests. > > The method names should also be changed to include "long"; > "minus_TemporalUnit" -> "minus_longTemporalUnit" > > The same additional three tests should be added for plus. > > thanks > Stephen > > > On 11 January 2013 08:27, Patrick Zhang wrote: >> Hi Team, >> >> Please help to review below new added test case: >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ >> >> In current test code, Instant.minus(TemporalSubtractor substractor) has been >> included but Instant.minus(long amountToSubtract, TemporalUnit unit) is >> missed. >> >> So below 3 methods are added to cover it: >> ================== >> minus_TemporalUnit() >> minus_TemporalUnit_overflowTooSmall() >> minus_TemporalUnit_overflowTooBig() >> ================== >> >> Actually the logic is same with existing minus_Duration(), >> minus_Duration_overflowTooSmall() and minus_Duration_overflowTooBig(). I >> just use Instant.minus(long amountToSubtract, TemporalUnit unit) to replace >> Instant.minus(TemporalSubtractor substractor). >> >> Test result is here: >> http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr >> >> Regards >> Patrick >> From scolebourne at joda.org Mon Jan 14 02:24:27 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 14 Jan 2013 10:24:27 +0000 Subject: [threeten-dev] zidtext parser In-Reply-To: <50F3532B.90807@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> Message-ID: On 14 January 2013 00:36, Xueming Shen wrote: > I don't see the necessity of exposing the metazone info to the users, at > least for now. > It's a combination of the alias/link from the tzdb and the metazone from > the cldr. I would expect we will/should get the metazone from the utility > class we currently get those zone name info (the jdk cldr code currently > reads metaZone.xml already, just need to read a little more). It's hard > coded for now simply because I can't get it from those utilities. It's > tricky > to handle the alias/link info. It's in the tzdb already, just need a way to > access it via the provider. I have debated whether the alias should be publicly visible. I decided most users don't care which is the "correct" version of an alised zone ID. If you need to expose it in the provider, that is fine by me. > Another issue is getAvailableZoneId(). We are not using the "size" to > decide whether or not there is no ids installed. Does it have to return > a "modified" map? It just appears to be too expensive to invoke this > method everything we need to parse a zoneid. It does not need to expose a modifiable map. If you change it to be an immutable map, then you should ensure that all similar methods in the same class behave in the same way. Stephen From scolebourne at joda.org Mon Jan 14 02:28:31 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 14 Jan 2013 10:28:31 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.Instant In-Reply-To: <50F3C896.6050503@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> Message-ID: Looks good to me. Are you committing this directly? Or via Sherman/Roger? Stephen On 14 January 2013 08:57, Patrick Zhang wrote: > Hi Stephen, > > It has been updated as below: > https://dl.dropbox.com/u/5812451/ppz/webrev/index.html > > Test result: > https://dl.dropbox.com/u/5812451/ppz/result/TCKInstant.jtr > > Regards > Patrick > > > On 1/11/13 7:11 PM, Stephen Colebourne wrote: >> >> The tests themselves are fine, however, they should be grouped in >> source code as a set of three after the minus_Duration() tests. >> >> The method names should also be changed to include "long"; >> "minus_TemporalUnit" -> "minus_longTemporalUnit" >> >> The same additional three tests should be added for plus. >> >> thanks >> Stephen >> >> >> On 11 January 2013 08:27, Patrick Zhang wrote: >>> >>> Hi Team, >>> >>> Please help to review below new added test case: >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ >>> >>> In current test code, Instant.minus(TemporalSubtractor substractor) has >>> been >>> included but Instant.minus(long amountToSubtract, TemporalUnit unit) is >>> missed. >>> >>> So below 3 methods are added to cover it: >>> ================== >>> minus_TemporalUnit() >>> minus_TemporalUnit_overflowTooSmall() >>> minus_TemporalUnit_overflowTooBig() >>> ================== >>> >>> Actually the logic is same with existing minus_Duration(), >>> minus_Duration_overflowTooSmall() and minus_Duration_overflowTooBig(). I >>> just use Instant.minus(long amountToSubtract, TemporalUnit unit) to >>> replace >>> Instant.minus(TemporalSubtractor substractor). >>> >>> Test result is here: >>> >>> http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr >>> >>> Regards >>> Patrick >>> > From scolebourne at joda.org Mon Jan 14 07:38:32 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Mon, 14 Jan 2013 15:38:32 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 5 new changesets Message-ID: <20130114154010.5C5C64724B@hg.openjdk.java.net> Changeset: b29c4f1251dd Author: scolebourne Date: 2013-01-14 11:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b29c4f1251dd Javadoc for query methods ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: 36228575b51f Author: scolebourne Date: 2013-01-14 12:04 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/36228575b51f Re-order methods static/get/is-length/with/plus/minus/query/adjust/period/at/to/compare/equal/str ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: 5900e30bee2f Author: scolebourne Date: 2013-01-14 12:05 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5900e30bee2f Javadoc for query method ! src/share/classes/java/time/temporal/Era.java Changeset: caae6a626adf Author: scolebourne Date: 2013-01-14 13:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/caae6a626adf Javadoc for adjustInto methods ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: ab5887e71694 Author: scolebourne Date: 2013-01-14 15:29 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ab5887e71694 Javadoc for periodUntil methods ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java From scolebourne at joda.org Mon Jan 14 09:32:23 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Mon, 14 Jan 2013 17:32:23 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 5 new changesets Message-ID: <20130114173332.A8F1447256@hg.openjdk.java.net> Changeset: 4ef208b6b4a9 Author: scolebourne Date: 2013-01-14 15:50 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4ef208b6b4a9 Javadoc for toString(formatter) methods ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: 9b6a877e71d5 Author: scolebourne Date: 2013-01-14 15:56 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9b6a877e71d5 Javadoc isEqual/After/Before methods ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java Changeset: 838aaf6d4eda Author: scolebourne Date: 2013-01-14 17:11 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/838aaf6d4eda Fix isEqual method ! src/share/classes/java/time/LocalDateTime.java Changeset: 6eb2c56a45dc Author: scolebourne Date: 2013-01-14 17:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6eb2c56a45dc Javadoc for temporal interfaces ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java Changeset: d11407a40b31 Author: scolebourne Date: 2013-01-14 17:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d11407a40b31 Javadoc, test and fix ValueRange ! src/share/classes/java/time/temporal/ValueRange.java ! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java From scolebourne at joda.org Mon Jan 14 10:43:20 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Mon, 14 Jan 2013 18:43:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Javadoc for isSupported/get methods Message-ID: <20130114184356.DCE9247258@hg.openjdk.java.net> Changeset: aaa5536666ed Author: scolebourne Date: 2013-01-14 18:42 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/aaa5536666ed Javadoc for isSupported/get methods ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java From Roger.Riggs at oracle.com Mon Jan 14 12:57:10 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 14 Jan 2013 15:57:10 -0500 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu Message-ID: <50F47126.2070606@oracle.com> I hereby nominate Masayoshi Okutsu to threeten-dev Committer. Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and is making significant contributions to the Threeten project with a particular focus on internationalization and internationalized calendars. Votes are due by Friday Jan 28. Only current threeten-dev Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Roger Riggs [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From xueming.shen at oracle.com Mon Jan 14 13:05:54 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 14 Jan 2013 13:05:54 -0800 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu In-Reply-To: <50F47126.2070606@oracle.com> References: <50F47126.2070606@oracle.com> Message-ID: <50F47332.5070206@oracle.com> vote: yes On 01/14/2013 12:57 PM, Roger Riggs wrote: > I hereby nominate Masayoshi Okutsu to threeten-dev Committer. > > Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and is making significant contributions to the Threeten project with a particular focus on internationalization and internationalized calendars. > > Votes are due by Friday Jan 28. > > Only current threeten-dev Committers [1] are eligible to vote on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Roger Riggs > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From Roger.Riggs at Oracle.com Mon Jan 14 13:03:21 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Mon, 14 Jan 2013 16:03:21 -0500 Subject: [threeten-dev] Review for updates to javadoc Message-ID: <50F47299.1070705@Oracle.com> Please review updates to Javadoc to satisfy DocLint http://cr.openjdk.java.net/~rriggs/webrev-issue202/ remove '/' from '<'br / '>' use html not xhtml change use of H4 and H5 to use P style="strong" paragraphs. (I18N of html requires starting at H1 but that doesn't make sense. Add missing @param tags Add missing @return tags Change package.html to package-info.java Add Caption tags to tables Close unclosed PRE tags Correct the ChronoLocalDate examples -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From dan.chiba at oracle.com Mon Jan 14 13:34:23 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Mon, 14 Jan 2013 13:34:23 -0800 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> <50F0BDEE.7040808@oracle.com> Message-ID: <50F479DF.7030407@oracle.com> Hi Stephen, Thank you for the comments. For the ambiguous cases with no cv code, let's let it fall back to "islamic", which is the default variant Umm Al-Quara ("ca-islamic-cv-uaq" in CLDR). I just updated github #118 with this information. For the chronology ID, I am not sure exactly what it is; is it an ID to specify a Chronology class? If it could affect Islamic calendar support, would you mind providing a pointer to the discussion? Thanks, -Dan On 1/13/2013 2:50 PM, Stephen Colebourne wrote: > This plan looks fine to me, > > There is a separate discussion around what the chronology ID will be, > currently "Hijrah" (the strings in your email are the calendar system > ID). > > I do think that it is important that if the Locale has a ca code, but > not a cv code, then it should map to something sensible. > > Stephen > > > > On 12 January 2013 01:35, Dan Chiba wrote: >> For 310, we like the approach to use "islamic" for the primary variant and >> using "islamic-xxx" for others. >> We would like to propose a few details to fit to the CLDR ca/cv separation >> as follows: >> >> 310 CLDR Description >> ------------- -------------------- --------------------------------- >> islamic ca-islamic-cv-uaq Umm Al-Qura >> islamic-sa ca-islamic-cv-sa Saudi Arabia Sighting >> islamic-??? ca-islamic-cv-??? "???" denotes a specific variant. >> >> >> * Chronology.of() takes a 310 string. In JDK8 "islamic" and "islamic-sa" are >> the only defined variants. >> * Chronology.ofLocale() creates the specified variant if the locale has the >> CLDR designation inside. >> * The variant identifier must be in lowerecase and can be 2 to 8 letters >> long. >> * The IANA region codes are reserved. A region other than "sa" may have a >> variant. >> * 310 and CLDR plan to identify the common variants. >> (e.g. "kuwaiti" may be in high demand and become the next defined variant. >> The list may grow.) >> * Users who need a user defined variant may use a custom ID at their own >> risk. >> They are encouraged to request getting the ID registered. >> * 310 could have "islamic-uaq" as an alias of "islamicc" to match the >> defaulting for deprecation in CLDR. >> * 310 could have "islamic-uaq" as an alias of "islamic" to help achieve >> consistent mapping from CLDR to 310. >> * The registration/maintenance process is TBD. >> >> May I ask if this looks something we can settle this with? >> >> Regards, >> -Dan >> >> >> On 1/11/2013 2:01 PM, Stephen Colebourne wrote: >>> The string can be anything you want, as its more of an Oracle >>> requirement than mine. >>> >>> Personally, I would recommend that Oracle chooses a default Islamic >>> calendar variant, so the string "islamic" maps to one of the variants. >>> I would then have the other variants as "islamic-xxx". The ca and cv >>> parts in the 310 calendar system id are not really relevant. >>> >>> Stephen >>> >>> >>> On 11 January 2013 20:49, Dan Chiba wrote: >>>> Thank you very much Yoshito-san. >>>> >>>> Stephen, can the single string be "ca-islamic-cv-???"? Then all we need >>>> to >>>> do may be define the ???s? >>>> >>>> Regards, >>>> -Dan >>>> >>>> >>>> On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >>>>> On 10 January 2013 21:04, wrote: >>>>>> We had a discussion about this in the CLDR TC meeting. >>>>>> Our tentative consensus is supporting calendar variations with a new >>>>>> extension. >>>>>> >>>>>> Although CLDR defines two types "islamic" and "islamicc", CLDR only has >>>>>> one set of formatting data. From formatting aspect, the difference in >>>>>> date >>>>>> calculation between them is not important. Our current plan is: >>>>>> >>>>>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>>>>> 2. Investigate necessary types from experts, based on some references >>>>>> including your ticket above. >>>>>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>>>>> determined later). >>>>>> >>>>>> Note that the type value is limited to 8 characters because of BCP 47 >>>>>> definition. We also considered multi-segment calendar type like >>>>>> islamic-umalqura as you suggested in the ticket, but it will require a >>>>>> bunch of duplicated references in CLDR data formatting data. For this >>>>>> reason, we are in favor of separating minor algorithm differences in a >>>>>> separate extension. >>>>> FWIW, I like the "cv" variant concept as it makes logical sense. It >>>>> will be harder to integrate into JSR-310 (where our methods take a >>>>> single String). The lookup from a Locale object will of course pose no >>>>> problem to adapt. >>>>> >>>>> Stephen From xueming.shen at oracle.com Mon Jan 14 13:38:37 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 14 Jan 2013 13:38:37 -0800 Subject: [threeten-dev] webrev for the TL/M6 integration Message-ID: <50F47ADD.1040004@oracle.com> Do we need keep the make/netbeans/threeten? Given the the script no longer works with java/time package without further tweak, I did not include it in the "rehearsal". Opinion? http://cr.openjdk.java.net/~sherman/8003680/webrev -Sherman From scolebourne at joda.org Mon Jan 14 15:34:17 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 14 Jan 2013 23:34:17 +0000 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu In-Reply-To: <50F47126.2070606@oracle.com> References: <50F47126.2070606@oracle.com> Message-ID: vote: yes Stephen On 14 January 2013 20:57, Roger Riggs wrote: > I hereby nominate Masayoshi Okutsu to threeten-dev Committer. > > Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and is > making significant contributions to the Threeten project with a particular > focus on internationalization and internationalized calendars. > > Votes are due by Friday Jan 28. > > Only current threeten-dev Committers [1] are eligible to vote on this > nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Roger Riggs > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From scolebourne at joda.org Mon Jan 14 16:00:13 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 15 Jan 2013 00:00:13 +0000 Subject: [threeten-dev] webrev for the TL/M6 integration In-Reply-To: <50F47ADD.1040004@oracle.com> References: <50F47ADD.1040004@oracle.com> Message-ID: I haven't used the ant scripts in a while. The java.util.Formatter includes the full packge name in the Javadoc refereces when it isn't necessary (as it is imported). I assume that we will agree a cutover date to the main repo? Will code committed tomorrow make M6? Stephen On 14 January 2013 21:38, Xueming Shen wrote: > Do we need keep the make/netbeans/threeten? Given the the > script no longer works with java/time package without further > tweak, I did not include it in the "rehearsal". Opinion? > > http://cr.openjdk.java.net/~sherman/8003680/webrev > > -Sherman From scolebourne at joda.org Mon Jan 14 16:06:30 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 15 Jan 2013 00:06:30 +0000 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: <50F479DF.7030407@oracle.com> References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> <50F0BDEE.7040808@oracle.com> <50F479DF.7030407@oracle.com> Message-ID: As we've discussed before, there are two parallel IDs. For example "Coptic" and "coptic", or "Hijrah" and "islamic". The table needs updating with another column for the chronology ID (essentially an alias based around the 310 class name). The ID isn't limited to 8 letters, but it is probably easiest and simplest to re-use the cv string. Thus "Hijrah-sa" would be an alias for islamic-sa" in the of(String) factory method. Stephen On 14 January 2013 21:34, Dan Chiba wrote: > Hi Stephen, > > Thank you for the comments. For the ambiguous cases with no cv code, let's > let it fall back to "islamic", which is the default variant Umm Al-Quara > ("ca-islamic-cv-uaq" in CLDR). I just updated github #118 > with this information. > > For the chronology ID, I am not sure exactly what it is; is it an ID to > specify a Chronology class? If it could affect Islamic calendar support, > would you mind providing a pointer to the discussion? > > Thanks, > -Dan > > > On 1/13/2013 2:50 PM, Stephen Colebourne wrote: >> >> This plan looks fine to me, >> >> There is a separate discussion around what the chronology ID will be, >> currently "Hijrah" (the strings in your email are the calendar system >> ID). >> >> I do think that it is important that if the Locale has a ca code, but >> not a cv code, then it should map to something sensible. >> >> Stephen >> >> >> >> On 12 January 2013 01:35, Dan Chiba wrote: >>> >>> For 310, we like the approach to use "islamic" for the primary variant >>> and >>> using "islamic-xxx" for others. >>> We would like to propose a few details to fit to the CLDR ca/cv >>> separation >>> as follows: >>> >>> 310 CLDR Description >>> ------------- -------------------- --------------------------------- >>> islamic ca-islamic-cv-uaq Umm Al-Qura >>> islamic-sa ca-islamic-cv-sa Saudi Arabia Sighting >>> islamic-??? ca-islamic-cv-??? "???" denotes a specific variant. >>> >>> >>> * Chronology.of() takes a 310 string. In JDK8 "islamic" and "islamic-sa" >>> are >>> the only defined variants. >>> * Chronology.ofLocale() creates the specified variant if the locale has >>> the >>> CLDR designation inside. >>> * The variant identifier must be in lowerecase and can be 2 to 8 letters >>> long. >>> * The IANA region codes are reserved. A region other than "sa" may have a >>> variant. >>> * 310 and CLDR plan to identify the common variants. >>> (e.g. "kuwaiti" may be in high demand and become the next defined >>> variant. >>> The list may grow.) >>> * Users who need a user defined variant may use a custom ID at their own >>> risk. >>> They are encouraged to request getting the ID registered. >>> * 310 could have "islamic-uaq" as an alias of "islamicc" to match the >>> defaulting for deprecation in CLDR. >>> * 310 could have "islamic-uaq" as an alias of "islamic" to help achieve >>> consistent mapping from CLDR to 310. >>> * The registration/maintenance process is TBD. >>> >>> May I ask if this looks something we can settle this with? >>> >>> Regards, >>> -Dan >>> >>> >>> On 1/11/2013 2:01 PM, Stephen Colebourne wrote: >>>> >>>> The string can be anything you want, as its more of an Oracle >>>> requirement than mine. >>>> >>>> Personally, I would recommend that Oracle chooses a default Islamic >>>> calendar variant, so the string "islamic" maps to one of the variants. >>>> I would then have the other variants as "islamic-xxx". The ca and cv >>>> parts in the 310 calendar system id are not really relevant. >>>> >>>> Stephen >>>> >>>> >>>> On 11 January 2013 20:49, Dan Chiba wrote: >>>>> >>>>> Thank you very much Yoshito-san. >>>>> >>>>> Stephen, can the single string be "ca-islamic-cv-???"? Then all we need >>>>> to >>>>> do may be define the ???s? >>>>> >>>>> Regards, >>>>> -Dan >>>>> >>>>> >>>>> On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >>>>>> >>>>>> On 10 January 2013 21:04, wrote: >>>>>>> >>>>>>> We had a discussion about this in the CLDR TC meeting. >>>>>>> Our tentative consensus is supporting calendar variations with a new >>>>>>> extension. >>>>>>> >>>>>>> Although CLDR defines two types "islamic" and "islamicc", CLDR only >>>>>>> has >>>>>>> one set of formatting data. From formatting aspect, the difference in >>>>>>> date >>>>>>> calculation between them is not important. Our current plan is: >>>>>>> >>>>>>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>>>>>> 2. Investigate necessary types from experts, based on some references >>>>>>> including your ticket above. >>>>>>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>>>>>> determined later). >>>>>>> >>>>>>> Note that the type value is limited to 8 characters because of BCP 47 >>>>>>> definition. We also considered multi-segment calendar type like >>>>>>> islamic-umalqura as you suggested in the ticket, but it will require >>>>>>> a >>>>>>> bunch of duplicated references in CLDR data formatting data. For this >>>>>>> reason, we are in favor of separating minor algorithm differences in >>>>>>> a >>>>>>> separate extension. >>>>>> >>>>>> FWIW, I like the "cv" variant concept as it makes logical sense. It >>>>>> will be harder to integrate into JSR-310 (where our methods take a >>>>>> single String). The lookup from a Locale object will of course pose no >>>>>> problem to adapt. >>>>>> >>>>>> Stephen From Roger.Riggs at Oracle.com Mon Jan 14 18:01:38 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Mon, 14 Jan 2013 21:01:38 -0500 Subject: [threeten-dev] [threeten-develop] Review for updates to javadoc In-Reply-To: References: <50F47299.1070705@Oracle.com> Message-ID: <50F4B882.6070301@Oracle.com> Hi Stephen, The
with the normal stylesheet used in the JDK is a bold font just a bit larger. The individual packages have no control over the style sheet. If the H5 is being used for the appearance then it is a mis-use of the header. The HTML accessibility guides (Oracle's anyway) dictate that headers start with H1 and be sequential. With respect to other paackage use of Hx, I have not yet seen what clean up will need to be done. That may result in the conventions being clarified and updated. One of the items that came up in the internal review is that the content of the "implementation notes" is in many cases normative. The interpretation of "implementation notes" in the JDK is informative, an implementation may follow the advice but is not required to. We will have to review all of the implementation notes and change the language to be specific about whether it is a must, should or may. The headings themselves need to make it clear whether the paragraph is normative or informative. Roger On 01/14/2013 06:52 PM, Stephen Colebourne wrote: > I've taken a look. I agree with most of it, but I can't say that I > agree with replacing
. The

provides less > semantic information to the HTML and would generally be considered bad > HTML. It is also worse for disabled accessibility (non visual readers > get less information to interpret). If this is a new Oracle > requirement, then so be it. However, I do believe that there are > numerous other examples of header tags being used in the JDK. > > Stephen > > > > > On 14 January 2013 21:03, Roger Riggs > wrote: > > Please review updates to Javadoc to satisfy DocLint > http://cr.openjdk.java.net/~rriggs/webrev-issue202/ > > > remove '/' from '<'br / '>' > use html not xhtml > change use of H4 and H5 to use P style="strong" paragraphs. > (I18N of html requires starting at H1 but that doesn't make > sense. > Add missing @param tags > Add missing @return tags > Change package.html to package-info.java > Add Caption tags to tables > Close unclosed PRE tags > Correct the ChronoLocalDate examples > > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is > committed to developing practices and products that help protect > the environment > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET , > C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills > current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122412 > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/threeten-develop > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. SALE $99.99 this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122412 > > > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop From Roger.Riggs at Oracle.com Mon Jan 14 18:07:14 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Mon, 14 Jan 2013 21:07:14 -0500 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu In-Reply-To: <50F47126.2070606@oracle.com> References: <50F47126.2070606@oracle.com> Message-ID: <50F4B9D2.1090008@Oracle.com> Vote: Yes On 01/14/2013 03:57 PM, Roger Riggs wrote: > I hereby nominate Masayoshi Okutsu to threeten-dev Committer. > > Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and > is making significant contributions to the Threeten project with a > particular focus on internationalization and internationalized calendars. > > Votes are due by Friday Jan 28. > > Only current threeten-dev Committers [1] are eligible to vote on this > nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Roger Riggs > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From patrick.zhang at oracle.com Mon Jan 14 18:15:07 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Tue, 15 Jan 2013 10:15:07 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.Instant In-Reply-To: References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> Message-ID: <50F4BBAB.3000604@oracle.com> It has not been committed. Hi Sherman, Could you help to push it? webrev is below: https://dl.dropbox.com/u/5812451/ppz/webrev/index.html Regards Patrick On 1/14/13 6:28 PM, Stephen Colebourne wrote: > Looks good to me. > Are you committing this directly? Or via Sherman/Roger? > Stephen > > > On 14 January 2013 08:57, Patrick Zhang wrote: >> Hi Stephen, >> >> It has been updated as below: >> https://dl.dropbox.com/u/5812451/ppz/webrev/index.html >> >> Test result: >> https://dl.dropbox.com/u/5812451/ppz/result/TCKInstant.jtr >> >> Regards >> Patrick >> >> >> On 1/11/13 7:11 PM, Stephen Colebourne wrote: >>> The tests themselves are fine, however, they should be grouped in >>> source code as a set of three after the minus_Duration() tests. >>> >>> The method names should also be changed to include "long"; >>> "minus_TemporalUnit" -> "minus_longTemporalUnit" >>> >>> The same additional three tests should be added for plus. >>> >>> thanks >>> Stephen >>> >>> >>> On 11 January 2013 08:27, Patrick Zhang wrote: >>>> Hi Team, >>>> >>>> Please help to review below new added test case: >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ >>>> >>>> In current test code, Instant.minus(TemporalSubtractor substractor) has >>>> been >>>> included but Instant.minus(long amountToSubtract, TemporalUnit unit) is >>>> missed. >>>> >>>> So below 3 methods are added to cover it: >>>> ================== >>>> minus_TemporalUnit() >>>> minus_TemporalUnit_overflowTooSmall() >>>> minus_TemporalUnit_overflowTooBig() >>>> ================== >>>> >>>> Actually the logic is same with existing minus_Duration(), >>>> minus_Duration_overflowTooSmall() and minus_Duration_overflowTooBig(). I >>>> just use Instant.minus(long amountToSubtract, TemporalUnit unit) to >>>> replace >>>> Instant.minus(TemporalSubtractor substractor). >>>> >>>> Test result is here: >>>> >>>> http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr >>>> >>>> Regards >>>> Patrick >>>> From roger.riggs at oracle.com Mon Jan 14 18:27:37 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 15 Jan 2013 02:27:37 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updates to Javadoc to satisfy DocLint Message-ID: <20130115022759.D5BB347274@hg.openjdk.java.net> Changeset: e7208543ed8e Author: rriggs Date: 2013-01-14 21:26 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e7208543ed8e Updates to Javadoc to satisfy DocLint remove '/' from '<'br / '>' use html not xhtml change use of H4 and H5 to use P style="strong" paragraphs. (I18N of html requires starting at H1 but that doesn't make sense. Add missing @param tags Add missing @return tags Change package.html to package-info.java Add Caption tags to tables Close unclosed PRE tags Correct the ChronoLocalDate examples ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/calendar/package.html ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package-info.java - src/share/classes/java/time/format/package.html ! src/share/classes/java/time/overview.html + src/share/classes/java/time/package-info.java - src/share/classes/java/time/package.html ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java - src/share/classes/java/time/temporal/package.html ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package-info.java - src/share/classes/java/time/zone/package.html From xueming.shen at oracle.com Mon Jan 14 19:00:57 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 14 Jan 2013 19:00:57 -0800 Subject: [threeten-dev] Please help to review new test code for java.time.Instant In-Reply-To: <50F4BBAB.3000604@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50F4BBAB.3000604@oracle.com> Message-ID: <50F4C669.6040806@oracle.com> pushed. On 1/14/13 6:15 PM, Patrick Zhang wrote: > It has not been committed. > > Hi Sherman, > Could you help to push it? webrev is below: > > https://dl.dropbox.com/u/5812451/ppz/webrev/index.html > > Regards > Patrick > > > > > On 1/14/13 6:28 PM, Stephen Colebourne wrote: >> Looks good to me. >> Are you committing this directly? Or via Sherman/Roger? >> Stephen >> >> >> On 14 January 2013 08:57, Patrick Zhang >> wrote: >>> Hi Stephen, >>> >>> It has been updated as below: >>> https://dl.dropbox.com/u/5812451/ppz/webrev/index.html >>> >>> Test result: >>> https://dl.dropbox.com/u/5812451/ppz/result/TCKInstant.jtr >>> >>> Regards >>> Patrick >>> >>> >>> On 1/11/13 7:11 PM, Stephen Colebourne wrote: >>>> The tests themselves are fine, however, they should be grouped in >>>> source code as a set of three after the minus_Duration() tests. >>>> >>>> The method names should also be changed to include "long"; >>>> "minus_TemporalUnit" -> "minus_longTemporalUnit" >>>> >>>> The same additional three tests should be added for plus. >>>> >>>> thanks >>>> Stephen >>>> >>>> >>>> On 11 January 2013 08:27, Patrick Zhang >>>> wrote: >>>>> Hi Team, >>>>> >>>>> Please help to review below new added test case: >>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/instant/ >>>>> >>>>> In current test code, Instant.minus(TemporalSubtractor >>>>> substractor) has >>>>> been >>>>> included but Instant.minus(long amountToSubtract, TemporalUnit >>>>> unit) is >>>>> missed. >>>>> >>>>> So below 3 methods are added to cover it: >>>>> ================== >>>>> minus_TemporalUnit() >>>>> minus_TemporalUnit_overflowTooSmall() >>>>> minus_TemporalUnit_overflowTooBig() >>>>> ================== >>>>> >>>>> Actually the logic is same with existing minus_Duration(), >>>>> minus_Duration_overflowTooSmall() and >>>>> minus_Duration_overflowTooBig(). I >>>>> just use Instant.minus(long amountToSubtract, TemporalUnit unit) to >>>>> replace >>>>> Instant.minus(TemporalSubtractor substractor). >>>>> >>>>> Test result is here: >>>>> >>>>> http://sqeweb.us.oracle.com/jsn/users/patrick/newresult1/work/java/time/tck/java/time/TCKInstant.jtr >>>>> >>>>> >>>>> Regards >>>>> Patrick >>>>> From xueming.shen at oracle.com Mon Jan 14 19:00:21 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 15 Jan 2013 03:00:21 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added more tests Message-ID: <20130115030034.2402947279@hg.openjdk.java.net> Changeset: 89a875f4018d Author: sherman Date: 2013-01-14 19:03 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/89a875f4018d Added more tests Contributed-by: patrick.zhang at oracle.com ! test/java/time/tck/java/time/TCKInstant.java From scolebourne at joda.org Tue Jan 15 04:54:54 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 12:54:54 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130115125608.05E614728D@hg.openjdk.java.net> Changeset: 19cb142c0c67 Author: scolebourne Date: 2013-01-15 11:26 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/19cb142c0c67 Enhance package info, adding null specification Move design notes from overview as a non-normative section ! src/share/classes/java/time/calendar/package-info.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/package-info.java Changeset: c918e23271bc Author: scolebourne Date: 2013-01-15 11:58 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c918e23271bc Javadoc for range methods ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: c0951ac56624 Author: scolebourne Date: 2013-01-15 12:54 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c0951ac56624 Enhance serialization documentation ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java From scolebourne at joda.org Tue Jan 15 07:06:20 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 15 Jan 2013 15:06:20 +0000 Subject: [threeten-dev] [threeten-develop] Review for updates to javadoc In-Reply-To: <50F4B882.6070301@Oracle.com> References: <50F47299.1070705@Oracle.com> <50F4B882.6070301@Oracle.com> Message-ID: On 15 January 2013 02:01, Roger Riggs wrote: > The

with the normal stylesheet used in the JDK is a bold font just a > bit larger. > The individual packages have no control over the style sheet. > If the H5 is being used for the appearance then it is a mis-use of the > header. > > The HTML accessibility guides (Oracle's anyway) dictate that headers start > with H1 and be sequential. > > With respect to other paackage use of Hx, I have not yet seen what clean > up will need to be done. > That may result in the conventions being clarified and updated. Well, the strong

you changed it to has no effect in the Javadoc HTML view, so it looks like we have no headings at all now. This change needs putting back or fixing - everywhere else in the JDK is using . > One of the items that came up in the internal review is that the content > of the "implementation notes" > is in many cases normative. The interpretation of "implementation notes" > in the JDK is informative, > an implementation may follow the advice but is not required to. We will > have to review all > of the implementation notes and change the language to be specific about > whether it is a must, should or may. > The headings themselves need to make it clear whether the paragraph is > normative or informative. The only "implementation notes" remaining in hg are on non-public classes. Stephen From Roger.Riggs at oracle.com Tue Jan 15 08:15:33 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 15 Jan 2013 11:15:33 -0500 Subject: [threeten-dev] [threeten-develop] Review for updates to javadoc In-Reply-To: References: <50F47299.1070705@Oracle.com> <50F4B882.6070301@Oracle.com> Message-ID: <50F580A5.3040906@oracle.com> Hi Stephen, On 1/15/2013 10:06 AM, Stephen Colebourne wrote: > On 15 January 2013 02:01, Roger Riggs wrote: >> The

with the normal stylesheet used in the JDK is a bold font just a >> bit larger. >> The individual packages have no control over the style sheet. >> If the H5 is being used for the appearance then it is a mis-use of the >> header. >> >> The HTML accessibility guides (Oracle's anyway) dictate that headers start >> with H1 and be sequential. >> >> With respect to other paackage use of Hx, I have not yet seen what clean >> up will need to be done. >> That may result in the conventions being clarified and updated. > Well, the strong

you changed it to has no effect in the Javadoc > HTML view, so it looks like we have no headings at all now. This > change needs putting back or fixing - everywhere else in the JDK is > using. Which HTML view is that? Is it using the stylesheet.css? I used the ant script to generate the javadoc and checked the results with firefox. It also builds and displays correctly as part of the full JDK javadoc. > > >> One of the items that came up in the internal review is that the content >> of the "implementation notes" >> is in many cases normative. The interpretation of "implementation notes" >> in the JDK is informative, >> an implementation may follow the advice but is not required to. We will >> have to review all >> of the implementation notes and change the language to be specific about >> whether it is a must, should or may. >> The headings themselves need to make it clear whether the paragraph is >> normative or informative. > The only "implementation notes" remaining in hg are on non-public classes. The "specification for implementors" is similar. Other JDK classes integrate this kind of statement and do not separate it. It is also unclear whether the implementor is someone implementing the JDK or a developer using the API. A more directive statement is needed. Roger From scolebourne at joda.org Tue Jan 15 08:31:50 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 16:31:50 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Javadoc for with methods Message-ID: <20130115163245.EE03547290@hg.openjdk.java.net> Changeset: 7478819b8e4a Author: scolebourne Date: 2013-01-15 16:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7478819b8e4a Javadoc for with methods ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java From scolebourne at joda.org Tue Jan 15 08:35:52 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 15 Jan 2013 16:35:52 +0000 Subject: [threeten-dev] [threeten-develop] Review for updates to javadoc In-Reply-To: <50F580A5.3040906@oracle.com> References: <50F47299.1070705@Oracle.com> <50F4B882.6070301@Oracle.com> <50F580A5.3040906@oracle.com> Message-ID: On 15 January 2013 16:15, Roger Riggs wrote: > On 1/15/2013 10:06 AM, Stephen Colebourne wrote: > On 15 January 2013 02:01, Roger Riggs wrote: > > The

with the normal stylesheet used in the JDK is a bold font just a > bit larger. > The individual packages have no control over the style sheet. > If the H5 is being used for the appearance then it is a mis-use of the > header. > > The HTML accessibility guides (Oracle's anyway) dictate that headers start > with H1 and be sequential. > > With respect to other paackage use of Hx, I have not yet seen what clean > up will need to be done. > That may result in the conventions being clarified and updated. > > Well, the strong

you changed it to has no effect in the Javadoc > HTML view, so it looks like we have no headings at all now. This > change needs putting back or fixing - everywhere else in the JDK is > using . > > Which HTML view is that? Is it using the stylesheet.css? > > I used the ant script to generate the javadoc and checked the results with > firefox. > > It also builds and displays correctly as part of the full JDK javadoc. I'm using the standard generation from IntelliJ. No style is seen for the headers in the package info (it is seen in the class/method docs). > One of the items that came up in the internal review is that the content > of the "implementation notes" > is in many cases normative. The interpretation of "implementation notes" > in the JDK is informative, > an implementation may follow the advice but is not required to. We will > have to review all > of the implementation notes and change the language to be specific about > whether it is a must, should or may. > The headings themselves need to make it clear whether the paragraph is > normative or informative. > > The only "implementation notes" remaining in hg are on non-public classes. > > The "specification for implementors" is similar. Other JDK classes > integrate this > kind of statement and do not separate it. > > It is also unclear whether the implementor is someone implementing the JDK > or a developer using the API. A more directive statement is needed. Both. Feel free to suggest something. These do need to be separate sections so that regular users do not need to read them. Its advanced specification that only 1% of users should care about (those writing subclasses, as Oracle won't allow anyone else to implement the JDK, cf Apache Harmony). Stephen From scolebourne at joda.org Tue Jan 15 09:01:20 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 17:01:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130115170203.2936247291@hg.openjdk.java.net> Changeset: 2c0da0b62908 Author: scolebourne Date: 2013-01-15 16:39 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2c0da0b62908 Add Javadoc note about DateTimeBuilder ! src/share/classes/java/time/format/DateTimeBuilder.java Changeset: ee7bd9d7cbf8 Author: scolebourne Date: 2013-01-15 16:59 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ee7bd9d7cbf8 Javadoc for from(TemporalAccessor) methods ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java From scolebourne at joda.org Tue Jan 15 09:03:41 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 17:03:41 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Remove TODO now class is not public Message-ID: <20130115170403.0C30647292@hg.openjdk.java.net> Changeset: 383ce6656339 Author: scolebourne Date: 2013-01-15 17:03 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/383ce6656339 Remove TODO now class is not public ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java From scolebourne at joda.org Tue Jan 15 09:21:14 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 17:21:14 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130115172143.7DC8B47294@hg.openjdk.java.net> Changeset: 9d0d6d98c287 Author: scolebourne Date: 2013-01-15 17:15 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9d0d6d98c287 Tidy throws clauses ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: 8794c58dabcc Author: scolebourne Date: 2013-01-15 17:20 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8794c58dabcc Organize imports java.time should now be in with java.util and java.io ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java From scolebourne at joda.org Tue Jan 15 10:01:08 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 15 Jan 2013 18:01:08 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Javadoc for isAfter/Before/Equal methods Message-ID: <20130115180132.4973447298@hg.openjdk.java.net> Changeset: f3c1b88c9396 Author: scolebourne Date: 2013-01-15 17:50 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f3c1b88c9396 Javadoc for isAfter/Before/Equal methods ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java From xueming.shen at oracle.com Tue Jan 15 10:39:20 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 15 Jan 2013 10:39:20 -0800 Subject: [threeten-dev] hg: threeten/threeten/jdk: Javadoc for isAfter/Before/Equal methods In-Reply-To: <20130115180132.4973447298@hg.openjdk.java.net> References: <20130115180132.4973447298@hg.openjdk.java.net> Message-ID: <50F5A258.8010605@oracle.com> Stephen, While you are here...it is said it might be better to update the wording in ZoneRulesException's constructor from "date-time exception" to something "zone" related? It's identical to the DateTimeException now. -Sherman On 01/15/2013 10:01 AM, scolebourne at joda.org wrote: > Changeset: f3c1b88c9396 > Author: scolebourne > Date: 2013-01-15 17:50 +0000 > URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f3c1b88c9396 > > Javadoc for isAfter/Before/Equal methods > > ! src/share/classes/java/time/LocalDate.java > ! src/share/classes/java/time/LocalDateTime.java > From roger.riggs at oracle.com Tue Jan 15 10:59:25 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 15 Jan 2013 18:59:25 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Correct style=strong to class=strong Message-ID: <20130115190004.4724D472A5@hg.openjdk.java.net> Changeset: 198a591c5ebb Author: rriggs Date: 2013-01-15 13:53 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/198a591c5ebb Correct style=strong to class=strong ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/package-info.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/package-info.java From xueming.shen at oracle.com Tue Jan 15 11:30:02 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 15 Jan 2013 19:30:02 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated TemporalAccessor link in Formatter.java Message-ID: <20130115193027.C9759472A7@hg.openjdk.java.net> Changeset: 5a83e7f6eed4 Author: sherman Date: 2013-01-15 11:33 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5a83e7f6eed4 Updated TemporalAccessor link in Formatter.java ! src/share/classes/java/util/Formatter.java From Roger.Riggs at oracle.com Tue Jan 15 12:18:04 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 15 Jan 2013 15:18:04 -0500 Subject: [threeten-dev] Comments from Oracle on Threeten APIs Message-ID: <50F5B97C.7020804@oracle.com> Several senior Oracle JDK developers reviewed the Threeten API and made the following proposals and comments to address incongruities between the JSR 310 java.time APIs and the organization and design patterns of the JDK. * java.time.temporal package should be reorganized to improve usability and gather functionally similar types together. o The support for non-Iso calendars should be consolidated in a new package. javax.time.chrono includes Chronology (renamed from Chrono), ChronoLocalDate, ChronoLocalDateTime, ChronoZonedDateTime, Era, and ISOChrono classes. This will help cleanup the mixed-bag of types in temporal. o The OffsetDate, OffsetDateTime, and OffsetTime classes are moved to java.time; these classes have the same level of use as LocalDate, ZonedDateTime and developers will expect them to be co-located. o The Year, YearMonth, and MonthDay classes are not central to the API and should be removed; if not removed they are moved to the java.time package since they are functionally similar to the other classes in java.time. o The Temporal package has the interfaces for date-time types, the frameworks for fields and units, and the adjusters. * java.time.format package improvements to better align with other JDK designs and patterns: o The DateTimeFormatter factory methods currently in DateTimeFormatters are moved to DateTimeFormatter; it is natural to look in DateTimeFormatters for the factories and predefined DateTimeFormatters. Currently, there are no constructors or factory methods in DTF. o The print method is renamed to format throughout the 310 API; the name is a better fit for the function and follows the more naming pattern used in java.lang.String and the java.util.Formatter. o For improved usability, concrete date-time classes with a format (aka print) method should also have a format method that takes the pattern as an argument, i.e. format("yyyy-mm-dd"). * In JDK class and method names camel-case is prevalent and more readable, change ISO to Iso. * Add @FunctionalInterface where appropriate * Duration.parse - parsing grammars should be specified in EBNF * The Clocks class would be better as an interface with static methods (when available). * The TemporalAdder and TemporalSubtractor should be a single interface. * The plethora of plusXXX(n), minusXXX(n), methods are adequately covered by the plus(n, UNIT) and minus(n, UNIT) methods and are unnecessary and add to the excessive number of methods. * Implementation notes that are normative should not be labeled implementation notes which implies the implementation has a choice of implementation. * The ISO specific class Month should be named ISOMonth, similarly perhaps DayOfWeek as ISODay * The Queries class name is too generic, perhaps TemporalQueries or move them to the TemporalQuery interface. * DateTimeBuilder needs work or does not belong in the format package. Thanks to Mark Reinhold, Joe Darcy, and Brian Goetz and others for comments. I will followup with issues in the tracker to gather any additional discussion, comments and resolution. Since the M6 cutoff is next week, it is unlikely that these can be addressed for M6. Roger From roger.riggs at oracle.com Tue Jan 15 12:46:51 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 15 Jan 2013 20:46:51 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Add SerialVersionUID to java.time.Temporal.JulianFields.Field Message-ID: <20130115204715.C3BB6472AD@hg.openjdk.java.net> Changeset: ad0a4bc0d7e2 Author: rriggs Date: 2013-01-15 15:46 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ad0a4bc0d7e2 Add SerialVersionUID to java.time.Temporal.JulianFields.Field ! src/share/classes/java/time/temporal/JulianFields.java From roger.riggs at oracle.com Tue Jan 15 13:37:09 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 15 Jan 2013 21:37:09 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130115213743.581F2472B5@hg.openjdk.java.net> Changeset: 6133785bbd61 Author: rriggs Date: 2013-01-15 16:33 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6133785bbd61 Remove obsolete doc reference link from javadoc build ! make/netbeans/threeten/build.xml Changeset: 0a6b6f6b9f65 Author: rriggs Date: 2013-01-15 16:36 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0a6b6f6b9f65 Use

consistently for headers, compatible with doclint ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/calendar/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/time/zone/package-info.java From xueming.shen at oracle.com Tue Jan 15 14:07:21 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 15 Jan 2013 22:07:21 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated the corresponding copyright years Message-ID: <20130115220749.6DCE7472B6@hg.openjdk.java.net> Changeset: 71a7d71a0d4c Author: sherman Date: 2013-01-15 14:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/71a7d71a0d4c Updated the corresponding copyright years ! make/java/time/Makefile ! make/sun/tzdb/Makefile ! makefiles/CompileTimeZoneData.gmk From xueming.shen at oracle.com Tue Jan 15 14:11:48 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 15 Jan 2013 22:11:48 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated the corresponding copyright years Message-ID: <20130115221209.62949472B8@hg.openjdk.java.net> Changeset: d0c1cef1c03f Author: sherman Date: 2013-01-15 14:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d0c1cef1c03f Updated the corresponding copyright years ! make/java/time/Makefile ! make/sun/tzdb/Makefile ! makefiles/CompileTimeZoneData.gmk From misterm at gmail.com Tue Jan 15 15:14:01 2013 From: misterm at gmail.com (Michael Nascimento) Date: Tue, 15 Jan 2013 21:14:01 -0200 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu In-Reply-To: <50F47126.2070606@oracle.com> References: <50F47126.2070606@oracle.com> Message-ID: Vote: yes Regards, Michael On Mon, Jan 14, 2013 at 6:57 PM, Roger Riggs wrote: > I hereby nominate Masayoshi Okutsu to threeten-dev Committer. > > Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and is > making significant contributions to the Threeten project with a particular > focus on internationalization and internationalized calendars. > > Votes are due by Friday Jan 28. > > Only current threeten-dev Committers [1] are eligible to vote on this > nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Roger Riggs > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From richard.warburton at gmail.com Tue Jan 15 15:23:38 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Tue, 15 Jan 2013 23:23:38 +0000 Subject: [threeten-dev] CFV: New Threeten Committer: Masayoshi Okutsu In-Reply-To: References: <50F47126.2070606@oracle.com> Message-ID: vote: yes regards, Richard On Tue, Jan 15, 2013 at 11:14 PM, Michael Nascimento wrote: > Vote: yes > > Regards, > Michael > > On Mon, Jan 14, 2013 at 6:57 PM, Roger Riggs > wrote: > > I hereby nominate Masayoshi Okutsu to threeten-dev Committer. > > > > Okutsu-san is reviewer for the jdk8, jdk7, jdk7j and jdk6 projects and is > > making significant contributions to the Threeten project with a > particular > > focus on internationalization and internationalized calendars. > > > > Votes are due by Friday Jan 28. > > > > Only current threeten-dev Committers [1] are eligible to vote on this > > nomination. > > > > Votes must be cast in the open by replying to this mailing list. > > > > For Lazy Consensus voting instructions, see [2]. > > > > Roger Riggs > > > > [1] http://openjdk.java.net/census > > [2] http://openjdk.java.net/projects/#committer-vote > > > -- regards, Richard Warburton http://insightfullogic.com @RichardWarburto From xueming.shen at oracle.com Tue Jan 15 16:13:01 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 15 Jan 2013 16:13:01 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API Message-ID: <50F5F08D.5000008@oracle.com> Hi, The Threeten project [1] is planned to be integrated into OpenJDK8 M6 milestone. Here is the webrev http://cr.openjdk.java.net/~sherman/8003680/webrev and the latest javadoc http://cr.openjdk.java.net/~sherman/8003680/javadoc Review comments can be sent to the threeten-dev email list [2] and/or core-libs-dev email list[3]. Thanks, Sherman [1] http://openjdk.java.net/projects/threeten [2] threeten-dev @ openjdk.java.net [3] core-libs-dev @ openjdk.java.net From dan.chiba at oracle.com Tue Jan 15 18:35:57 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Tue, 15 Jan 2013 18:35:57 -0800 Subject: [threeten-dev] Islamic calendar variants need disambiguation In-Reply-To: References: <50CF9851.2060804@oracle.com> <50D10DC9.9080505@oracle.com> <50F07ABC.6010600@oracle.com> <50F0BDEE.7040808@oracle.com> <50F479DF.7030407@oracle.com> Message-ID: <50F6120D.10904@oracle.com> Thank you Stephen. #118 is just updated. Would you review it once again so we can confirm it looks good to you. Regards, -Dan On 1/14/2013 4:06 PM, Stephen Colebourne wrote: > As we've discussed before, there are two parallel IDs. For example > "Coptic" and "coptic", or "Hijrah" and "islamic". The table needs > updating with another column for the chronology ID (essentially an > alias based around the 310 class name). The ID isn't limited to 8 > letters, but it is probably easiest and simplest to re-use the cv > string. Thus "Hijrah-sa" would be an alias for islamic-sa" in the > of(String) factory method. > > Stephen > > > On 14 January 2013 21:34, Dan Chiba wrote: >> Hi Stephen, >> >> Thank you for the comments. For the ambiguous cases with no cv code, let's >> let it fall back to "islamic", which is the default variant Umm Al-Quara >> ("ca-islamic-cv-uaq" in CLDR). I just updated github #118 >> with this information. >> >> For the chronology ID, I am not sure exactly what it is; is it an ID to >> specify a Chronology class? If it could affect Islamic calendar support, >> would you mind providing a pointer to the discussion? >> >> Thanks, >> -Dan >> >> >> On 1/13/2013 2:50 PM, Stephen Colebourne wrote: >>> This plan looks fine to me, >>> >>> There is a separate discussion around what the chronology ID will be, >>> currently "Hijrah" (the strings in your email are the calendar system >>> ID). >>> >>> I do think that it is important that if the Locale has a ca code, but >>> not a cv code, then it should map to something sensible. >>> >>> Stephen >>> >>> >>> >>> On 12 January 2013 01:35, Dan Chiba wrote: >>>> For 310, we like the approach to use "islamic" for the primary variant >>>> and >>>> using "islamic-xxx" for others. >>>> We would like to propose a few details to fit to the CLDR ca/cv >>>> separation >>>> as follows: >>>> >>>> 310 CLDR Description >>>> ------------- -------------------- --------------------------------- >>>> islamic ca-islamic-cv-uaq Umm Al-Qura >>>> islamic-sa ca-islamic-cv-sa Saudi Arabia Sighting >>>> islamic-??? ca-islamic-cv-??? "???" denotes a specific variant. >>>> >>>> >>>> * Chronology.of() takes a 310 string. In JDK8 "islamic" and "islamic-sa" >>>> are >>>> the only defined variants. >>>> * Chronology.ofLocale() creates the specified variant if the locale has >>>> the >>>> CLDR designation inside. >>>> * The variant identifier must be in lowerecase and can be 2 to 8 letters >>>> long. >>>> * The IANA region codes are reserved. A region other than "sa" may have a >>>> variant. >>>> * 310 and CLDR plan to identify the common variants. >>>> (e.g. "kuwaiti" may be in high demand and become the next defined >>>> variant. >>>> The list may grow.) >>>> * Users who need a user defined variant may use a custom ID at their own >>>> risk. >>>> They are encouraged to request getting the ID registered. >>>> * 310 could have "islamic-uaq" as an alias of "islamicc" to match the >>>> defaulting for deprecation in CLDR. >>>> * 310 could have "islamic-uaq" as an alias of "islamic" to help achieve >>>> consistent mapping from CLDR to 310. >>>> * The registration/maintenance process is TBD. >>>> >>>> May I ask if this looks something we can settle this with? >>>> >>>> Regards, >>>> -Dan >>>> >>>> >>>> On 1/11/2013 2:01 PM, Stephen Colebourne wrote: >>>>> The string can be anything you want, as its more of an Oracle >>>>> requirement than mine. >>>>> >>>>> Personally, I would recommend that Oracle chooses a default Islamic >>>>> calendar variant, so the string "islamic" maps to one of the variants. >>>>> I would then have the other variants as "islamic-xxx". The ca and cv >>>>> parts in the 310 calendar system id are not really relevant. >>>>> >>>>> Stephen >>>>> >>>>> >>>>> On 11 January 2013 20:49, Dan Chiba wrote: >>>>>> Thank you very much Yoshito-san. >>>>>> >>>>>> Stephen, can the single string be "ca-islamic-cv-???"? Then all we need >>>>>> to >>>>>> do may be define the ???s? >>>>>> >>>>>> Regards, >>>>>> -Dan >>>>>> >>>>>> >>>>>> On 1/10/2013 5:20 PM, Stephen Colebourne wrote: >>>>>>> On 10 January 2013 21:04, wrote: >>>>>>>> We had a discussion about this in the CLDR TC meeting. >>>>>>>> Our tentative consensus is supporting calendar variations with a new >>>>>>>> extension. >>>>>>>> >>>>>>>> Although CLDR defines two types "islamic" and "islamicc", CLDR only >>>>>>>> has >>>>>>>> one set of formatting data. From formatting aspect, the difference in >>>>>>>> date >>>>>>>> calculation between them is not important. Our current plan is: >>>>>>>> >>>>>>>> 1. Add a new extension "cv" (calendar algorithm variant - tentative). >>>>>>>> 2. Investigate necessary types from experts, based on some references >>>>>>>> including your ticket above. >>>>>>>> 3. Deprecate "islamicc", and map to ca-islamic-cv-??? (??? will be >>>>>>>> determined later). >>>>>>>> >>>>>>>> Note that the type value is limited to 8 characters because of BCP 47 >>>>>>>> definition. We also considered multi-segment calendar type like >>>>>>>> islamic-umalqura as you suggested in the ticket, but it will require >>>>>>>> a >>>>>>>> bunch of duplicated references in CLDR data formatting data. For this >>>>>>>> reason, we are in favor of separating minor algorithm differences in >>>>>>>> a >>>>>>>> separate extension. >>>>>>> FWIW, I like the "cv" variant concept as it makes logical sense. It >>>>>>> will be harder to integrate into JSR-310 (where our methods take a >>>>>>> single String). The lookup from a Locale object will of course pose no >>>>>>> problem to adapt. >>>>>>> >>>>>>> Stephen From Alan.Bateman at oracle.com Wed Jan 16 04:08:01 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 16 Jan 2013 12:08:01 +0000 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F5F08D.5000008@oracle.com> References: <50F5F08D.5000008@oracle.com> Message-ID: <50F69821.6040300@oracle.com> On 16/01/2013 00:13, Xueming Shen wrote: > Hi, > > The Threeten project [1] is planned to be integrated into OpenJDK8 M6 > milestone. > > Here is the webrev > http://cr.openjdk.java.net/~sherman/8003680/webrev > > and the latest javadoc > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Review comments can be sent to the threeten-dev email list [2] and/or > core-libs-dev email list[3]. This is not a review of the API or implementation. Rather just a few random comments as I look through the webrev. It looks to me that the zone rules compiler ends up in rt.jar, is that expected and is it actually used at runtime? On initial read I thought it was build-time only but I might be wrong. As per off-list discussion, it needs to run on the boot JDK to work in cross-compilation environments and so the dependency on java.time is an issue. I see Formatter has been updated to support conversions of TemporalAccessor. Is the assert(width == -1) on L4067 right or was it copied from another print method? (Brian Burkhalter and I were chatting recently about an assert into another print method). Also on Formatter then I think it would be good to put the tests in test/java/util/Formatter as someone touching the Formatter code might not know there are additional tests hiding down in the odd location test/java/time/test/java/util. As you are adding a jdk_test target to test/Makefile then you will should also add the target to jprt.properties (btoh top-level repo and jdk/make). This is only interesting for Oracle build+test system of course. Just on the tests, is the plan to push the TCK tests to the jdk as proposed in the webrev? -Alan. From Roger.Riggs at oracle.com Wed Jan 16 09:10:47 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 16 Jan 2013 12:10:47 -0500 Subject: [threeten-dev] Result: New Threeten Committer: Masayoshi Okutsu Message-ID: <50F6DF17.1050307@oracle.com> |Voting for Masayoshi Okutsu [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Roger Riggs [1] http://mail.openjdk.java.net/pipermail/threeten-dev/2013-January/000452.html| From xueming.shen at oracle.com Wed Jan 16 10:28:04 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 16 Jan 2013 10:28:04 -0800 Subject: [threeten-dev] to add since 1.8 tag Message-ID: <50F6F134.8090101@oracle.com> http://cr.openjdk.java.net/~sherman/jdk8_threeten/since/ From xueming.shen at oracle.com Wed Jan 16 10:46:13 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 16 Jan 2013 10:46:13 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F69821.6040300@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F69821.6040300@oracle.com> Message-ID: <50F6F575.6060303@oracle.com> On 01/16/2013 04:08 AM, Alan Bateman wrote: > On 16/01/2013 00:13, Xueming Shen wrote: >> Hi, >> >> The Threeten project [1] is planned to be integrated into OpenJDK8 M6 milestone. >> >> Here is the webrev >> http://cr.openjdk.java.net/~sherman/8003680/webrev >> >> and the latest javadoc >> http://cr.openjdk.java.net/~sherman/8003680/javadoc >> >> Review comments can be sent to the threeten-dev email list [2] and/or >> core-libs-dev email list[3]. > This is not a review of the API or implementation. Rather just a few random comments as I look through the webrev. > > It looks to me that the zone rules compiler ends up in rt.jar, is that expected and is it actually used at runtime? On initial read I thought it was build-time only but I might be wrong. As per off-list discussion, it needs to run on the boot JDK to work in cross-compilation environments and so the dependency on java.time is an issue. Yes, looking into rewriting or moving some pieces around to satisfy the cross-compilation env. No, those should not be in rt.jar, at least for now. > > I see Formatter has been updated to support conversions of TemporalAccessor. Is the assert(width == -1) on L4067 right or was it copied from another print method? (Brian Burkhalter and I were chatting recently about an assert into another print method). It's copy/pasted from print(StringBuffer, Calendar...) > Also on Formatter then I think it would be good to put the tests in test/java/util/Formatter as someone touching the Formatter code might not know there are additional tests hiding down in the odd location test/java/time/test/java/util. > Yes, understood. The concern is that, at least for now, it is more likely we are going to change the java/time and we forget there is another test case at java/util/Formatter:-) Maybe it is more convenient to keep it here for a little while until the threeten is stable enough. The "location" is odd, mainly to satisfy the TestNG requirement (for tests with their own package). The test is written to use TestNG. > As you are adding a jdk_test target to test/Makefile then you will should also add the target to jprt.properties (btoh top-level repo and jdk/make). This is only interesting for Oracle build+test system of course. Sure, will added. > > Just on the tests, is the plan to push the TCK tests to the jdk as proposed in the webrev? Those tck tests also serve as unit tests. They are so named for the convenience that TCK guys can just pick them up and drop into their suite easily. -Sherman From xueming.shen at oracle.com Wed Jan 16 10:50:34 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 16 Jan 2013 18:50:34 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added since1.8 tag Message-ID: <20130116185108.2088947300@hg.openjdk.java.net> Changeset: 1764fcca1704 Author: sherman Date: 2013-01-16 10:54 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1764fcca1704 Added since1.8 tag ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/PeriodParser.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoLocalDate.java ! src/share/classes/java/time/temporal/ChronoLocalDateTime.java ! src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/ISOChrono.java ! src/share/classes/java/time/temporal/ISOEra.java ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/sun/tools/tzdb/TzdbZoneRulesCompiler.java ! src/share/classes/sun/tools/tzdb/ZoneRules.java ! src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java From scolebourne at joda.org Wed Jan 16 11:51:35 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 16 Jan 2013 19:51:35 +0000 Subject: [threeten-dev] to add since 1.8 tag In-Reply-To: <50F6F134.8090101@oracle.com> References: <50F6F134.8090101@oracle.com> Message-ID: +1 Stephen On Jan 16, 2013 6:24 PM, "Xueming Shen" wrote: > http://cr.openjdk.java.net/~**sherman/jdk8_threeten/since/ > From xueming.shen at oracle.com Wed Jan 16 14:36:24 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 16 Jan 2013 14:36:24 -0800 Subject: [threeten-dev] era formatting and era.getText(...) Message-ID: <50F72B68.2080406@oracle.com> It appears the Era formatting and Era.getText(...) never works as expected (DateTimeTextProvider does not suport Era field), so following code gives you numeric value of each era. Locale locale = Locale.JAPANESE; ChronoLocalDate cld = JapaneseChrono.INSTANCE.date(LocalDateTime.now()); DateTimeFormatter fmt = new DateTimeFormatterBuilder() .appendLocalized(FormatStyle.FULL, null, JapaneseChrono.INSTANCE) .toFormatter(locale); System.out.println(cld); System.out.println(fmt.print(cld)); System.out.println(DateTimeFormatters.pattern("GGGG").withLocale(locale).print(cld)); //for (Era era : ISOChrono.INSTANCE.eras()) { for (Era era : JapaneseChrono.INSTANCE.eras()) { System.out.printf("%s -> %s%n", era.toString(), era.getText(TextStyle.FULL, locale)); } Here is the webrev to make it work http://cr.openjdk.java.net/~sherman/jdk8_threeten/era/ DateTimeTextProvider can be consolidated later, probably goes to CalendarDateUtilities directly... Parser still does not work as we don't have a "chrono" in parser context, yet. -Sherman From yoshito_umaoka at us.ibm.com Wed Jan 16 14:41:37 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Wed, 16 Jan 2013 17:41:37 -0500 Subject: [threeten-dev] New time zone format patterns in LDML/CLDR Message-ID: As I mentioned last week, CLDR TC had discussed about new time zone format patterns based on Java/JSR-310 proposal. In this morning, we had a discussion about the remaining item (time zone ID) and reached to a conclusion. Our conclusion is to use pattern "VV" for time zone ID, redefine already semantically deprecated "V" for CLDR short time zone ID (BCP 47 locale extension - time zone value) and new pattern "VVV" for time zone's exemplar location. In other words, we still want to reserve 'I' for future enhancement. I updated the design document - http://sites.google.com/site/cldr/development/development-process/design-proposals/time-zone-offset-patterns These new date format patterns should be included in UTR#35 LDML for CLDR 23 release in March. Of course, JSR-310 does not need to use the same definition, but if possible, it would be nice if JSR-310 can use the same definition (probably, just "VV" for now). I think the distinction between 'X' and 'x' is practically more useful and I'd propose JSR-310 (and also, Java SimpleDateFormat) to accept 'X' and 'x' patterns as is. Anyway, If you have any comments, please let me know. We might still make some minor adjustments if there are any strong objections from JSR-310 community. For Islamic calendar variants definitions - I'll post the proposal to CLDR TC soon, and it should be ready by the end of this month. Thanks, Yoshito From scolebourne at joda.org Wed Jan 16 16:02:56 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 17 Jan 2013 00:02:56 +0000 Subject: [threeten-dev] era formatting and era.getText(...) In-Reply-To: <50F72B68.2080406@oracle.com> References: <50F72B68.2080406@oracle.com> Message-ID: Webrev looks fine. Parsing can work as far as the context. The addCalendrical() method will accept a Chrono. Stephen On 16 January 2013 22:36, Xueming Shen wrote: > It appears the Era formatting and Era.getText(...) never works > as expected (DateTimeTextProvider does not suport Era field), > so following code gives you numeric value of each era. > > Locale locale = Locale.JAPANESE; > > ChronoLocalDate cld = > JapaneseChrono.INSTANCE.date(LocalDateTime.now()); > DateTimeFormatter fmt = new DateTimeFormatterBuilder() > .appendLocalized(FormatStyle.FULL, null, > JapaneseChrono.INSTANCE) > .toFormatter(locale); > > System.out.println(cld); > System.out.println(fmt.print(cld)); > > System.out.println(DateTimeFormatters.pattern("GGGG").withLocale(locale).print(cld)); > > > //for (Era era : ISOChrono.INSTANCE.eras()) { > for (Era era : JapaneseChrono.INSTANCE.eras()) { > System.out.printf("%s -> %s%n", era.toString(), > era.getText(TextStyle.FULL, locale)); > } > > Here is the webrev to make it work > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/era/ > > DateTimeTextProvider can be consolidated later, probably goes to > CalendarDateUtilities directly... > > Parser still does not work as we don't have a "chrono" in parser context, > yet. > > -Sherman From scolebourne at joda.org Wed Jan 16 16:50:29 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 17 Jan 2013 00:50:29 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130117005115.5395447322@hg.openjdk.java.net> Changeset: 2c24432e1b28 Author: scolebourne Date: 2013-01-17 00:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2c24432e1b28 Remove references to non-existent class ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java Changeset: 99d329f42709 Author: scolebourne Date: 2013-01-17 00:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/99d329f42709 Minor Javadoc nits ! src/share/classes/java/time/temporal/ISOFields.java ! src/share/classes/java/time/temporal/ValueRange.java Changeset: 7300c4e6f7be Author: scolebourne Date: 2013-01-17 00:49 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7300c4e6f7be Add linkplain Javadoc tag in a number of locations ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/WeekFields.java From scolebourne at joda.org Wed Jan 16 17:08:57 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 17 Jan 2013 01:08:57 +0000 Subject: [threeten-dev] New time zone format patterns in LDML/CLDR In-Reply-To: References: Message-ID: On 16 January 2013 22:41, wrote: > As I mentioned last week, CLDR TC had discussed about new time zone format > patterns based on Java/JSR-310 proposal. In this morning, we had a > discussion about the remaining item (time zone ID) and reached to a > conclusion. Our conclusion is to use pattern "VV" for time zone ID, > redefine already semantically deprecated "V" for CLDR short time zone ID > (BCP 47 locale extension - time zone value) and new pattern "VVV" for time > zone's exemplar location. In other words, we still want to reserve 'I' for > future enhancement. I'm happy to swap JSR-310 to VV for time-zone ID. > I updated the design document - > http://sites.google.com/site/cldr/development/development-process/design-proposals/time-zone-offset-patterns > These new date format patterns should be included in UTR#35 LDML for CLDR > 23 release in March. > > Of course, JSR-310 does not need to use the same definition, but if > possible, it would be nice if JSR-310 can use the same definition > (probably, just "VV" for now). > > I think the distinction between 'X' and 'x' is practically more useful and > I'd propose JSR-310 (and also, Java SimpleDateFormat) to accept 'X' and > 'x' patterns as is. The X/x definitions look good. I like them. They will involve slightly more tweaking on our end to make them work, but thats OK. > Anyway, If you have any comments, please let me know. We might still make > some minor adjustments if there are any strong objections from JSR-310 > community. The remaining items were the padding "p" modifier and the use of # for fraction control. Any others? Stephen From xueming.shen at oracle.com Wed Jan 16 18:00:46 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 17 Jan 2013 02:00:46 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added Era.getText and DateTimeFormatter/Era support Message-ID: <20130117020107.DC4F447324@hg.openjdk.java.net> Changeset: 5a09aced4db6 Author: sherman Date: 2013-01-16 18:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5a09aced4db6 Added Era.getText and DateTimeFormatter/Era support ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeTextProvider.java From scolebourne at joda.org Thu Jan 17 03:48:38 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 17 Jan 2013 11:48:38 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130117114925.15D6547365@hg.openjdk.java.net> Changeset: 0c7df471bee3 Author: scolebourne Date: 2013-01-17 11:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0c7df471bee3 Minor fix to comments ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java Changeset: 3546fbfa186d Author: scolebourne Date: 2013-01-17 11:41 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3546fbfa186d Minor Javadoc formatting nits ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/temporal/MonthDay.java From Roger.Riggs at oracle.com Thu Jan 17 08:18:47 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 17 Jan 2013 11:18:47 -0500 Subject: [threeten-dev] Webrev for Minor cleanup of test Message-ID: <50F82467.5090102@oracle.com> Remove spurious output in TestISOCronoImpl due to pending issue #186. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-spur/ Thanks, Roger From scolebourne at joda.org Thu Jan 17 08:27:10 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 17 Jan 2013 16:27:10 +0000 Subject: [threeten-dev] Webrev for Minor cleanup of test In-Reply-To: <50F82467.5090102@oracle.com> References: <50F82467.5090102@oracle.com> Message-ID: +1 Stephen On 17 January 2013 16:18, Roger Riggs wrote: > Remove spurious output in TestISOCronoImpl due to pending issue #186. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-spur/ > > Thanks, Roger From roger.riggs at oracle.com Thu Jan 17 10:46:22 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 17 Jan 2013 18:46:22 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Remove misleading test output pending issue #186 resolution Message-ID: <20130117184703.BFD9B47377@hg.openjdk.java.net> Changeset: 846cd48b247b Author: rriggs Date: 2013-01-17 11:02 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/846cd48b247b Remove misleading test output pending issue #186 resolution ! test/java/time/test/java/time/temporal/TestISOChronoImpl.java From Roger.Riggs at oracle.com Thu Jan 17 10:53:04 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 17 Jan 2013 13:53:04 -0500 Subject: [threeten-dev] Prospective review for renaming ISO to Iso in classnames and method names (not for M6) Message-ID: <50F84890.4070209@oracle.com> While waiting for the M6 reviews to close, I thought I start on the changes for after M6. Issue #211 Camel-case for names - ISOXXX - IsoXxx Webrev: http://cr.openjdk.java.net/~rriggs/webrev-rename-iso/ Not to be pushed until the current M6 work is completed and pushed to the TL repository. -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From naoto.sato at oracle.com Thu Jan 17 15:53:22 2013 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 17 Jan 2013 15:53:22 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F5F08D.5000008@oracle.com> References: <50F5F08D.5000008@oracle.com> Message-ID: <50F88EF2.5060507@oracle.com> Hi Sherman, Here are my comments on the 310 changes: - java/util/Formatter.java Line 4125: To do a locale neutral case mapping, use Locale.ROOT instead of Locale.US. Line 4161-4169: Remove this as it is commented out. Also "import sun.util.locale.provider.TimeZoneNameUtility" is not needed either. Line 4173, 4183, 4195: The code assumes Locale.US if "l == null." Is this correct? Should it be Locale.ROOT? - java/time/DayOfWeek.java Line 298-300: Maybe just me, but I thought the convention for "throws" was to consolidate conditions into a single "throws" line for the same exception. - java/time/ZoneOffset.java Line 214: @SuppressWarnings("fallthrough")? - java/time/calendar/ChronoDateImpl.java: In the example in the class description, "%n" should be "\n" for the new lines in the printf()s. - java/time/calendar/HijrahDeviationReader.java Line 224: Is it OK to catch all Exception here, and pretends as if nothing happened? - java/time/calendar/JapaneseChrono.java Line 166-172: How come it includes "Keio"? Isn't the era before "Meiji" "Seireki"? - java/time/calendar/MinguoDate.java Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on this field. - java/time/calendar/ThaiBuddhistDate.java Same as above MinguoDate.java - java/time/format/DateTimeBuilder.java There are several "TODO"s in here. Line 357: It is commented that return value is for ZoneOffset/ZoneId. But since it is public, could this be safe? Can arbitrary app modify it maliciously? - java/time/format/DateTimeFormatSymbols.java Line 131: It should use the default locale for formatting, i.e, Locale.getDefault(Locale.Category.FORMAT) - java/time/format/DateTimeFormatter.java Line 411: DateTimeException needs to be described, as it is thrown in this method. Line 486: The DateTimeException needs to be on @throws clause. - java/time/format/DateTimeFormatterBuilder Line 174: The type for "padNextChar" should be "int" to accommodate supplementary characters. Not only this particular instance, it looks like there are bunch of places that use ++/-- for character iteration. Are they OK? Line 236: "sensitive" -> "insensitive" Line 276: "strict" -> "lenient" Line 1440: use Locale.getDefault(Locale.Category.FORMAT) - java/time/format/DateTimeFormatters.java Line 271, 294, 317, 340: Locale.getDefault() -> Locale.getDefault(Locale.Category), "default locale" -> "default FORMAT locale" - java/time/format/DateTimeParseContext.java Line 194, 195: Should those to[Lower/Upper]Case() take Locale.ROOT as an argument? Remember the Turkish 'i' case? - java/time/overview.html Should the contents here be moved to package.html? Should we continue to use "Threeten" name? - java/time/temporal/Chrono.java Line 102: "minguoDate" -> "thaiDate" Line 212: The comment is kind of cryptic. Looks like not "removing" but "registering" - java/time/zone/TzdbZoneRulesProvider.java Line 171: Is it OK to catch all exceptions here and ignore? - sun/tools/tzdb/* Should the compile be moved under "make" directory, instead of "src"? Naoto On 1/15/13 4:13 PM, Xueming Shen wrote: > Hi, > > The Threeten project [1] is planned to be integrated into OpenJDK8 M6 > milestone. > > Here is the webrev > http://cr.openjdk.java.net/~sherman/8003680/webrev > > and the latest javadoc > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Review comments can be sent to the threeten-dev email list [2] and/or > core-libs-dev email list[3]. > > Thanks, > Sherman > > [1] http://openjdk.java.net/projects/threeten > [2] threeten-dev @ openjdk.java.net > [3] core-libs-dev @ openjdk.java.net > > From naoto.sato at oracle.com Thu Jan 17 15:55:46 2013 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 17 Jan 2013 15:55:46 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F5F08D.5000008@oracle.com> References: <50F5F08D.5000008@oracle.com> Message-ID: <50F88F82.40507@oracle.com> Hi Sherman, Here are my comments on the 310 changes: - java/util/Formatter.java Line 4125: To do a locale neutral case mapping, use Locale.ROOT instead of Locale.US. Line 4161-4169: Remove this as it is commented out. Also "import sun.util.locale.provider.TimeZoneNameUtility" is not needed either. Line 4173, 4183, 4195: The code assumes Locale.US if "l == null." Is this correct? Should it be Locale.ROOT? - java/time/DayOfWeek.java Line 298-300: Maybe just me, but I thought the convention for "throws" was to consolidate conditions into a single "throws" line for the same exception. - java/time/ZoneOffset.java Line 214: @SuppressWarnings("fallthrough")? - java/time/calendar/ChronoDateImpl.java: In the example in the class description, "%n" should be "\n" for the new lines in the printf()s. - java/time/calendar/HijrahDeviationReader.java Line 224: Is it OK to catch all Exception here, and pretends as if nothing happened? - java/time/calendar/JapaneseChrono.java Line 166-172: How come it includes "Keio"? Isn't the era before "Meiji" "Seireki"? - java/time/calendar/MinguoDate.java Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on this field. - java/time/calendar/ThaiBuddhistDate.java Same as above MinguoDate.java - java/time/format/DateTimeBuilder.java There are several "TODO"s in here. Line 357: It is commented that return value is for ZoneOffset/ZoneId. But since it is public, could this be safe? Can arbitrary app modify it maliciously? - java/time/format/DateTimeFormatSymbols.java Line 131: It should use the default locale for formatting, i.e, Locale.getDefault(Locale.Category.FORMAT) - java/time/format/DateTimeFormatter.java Line 411: DateTimeException needs to be described, as it is thrown in this method. Line 486: The DateTimeException needs to be on @throws clause. - java/time/format/DateTimeFormatterBuilder Line 174: The type for "padNextChar" should be "int" to accommodate supplementary characters. Not only this particular instance, it looks like there are bunch of places that use ++/-- for character iteration. Are they OK? Line 236: "sensitive" -> "insensitive" Line 276: "strict" -> "lenient" Line 1440: use Locale.getDefault(Locale.Category.FORMAT) - java/time/format/DateTimeFormatters.java Line 271, 294, 317, 340: Locale.getDefault() -> Locale.getDefault(Locale.Category), "default locale" -> "default FORMAT locale" - java/time/format/DateTimeParseContext.java Line 194, 195: Should those to[Lower/Upper]Case() take Locale.ROOT as an argument? Remember the Turkish 'i' case? - java/time/overview.html Should the contents here be moved to package.html? Should we continue to use "Threeten" name? - java/time/temporal/Chrono.java Line 102: "minguoDate" -> "thaiDate" Line 212: The comment is kind of cryptic. Looks like not "removing" but "registering" - java/time/zone/TzdbZoneRulesProvider.java Line 171: Is it OK to catch all exceptions here and ignore? - sun/tools/tzdb/* Should the compile be moved under "make" directory, instead of "src"? Naoto On 1/15/13 4:13 PM, Xueming Shen wrote: > Hi, > > The Threeten project [1] is planned to be integrated into OpenJDK8 M6 > milestone. > > Here is the webrev > http://cr.openjdk.java.net/~sherman/8003680/webrev > > and the latest javadoc > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Review comments can be sent to the threeten-dev email list [2] and/or > core-libs-dev email list[3]. > > Thanks, > Sherman > > [1] http://openjdk.java.net/projects/threeten > [2] threeten-dev @ openjdk.java.net > [3] core-libs-dev @ openjdk.java.net > > From xueming.shen at oracle.com Thu Jan 17 20:55:42 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 17 Jan 2013 20:55:42 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F88F82.40507@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F88F82.40507@oracle.com> Message-ID: <50F8D5CE.6060508@oracle.com> Thanks Naoto! We will see how many we can update tomorrow. Regarding the Locale.ROOT vs Locale.US, it appears we are now using Locale.US in j.u.Formatter for l==null case in existing. (Formatter is earlier than the the 1.6 ROOT). So I may keep the US for now for the consistency. It may be a good small Locale.US cleanup project later. -Sherman On 01/17/2013 03:55 PM, Naoto Sato wrote: > Hi Sherman, > > Here are my comments on the 310 changes: > > > - java/util/Formatter.java > > Line 4125: To do a locale neutral case mapping, use Locale.ROOT instead of Locale.US. > > Line 4161-4169: Remove this as it is commented out. Also "import sun.util.locale.provider.TimeZoneNameUtility" is not needed either. > > Line 4173, 4183, 4195: The code assumes Locale.US if "l == null." Is this correct? Should it be Locale.ROOT? > > > - java/time/DayOfWeek.java > > Line 298-300: Maybe just me, but I thought the convention for "throws" was to consolidate conditions into a single "throws" line for the same exception. > > > - java/time/ZoneOffset.java > > Line 214: @SuppressWarnings("fallthrough")? > > > - java/time/calendar/ChronoDateImpl.java: > > In the example in the class description, "%n" should be "\n" for the new lines in the printf()s. > > > - java/time/calendar/HijrahDeviationReader.java > > Line 224: Is it OK to catch all Exception here, and pretends as if nothing happened? > > > - java/time/calendar/JapaneseChrono.java > > Line 166-172: How come it includes "Keio"? Isn't the era before "Meiji" "Seireki"? > > > - java/time/calendar/MinguoDate.java > > Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on this field. > > - java/time/calendar/ThaiBuddhistDate.java > > Same as above MinguoDate.java > > - java/time/format/DateTimeBuilder.java > > There are several "TODO"s in here. > > Line 357: It is commented that return value is for ZoneOffset/ZoneId. But since it is public, could this be safe? Can arbitrary app modify it maliciously? > > > - java/time/format/DateTimeFormatSymbols.java > > Line 131: It should use the default locale for formatting, i.e, Locale.getDefault(Locale.Category.FORMAT) > > > - java/time/format/DateTimeFormatter.java > > Line 411: DateTimeException needs to be described, as it is thrown in this method. > > Line 486: The DateTimeException needs to be on @throws clause. > > > - java/time/format/DateTimeFormatterBuilder > > Line 174: The type for "padNextChar" should be "int" to accommodate supplementary characters. Not only this particular instance, it looks like there are bunch of places that use ++/-- for character iteration. Are they OK? > > Line 236: "sensitive" -> "insensitive" > > Line 276: "strict" -> "lenient" > > Line 1440: use Locale.getDefault(Locale.Category.FORMAT) > > > - java/time/format/DateTimeFormatters.java > > Line 271, 294, 317, 340: Locale.getDefault() -> Locale.getDefault(Locale.Category), "default locale" -> "default FORMAT locale" > > > - java/time/format/DateTimeParseContext.java > > Line 194, 195: Should those to[Lower/Upper]Case() take Locale.ROOT as an argument? Remember the Turkish 'i' case? > > > - java/time/overview.html > > Should the contents here be moved to package.html? Should we continue to use "Threeten" name? > > > - java/time/temporal/Chrono.java > > Line 102: "minguoDate" -> "thaiDate" > > Line 212: The comment is kind of cryptic. Looks like not "removing" but "registering" > > > - java/time/zone/TzdbZoneRulesProvider.java > > Line 171: Is it OK to catch all exceptions here and ignore? > > > - sun/tools/tzdb/* > > Should the compile be moved under "make" directory, instead of "src"? > > > Naoto > > On 1/15/13 4:13 PM, Xueming Shen wrote: >> Hi, >> >> The Threeten project [1] is planned to be integrated into OpenJDK8 M6 >> milestone. >> >> Here is the webrev >> http://cr.openjdk.java.net/~sherman/8003680/webrev >> >> and the latest javadoc >> http://cr.openjdk.java.net/~sherman/8003680/javadoc >> >> Review comments can be sent to the threeten-dev email list [2] and/or >> core-libs-dev email list[3]. >> >> Thanks, >> Sherman >> >> [1] http://openjdk.java.net/projects/threeten >> [2] threeten-dev @ openjdk.java.net >> [3] core-libs-dev @ openjdk.java.net >> >> > From scolebourne at joda.org Fri Jan 18 09:20:42 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 18 Jan 2013 17:20:42 +0000 Subject: [threeten-dev] New home page and backport project Message-ID: There is now a new home page for the ThreeTen project. The ThreeTen project is larger than JSR-310. The JSR is solely focussed on getting the code into OpenJDK and JDK 1.8. The ThreeTen project is a broader one that now includes a backport to JDK 1.7. The backport is not a JSR implementation, but is sourced of the same code base (using the original BSD license). This home page includes a documentation section which needs considerable expansion. If there are any volunteers that want to help expand the documentation, let me know. It can be done in markdown by forking the website git and sending pull requests, New home page: http://threeten.github.com/ Backport: https://github.com/ThreeTen/threetenbp Documentation: http://threeten.github.com/articles/index.html http://threeten.org also now redirects to the home page as I have bought the domain name. Stephen From xueming.shen at oracle.com Fri Jan 18 09:51:24 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 09:51:24 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk Message-ID: <50F98B9C.5030503@oracle.com> Current approach to build tzdb data is a no-go from build and embedded team. Here is the webrev that to have the tzdb compiler works with a set of strip-down JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed to be a early jdk release that does not have any jdk8 feature. I also remove the leak second from tool and the date. The code probably need further clean-up. But I will spend most of the time today to make sure the correctness of the output (the tests are all past, but I will verify the output is identical to the output from the "normal" version) http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ -Sherman From scolebourne at joda.org Fri Jan 18 10:08:30 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 18 Jan 2013 18:08:30 +0000 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50F98B9C.5030503@oracle.com> References: <50F98B9C.5030503@oracle.com> Message-ID: This looks like a reasonable approach. Ultimately, these classes could be slimmed down more, but that isn't vital now. Stephen On 18 January 2013 17:51, Xueming Shen wrote: > Current approach to build tzdb data is a no-go from build and embedded team. > > Here is the webrev that to have the tzdb compiler works with a set of > strip-down > JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed to > be > a early jdk release that does not have any jdk8 feature. I also remove the > leak > second from tool and the date. > > The code probably need further clean-up. But I will spend most of the time > today > to make sure the correctness of the output (the tests are all past, but I > will verify > the output is identical to the output from the "normal" version) > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ > > -Sherman From xueming.shen at oracle.com Fri Jan 18 10:32:18 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 10:32:18 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: References: <50F98B9C.5030503@oracle.com> Message-ID: <50F99532.5050108@oracle.com> Yes, they can be further consolidated, if given more time:-) On 01/18/2013 10:08 AM, Stephen Colebourne wrote: > This looks like a reasonable approach. Ultimately, these classes could > be slimmed down more, but that isn't vital now. > Stephen > > On 18 January 2013 17:51, Xueming Shen wrote: >> Current approach to build tzdb data is a no-go from build and embedded team. >> >> Here is the webrev that to have the tzdb compiler works with a set of >> strip-down >> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed to >> be >> a early jdk release that does not have any jdk8 feature. I also remove the >> leak >> second from tool and the date. >> >> The code probably need further clean-up. But I will spend most of the time >> today >> to make sure the correctness of the output (the tests are all past, but I >> will verify >> the output is identical to the output from the "normal" version) >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >> >> -Sherman From Roger.Riggs at oracle.com Fri Jan 18 10:36:01 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 18 Jan 2013 13:36:01 -0500 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F88F82.40507@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F88F82.40507@oracle.com> Message-ID: <50F99611.2050805@oracle.com> Hi Naoto, Thank you for the review, comments inline. Some issues are still to be addressed. On 1/17/2013 6:55 PM, Naoto Sato wrote: > Hi Sherman, > > Here are my comments on the 310 changes: > > > - java/util/Formatter.java > > Line 4125: To do a locale neutral case mapping, use Locale.ROOT > instead of Locale.US. > > Line 4161-4169: Remove this as it is commented out. Also "import > sun.util.locale.provider.TimeZoneNameUtility" is not needed either. > > Line 4173, 4183, 4195: The code assumes Locale.US if "l == null." Is > this correct? Should it be Locale.ROOT? > > > - java/time/DayOfWeek.java > > Line 298-300: Maybe just me, but I thought the convention for "throws" > was to consolidate conditions into a single "throws" line for the same > exception. This style is used by JSR 310 and will need to be reconciled with the JDK before release. > > > - java/time/ZoneOffset.java > > Line 214: @SuppressWarnings("fallthrough")? intentional; fixed with @SuppressWarnings > > > - java/time/calendar/ChronoDateImpl.java: > > In the example in the class description, "%n" should be "\n" for the > new lines in the printf()s. According to java.util.Format %n is the platform specific line separator. "\n" would, I expect, work just as well. > > > - java/time/calendar/HijrahDeviationReader.java > > Line 224: Is it OK to catch all Exception here, and pretends as if > nothing happened? That check is an optimization of the library path. Even if it fails, the file will be checked with the unoptimized library path. What is the convention for reporting configuration errors? It might be applicable in this case. > > > - java/time/calendar/JapaneseChrono.java > > Line 166-172: How come it includes "Keio"? Isn't the era before > "Meiji" "Seireki"? Those resources are unused and should be removed. The Era names are provided by the JapaneseEra class. > > > - java/time/calendar/MinguoDate.java > > Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on > this field. \ The @serial and readObject in JapaneseDate is out of date, the serialized form for all of ChronoLocalDates use writeReplace to put an instance of "Ser" in the stream. > > - java/time/calendar/ThaiBuddhistDate.java > > Same as above MinguoDate.java Same as MinguoDate > > - java/time/format/DateTimeBuilder.java > > There are several "TODO"s in here. DateTimeBuilder is in the process of being redesigned and will be updated for M7. > > Line 357: It is commented that return value is for ZoneOffset/ZoneId. > But since it is public, could this be safe? Can arbitrary app modify > it maliciously? DateTimeBuilder is a working context for resolving individual fields during parsing. Its instances are short lived and not shared. > > > - java/time/format/DateTimeFormatSymbols.java > > Line 131: It should use the default locale for formatting, i.e, > Locale.getDefault(Locale.Category.FORMAT) > > > - java/time/format/DateTimeFormatter.java > > Line 411: DateTimeException needs to be described, as it is thrown in > this method. added > > Line 486: The DateTimeException needs to be on @throws clause. added > > > - java/time/format/DateTimeFormatterBuilder > > Line 174: The type for "padNextChar" should be "int" to accommodate > supplementary characters. Not only this particular instance, it looks > like there are bunch of places that use ++/-- for character iteration. > Are they OK? > > Line 236: "sensitive" -> "insensitive" > > Line 276: "strict" -> "lenient" > > Line 1440: use Locale.getDefault(Locale.Category.FORMAT) > > > - java/time/format/DateTimeFormatters.java > > Line 271, 294, 317, 340: Locale.getDefault() -> > Locale.getDefault(Locale.Category), "default locale" -> "default > FORMAT locale" > > > - java/time/format/DateTimeParseContext.java > > Line 194, 195: Should those to[Lower/Upper]Case() take Locale.ROOT as > an argument? Remember the Turkish 'i' case? > > > - java/time/overview.html > > Should the contents here be moved to package.html? Should we continue > to use "Threeten" name? The overview.html is present only for the JSR 310 Public Review as an overview of the API and will not be present in the JDK. Most of its contents have been integrated into java.time package javadoc. > > > - java/time/temporal/Chrono.java > > Line 102: "minguoDate" -> "thaiDate" fixed > > Line 212: The comment is kind of cryptic. Looks like not "removing" > but "registering" Corrected. > > > - java/time/zone/TzdbZoneRulesProvider.java > > Line 171: Is it OK to catch all exceptions here and ignore? Similar to the treatment in HijrahDeviationReader; the library path optimization may fail but the file checks are done later. > > > - sun/tools/tzdb/* > > Should the compile be moved under "make" directory, instead of "src"? > > > Naoto > > On 1/15/13 4:13 PM, Xueming Shen wrote: >> Hi, >> >> The Threeten project [1] is planned to be integrated into OpenJDK8 M6 >> milestone. >> >> Here is the webrev >> http://cr.openjdk.java.net/~sherman/8003680/webrev >> >> and the latest javadoc >> http://cr.openjdk.java.net/~sherman/8003680/javadoc >> >> Review comments can be sent to the threeten-dev email list [2] and/or >> core-libs-dev email list[3]. >> >> Thanks, >> Sherman >> >> [1] http://openjdk.java.net/projects/threeten >> [2] threeten-dev @ openjdk.java.net >> [3] core-libs-dev @ openjdk.java.net >> >> > From Roger.Riggs at oracle.com Fri Jan 18 10:42:21 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 18 Jan 2013 13:42:21 -0500 Subject: [threeten-dev] Fixes for several review issues Message-ID: <50F9978D.20500@oracle.com> Hi, I responded to some of the review comments. Here is the webrev for the changes. http://cr.openjdk.java.net/~rriggs/webrev-review-fixes/ -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From Brian.Harris at morganstanley.com Fri Jan 18 10:47:02 2013 From: Brian.Harris at morganstanley.com (Harris, Brian) Date: Fri, 18 Jan 2013 18:47:02 +0000 Subject: [threeten-dev] New home page and backport project In-Reply-To: References: Message-ID: <28F1E4DF81064C4E8C89AE6007D2091116C1F7F2@HZWEX2009N4.msad.ms.com> Hi Stephen, Do you have an idea of how often the backport will be synced up? Thanks, Brian -----Original Message----- From: threeten-dev-bounces at openjdk.java.net [mailto:threeten-dev-bounces at openjdk.java.net] On Behalf Of Stephen Colebourne Sent: Friday, January 18, 2013 9:21 AM To: threeten-develop at lists.sourceforge.net Cc: threeten-dev at openjdk.java.net Subject: [threeten-dev] New home page and backport project There is now a new home page for the ThreeTen project. The ThreeTen project is larger than JSR-310. The JSR is solely focussed on getting the code into OpenJDK and JDK 1.8. The ThreeTen project is a broader one that now includes a backport to JDK 1.7. The backport is not a JSR implementation, but is sourced of the same code base (using the original BSD license). This home page includes a documentation section which needs considerable expansion. If there are any volunteers that want to help expand the documentation, let me know. It can be done in markdown by forking the website git and sending pull requests, New home page: http://threeten.github.com/ Backport: https://github.com/ThreeTen/threetenbp Documentation: http://threeten.github.com/articles/index.html http://threeten.org also now redirects to the home page as I have bought the domain name. Stephen -------------------------------------------------------------------------------- NOTICE: Morgan Stanley is not acting as a municipal advisor and the opinions or views contained herein are not intended to be, and do not constitute, advice within the meaning of Section 975 of the Dodd-Frank Wall Street Reform and Consumer Protection Act. If you have received this communication in error, please destroy all electronic and paper copies and notify the sender immediately. Mistransmission is not intended to waive confidentiality or privilege. Morgan Stanley reserves the right, to the extent permitted under applicable law, to monitor electronic communications. This message is subject to terms available at the following link: http://www.morganstanley.com/disclaimers. If you cannot access these links, please notify us by reply message and we will send the contents to you. By messaging with Morgan Stanley you consent to the foregoing. From roger.riggs at oracle.com Fri Jan 18 11:27:39 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 18 Jan 2013 19:27:39 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130118192833.5789F473D9@hg.openjdk.java.net> Changeset: 10297f08a70e Author: rriggs Date: 2013-01-18 14:13 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/10297f08a70e Corrections to issues raised in the review > - java/time/ZoneOffset.java > > Line 214: @SuppressWarnings("fallthrough")? intentionally; warnings fixed with @SuppressWarnings > > - java/time/calendar/JapaneseChrono.java > > Line 166-172: How come it includes "Keio"? Isn't the era before "Meiji" "Seireki"? Those resources are unused and should be removed. The Era names are provided by the JapaneseEra class. > > - java/time/calendar/MinguoDate.java > > Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on this field. The @serial and readObject in JapaneseDate is out of date, the serialized form for all of ChronoLocalDates use writeReplace to put an instance of "Ser" in the stream. > > - java/time/format/DateTimeFormatter.java > > Line 411: DateTimeException needs to be described, as it is thrown in this method. added > > Line 486: The DateTimeException needs to be on @throws clause. added > > - java/time/temporal/Chrono.java > > Line 102: "minguoDate" -> "thaiDate" fixed > > Line 212: The comment is kind of cryptic. Looks like not "removing" but "registering" Corrected. ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/temporal/Chrono.java Changeset: d1ca600668c7 Author: rriggs Date: 2013-01-18 14:23 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d1ca600668c7 Merge ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/temporal/Chrono.java From xueming.shen at oracle.com Fri Jan 18 12:09:51 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 12:09:51 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50F99532.5050108@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> Message-ID: <50F9AC0F.7090800@oracle.com> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated by the new version matches the previous one. So I'm confident now to go:-) http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java -Sherman On 01/18/2013 10:32 AM, Xueming Shen wrote: > Yes, they can be further consolidated, if given more time:-) > > On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >> This looks like a reasonable approach. Ultimately, these classes could >> be slimmed down more, but that isn't vital now. >> Stephen >> >> On 18 January 2013 17:51, Xueming Shen wrote: >>> Current approach to build tzdb data is a no-go from build and embedded team. >>> >>> Here is the webrev that to have the tzdb compiler works with a set of >>> strip-down >>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed to >>> be >>> a early jdk release that does not have any jdk8 feature. I also remove the >>> leak >>> second from tool and the date. >>> >>> The code probably need further clean-up. But I will spend most of the time >>> today >>> to make sure the correctness of the output (the tests are all past, but I >>> will verify >>> the output is identical to the output from the "normal" version) >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>> >>> -Sherman > From xueming.shen at oracle.com Fri Jan 18 12:39:43 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 12:39:43 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50F9AC0F.7090800@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> Message-ID: <50F9B30F.1080901@oracle.com> webrev has been updated, with some minor changes. Fully tested, ready to go. http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2 -sherman On 01/18/2013 12:09 PM, Xueming Shen wrote: > A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated > by the new version matches the previous one. So I'm confident now > to go:-) > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java > > -Sherman > > On 01/18/2013 10:32 AM, Xueming Shen wrote: >> Yes, they can be further consolidated, if given more time:-) >> >> On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >>> This looks like a reasonable approach. Ultimately, these classes could >>> be slimmed down more, but that isn't vital now. >>> Stephen >>> >>> On 18 January 2013 17:51, Xueming Shen wrote: >>>> Current approach to build tzdb data is a no-go from build and embedded team. >>>> >>>> Here is the webrev that to have the tzdb compiler works with a set of >>>> strip-down >>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed to >>>> be >>>> a early jdk release that does not have any jdk8 feature. I also remove the >>>> leak >>>> second from tool and the date. >>>> >>>> The code probably need further clean-up. But I will spend most of the time >>>> today >>>> to make sure the correctness of the output (the tests are all past, but I >>>> will verify >>>> the output is identical to the output from the "normal" version) >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>>> >>>> -Sherman >> > From scolebourne at joda.org Fri Jan 18 12:37:12 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 18 Jan 2013 20:37:12 +0000 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50F9B30F.1080901@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> Message-ID: Looks like your last webrev doesn't show files as being moved, just deleted and re-created. Otherwise, I've no problems with pushing if the functionality matches, although I am sad to lose the leap seconds. Stephen On 18 January 2013 20:39, Xueming Shen wrote: > webrev has been updated, with some minor changes. Fully tested, > ready to go. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2 > > -sherman > > > On 01/18/2013 12:09 PM, Xueming Shen wrote: >> >> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated >> by the new version matches the previous one. So I'm confident now >> to go:-) >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java >> >> -Sherman >> >> On 01/18/2013 10:32 AM, Xueming Shen wrote: >>> >>> Yes, they can be further consolidated, if given more time:-) >>> >>> On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >>>> >>>> This looks like a reasonable approach. Ultimately, these classes could >>>> be slimmed down more, but that isn't vital now. >>>> Stephen >>>> >>>> On 18 January 2013 17:51, Xueming Shen wrote: >>>>> >>>>> Current approach to build tzdb data is a no-go from build and embedded >>>>> team. >>>>> >>>>> Here is the webrev that to have the tzdb compiler works with a set of >>>>> strip-down >>>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed >>>>> to >>>>> be >>>>> a early jdk release that does not have any jdk8 feature. I also remove >>>>> the >>>>> leak >>>>> second from tool and the date. >>>>> >>>>> The code probably need further clean-up. But I will spend most of the >>>>> time >>>>> today >>>>> to make sure the correctness of the output (the tests are all past, but >>>>> I >>>>> will verify >>>>> the output is identical to the output from the "normal" version) >>>>> >>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>>>> >>>>> -Sherman >>> >>> >> > From xueming.shen at oracle.com Fri Jan 18 13:02:04 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 13:02:04 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> Message-ID: <50F9B84C.6060500@oracle.com> On 01/18/2013 12:37 PM, Stephen Colebourne wrote: > Looks like your last webrev doesn't show files as being moved, just > deleted and re-created. I brought them back to generate the "diff" of those three files. The latest is generated via webrev -N, so a real snapshot of the change. leap second can be brought back if the api/impl need them. Maybe 9:-) The test suggests we have the exactly the same rules. -Sherman > Otherwise, I've no problems with pushing if the functionality matches, > although I am sad to lose the leap seconds. > Stephen > > On 18 January 2013 20:39, Xueming Shen wrote: >> webrev has been updated, with some minor changes. Fully tested, >> ready to go. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2 >> >> -sherman >> >> >> On 01/18/2013 12:09 PM, Xueming Shen wrote: >>> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated >>> by the new version matches the previous one. So I'm confident now >>> to go:-) >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java >>> >>> -Sherman >>> >>> On 01/18/2013 10:32 AM, Xueming Shen wrote: >>>> Yes, they can be further consolidated, if given more time:-) >>>> >>>> On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >>>>> This looks like a reasonable approach. Ultimately, these classes could >>>>> be slimmed down more, but that isn't vital now. >>>>> Stephen >>>>> >>>>> On 18 January 2013 17:51, Xueming Shen wrote: >>>>>> Current approach to build tzdb data is a no-go from build and embedded >>>>>> team. >>>>>> >>>>>> Here is the webrev that to have the tzdb compiler works with a set of >>>>>> strip-down >>>>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed >>>>>> to >>>>>> be >>>>>> a early jdk release that does not have any jdk8 feature. I also remove >>>>>> the >>>>>> leak >>>>>> second from tool and the date. >>>>>> >>>>>> The code probably need further clean-up. But I will spend most of the >>>>>> time >>>>>> today >>>>>> to make sure the correctness of the output (the tests are all past, but >>>>>> I >>>>>> will verify >>>>>> the output is identical to the output from the "normal" version) >>>>>> >>>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>>>>> >>>>>> -Sherman >>>> From roger.riggs at oracle.com Fri Jan 18 13:56:57 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 18 Jan 2013 21:56:57 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Cleanup uses of Threeten and 310 Message-ID: <20130118215738.88AF7473DE@hg.openjdk.java.net> Changeset: 4444b49757fe Author: rriggs Date: 2013-01-18 16:56 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4444b49757fe Cleanup uses of Threeten and 310 ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/temporal/Ser.java From xueming.shen at oracle.com Fri Jan 18 15:24:42 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 18 Jan 2013 23:24:42 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: To use boot-jdk to generate tzdb.jar Message-ID: <20130118232514.68F1B473E0@hg.openjdk.java.net> Changeset: bd6453a8883f Author: sherman Date: 2013-01-18 15:29 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bd6453a8883f To use boot-jdk to generate tzdb.jar Updates for the review feedback ! make/jprt.properties ! make/sun/tzdb/Makefile ! make/tools/Makefile + make/tools/src/build/tools/tzdb/ChronoField.java + make/tools/src/build/tools/tzdb/DateTimeException.java + make/tools/src/build/tools/tzdb/DayOfWeek.java + make/tools/src/build/tools/tzdb/LocalDate.java + make/tools/src/build/tools/tzdb/LocalDateTime.java + make/tools/src/build/tools/tzdb/LocalTime.java + make/tools/src/build/tools/tzdb/Month.java + make/tools/src/build/tools/tzdb/TimeDefinition.java + make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/tools/src/build/tools/tzdb/Utils.java + make/tools/src/build/tools/tzdb/ZoneOffset.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/tools/src/build/tools/tzdb/ZoneRules.java + make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java + make/tools/tzdb/Makefile ! makefiles/BuildJdk.gmk - makefiles/CompileTimeZoneData.gmk + makefiles/GendataTZDB.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/util/Formatter.java - src/share/classes/sun/tools/tzdb/TzdbZoneRulesCompiler.java - src/share/classes/sun/tools/tzdb/ZoneRules.java - src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java - test/java/time/test/sun/tools/tzdb/TestZoneRulesBuilder.java From xueming.shen at oracle.com Fri Jan 18 16:03:26 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 18 Jan 2013 16:03:26 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F5F08D.5000008@oracle.com> References: <50F5F08D.5000008@oracle.com> Message-ID: <50F9E2CE.9090500@oracle.com> Hi, The webrev and Javadoc have been updated based on the feedback we received so far. The main stopper is the timezone data compiler had dependency on new threeten classes (and these classes themselves depend on new JDK8 features). The compiler has been re-written to remove the dependency and now work as a "normal" build tool at make/tool. Build-infra team please help take a look if all our makefile changes are OK for the new/ old build system. http://cr.openjdk.java.net/~sherman/8003680/webrev http://cr.openjdk.java.net/~sherman/8003680/javadoc Thanks, Sherman On 01/15/2013 04:13 PM, Xueming Shen wrote: > Hi, > > The Threeten project [1] is planned to be integrated into OpenJDK8 M6 milestone. > > Here is the webrev > http://cr.openjdk.java.net/~sherman/8003680/webrev > > and the latest javadoc > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Review comments can be sent to the threeten-dev email list [2] and/or > core-libs-dev email list[3]. > > Thanks, > Sherman > > [1] http://openjdk.java.net/projects/threeten > [2] threeten-dev @ openjdk.java.net > [3] core-libs-dev @ openjdk.java.net > > From patrick.zhang at oracle.com Sat Jan 19 22:31:44 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Sun, 20 Jan 2013 14:31:44 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.Period In-Reply-To: <50F3C896.6050503@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> Message-ID: <50FB8F50.1030004@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/period/webrev/test/java/time/test/java/time/TestPeriod.java.udiff.html Description: 1. Use minusYears(amount) to rewrite existing test about minus(amout, YEARS). plusYears(amout) has been covered and we do not touch it. And we do same thing to other TemporalUnit, for example, MONTHS, DAYS, HOURS, MINUTES, SECONDS and NANOS. Then below missed methods are covered: minusYears(amount) minusMonths(amount) minusDays(amount) minusHourss(amount) minusMinutess(amount) minusSeconds(amount) minusNanos(amount) 2. Add one new data provider and related test case for toDateOnly() and toTimeOnly(). Regards Patrick From xueming.shen at oracle.com Sun Jan 20 00:24:16 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 20 Jan 2013 00:24:16 -0800 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50F9B84C.6060500@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> <50F9B84C.6060500@oracle.com> Message-ID: <50FBA9B0.6090106@oracle.com> hash() & equals() have been missing from the version of ZoneRules.java for the tzdb compiler package. So the dup mechanism is broken, the size of tzdb.jar that includes n versions of rules is huge. The fix is to add these two pair back into ZoneRules.java. The webrev below includes more updates, mainly removed the dependency for the Month and DayOfWeek and more non-needed methods from couple classes. http://cr.openjdk.java.net/~sherman/jdk8_threeten/zruleDup/ Let me know if you don't like this version and prefers the ZoneRules.java change:-) Sherman On 1/18/2013 1:02 PM, Xueming Shen wrote: > On 01/18/2013 12:37 PM, Stephen Colebourne wrote: >> Looks like your last webrev doesn't show files as being moved, just >> deleted and re-created. > > I brought them back to generate the "diff" of those three files. The latest is > generated via webrev -N, so a real snapshot of the change. > > leap second can be brought back if the api/impl need them. Maybe 9:-) > > The test suggests we have the exactly the same rules. > > -Sherman > >> Otherwise, I've no problems with pushing if the functionality matches, >> although I am sad to lose the leap seconds. >> Stephen >> >> On 18 January 2013 20:39, Xueming Shen wrote: >>> webrev has been updated, with some minor changes. Fully tested, >>> ready to go. >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2 >>> >>> -sherman >>> >>> >>> On 01/18/2013 12:09 PM, Xueming Shen wrote: >>>> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated >>>> by the new version matches the previous one. So I'm confident now >>>> to go:-) >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java >>>> >>>> -Sherman >>>> >>>> On 01/18/2013 10:32 AM, Xueming Shen wrote: >>>>> Yes, they can be further consolidated, if given more time:-) >>>>> >>>>> On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >>>>>> This looks like a reasonable approach. Ultimately, these classes could >>>>>> be slimmed down more, but that isn't vital now. >>>>>> Stephen >>>>>> >>>>>> On 18 January 2013 17:51, Xueming Shen wrote: >>>>>>> Current approach to build tzdb data is a no-go from build and embedded >>>>>>> team. >>>>>>> >>>>>>> Here is the webrev that to have the tzdb compiler works with a set of >>>>>>> strip-down >>>>>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed >>>>>>> to >>>>>>> be >>>>>>> a early jdk release that does not have any jdk8 feature. I also remove >>>>>>> the >>>>>>> leak >>>>>>> second from tool and the date. >>>>>>> >>>>>>> The code probably need further clean-up. But I will spend most of the >>>>>>> time >>>>>>> today >>>>>>> to make sure the correctness of the output (the tests are all past, but >>>>>>> I >>>>>>> will verify >>>>>>> the output is identical to the output from the "normal" version) >>>>>>> >>>>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>>>>>> >>>>>>> -Sherman >>>>> > From scolebourne at joda.org Sun Jan 20 02:24:38 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 20 Jan 2013 10:24:38 +0000 Subject: [threeten-dev] tzdb compiler on boot-jdk In-Reply-To: <50FBA9B0.6090106@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> <50F9B84C.6060500@oracle.com> <50FBA9B0.6090106@oracle.com> Message-ID: Looks fine to me. I guess TimeDefinition would be another easy target for "slimming down", as would replacing factory methods by constructors. But those can be done later. Stephen On 20 January 2013 08:24, Xueming Shen wrote: > hash() & equals() have been missing from the version of ZoneRules.java for > the tzdb compiler package. So the dup mechanism is broken, the size of > tzdb.jar that includes n versions of rules is huge. > > The fix is to add these two pair back into ZoneRules.java. The webrev > below includes more updates, mainly removed the dependency for > the Month and DayOfWeek and more non-needed methods from couple > classes. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/zruleDup/ > > Let me know if you don't like this version and prefers the ZoneRules.java > change:-) > > Sherman > > > On 1/18/2013 1:02 PM, Xueming Shen wrote: >> >> On 01/18/2013 12:37 PM, Stephen Colebourne wrote: >>> >>> Looks like your last webrev doesn't show files as being moved, just >>> deleted and re-created. >> >> >> I brought them back to generate the "diff" of those three files. The >> latest is >> generated via webrev -N, so a real snapshot of the change. >> >> leap second can be brought back if the api/impl need them. Maybe 9:-) >> >> The test suggests we have the exactly the same rules. >> >> -Sherman >> >>> Otherwise, I've no problems with pushing if the functionality matches, >>> although I am sad to lose the leap seconds. >>> Stephen >>> >>> On 18 January 2013 20:39, Xueming Shen wrote: >>>> >>>> webrev has been updated, with some minor changes. Fully tested, >>>> ready to go. >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2 >>>> >>>> -sherman >>>> >>>> >>>> On 01/18/2013 12:09 PM, Xueming Shen wrote: >>>>> >>>>> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated >>>>> by the new version matches the previous one. So I'm confident now >>>>> to go:-) >>>>> >>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java >>>>> >>>>> -Sherman >>>>> >>>>> On 01/18/2013 10:32 AM, Xueming Shen wrote: >>>>>> >>>>>> Yes, they can be further consolidated, if given more time:-) >>>>>> >>>>>> On 01/18/2013 10:08 AM, Stephen Colebourne wrote: >>>>>>> >>>>>>> This looks like a reasonable approach. Ultimately, these classes >>>>>>> could >>>>>>> be slimmed down more, but that isn't vital now. >>>>>>> Stephen >>>>>>> >>>>>>> On 18 January 2013 17:51, Xueming Shen >>>>>>> wrote: >>>>>>>> >>>>>>>> Current approach to build tzdb data is a no-go from build and >>>>>>>> embedded >>>>>>>> team. >>>>>>>> >>>>>>>> Here is the webrev that to have the tzdb compiler works with a set >>>>>>>> of >>>>>>>> strip-down >>>>>>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is >>>>>>>> assumed >>>>>>>> to >>>>>>>> be >>>>>>>> a early jdk release that does not have any jdk8 feature. I also >>>>>>>> remove >>>>>>>> the >>>>>>>> leak >>>>>>>> second from tool and the date. >>>>>>>> >>>>>>>> The code probably need further clean-up. But I will spend most of >>>>>>>> the >>>>>>>> time >>>>>>>> today >>>>>>>> to make sure the correctness of the output (the tests are all past, >>>>>>>> but >>>>>>>> I >>>>>>>> will verify >>>>>>>> the output is identical to the output from the "normal" version) >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/ >>>>>>>> >>>>>>>> -Sherman >>>>>> >>>>>> >> > From xueming.shen at oracle.com Sun Jan 20 09:44:24 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sun, 20 Jan 2013 17:44:24 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: updated tzdb compiler Message-ID: <20130120174444.E9C814740A@hg.openjdk.java.net> Changeset: 2d5ec9a4772c Author: sherman Date: 2013-01-20 09:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2d5ec9a4772c updated tzdb compiler - make/tools/src/build/tools/tzdb/DayOfWeek.java ! make/tools/src/build/tools/tzdb/LocalDate.java ! make/tools/src/build/tools/tzdb/LocalDateTime.java - make/tools/src/build/tools/tzdb/Month.java ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! make/tools/src/build/tools/tzdb/Utils.java ! make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java ! make/tools/src/build/tools/tzdb/ZoneRules.java ! make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java From xueming.shen at oracle.com Sun Jan 20 11:53:35 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 20 Jan 2013 11:53:35 -0800 Subject: [threeten-dev] the "deduplicate" mechanism in tzdb compiler In-Reply-To: References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> <50F9B84C.6060500@oracle.com> <50FBA9B0.6090106@oracle.com> Message-ID: <50FC4B3F.80901@oracle.com> The "deduplicate" mechanism in tzdb compiler looks really fishy, so I took a look into how it really works. It turns out this is really something not necessary, at least for the compiler tool we are looking for here. All those date/time, offset, trans, transruls will be thrown out at the end, why should we care about whether they are dup or not? they have been created anyway. The only thing we really care here is the ZoneRules which will be output to the tzdb.jar, they need to be de-duplicated before written out. But this is being done perfectly at outputFile(s) via the combination of Set loopAllRules = new HashSet(builtZones.values()); ... List rulesList = new ArrayList<>(allRules); ... int rulesIndex = rulesList.indexOf(entry.getValue()); The HashSet, ArrayList.indexOf() works on ZoneRules.equals() so the ZoneRules objects are being effectively de-duplicated without any help from that "deduplicate" mechanism. http://cr.openjdk.java.net/~sherman/jdk8_threeten/zruleDup2 -Sherman From scolebourne at joda.org Sun Jan 20 15:22:50 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 20 Jan 2013 23:22:50 +0000 Subject: [threeten-dev] the "deduplicate" mechanism in tzdb compiler In-Reply-To: <50FC4B3F.80901@oracle.com> References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> <50F9B84C.6060500@oracle.com> <50FBA9B0.6090106@oracle.com> <50FC4B3F.80901@oracle.com> Message-ID: The purpose was to deduplicate objects within other objects. If this patch produces a tzdb.jar file with exactly the same data, then its fine by me. Stephen On 20 January 2013 19:53, Xueming Shen wrote: > The "deduplicate" mechanism in tzdb compiler looks really fishy, so I > took a look into how it really works. It turns out this is really something > not necessary, at least for the compiler tool we are looking for here. > All those date/time, offset, trans, transruls will be thrown out at the end, > why should we care about whether they are dup or not? they have been > created anyway. The only thing we really care here is the ZoneRules > which will be output to the tzdb.jar, they need to be de-duplicated > before written out. But this is being done perfectly at outputFile(s) via > the combination of > > Set loopAllRules = new HashSet(builtZones.values()); > ... > List rulesList = new ArrayList<>(allRules); > ... > int rulesIndex = rulesList.indexOf(entry.getValue()); > > The HashSet, ArrayList.indexOf() works on ZoneRules.equals() so > the ZoneRules objects are being effectively de-duplicated without > any help from that "deduplicate" mechanism. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/zruleDup2 > > -Sherman From scolebourne at joda.org Sun Jan 20 15:46:44 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 20 Jan 2013 23:46:44 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.Period In-Reply-To: <50FB8F50.1030004@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> Message-ID: On 20 January 2013 06:31, Patrick Zhang wrote: > Description: > 1. Use minusYears(amount) to rewrite existing test about minus(amout, > YEARS). plusYears(amout) has been covered and we do not touch it. And we do > same thing to other TemporalUnit, for example, MONTHS, DAYS, HOURS, MINUTES, > SECONDS and NANOS. > Then below missed methods are covered: > minusYears(amount) > minusMonths(amount) > minusDays(amount) > minusHourss(amount) > minusMinutess(amount) > minusSeconds(amount) > minusNanos(amount) As a general rule, the test case method names for non-static methods should be: public void test_methodName_arguments_whatMakesTheTestSpecial() So, public void test_minus_Years should be public void test_minus_longTemporalUnit_Years (not all existing tests match this pattern) The changes you've made do successfully test what needs testing, however they would be more scalable as DataProvider tests. That way one set of data could test both types of method. (DataProvider tests are much more scalable in general, so feel free to refactor tests to DataProvider in the future.) Its up to you as to whether you make these recommended changes for this webrev, or future ones. > 2. Add one new data provider and related test case for toDateOnly() and > toTimeOnly(). Looks good Stephen From xueming.shen at oracle.com Sun Jan 20 16:44:14 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 20 Jan 2013 16:44:14 -0800 Subject: [threeten-dev] the "deduplicate" mechanism in tzdb compiler In-Reply-To: References: <50F98B9C.5030503@oracle.com> <50F99532.5050108@oracle.com> <50F9AC0F.7090800@oracle.com> <50F9B30F.1080901@oracle.com> <50F9B84C.6060500@oracle.com> <50FBA9B0.6090106@oracle.com> <50FC4B3F.80901@oracle.com> Message-ID: <50FC8F5E.3040304@oracle.com> It produces exactly the same TZDB.dat though it appears the compressed results area slightly different. Objects within other objects do not matter in tzdb compiler case, since the only thing we care here is the ZoneRules, anything inside a ZoneRules will be output by their real bits. This optimization may make some sense if we try to have an in-memory ZoneRules collections and there is need to optimize the memory foot-print, then "shared" objects inside objects may bring us some benefits. It does not help in our case. -Sherman PS. the size of the "new" and the "old" tzdb-all.jar for all versions. sherman at sherman-linux:~/Workspace/310/tzdb$ ls -al new/tzdb-all.jar old/tzdb-all.jar -rw-r--r-- 1 sherman 1050 60046 2013-01-20 16:34 new/tzdb-all.jar -rw-r--r-- 1 sherman 1050 59274 2013-01-20 16:34 old/tzdb-all.jar sherman at sherman-linux:~/Workspace/310/tzdb$ jar tvf new/tzdb-all.jar 346543 Sun Jan 20 16:34:26 PST 2013 TZDB.dat sherman at sherman-linux:~/Workspace/310/tzdb$ jar tvf old/tzdb-all.jar 346543 Sun Jan 20 16:34:52 PST 2013 TZDB.dat 305 Sun Jan 20 16:34:52 PST 2013 LeapSecondRules.dat sherman at sherman-linux:~/Workspace/310/tzdb$ On 01/20/2013 03:22 PM, Stephen Colebourne wrote: > The purpose was to deduplicate objects within other objects. > If this patch produces a tzdb.jar file with exactly the same data, > then its fine by me. > > Stephen > > > On 20 January 2013 19:53, Xueming Shen wrote: >> The "deduplicate" mechanism in tzdb compiler looks really fishy, so I >> took a look into how it really works. It turns out this is really something >> not necessary, at least for the compiler tool we are looking for here. >> All those date/time, offset, trans, transruls will be thrown out at the end, >> why should we care about whether they are dup or not? they have been >> created anyway. The only thing we really care here is the ZoneRules >> which will be output to the tzdb.jar, they need to be de-duplicated >> before written out. But this is being done perfectly at outputFile(s) via >> the combination of >> >> Set loopAllRules = new HashSet(builtZones.values()); >> ... >> List rulesList = new ArrayList<>(allRules); >> ... >> int rulesIndex = rulesList.indexOf(entry.getValue()); >> >> The HashSet, ArrayList.indexOf() works on ZoneRules.equals() so >> the ZoneRules objects are being effectively de-duplicated without >> any help from that "deduplicate" mechanism. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zruleDup2 >> >> -Sherman From xueming.shen at oracle.com Sun Jan 20 17:21:20 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 21 Jan 2013 01:21:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: tzdb compiler update Message-ID: <20130121012142.E88B14740D@hg.openjdk.java.net> Changeset: 775c73127d48 Author: sherman Date: 2013-01-20 17:25 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/775c73127d48 tzdb compiler update ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java From patrick.zhang at oracle.com Sun Jan 20 22:53:24 2013 From: patrick.zhang at oracle.com (patrick zhang) Date: Mon, 21 Jan 2013 14:53:24 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.Period In-Reply-To: References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> Message-ID: <50FCE5E4.2040007@oracle.com> Hi Stephen, Thanks for your suggestion. I will take care of it in future webrev. More dataprovider pattern will be introduced in future test cases. Hi Sherman, Could you help to push it? http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/period/webrev/ Regards Patrick On 2013-1-21 7:46, Stephen Colebourne wrote: > On 20 January 2013 06:31, Patrick Zhang wrote: > >> Description: >> 1. Use minusYears(amount) to rewrite existing test about minus(amout, >> YEARS). plusYears(amout) has been covered and we do not touch it. And we do >> same thing to other TemporalUnit, for example, MONTHS, DAYS, HOURS, MINUTES, >> SECONDS and NANOS. >> Then below missed methods are covered: >> minusYears(amount) >> minusMonths(amount) >> minusDays(amount) >> minusHourss(amount) >> minusMinutess(amount) >> minusSeconds(amount) >> minusNanos(amount) >> > > As a general rule, the test case method names for non-static methods should be: > > public void test_methodName_arguments_whatMakesTheTestSpecial() > > So, > public void test_minus_Years > should be > public void test_minus_longTemporalUnit_Years > > (not all existing tests match this pattern) > > The changes you've made do successfully test what needs testing, > however they would be more scalable as DataProvider tests. That way > one set of data could test both types of method. (DataProvider tests > are much more scalable in general, so feel free to refactor tests to > DataProvider in the future.) > > Its up to you as to whether you make these recommended changes for > this webrev, or future ones. > > > >> 2. Add one new data provider and related test case for toDateOnly() and >> toTimeOnly(). >> > > Looks good > Stephen > From xueming.shen at oracle.com Mon Jan 21 10:53:45 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 21 Jan 2013 18:53:45 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: added missing copyright note Message-ID: <20130121185435.A110F4742E@hg.openjdk.java.net> Changeset: 7768e5f4ba6d Author: sherman Date: 2013-01-21 10:58 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7768e5f4ba6d added missing copyright note ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java From xueming.shen at oracle.com Mon Jan 21 14:11:36 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 21 Jan 2013 14:11:36 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F9E2CE.9090500@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> Message-ID: <50FDBD18.4060608@oracle.com> Hi, Webrev has been updated with the latest build-infra changes in TL. The jprt.properties change in control repo is also included. This is probably the final bits we are going to push for M6. http://cr.openjdk.java.net/~sherman/8003680/webrev http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl http://cr.openjdk.java.net/~sherman/8003680/javadoc I'm yet to run the jprt build. Build with new buld-infra (config/make) and old make have been verified locally. Thanks, Sherman On 1/18/13 4:03 PM, Xueming Shen wrote: > Hi, > > The webrev and Javadoc have been updated based on the feedback > we received so far. > > The main stopper is the timezone data compiler had dependency on > new threeten classes (and these classes themselves depend on new > JDK8 features). The compiler has been re-written to remove the dependency > and now work as a "normal" build tool at make/tool. Build-infra team > please help take a look if all our makefile changes are OK for the new/ > old build system. > > http://cr.openjdk.java.net/~sherman/8003680/webrev > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Thanks, > Sherman > > On 01/15/2013 04:13 PM, Xueming Shen wrote: >> Hi, >> >> The Threeten project [1] is planned to be integrated into OpenJDK8 M6 >> milestone. >> >> Here is the webrev >> http://cr.openjdk.java.net/~sherman/8003680/webrev >> >> and the latest javadoc >> http://cr.openjdk.java.net/~sherman/8003680/javadoc >> >> Review comments can be sent to the threeten-dev email list [2] and/or >> core-libs-dev email list[3]. >> >> Thanks, >> Sherman >> >> [1] http://openjdk.java.net/projects/threeten >> [2] threeten-dev @ openjdk.java.net >> [3] core-libs-dev @ openjdk.java.net >> >> > From Roger.Riggs at oracle.com Tue Jan 22 08:40:28 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 22 Jan 2013 11:40:28 -0500 Subject: [threeten-dev] Schedule after M6 Message-ID: <50FEC0FC.9090301@oracle.com> fyi, the dates for Threeten work leading up to M7 - Developer Preview * Feb 4 - final API freeze for review * Feb 13 - last day to push into the OpenJDK TL repository on the way to JDK 8 repository * Feb 21 - M7 build completes The Public Review of JSR310 should be based on this milestone also. The milestones after M7 are identified primarily as bug fixing and test completion but if necessary can resolve API issues raised during JSR 310 public review. [1] http://openjdk.java.net/projects/jdk8/milestones From scolebourne at joda.org Tue Jan 22 17:00:30 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 23 Jan 2013 01:00:30 +0000 Subject: [threeten-dev] [threeten-develop] Schedule after M6 In-Reply-To: <50FEC0FC.9090301@oracle.com> References: <50FEC0FC.9090301@oracle.com> Message-ID: So, am I going to carry on committing direct to the repo as before? Do I have to match an exact commit message format now? Stephen On 22 January 2013 16:40, Roger Riggs wrote: > fyi, the dates for Threeten work leading up to M7 - Developer Preview > > Feb 4 - final API freeze for review > Feb 13 - last day to push into the OpenJDK TL repository on the way to JDK 8 > repository > Feb 21 - M7 build completes > > The Public Review of JSR310 should be based on this milestone also. > > The milestones after M7 are identified primarily as bug fixing and test > completion > but if necessary can resolve API issues raised during JSR 310 public review. > > [1] http://openjdk.java.net/projects/jdk8/milestones > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From Roger.Riggs at Oracle.com Tue Jan 22 19:11:41 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Tue, 22 Jan 2013 22:11:41 -0500 Subject: [threeten-dev] [threeten-develop] Schedule after M6 In-Reply-To: References: <50FEC0FC.9090301@oracle.com> Message-ID: <50FF54ED.8080606@Oracle.com> Hi, We will continue to use current protocols with the threeten-dev repositories until M7. The current protocol of posting webrev's and getting reviews is a good thing. Sherman and I would like to see webrev's or know about changes before they occur. With cygwin installed, webrev is straightforward and with scp making them available to review is can be automated. Roger On 01/22/2013 08:00 PM, Stephen Colebourne wrote: > So, am I going to carry on committing direct to the repo as before? Do > I have to match an exact commit message format now? > Stephen > > > On 22 January 2013 16:40, Roger Riggs wrote: >> fyi, the dates for Threeten work leading up to M7 - Developer Preview >> >> Feb 4 - final API freeze for review >> Feb 13 - last day to push into the OpenJDK TL repository on the way to JDK 8 >> repository >> Feb 21 - M7 build completes >> >> The Public Review of JSR310 should be based on this milestone also. >> >> The milestones after M7 are identified primarily as bug fixing and test >> completion >> but if necessary can resolve API issues raised during JSR 310 public review. >> >> [1] http://openjdk.java.net/projects/jdk8/milestones >> >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnnow-d2d >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop >> From xueming.shen at oracle.com Tue Jan 22 21:42:13 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 05:42:13 +0000 Subject: [threeten-dev] hg: threeten/threeten: 60 new changesets Message-ID: <20130123054216.D0F30474A9@hg.openjdk.java.net> Changeset: 98a7af257bee Author: erikj Date: 2012-12-03 10:26 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/98a7af257bee 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk Summary: Removing trailing backslash from LIB and INCLUDE. Reviewed-by: ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 754f91d22e1c Author: erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: ec187d02c95e Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/ec187d02c95e 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Summary: Fixed bug in setting up make dependencies in SetupArchive. Reviewed-by: ohair, tbell, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: bd32ef0789ca Author: erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 9a6ec97ec45c Author: katleman Date: 2012-12-05 12:52 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/9a6ec97ec45c Merge Changeset: c91c581321ce Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: ab1ab9b148dd Author: smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/ab1ab9b148dd 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties Changeset: ad54163c95f5 Author: lana Date: 2012-11-30 16:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/ad54163c95f5 Merge Changeset: 04435608c613 Author: lana Date: 2012-12-10 20:52 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/04435608c613 Merge Changeset: 6b96b7744913 Author: erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: 2795874efd16 Author: erikj Date: 2012-12-11 11:29 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2795874efd16 8003945: build-infra: problems finding compiler when using --with-dev-kit Summary: Search all compiler names in dev-kit dir first. Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e175ecff1391 Author: erikj Date: 2012-12-11 11:33 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/e175ecff1391 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Enabling hotspot to use the FDS settings established at configure time Reviewed-by: dholmes, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: cdb401a60cea Author: katleman Date: 2012-12-12 13:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/cdb401a60cea Merge Changeset: e9ec00893bb4 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/e9ec00893bb4 Added tag jdk8-b68 for changeset cdb401a60cea ! .hgtags Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/e08b0096058f Merge Changeset: 8e36a0fabf58 Author: ohrstrom Date: 2012-12-18 09:57 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/8e36a0fabf58 8004145: New improved hgforest.sh, ctrl-c now properly terminates mercurial processes. Reviewed-by: ohair, erikj + common/bin/hgforest.sh ! get_source.sh Changeset: 51d3b65b8093 Author: erikj Date: 2012-12-18 17:54 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/51d3b65b8093 8001901: build-infra: Fix "misbehaving" which command on Solaris Summary: Removed all uses of which in configure on solaris. Reviewed-by: ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: 6ee8080a6efe Author: katleman Date: 2012-12-19 13:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/6ee8080a6efe Merge Changeset: 32148e971ac8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/32148e971ac8 Added tag jdk8-b69 for changeset 6ee8080a6efe ! .hgtags Changeset: 6b93e7a4401d Author: dholmes Date: 2012-12-20 01:44 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/6b93e7a4401d 7190137: Add support for JVM_VARIANT minimal1 Summary: Allow configuration of minimal1 as a target VM along with client and server Reviewed-by: ohair, erikj ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: cd06b2ea58dd Author: katleman Date: 2012-12-20 16:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/cd06b2ea58dd 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! common/makefiles/RMICompilation.gmk Changeset: 105a25ffa4a4 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/105a25ffa4a4 Merge Changeset: 3fb32a5a2388 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/3fb32a5a2388 Added tag jdk8-b70 for changeset 105a25ffa4a4 ! .hgtags Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2ed5be3dd506 Merge Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/68a81db3ceb1 Merge Changeset: 51ad2a343420 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/51ad2a343420 Merge Changeset: c1be681d80a1 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c1be681d80a1 Added tag jdk8-b71 for changeset 51ad2a343420 ! .hgtags Changeset: f03f90a4308d Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/f03f90a4308d Added tag jdk8-b72 for changeset c1be681d80a1 ! .hgtags Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl Changeset: b845a2494261 Author: lana Date: 2013-01-01 12:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/b845a2494261 Merge Changeset: 93b9664f97ee Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/93b9664f97ee Merge Changeset: 4090847a5444 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/4090847a5444 Added tag jdk8-b73 for changeset 93b9664f97ee ! .hgtags Changeset: 77f062a41850 Author: erikj Date: 2012-12-27 20:15 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/77f062a41850 8001942: build-infra: General permission problems on Windows/cygwin Summary: Added sanity check for file permissions in configure Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: d2c1f80118de Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/d2c1f80118de 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/NativeCompilation.gmk Changeset: d5f3a6f60d51 Author: erikj Date: 2012-12-27 20:55 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/d5f3a6f60d51 8005548: build-infra: Fix docs target on windows Summary: Fix path sep variable Reviewed-by: tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: ef6adbf511cc Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/ef6adbf511cc 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! NewMakefile.gmk ! common/autoconf/Makefile.in ! common/autoconf/generated-configure.sh + common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/Makefile Changeset: 2d9bb72b4e34 Author: erikj Date: 2012-12-30 12:15 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2d9bb72b4e34 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: abc8078e070b Author: erikj Date: 2013-01-01 14:13 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/abc8078e070b 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable Summary: Added configure params Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/version.numbers Changeset: 14d7ebe42c8d Author: erikj Date: 2013-01-02 11:29 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/14d7ebe42c8d 8005347: build-infra: Verify 'gnumake source' at the top level works ok Reviewed-by: tbell, ohair, dholmes ! common/autoconf/basics.m4 - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in = common/autoconf/version-numbers < common/autoconf/version.numbers Changeset: 348a881c6da0 Author: erikj Date: 2013-01-02 15:36 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/348a881c6da0 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: befbad2e4d87 Author: erikj Date: 2013-01-03 20:54 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/befbad2e4d87 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl ! common/makefiles/Jprt.gmk ! common/src/fixpath.c Changeset: 39194e004ade Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/39194e004ade 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 9263657c2756 Author: erikj Date: 2013-01-04 16:56 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/9263657c2756 8005692: build-infra: Target "all" should do the right thing Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: c874a8a27933 Author: erikj Date: 2013-01-04 17:05 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c874a8a27933 8005597: build-infra: bridgeBuild broken for pure openjdk build Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: 7b9c42f14281 Author: erikj Date: 2013-01-04 17:08 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/7b9c42f14281 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! common/bin/compare.sh ! common/makefiles/JavaCompilation.gmk Changeset: 2597feac57c0 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2597feac57c0 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl Changeset: 5cf7750c8c43 Author: ohair Date: 2013-01-04 21:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/5cf7750c8c43 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Reviewed-by: erikj, tbell ! Makefile ! make/jprt.properties Changeset: 7a3c6ffdf1fb Author: tbell Date: 2013-01-07 14:01 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/7a3c6ffdf1fb 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Reviewed-by: ohair ! common/autoconf/autogen.sh Changeset: 64a9ebad39fe Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/64a9ebad39fe Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: b284980b7d9a Author: tbell Date: 2013-01-08 16:23 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/b284980b7d9a 8005794: in new infra, how do we change java -version? Summary: Added configure parameter --with-user-release-suffix Reviewed-by: ohair, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: db3984e4eb97 Author: erikj Date: 2013-01-10 12:20 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/db3984e4eb97 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Reviewed-by: tbell, ohair ! common/bin/compare.sh Changeset: 6f8f7a5449f6 Author: erikj Date: 2013-01-11 10:46 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/6f8f7a5449f6 8005850: build-infra: Make --enable-openjdk-only really disable custom Reviewed-by: ohair, dholmes ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: b66c81dfa291 Author: ohair Date: 2013-01-14 16:38 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/b66c81dfa291 8005284: build-infra: nonstandard copyright headers under common/autoconf/build-aux Reviewed-by: katleman ! common/autoconf/build-aux/autoconf-config.guess ! common/autoconf/build-aux/config.sub ! common/autoconf/build-aux/pkg.m4 Changeset: 3540aa40c868 Author: erikj Date: 2013-01-14 13:09 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/3540aa40c868 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk Reviewed-by: tbell, ohair ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh Changeset: 6e822b534678 Author: erikj Date: 2013-01-14 15:30 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/6e822b534678 8006100: build-infra: Bundle up the correct images in jprt Reviewed-by: tbell ! NewMakefile.gmk ! common/makefiles/Jprt.gmk Changeset: 52cce3326649 Author: erikj Date: 2013-01-15 09:50 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/52cce3326649 Merge Changeset: fe1c94aca5a8 Author: katleman Date: 2013-01-15 10:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/fe1c94aca5a8 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: dc84b505b408 Author: katleman Date: 2013-01-16 22:16 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/dc84b505b408 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl From xueming.shen at oracle.com Tue Jan 22 21:45:39 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 05:45:39 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 48 new changesets Message-ID: <20130123055444.315DC474AA@hg.openjdk.java.net> Changeset: c9a914b11436 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c9a914b11436 Added tag jdk8-b72 for changeset 32a57e645e01 ! .hgtags Changeset: d54922883f4c Author: alexsch Date: 2013-01-09 16:52 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d54922883f4c 8005019: JTable passes row index instead of length when inserts selection interval Reviewed-by: serb, denis ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/8005019/bug8005019.java Changeset: b2c425d7e5be Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b2c425d7e5be Merge Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java Changeset: 38b9a7646093 Author: lana Date: 2013-01-01 17:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/38b9a7646093 Merge ! makefiles/CreateJars.gmk Changeset: cc78ceb99284 Author: jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java ! src/share/classes/java/lang/StringIndexOutOfBoundsException.java Changeset: 21708d15553b Author: chegar Date: 2013-01-03 10:00 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/21708d15553b 8005634: tools/launcher/VersionCheck.java fails version check on jdeps Summary: add jdeps to the list of tools that do not support '-version' Reviewed-by: mchung ! test/tools/launcher/VersionCheck.java Changeset: 438d37d16417 Author: chegar Date: 2013-01-04 11:18 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/438d37d16417 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters Reviewed-by: mchung, ksrini ! test/ProblemList.txt Changeset: 6d814b2f9112 Author: chegar Date: 2013-01-04 11:34 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6d814b2f9112 8005638: Less secure Authentication schemes should work when more secure schemes are not available Reviewed-by: alanb ! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java Changeset: 92c3b24a8e9a Author: smarks Date: 2013-01-04 16:10 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/92c3b24a8e9a 8005683: ProblemList.txt updates (01/2013) Reviewed-by: mchung, alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 0c89465b656a Author: chegar Date: 2013-01-05 17:06 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0c89465b656a 8005709: Add at since tags to new FJP getCommonPoolParallelism and commonPool Reviewed-by: dl ! src/share/classes/java/util/concurrent/ForkJoinPool.java Changeset: 1d9638ba5202 Author: ksrini Date: 2013-01-07 09:58 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1d9638ba5202 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set Reviewed-by: mchung, kcr, ksrini Contributed-by: david.dehaven at oracle.com ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/FXLauncherTest.java Changeset: dbc692ea3f0a Author: bchristi Date: 2013-01-07 13:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/dbc692ea3f0a 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] Summary: Hard-code sun.jnu.encoding to UTF-8 on Mac Reviewed-by: naoto ! src/share/native/java/lang/System.c ! src/solaris/native/java/lang/java_props_md.c + test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java + test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 797e8a3dcd51 Author: smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to match. Reviewed-by: mchung, dmocek ! test/ProblemList.txt ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/sun/rmi/runtime/Log/4504153/Test4504153.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java Changeset: 98935c514de4 Author: weijun Date: 2013-01-08 14:54 +0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/98935c514de4 8005447: default principal should act as anyone Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/krb5/ServiceCredsCombination.java + test/sun/security/krb5/auto/AcceptPermissions.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/DiffNameSameKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/KeyTabCompat.java + test/sun/security/krb5/auto/TwoOrThree.java Changeset: d29a7ce28189 Author: dxu Date: 2013-01-08 20:37 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d29a7ce28189 8002306: (se) Selector.open fails if invoked with thread interrupt status set [win] Reviewed-by: alanb ! src/windows/classes/sun/nio/ch/PipeImpl.java + test/java/nio/channels/Pipe/PipeInterrupt.java Changeset: 46e6a4b7ca26 Author: valeriep Date: 2013-01-07 11:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/46e6a4b7ca26 6996769: support AEAD cipher Summary: Added implementation for GCM mode under AES cipher Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/AESCipher.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherTextStealing.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java + src/share/classes/com/sun/crypto/provider/GCMParameters.java + src/share/classes/com/sun/crypto/provider/GCTR.java + src/share/classes/com/sun/crypto/provider/GHASH.java + src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/spec/GCMParameterSpec.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512524.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512704.java ! test/com/sun/crypto/provider/Cipher/AES/Test4517355.java ! test/com/sun/crypto/provider/Cipher/AES/Test4626070.java + test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java + test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java ! test/javax/crypto/Cipher/GCMAPI.java Changeset: 5333a4c8cade Author: valeriep Date: 2013-01-07 14:40 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5333a4c8cade Merge Changeset: 3c5a62290939 Author: valeriep Date: 2013-01-08 11:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3c5a62290939 8004044: Lazily instantiate SunJCE.RANDOM Summary: Replace the static initialization of SunJCE.RANDOM object w/ lazy initialization Reviewed-by: mchung ! src/share/classes/com/sun/crypto/provider/AESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/BlowfishKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacMD5KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/ISO10126Padding.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java Changeset: 9b6a29cb04ac Author: valeriep Date: 2013-01-08 13:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9b6a29cb04ac Merge Changeset: ac5fd681a7a2 Author: darcy Date: 2013-01-08 16:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ac5fd681a7a2 8005298: Add FunctionalInterface type to the core libraries Reviewed-by: mduigou + src/share/classes/java/lang/FunctionalInterface.java Changeset: 86828e84654f Author: mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method Reviewed-by: alanb ! src/share/classes/java/security/Principal.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + test/java/security/Principal/Implies.java ! test/sun/security/provider/PolicyFile/Comparator.java Changeset: bf6d0bca5ea7 Author: mullan Date: 2013-01-08 19:02 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bf6d0bca5ea7 Merge - make/jdk/asm/Makefile - src/share/classes/sun/awt/TextureSizeConstraining.java - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: f0ed9ef84637 Author: mullan Date: 2013-01-09 08:59 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f0ed9ef84637 Merge Changeset: 4c8b37f159f9 Author: mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/lang/Integer.java Changeset: 4176e6cc499e Author: darcy Date: 2013-01-09 20:20 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4176e6cc499e 8005713: Simplify library support for repeating annotations in java.lang.annotation Reviewed-by: abuckley + src/share/classes/java/lang/annotation/Repeatable.java Changeset: c622df692bfb Author: bchristi Date: 2013-01-10 10:21 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c622df692bfb 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments Summary: Test script now sets LC_ALL, other small changes, relocate test Reviewed-by: naoto, alanb + test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java + test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 13ff1089e625 Author: jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup Reviewed-by: chegar ! test/java/lang/Runtime/exec/WinCommand.java Changeset: 3e906ccad412 Author: chegar Date: 2013-01-10 21:52 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3e906ccad412 8006007: j.u.c.atomic classes should use intrinsic getAndXXX provided by 7023898 Reviewed-by: dl, shade ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: 733885f57e14 Author: lana Date: 2013-01-10 15:52 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/733885f57e14 Merge Changeset: 965e89e2abd3 Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/965e89e2abd3 Added tag jdk8-b73 for changeset 733885f57e14 ! .hgtags Changeset: e91caf05f441 Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e91caf05f441 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: 368fa50469da Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/368fa50469da 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! makefiles/BuildJdk.gmk Changeset: 461b069100fa Author: erikj Date: 2013-01-02 15:35 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/461b069100fa 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/SignJars.gmk Changeset: 3841da683703 Author: erikj Date: 2013-01-03 20:55 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3841da683703 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! make/common/shared/Defs-windows.gmk ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: a8d25b689563 Author: erikj Date: 2013-01-04 16:54 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a8d25b689563 8005694: build-infra: Cleanup of misc changes in build-infra Reviewed-by: tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 3824d8469dcf Author: erikj Date: 2013-01-04 17:09 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3824d8469dcf 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: d98e73b7bc78 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d98e73b7bc78 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: 244e481f538b Author: katleman Date: 2013-01-08 13:15 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/244e481f538b Merge ! makefiles/CreateJars.gmk Changeset: 1868bde529b8 Author: ohrstrom Date: 2013-01-09 13:33 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1868bde529b8 8005096: Move a few source files in swing/beaninfo and in a demo. Reviewed-by: ohair, erikj, malenkov ! make/javax/swing/beaninfo/SwingBeans.gmk - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java + make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java + make/tools/swing-beans/sun/swing/BeanInfoUtils.java ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcSwing.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethod.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethodDescriptor.java Changeset: 2cc29d0b9eaf Author: erikj Date: 2013-01-09 16:13 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2cc29d0b9eaf 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: f92ab6dbbff8 Author: erikj Date: 2013-01-10 12:23 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f92ab6dbbff8 8005856: build-infra: Remove special handling of base module classes header generation Reviewed-by: alanb, tbell, ohair Contributed-by: fredrik.ohrstrom at oracle.com ! makefiles/CompileJavaClasses.gmk ! src/share/classes/java/io/FileSystem.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/windows/classes/sun/nio/ch/PollArrayWrapper.java Changeset: 4d80ab394efa Author: erikj Date: 2013-01-15 16:50 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4d80ab394efa 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Reviewed-by: alanb, tbell ! makefiles/CreateJars.gmk Changeset: 6d1a3d43851d Author: katleman Date: 2013-01-15 10:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6d1a3d43851d Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 3eef1e0540c4 Author: erikj Date: 2013-01-16 16:40 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3eef1e0540c4 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Reviewed-by: tbell ! makefiles/Import.gmk Changeset: 54bbeb149525 Author: katleman Date: 2013-01-16 22:21 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/54bbeb149525 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! src/share/classes/java/lang/Integer.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 869940947841 Author: sherman Date: 2013-01-22 21:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/869940947841 Merge ! .hgtags - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/BuildJdk.gmk ! makefiles/Tools.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java From xueming.shen at oracle.com Tue Jan 22 21:32:34 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 05:32:34 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: removed unnecessary casting (same change has been in TL) Message-ID: <20130123053306.32D77474A7@hg.openjdk.java.net> Changeset: 2b170c9d7dfe Author: sherman Date: 2013-01-22 21:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2b170c9d7dfe removed unnecessary casting (same change has been in TL) ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java From xueming.shen at oracle.com Tue Jan 22 22:03:07 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 06:03:07 +0000 Subject: [threeten-dev] hg: threeten/threeten/langtools: 18 new changesets Message-ID: <20130123060354.A5973474AD@hg.openjdk.java.net> Changeset: 45fed5cfd1c3 Author: katleman Date: 2013-01-10 09:56 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/45fed5cfd1c3 Added tag jdk8-b72 for changeset 6f0986ed9b7e ! .hgtags Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java Changeset: 1d8438db45f2 Author: lana Date: 2013-01-01 17:50 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/1d8438db45f2 Merge Changeset: 0e17c3c23e3b Author: bpatel Date: 2013-01-04 23:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/0e17c3c23e3b 8004891: Check for abstract method in javadoc does not conform to the language model Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java + test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java + test/com/sun/javadoc/testAbstractMethod/pkg/A.java + test/com/sun/javadoc/testAbstractMethod/pkg/B.java + test/com/sun/javadoc/testAbstractMethod/pkg/C.java Changeset: 8c0c63a6e3b7 Author: bpatel Date: 2013-01-05 00:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/8c0c63a6e3b7 8005092: javadoc should check for synthesized bit on an annotation Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/AnnotationDesc.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/D.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/NonSynthDocContainer.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegArryDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValNotDoc.java Changeset: a9cb93cca229 Author: jjh Date: 2013-01-07 17:51 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/a9cb93cca229 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows Summary: Fix javap to not output \r\r\n Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! test/tools/javac/MethodParameters.java ! test/tools/javap/MethodParameters.java Changeset: 38d3d1027f5a Author: mcimadamore Date: 2013-01-08 10:15 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/38d3d1027f5a 8005243: Restructure method check code to allow pluggable checkers Summary: Add interface to perform a method check - to be implemented by helper classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: db91d860156a Author: mcimadamore Date: 2013-01-08 10:16 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/db91d860156a 8005179: Cleanup Resolve.AmbiguityError Summary: Linearize nested ambiguity errors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out Changeset: d07340b61e6a Author: mcimadamore Date: 2013-01-08 10:17 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/d07340b61e6a 8005184: Restructure DeferredAttr to allow pluggable deferred type completers Summary: Add hooks to generalize deferred type completion via custom helper objects Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java Changeset: 954541f13717 Author: vromero Date: 2013-01-08 13:47 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/954541f13717 8005167: execution time of combo tests in javac should be improved Reviewed-by: jjg, jjh ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java + test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: d2eb08b3f64f Author: jjg Date: 2013-01-09 10:26 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/d2eb08b3f64f 8005644: set default max errs and max warns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/Messager.java + test/tools/javadoc/MaxWarns.java Changeset: 7612fe48be90 Author: darcy Date: 2013-01-09 20:02 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7612fe48be90 8004730: Add language model support for parameter reflection Reviewed-by: abuckley ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/element/package-info.java Changeset: d462da465da6 Author: jjg Date: 2013-01-10 14:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/d462da465da6 8006037: extra space in javac -help for -J and @ options Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java + test/tools/javac/main/Option_J_At_Test.java Changeset: 7d2f628f04f1 Author: jjg Date: 2013-01-10 15:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7d2f628f04f1 8006033: bug in Pretty.toSimpleString Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/PrettySimpleStringTest.java Changeset: 8d0baee36c71 Author: lana Date: 2013-01-10 15:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/8d0baee36c71 Merge Changeset: 56c97aff46bb Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/56c97aff46bb Added tag jdk8-b73 for changeset 8d0baee36c71 ! .hgtags From xueming.shen at oracle.com Tue Jan 22 22:04:51 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 06:04:51 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxp: 6 new changesets Message-ID: <20130123060510.211E3474AE@hg.openjdk.java.net> Changeset: 84946404d1e1 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/84946404d1e1 Added tag jdk8-b72 for changeset bdf2af722a6b ! .hgtags Changeset: cf0917c0d771 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/cf0917c0d771 Added tag jdk8-b73 for changeset 84946404d1e1 ! .hgtags Changeset: 278a2f60c55b Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/278a2f60c55b 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxp.gmk Changeset: 2e4d87e6662e Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/2e4d87e6662e Merge Changeset: a317d3e1bbac Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/a317d3e1bbac Merge Changeset: 2087e24a4357 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/2087e24a4357 Merge From xueming.shen at oracle.com Tue Jan 22 21:55:59 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 05:55:59 +0000 Subject: [threeten-dev] hg: threeten/threeten/corba: 2 new changesets Message-ID: <20130123055601.D4BEF474AB@hg.openjdk.java.net> Changeset: 191afde59e7b Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/191afde59e7b Added tag jdk8-b72 for changeset cb40427f4714 ! .hgtags Changeset: 2132845cf5f7 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/2132845cf5f7 Added tag jdk8-b73 for changeset 191afde59e7b ! .hgtags From xueming.shen at oracle.com Tue Jan 22 21:57:46 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 05:57:46 +0000 Subject: [threeten-dev] hg: threeten/threeten/hotspot: 40 new changesets Message-ID: <20130123055904.DFFEA474AC@hg.openjdk.java.net> Changeset: 11619f33cd68 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/11619f33cd68 Added tag jdk8-b72 for changeset d5cb5830f570 ! .hgtags Changeset: cd962e15c08e Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/cd962e15c08e 8005382: new hotspot build - hs25-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e51c9860cf66 Author: jmasa Date: 2012-12-03 15:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e51c9860cf66 8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous classloaders Reviewed-by: johnc, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/globals.hpp Changeset: 1de1b145f6bc Author: jmasa Date: 2012-12-26 15:05 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1de1b145f6bc 8005486: NPG: Incorrect assertion in ChunkManager::list_index() Reviewed-by: coleenp ! src/share/vm/memory/metaspace.cpp Changeset: b735136e0d82 Author: johnc Date: 2013-01-02 11:32 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b735136e0d82 8004132: SerialGC: ValidateMarkSweep broken when running GCOld Summary: Remove bit-rotten ValidateMarkSweep functionality and flag. Reviewed-by: johnc, jmasa Contributed-by: tamao ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/debug.cpp Changeset: 37f7535e5f18 Author: johnc Date: 2012-12-21 11:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/37f7535e5f18 8001424: G1: Rename certain G1-specific flags Summary: Rename G1DefaultMinNewGenPercent, G1DefaultMaxNewGenPercent, and G1OldCSetRegionLiveThresholdPercent to G1NewSizePercent, G1MaxNewSizePercent, and G1MixedGCLiveThresholdPercent respectively. The previous names are no longer accepted. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d275c3dc73e6 Author: johnc Date: 2013-01-03 16:28 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d275c3dc73e6 8004816: G1: Kitchensink failures after marking stack changes Summary: Reset the marking state, including the mark stack overflow flag, in the event of a marking stack overflow during serial reference processing. Reviewed-by: jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: ca0a78017dc7 Author: brutisso Date: 2012-12-30 08:47 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ca0a78017dc7 8005396: Use ParNew with only one thread instead of DefNew as default for CMS on single CPU machines Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/runtime/arguments.cpp Changeset: e0ab18eafbde Author: brutisso Date: 2013-01-04 11:10 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e0ab18eafbde 8003820: Deprecate untested and rarely used GC combinations Summary: Log warning messages for DefNew+CMS and ParNew+SerialOld Reviewed-by: ysr, jwilhelm, jcoomes ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: c98b676a98b4 Author: brutisso Date: 2013-01-04 21:33 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c98b676a98b4 8003822: Deprecate the incremental mode of CMS Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp Changeset: 6e9174173e00 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/6e9174173e00 8000325: Change default for CMSClassUnloadingEnabled to true Reviewed-by: stefank, ysr ! src/share/vm/runtime/globals.hpp Changeset: 0b54ffe4c2d3 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0b54ffe4c2d3 8005672: Clean up some changes to GC logging with GCCause's Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 7d42f3b08300 Author: dcubed Date: 2012-12-19 10:35 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/7d42f3b08300 8005044: remove crufty '_g' support from HS runtime code Summary: Phase 2 is removing '_g' support from the Runtime code. Reviewed-by: dcubed, coleenp, hseigel Contributed-by: ron.durbin at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/vm/runtime/arguments.cpp Changeset: 35431a769282 Author: stefank Date: 2012-12-20 10:22 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/35431a769282 8004823: Add VM support for type annotation reflection Reviewed-by: dholmes, coleenp Contributed-by: joel.franck at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflection.cpp Changeset: 4daebd4cc1dd Author: minqi Date: 2012-12-24 11:46 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4daebd4cc1dd Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/arguments.cpp Changeset: cc6a617fffd2 Author: coleenp Date: 2013-01-02 20:28 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/cc6a617fffd2 8005494: SIGSEGV in Rewriter::relocate_and_link() when testing Weblogic with CompressedOops and KlassPtrs Summary: Relocate functions with jsr's when rewriting so not repeated after reading shared archive Reviewed-by: twisti, jrose ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.inline.hpp Changeset: 6c3f47d964f3 Author: hseigel Date: 2013-01-07 15:32 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/6c3f47d964f3 8003705: CDS failed on Windows: can not map in the CDS. Summary: Map memory only once to prevent 'already mapped' failures. Reviewed-by: acorn, zgu ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 561148896559 Author: hseigel Date: 2013-01-08 13:38 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/561148896559 8005076: Creating a CDS archive with one alignment and running another causes a crash. Summary: Save the alignment when writing the CDS and compare it when reading the CDS. Reviewed-by: kvn, coleenp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ade95d680b42 Author: coleenp Date: 2013-01-08 14:01 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ade95d680b42 8004728: Add hotspot support for parameter reflection Summary: Add hotspot support for parameter reflection Reviewed-by: acorn, jrose, coleenp Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileStream.cpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp Changeset: 185a2c979a0e Author: coleenp Date: 2013-01-08 13:44 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/185a2c979a0e Merge Changeset: ecd24264898b Author: zgu Date: 2013-01-08 14:04 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ecd24264898b 8005048: NMT: #loaded classes needs to just show the # defined classes Summary: Count number of instance classes so that it matches class metadata size Reviewed-by: coleenp, acorn ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 37a3e8b7a1e9 Author: zgu Date: 2013-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/37a3e8b7a1e9 Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 0c93d4818214 Author: zgu Date: 2013-01-08 15:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0c93d4818214 Merge Changeset: 1f6d10b4cc0c Author: acorn Date: 2013-01-09 18:06 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1f6d10b4cc0c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 608b2e8a0063 Author: bpittore Date: 2013-01-03 15:08 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/608b2e8a0063 8004051: assert(_oprs_len[mode] < maxNumberOfOperands) failed: array overflow Summary: assert is triggered when number of register based arguments passed to a java method exceeds 16. Reviewed-by: roland, vladidan ! src/share/vm/c1/c1_LIR.hpp Changeset: 0c8717a92b2d Author: jiangli Date: 2013-01-08 13:01 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/0c8717a92b2d 8001341: SIGSEGV in methodOopDesc::fast_exception_handler_bci_for(KlassHandle,int,Thread*)+0x3e9. Summary: Use methodHandle. Reviewed-by: coleenp, acorn, twisti, sspitsyn ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 18c3c3fa291b Author: dlong Date: 2013-01-09 21:18 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/18c3c3fa291b Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 4c8bf5e55392 Author: brutisso Date: 2013-01-09 09:48 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4c8bf5e55392 8005489: VM hangs during GC with ParallelGC and ParallelGCThreads=0 Summary: Print an error message and exit the VM if UseParallalGC is combined with ParllelGCThreads==0. Also reviewed by vitalyd at gmail.com. Reviewed-by: stefank, ehelin ! src/share/vm/runtime/arguments.cpp Changeset: b2fef6b220e9 Author: jmasa Date: 2013-01-10 07:32 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b2fef6b220e9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d092d1b31229 Author: roland Date: 2012-12-23 17:08 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d092d1b31229 8005071: Incremental inlining for JSR 292 Summary: post parse inlining driven by number of live nodes. Reviewed-by: twisti, kvn, jrose ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 00af3a3a8df4 Author: kvn Date: 2013-01-03 15:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/00af3a3a8df4 8005522: use fast-string instructions on x86 for zeroing Summary: use 'rep stosb' instead of 'rep stosq' when fast-string operations are available. Reviewed-by: twisti, roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/memnode.cpp Changeset: e2e6bf86682c Author: kvn Date: 2013-01-03 16:30 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e2e6bf86682c 8005544: Use 256bit YMM registers in arraycopy stubs on x86 Summary: Use YMM registers in arraycopy and array_fill stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: ffa87474d7a4 Author: twisti Date: 2013-01-07 14:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ffa87474d7a4 8004537: replace AbstractAssembler emit_long with emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 038dd2875b94 Author: kvn Date: 2013-01-08 11:30 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/038dd2875b94 8005419: Improve intrinsics code performance on x86 by using AVX2 Summary: use 256bit vpxor,vptest instructions in String.compareTo() and equals() intrinsics. Reviewed-by: twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp + test/compiler/8005419/Test8005419.java Changeset: 5698813d45eb Author: twisti Date: 2013-01-09 15:37 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/5698813d45eb 8005418: JSR 292: virtual dispatch bug in 292 impl Reviewed-by: jrose, kvn ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp Changeset: f1c06dcee0b5 Author: kvn Date: 2013-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f1c06dcee0b5 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 1e129851479e Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1e129851479e Merge Changeset: b5e6bec76f4a Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b5e6bec76f4a Added tag hs25-b15 for changeset 1e129851479e ! .hgtags Changeset: 41ccb2e737fb Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/41ccb2e737fb Added tag jdk8-b73 for changeset 11619f33cd68 ! .hgtags Changeset: 1a3e54283c54 Author: katleman Date: 2013-01-16 20:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/1a3e54283c54 Merge ! .hgtags From xueming.shen at oracle.com Tue Jan 22 22:05:52 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 06:05:52 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxws: 6 new changesets Message-ID: <20130123060608.38197474AF@hg.openjdk.java.net> Changeset: c606f644a5d9 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/c606f644a5d9 Added tag jdk8-b72 for changeset d9707230294d ! .hgtags Changeset: 68f508979ffe Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/68f508979ffe Added tag jdk8-b73 for changeset c606f644a5d9 ! .hgtags Changeset: 51f3117e2b75 Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/51f3117e2b75 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxws.gmk Changeset: dd7473082690 Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/dd7473082690 Merge Changeset: b8fd32e44c26 Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/b8fd32e44c26 Merge Changeset: 12db3c5a3393 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/12db3c5a3393 Merge From xueming.shen at oracle.com Tue Jan 22 22:13:25 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 06:13:25 +0000 Subject: [threeten-dev] hg: threeten/threeten: synced the build changes made for tl top repo Message-ID: <20130123061325.9463B474B1@hg.openjdk.java.net> Changeset: c51bde914a3c Author: sherman Date: 2013-01-22 22:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c51bde914a3c synced the build changes made for tl top repo ! common/makefiles/javadoc/CORE_PKGS.gmk ! make/jprt.properties ! test/Makefile From xueming.shen at oracle.com Tue Jan 22 22:22:03 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 06:22:03 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: sync-ed the build changes made for tl jdk repo Message-ID: <20130123062226.1834E474B2@hg.openjdk.java.net> Changeset: 082f38e1448a Author: sherman Date: 2013-01-22 22:26 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/082f38e1448a sync-ed the build changes made for tl jdk repo ! makefiles/CreateJars.gmk ! makefiles/GendataTZDB.gmk From xueming.shen at oracle.com Tue Jan 22 23:07:20 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 22 Jan 2013 23:07:20 -0800 Subject: [threeten-dev] Threeten repo is open for M7 Message-ID: <50FF8C28.8050302@oracle.com> Hi, Just pushed the current Threeten into TL repo for M6[1]. The threeten repository [2] ha been sync-ed with the new build infra change from the master. The repo has been test-built and tested (one new config/make build from the top repo on mac and one old jdk/make build on linux), everything looks fine. So it is now open for business for M7:-) -Sherman [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-Jauary/013927.html [2] http://hg.openjdk.java.net/threeten/threeten From xueming.shen at oracle.com Tue Jan 22 23:38:50 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 23 Jan 2013 07:38:50 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added more tests to Period Message-ID: <20130123073911.6F4D7474BA@hg.openjdk.java.net> Changeset: ff4436ce7041 Author: sherman Date: 2013-01-22 23:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ff4436ce7041 Added more tests to Period Contributed-by: patrick.zhang at oracle.com ! test/java/time/test/java/time/TestPeriod.java From masayoshi.okutsu at oracle.com Wed Jan 23 00:30:09 2013 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 23 Jan 2013 17:30:09 +0900 Subject: [threeten-dev] RFR get properties from lib/calendars.properties Message-ID: <50FF9F91.5080404@oracle.com> Per Roger's request, I've created a static method for getting a Properties from /lib/calendars.properties. The plan is to put Hijrah calendar properties in the properties file. http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.00/ Thanks, Masayoshi From Roger.Riggs at oracle.com Wed Jan 23 06:12:03 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 23 Jan 2013 09:12:03 -0500 Subject: [threeten-dev] Review for package changes related to issues 207, 208, 209, 211 Message-ID: <50FFEFB3.9080902@oracle.com> Hi, Please review the following changes: Javadoc - http://cr.openjdk.java.net/~rriggs/threeten/javadoc-207-208-209/ Webrev - http://cr.openjdk.java.net/~rriggs/threeten/webrev-207-208-209/ The related issues are: - #211 - Camel-case for names - ISO XXX -> IsoXxx - #207 - Move support for localized calendars to new java.time.chrono package - Rename Chrono to Chronology - #207 - Rename java.time.calendar to java.time.calendar*s* to distinguish its purpose from java time.chrono - #208 - Move OffsetDate, OffsetTime, OffsetDateTime to the java.time package - #209 - Move Year, YearMonth, MonthDay to the java.time package [Some other issues with these last two are not yet reflected in this update]. These changes bring the Threeten packages into alignment with JDK conventions for functional definition of packages. The package names are concise and describe their contents without any package being a grab-bag of classes. Collecting the datetime times into java.time will give them the cohesiveness and visibility they need to be found and used by developers. Thanks, Roger From Roger.Riggs at oracle.com Wed Jan 23 06:24:46 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 23 Jan 2013 09:24:46 -0500 Subject: [threeten-dev] RFR get properties from lib/calendars.properties In-Reply-To: <50FF9F91.5080404@oracle.com> References: <50FF9F91.5080404@oracle.com> Message-ID: <50FFF2AE.8030708@oracle.com> Hi, Thanks, this provides the function needed for Hijrah calendar properties. In the rare case that there is an error in calendars.properties, will the RuntimeException provide enough information to diagnose the problem? Is this a case where the error should be logged to the PlatformLogger? Perhaps the throw of the RuntimeException could include a message "Configuration error in calendars.properties". In some other cases, I have seen an InternalError thrown (Currency.java). Thanks, Roger On 1/23/2013 3:30 AM, Masayoshi Okutsu wrote: > Per Roger's request, I've created a static method for getting a > Properties from /lib/calendars.properties. The plan is to > put Hijrah calendar properties in the properties file. > > http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.00/ > > Thanks, > Masayoshi > From Roger.Riggs at oracle.com Wed Jan 23 06:37:23 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 23 Jan 2013 09:37:23 -0500 Subject: [threeten-dev] Threeten repo is open for M7 In-Reply-To: <50FF8C28.8050302@oracle.com> References: <50FF8C28.8050302@oracle.com> Message-ID: <50FFF5A3.7080607@oracle.com> Thank you very much Sherman for the getting it integrated and working ! On 1/23/2013 2:07 AM, Xueming Shen wrote: > Hi, > > Just pushed the current Threeten into TL repo for M6[1]. > The threeten repository [2] ha been sync-ed with the new build infra > change from > the master. The repo has been test-built and tested (one new > config/make build > from the top repo on mac and one old jdk/make build on linux), > everything looks > fine. So it is now open for business for M7:-) > > -Sherman > > [1] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-Jauary/013927.html > [2] http://hg.openjdk.java.net/threeten/threeten From scolebourne at joda.org Wed Jan 23 06:53:23 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 23 Jan 2013 14:53:23 +0000 Subject: [threeten-dev] [threeten-develop] Review for package changes related to issues 207, 208, 209, 211 In-Reply-To: <50FFEFB3.9080902@oracle.com> References: <50FFEFB3.9080902@oracle.com> Message-ID: +1 to push these Note for posterity - these are driven by Oracle's choices, not mine. Stephen On 23 January 2013 14:12, Roger Riggs wrote: > Hi, > > Please review the following changes: > Javadoc - > http://cr.openjdk.java.net/~rriggs/threeten/javadoc-207-208-209/ > Webrev - http://cr.openjdk.java.net/~rriggs/threeten/webrev-207-208-209/ > > The related issues are: > - #211 - Camel-case for names - ISO XXX -> IsoXxx > - #207 - Move support for localized calendars to new java.time.chrono > package > - Rename Chrono to Chronology > - #207 - Rename java.time.calendar to java.time.calendars to > distinguish its purpose from java time.chrono > - #208 - Move OffsetDate, OffsetTime, OffsetDateTime to the java.time > package > - #209 - Move Year, YearMonth, MonthDay to the java.time package > [Some other issues with these last two are not yet reflected > in this update]. > > These changes bring the Threeten packages into alignment with JDK > conventions > for functional definition of packages. The package names are concise and > describe their contents without any package being a grab-bag of classes. > > Collecting the datetime times into java.time will give them the cohesiveness > and visibility they need to be found and used by developers. > > Thanks, Roger > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From misterm at gmail.com Wed Jan 23 06:54:37 2013 From: misterm at gmail.com (Michael Nascimento) Date: Wed, 23 Jan 2013 12:54:37 -0200 Subject: [threeten-dev] [threeten-develop] Review for package changes related to issues 207, 208, 209, 211 In-Reply-To: References: <50FFEFB3.9080902@oracle.com> Message-ID: LGTM. Regards, Michael On Wed, Jan 23, 2013 at 12:53 PM, Stephen Colebourne wrote: > +1 to push these > Note for posterity - these are driven by Oracle's choices, not mine. > Stephen > > On 23 January 2013 14:12, Roger Riggs wrote: >> Hi, >> >> Please review the following changes: >> Javadoc - >> http://cr.openjdk.java.net/~rriggs/threeten/javadoc-207-208-209/ >> Webrev - http://cr.openjdk.java.net/~rriggs/threeten/webrev-207-208-209/ >> >> The related issues are: >> - #211 - Camel-case for names - ISO XXX -> IsoXxx >> - #207 - Move support for localized calendars to new java.time.chrono >> package >> - Rename Chrono to Chronology >> - #207 - Rename java.time.calendar to java.time.calendars to >> distinguish its purpose from java time.chrono >> - #208 - Move OffsetDate, OffsetTime, OffsetDateTime to the java.time >> package >> - #209 - Move Year, YearMonth, MonthDay to the java.time package >> [Some other issues with these last two are not yet reflected >> in this update]. >> >> These changes bring the Threeten packages into alignment with JDK >> conventions >> for functional definition of packages. The package names are concise and >> describe their contents without any package being a grab-bag of classes. >> >> Collecting the datetime times into java.time will give them the cohesiveness >> and visibility they need to be found and used by developers. >> >> Thanks, Roger >> >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnnow-d2d >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop >> From roger.riggs at oracle.com Wed Jan 23 10:30:35 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Wed, 23 Jan 2013 18:30:35 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 8 new changesets Message-ID: <20130123183216.B368E474D7@hg.openjdk.java.net> Changeset: c0cefac11016 Author: rriggs Date: 2013-01-17 15:20 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c0cefac11016 Rename ISO* classes and methods to Iso* Issue #211 Camel-case for names - ISOXXX - IsoXxx ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/IsoChrono.java + src/share/classes/java/time/temporal/IsoEra.java + src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendar/TestHijrahChrono.java ! test/java/time/tck/java/time/calendar/TestJapaneseChrono.java ! test/java/time/tck/java/time/calendar/TestMinguoChrono.java ! test/java/time/tck/java/time/calendar/TestServiceLoader.java ! test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java - test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKOffsetDate.java ! test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/temporal/TestIsoChrono.java ! test/java/time/test/java/time/TestPeriod.java = test/java/time/test/java/time/temporal/TestIsoChronoImpl.java < test/java/time/test/java/time/temporal/TestISOChronoImpl.java Changeset: a9535184d6dd Author: rriggs Date: 2013-01-17 17:57 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a9535184d6dd Move support for localized calendars to new java.time.chrono package Issue #207 ! make/netbeans/threeten/build.xml ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendar/HijrahChrono.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendar/MinguoChrono.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java ! src/share/classes/java/time/calendar/ThaiBuddhistChrono.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/chrono/Chrono.java < src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoLocalDateTime.java + src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/chrono/ChronoZonedDateTime.java + src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoChrono.java < src/share/classes/java/time/temporal/IsoChrono.java ! src/share/classes/java/time/chrono/IsoEra.java < src/share/classes/java/time/temporal/IsoEra.java + src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/package-info.java < src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/OffsetDate.java ! src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/Year.java ! src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java + test/java/time/META-INF/services/java.time.chrono.Chrono - test/java/time/META-INF/services/java.time.temporal.Chrono ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendar/CopticChrono.java ! test/java/time/tck/java/time/calendar/CopticDate.java ! test/java/time/tck/java/time/calendar/CopticEra.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendar/TestHijrahChrono.java ! test/java/time/tck/java/time/calendar/TestJapaneseChrono.java ! test/java/time/tck/java/time/calendar/TestMinguoChrono.java ! test/java/time/tck/java/time/calendar/TestServiceLoader.java ! test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/temporal/TCKOffsetDate.java ! test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/tck/java/time/temporal/TestIsoChrono.java ! test/java/time/test/java/time/temporal/TestIsoChronoImpl.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java Changeset: 2d7165ea0b37 Author: rriggs Date: 2013-01-18 15:37 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2d7165ea0b37 Move OffsetDate, OffsetTime, OffsetDateTime to the java.time package Issue #208 ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDate.java < src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java < src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/package-info.java - src/share/classes/java/time/temporal/OffsetDateTime.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/util/Formatter.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetDate.java < test/java/time/tck/java/time/temporal/TCKOffsetDate.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java < test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TCKYear.java ! test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/test/java/time/TestOffsetDate.java + test/java/time/test/java/time/TestOffsetDateTime.java + test/java/time/test/java/time/TestOffsetDateTime_instants.java + test/java/time/test/java/time/TestOffsetTime.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java ! test/java/time/test/java/util/TestFormatter.java Changeset: deb365829324 Author: rriggs Date: 2013-01-18 17:10 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/deb365829324 Move OffsetDate, OffsetTime, OffsetDateTime to the java.time package Issue #208 Move Year, YearMonth, MonthDay to java.time package. Issue #209 ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/Ser.java + src/share/classes/java/time/Year.java + src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java - src/share/classes/java/time/temporal/MonthDay.java ! src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/sun/tools/tzdb/TzdbZoneRulesCompiler.java ! src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKMonthDay.java < test/java/time/tck/java/time/temporal/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDate.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKYear.java < test/java/time/tck/java/time/temporal/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java < test/java/time/tck/java/time/temporal/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendar/CopticDate.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/test/java/time/TestMonthDay.java ! test/java/time/test/java/time/TestOffsetDateTime_instants.java ! test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestYear.java + test/java/time/test/java/time/TestYearMonth.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java ! test/java/time/test/sun/tools/tzdb/TestZoneRulesBuilder.java Changeset: 3689df0d6231 Author: rriggs Date: 2013-01-19 16:05 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3689df0d6231 Rename Chrono to Chronology in classnames and method names Issue #207 ! make/netbeans/threeten/build.xml ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahChronology.java ! src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendar/JapaneseChronology.java < src/share/classes/java/time/calendar/JapaneseChrono.java ! src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoChronology.java ! src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistChronology.java ! src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/chrono/Chrono.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java - src/share/classes/java/time/chrono/IsoChrono.java + src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Ser.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/sun/tools/tzdb/ZoneRulesBuilder.java - test/java/time/META-INF/services/java.time.chrono.Chrono + test/java/time/META-INF/services/java.time.chrono.Chronology ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKOffsetDate.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/TestChronology.java + test/java/time/tck/java/time/TestIsoChronology.java - test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticChronology.java ! test/java/time/tck/java/time/calendar/CopticDate.java ! test/java/time/tck/java/time/calendar/CopticEra.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestHijrahChronology.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChronology.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChronology.java ! test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChronology.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java - test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/tck/java/time/temporal/TestIsoChrono.java + test/java/time/test/java/time/chrono/TestIsoChronoImpl.java - test/java/time/test/java/time/temporal/TestIsoChronoImpl.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java Changeset: 9f5749b4e1ca Author: rriggs Date: 2013-01-22 15:44 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9f5749b4e1ca Rename java.time.calendar to java.time.calendars to make a clear distinction as to the types in the package as different from the java.time.chrono package. Followup to Issue #207 - src/share/classes/java/time/calendar/Ser.java ! src/share/classes/java/time/calendars/ChronoDateImpl.java < src/share/classes/java/time/calendar/ChronoDateImpl.java ! src/share/classes/java/time/calendars/HijrahChronology.java < src/share/classes/java/time/calendar/HijrahChronology.java ! src/share/classes/java/time/calendars/HijrahDate.java < src/share/classes/java/time/calendar/HijrahDate.java ! src/share/classes/java/time/calendars/HijrahDeviationReader.java < src/share/classes/java/time/calendar/HijrahDeviationReader.java ! src/share/classes/java/time/calendars/HijrahEra.java < src/share/classes/java/time/calendar/HijrahEra.java ! src/share/classes/java/time/calendars/JapaneseChronology.java < src/share/classes/java/time/calendar/JapaneseChronology.java ! src/share/classes/java/time/calendars/JapaneseDate.java < src/share/classes/java/time/calendar/JapaneseDate.java ! src/share/classes/java/time/calendars/JapaneseEra.java < src/share/classes/java/time/calendar/JapaneseEra.java ! src/share/classes/java/time/calendars/MinguoChronology.java < src/share/classes/java/time/calendar/MinguoChronology.java ! src/share/classes/java/time/calendars/MinguoDate.java < src/share/classes/java/time/calendar/MinguoDate.java ! src/share/classes/java/time/calendars/MinguoEra.java < src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendars/Ser.java ! src/share/classes/java/time/calendars/ThaiBuddhistChronology.java < src/share/classes/java/time/calendar/ThaiBuddhistChronology.java ! src/share/classes/java/time/calendars/ThaiBuddhistDate.java < src/share/classes/java/time/calendar/ThaiBuddhistDate.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java < src/share/classes/java/time/calendar/ThaiBuddhistEra.java ! src/share/classes/java/time/calendars/package-info.java < src/share/classes/java/time/calendar/package-info.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/overview.html ! test/java/time/META-INF/services/java.time.chrono.Chronology ! test/java/time/tck/java/time/TestChronology.java ! test/java/time/tck/java/time/TestIsoChronology.java ! test/java/time/tck/java/time/calendars/CopticChronology.java < test/java/time/tck/java/time/calendar/CopticChronology.java ! test/java/time/tck/java/time/calendars/CopticDate.java < test/java/time/tck/java/time/calendar/CopticDate.java ! test/java/time/tck/java/time/calendars/CopticEra.java < test/java/time/tck/java/time/calendar/CopticEra.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java < test/java/time/tck/java/time/calendar/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java < test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendars/TestHijrahChronology.java < test/java/time/tck/java/time/calendar/TestHijrahChronology.java ! test/java/time/tck/java/time/calendars/TestJapaneseChronology.java < test/java/time/tck/java/time/calendar/TestJapaneseChronology.java ! test/java/time/tck/java/time/calendars/TestMinguoChronology.java < test/java/time/tck/java/time/calendar/TestMinguoChronology.java ! test/java/time/tck/java/time/calendars/TestServiceLoader.java < test/java/time/tck/java/time/calendar/TestServiceLoader.java ! test/java/time/tck/java/time/calendars/TestThaiBuddhistChronology.java < test/java/time/tck/java/time/calendar/TestThaiBuddhistChronology.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java Changeset: 9214bfd7796c Author: rriggs Date: 2013-01-22 16:00 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9214bfd7796c Update to include chrono and calendars in the javadoc makefile ! make/docs/CORE_PKGS.gmk Changeset: e1ff4fa99eed Author: rriggs Date: 2013-01-23 13:28 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e1ff4fa99eed Merge - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/calendars/JapaneseChronology.java + src/share/classes/java/time/calendars/JapaneseDate.java + src/share/classes/java/time/calendars/Ser.java + src/share/classes/java/time/chrono/Chronology.java + src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/overview.html - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/util/Formatter.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java ! test/java/time/test/java/time/TestPeriod.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java From masayoshi.okutsu at oracle.com Wed Jan 23 15:28:43 2013 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 24 Jan 2013 08:28:43 +0900 Subject: [threeten-dev] RFR get properties from lib/calendars.properties In-Reply-To: <50FFF2AE.8030708@oracle.com> References: <50FF9F91.5080404@oracle.com> <50FFF2AE.8030708@oracle.com> Message-ID: <5100722B.2070004@oracle.com> During loading properties, it may throw either IOException or IllegalArgumentException. The caller should catch RuntimeException and get its Cause and determine what to do. Masayoshi On 1/23/2013 11:24 PM, Roger Riggs wrote: > Hi, > > Thanks, this provides the function needed for Hijrah calendar properties. > > In the rare case that there is an error in calendars.properties, will > the RuntimeException > provide enough information to diagnose the problem? Is this a case > where > the error should be logged to the PlatformLogger? > Perhaps the throw of the RuntimeException could include a message > "Configuration error in calendars.properties". > > In some other cases, I have seen an InternalError thrown (Currency.java). > > Thanks, Roger > > > > On 1/23/2013 3:30 AM, Masayoshi Okutsu wrote: >> Per Roger's request, I've created a static method for getting a >> Properties from /lib/calendars.properties. The plan is to >> put Hijrah calendar properties in the properties file. >> >> http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.00/ >> >> Thanks, >> Masayoshi >> > From scolebourne at joda.org Wed Jan 23 16:18:25 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 24 Jan 2013 00:18:25 +0000 Subject: [threeten-dev] Threeten repo is open for M7 In-Reply-To: <50FFF5A3.7080607@oracle.com> References: <50FF8C28.8050302@oracle.com> <50FFF5A3.7080607@oracle.com> Message-ID: So, I've wasted an entire evening failing to get OpenJDK to build. Its incredibly slow and buggy. I gave up and installed the lambda binary and can compile against that, but webrev fails, probably because I checkout mercurial outside cygwin. Frankly, I don't have time for this rubbish. If you want me to write code, then thats what I need to be doing. The OpenJDK build system simply isn't good enough for non-Oracle / Windows people like me to use. Stephen On 23 January 2013 14:37, Roger Riggs wrote: > Thank you very much Sherman for the getting it integrated and working ! > > > On 1/23/2013 2:07 AM, Xueming Shen wrote: >> >> Hi, >> >> Just pushed the current Threeten into TL repo for M6[1]. >> The threeten repository [2] ha been sync-ed with the new build infra >> change from >> the master. The repo has been test-built and tested (one new config/make >> build >> from the top repo on mac and one old jdk/make build on linux), everything >> looks >> fine. So it is now open for business for M7:-) >> >> -Sherman >> >> [1] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-Jauary/013927.html >> [2] http://hg.openjdk.java.net/threeten/threeten > > From masayoshi.okutsu at oracle.com Wed Jan 23 21:02:38 2013 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Thu, 24 Jan 2013 14:02:38 +0900 Subject: [threeten-dev] RFR get properties from lib/calendars.properties In-Reply-To: <5100722B.2070004@oracle.com> References: <50FF9F91.5080404@oracle.com> <50FFF2AE.8030708@oracle.com> <5100722B.2070004@oracle.com> Message-ID: <5100C06E.60700@oracle.com> I've change the exception handling so that you can expect "regular" exceptions. I don't see much value to this change, though. Here's the new webrev. http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.01/ Thanks, Masayoshi On 1/24/2013 8:28 AM, Masayoshi Okutsu wrote: > During loading properties, it may throw either IOException or > IllegalArgumentException. The caller should catch RuntimeException and > get its Cause and determine what to do. > > Masayoshi > > On 1/23/2013 11:24 PM, Roger Riggs wrote: >> Hi, >> >> Thanks, this provides the function needed for Hijrah calendar >> properties. >> >> In the rare case that there is an error in calendars.properties, will >> the RuntimeException >> provide enough information to diagnose the problem? Is this a case >> where >> the error should be logged to the PlatformLogger? >> Perhaps the throw of the RuntimeException could include a message >> "Configuration error in calendars.properties". >> >> In some other cases, I have seen an InternalError thrown >> (Currency.java). >> >> Thanks, Roger >> >> >> >> On 1/23/2013 3:30 AM, Masayoshi Okutsu wrote: >>> Per Roger's request, I've created a static method for getting a >>> Properties from /lib/calendars.properties. The plan is to >>> put Hijrah calendar properties in the properties file. >>> >>> http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.00/ >>> >>> Thanks, >>> Masayoshi >>> >> > From richard.warburton at gmail.com Thu Jan 24 02:38:56 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Thu, 24 Jan 2013 10:38:56 +0000 Subject: [threeten-dev] Threeten repo is open for M7 In-Reply-To: References: <50FF8C28.8050302@oracle.com> <50FFF5A3.7080607@oracle.com> Message-ID: > > Frankly, I don't have time for this rubbish. If you want me to write > code, then thats what I need to be doing. The OpenJDK build system > simply isn't good enough for non-Oracle / Windows people like me to > use. > Hey Stephen - we've had quite a few people have issues with this. There are adopt-openjdk instructions [0], which are more detailed than the official ones, and I've heard they work well if you're using Windows 7. There's certainly help available at https://groups.google.com/forum/?fromgroups#!forum/adopt-openjdk for people building openjdk, which is a lot friendlier/help oriented than on the official mailing lists. I did a build on my laptop last night and I've found build-infra to work very effectively if you're using the latest ubuntu, so it might be worth just trying to use that in a virtual machine. When running openjdk hackdays we usually build ubuntu VMs because it results in /far/ less issues than people trying to use OS X or Windows. regards, Richard Warburton http://insightfullogic.com @RichardWarburto [0] http://java.net/projects/adoptopenjdk/pages/BuildWindows From misterm at gmail.com Thu Jan 24 02:52:50 2013 From: misterm at gmail.com (Michael Nascimento) Date: Thu, 24 Jan 2013 08:52:50 -0200 Subject: [threeten-dev] Threeten repo is open for M7 In-Reply-To: References: <50FF8C28.8050302@oracle.com> <50FFF5A3.7080607@oracle.com> Message-ID: I share Stephen's pain. My time is quite limited these days, so sometimes I would do something and there was a major refactoring. Now I am pursuing small changes and things should be moving on, but everything got moved to java.time and I have to build OpenJDK, which is a very painful process on Windows - and doesn't work at all. The current process is hindering contributions, when we have to spend tons of time just trying to catch up with changes in the build infrastructure instead of just writing code. Regarding webrev, I really think that if committers were allowed to create branches in the the format person-feature so they could push their changes there and everyone could simply diff against it, it would be way simpler. Once approved, we'd merge it into trunk. I am still trying to comply with the process, but because of that, I haven't been able to produce working code since we moved to OpenJDK. Regards, Michael On Thu, Jan 24, 2013 at 8:38 AM, Richard Warburton wrote: >> >> Frankly, I don't have time for this rubbish. If you want me to write >> code, then thats what I need to be doing. The OpenJDK build system >> simply isn't good enough for non-Oracle / Windows people like me to >> use. >> > > Hey Stephen - we've had quite a few people have issues with this. There > are adopt-openjdk instructions [0], which are more detailed than the > official ones, and I've heard they work well if you're using Windows 7. > There's certainly help available at > https://groups.google.com/forum/?fromgroups#!forum/adopt-openjdk for people > building openjdk, which is a lot friendlier/help oriented than on the > official mailing lists. > > I did a build on my laptop last night and I've found build-infra to work > very effectively if you're using the latest ubuntu, so it might be worth > just trying to use that in a virtual machine. When running openjdk > hackdays we usually build ubuntu VMs because it results in /far/ less > issues than people trying to use OS X or Windows. > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto > > [0] http://java.net/projects/adoptopenjdk/pages/BuildWindows From Roger.Riggs at oracle.com Thu Jan 24 06:36:51 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 24 Jan 2013 09:36:51 -0500 Subject: [threeten-dev] RFR get properties from lib/calendars.properties In-Reply-To: <5100C06E.60700@oracle.com> References: <50FF9F91.5080404@oracle.com> <50FFF2AE.8030708@oracle.com> <5100722B.2070004@oracle.com> <5100C06E.60700@oracle.com> Message-ID: <51014703.4000204@oracle.com> Thanks for the update. This looks fine. My question/point was more whether a missing or corruption problem in the calendars.properties configuration file should be considered fatal. I understand your point to be that depending on how the caller is using the properties, a corrupted Properties file might be not be fatal. But either way I think it would be useful to log problems with the properties file. But that can be handled by the caller. As an internal method is doesn't matter much either way. A second observation, this code uses a standard GetPropertyAction for accessing the java.home property but is in a separate doPrivileged call. Is that significant? It would seem just as easy to put the System.getProperty in the doPrivileged block that reads the file and save the overhead. It doesn't seem significant but if there is a recommended practice around security, I'll make a note. Thanks, Roger On 1/24/2013 12:02 AM, Masayoshi Okutsu wrote: > I've change the exception handling so that you can expect "regular" > exceptions. I don't see much value to this change, though. > > Here's the new webrev. > > http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.01/ > > Thanks, > Masayoshi > > On 1/24/2013 8:28 AM, Masayoshi Okutsu wrote: >> During loading properties, it may throw either IOException or >> IllegalArgumentException. The caller should catch RuntimeException >> and get its Cause and determine what to do. >> >> Masayoshi >> >> On 1/23/2013 11:24 PM, Roger Riggs wrote: >>> Hi, >>> >>> Thanks, this provides the function needed for Hijrah calendar >>> properties. >>> >>> In the rare case that there is an error in calendars.properties, >>> will the RuntimeException >>> provide enough information to diagnose the problem? Is this a case >>> where >>> the error should be logged to the PlatformLogger? >>> Perhaps the throw of the RuntimeException could include a message >>> "Configuration error in calendars.properties". >>> >>> In some other cases, I have seen an InternalError thrown >>> (Currency.java). >>> >>> Thanks, Roger >>> >>> >>> >>> On 1/23/2013 3:30 AM, Masayoshi Okutsu wrote: >>>> Per Roger's request, I've created a static method for getting a >>>> Properties from /lib/calendars.properties. The plan is >>>> to put Hijrah calendar properties in the properties file. >>>> >>>> http://cr.openjdk.java.net/~okutsu/310/calendarprops/webrev.00/ >>>> >>>> Thanks, >>>> Masayoshi >>>> >>> >> > -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From scolebourne at joda.org Thu Jan 24 06:49:06 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 24 Jan 2013 14:49:06 +0000 Subject: [threeten-dev] Threeten repo is open for M7 In-Reply-To: References: <50FF8C28.8050302@oracle.com> <50FFF5A3.7080607@oracle.com> Message-ID: On 24 January 2013 10:38, Richard Warburton wrote: >> Frankly, I don't have time for this rubbish. If you want me to write >> code, then thats what I need to be doing. The OpenJDK build system >> simply isn't good enough for non-Oracle / Windows people like me to >> use. > > > Hey Stephen - we've had quite a few people have issues with this. There are > adopt-openjdk instructions [0], which are more detailed than the official > ones, and I've heard they work well if you're using Windows 7. There's > certainly help available at > https://groups.google.com/forum/?fromgroups#!forum/adopt-openjdk for people > building openjdk, which is a lot friendlier/help oriented than on the > official mailing lists. The Adopt a JDK Windows instructions are good, although they could do with a little more about "why" the step is needed. Apparantly, re-pulling means running configure again. Not something that is clear anywhere. On 24 January 2013 10:52, Michael Nascimento wrote: > Regarding webrev, I really think that if committers were allowed to > create branches in the the format person-feature so they could push > their changes there and everyone could simply diff against it, it > would be way simpler. Once approved, we'd merge it into trunk. OpenJDK contributing is like being in the stone age compared to what I'm used to with git and GitHub. Stephen From Roger.Riggs at oracle.com Thu Jan 24 08:42:37 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 24 Jan 2013 08:42:37 -0800 (PST) Subject: [threeten-dev] Review for Remove of OffsetDate Message-ID: <5101647D.9090109@oracle.com> Please review: http://cr.openjdk.java.net/~rriggs/webrev-nooffsetdate/ Resolves issue #228: Remove OffsetDate Thanks, Roger From scolebourne at joda.org Thu Jan 24 08:45:01 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 16:45:01 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 5 new changesets Message-ID: <20130124164753.0F1FF4751D@hg.openjdk.java.net> Changeset: 6401f26ff6ec Author: scolebourne Date: 2013-01-24 14:25 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6401f26ff6ec Fix Javadoc ! src/share/classes/java/time/LocalTime.java Changeset: 42478a7dbb49 Author: scolebourne Date: 2013-01-24 15:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/42478a7dbb49 Add Instant.atZone() and Instant.atOffset() Fixes #201 ! src/share/classes/java/time/Instant.java ! test/java/time/tck/java/time/TCKInstant.java Changeset: e8bbb81d4e7a Author: scolebourne Date: 2013-01-24 16:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e8bbb81d4e7a Better Javadoc for atXxx() methods ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java Changeset: 3851eb56f652 Author: scolebourne Date: 2013-01-24 16:32 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3851eb56f652 Fix definition of Year.atMonthDay() to be symmetric with MonthDay Improve associated tests ! src/share/classes/java/time/Year.java ! test/java/time/tck/java/time/TCKYear.java Changeset: a067a16bdd5d Author: scolebourne Date: 2013-01-24 16:41 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a067a16bdd5d Add getMonthValue() to YearMonth and MonthDay Fixes #220 ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/YearMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKYearMonth.java From scolebourne at joda.org Thu Jan 24 08:52:02 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 16:52:02 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Change precision query to return TemporalUnit not ChronoUnit Message-ID: <20130124165232.0A9754751E@hg.openjdk.java.net> Changeset: 8cbbd29d987c Author: scolebourne Date: 2013-01-24 16:51 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8cbbd29d987c Change precision query to return TemporalUnit not ChronoUnit Fix Javadoc Fixes #204 ! src/share/classes/java/time/temporal/Queries.java From scolebourne at joda.org Thu Jan 24 09:12:56 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 24 Jan 2013 17:12:56 +0000 Subject: [threeten-dev] [threeten-develop] Review for Remove of OffsetDate In-Reply-To: <5101647D.9090109@oracle.com> References: <5101647D.9090109@oracle.com> Message-ID: The DateTimeFormatter comment has YearMonth when it shouldn't The Javadoc of all the classes below OffsetDate in the Ser class will need their javadoc updating in writeReplace(). The writeReplace() method specifies the ordinal index in the Ser class. Otherwise fine. Stephen On 24 January 2013 16:42, Roger Riggs wrote: > Please review: > http://cr.openjdk.java.net/~rriggs/webrev-nooffsetdate/ > > Resolves issue #228: Remove OffsetDate > > Thanks, Roger > > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From scolebourne at joda.org Thu Jan 24 09:20:33 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 17:20:33 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130124172141.2ED5847521@hg.openjdk.java.net> Changeset: 552b668aefe8 Author: scolebourne Date: 2013-01-24 16:57 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/552b668aefe8 Add @FunctionalInterface Fixes #196 ! src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalSubtractor.java Changeset: 5f1ceaf3fe72 Author: scolebourne Date: 2013-01-24 17:19 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5f1ceaf3fe72 Add LocalDate.atStartOfDay() Fixes #226 ! src/share/classes/java/time/LocalDate.java ! test/java/time/tck/java/time/TCKLocalDate.java From scolebourne at joda.org Thu Jan 24 10:12:44 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 18:12:44 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130124181317.F061C47526@hg.openjdk.java.net> Changeset: 29f0c07a9cd1 Author: scolebourne Date: 2013-01-24 18:01 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/29f0c07a9cd1 Add Instant.truncatedTo() Fixes #217 ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! test/java/time/tck/java/time/TCKInstant.java Changeset: 05c6a7ecdc73 Author: scolebourne Date: 2013-01-24 18:11 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/05c6a7ecdc73 Better specification and implementation of LocalTime truncatedTo Previous version was too lenient and effectively buggy, handilng a unit of 18 hours or 95 minutes weirdly. New definition is stricter but still handles all normal cases. ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZonedDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java From xueming.shen at oracle.com Thu Jan 24 10:22:51 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 24 Jan 2013 18:22:51 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130124182326.9211347528@hg.openjdk.java.net> Changeset: 61a2e4930bdd Author: sherman Date: 2013-01-24 10:21 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/61a2e4930bdd Removed -verbose when build tzdb.jar ! make/sun/tzdb/Makefile ! makefiles/GendataTZDB.gmk Changeset: 3a6cc52d81cb Author: sherman Date: 2013-01-24 10:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3a6cc52d81cb Merge - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java From roger.riggs at oracle.com Thu Jan 24 10:47:45 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 24 Jan 2013 18:47:45 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 4 new changesets Message-ID: <20130124184843.DE91F4752A@hg.openjdk.java.net> Changeset: 6b7f9b9117f7 Author: rriggs Date: 2013-01-24 13:10 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6b7f9b9117f7 Remove OffsetDate class See issue #228 ! src/share/classes/java/time/LocalDate.java - src/share/classes/java/time/OffsetDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/util/Formatter.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKMonthDay.java - test/java/time/tck/java/time/TCKOffsetDate.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java - test/java/time/test/java/time/TestOffsetDate.java ! test/java/time/test/java/time/TestOffsetDateTime_instants.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java ! test/java/time/test/java/util/TestFormatter.java Changeset: 4843b271b1cf Author: rriggs Date: 2013-01-24 13:21 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4843b271b1cf fix @link to ChronoLocalDate ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java Changeset: 5fb74e3b2bc1 Author: rriggs Date: 2013-01-24 13:45 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5fb74e3b2bc1 Merge ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/temporal/Queries.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java Changeset: 9e2f2510e485 Author: rriggs Date: 2013-01-24 13:47 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9e2f2510e485 Merge From scolebourne at joda.org Thu Jan 24 11:13:09 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 19:13:09 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130124191353.754EB4752B@hg.openjdk.java.net> Changeset: 09e48a11a3b4 Author: scolebourne Date: 2013-01-24 18:50 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/09e48a11a3b4 Add normalizedYearsToMonths(), rename normalizedMonthsIso() Makes a symettric pair as per days/hours. Allows user to calculate totalMonths(). Iso sufffix unecessary and intrusive with Javadoc. See #223 ! src/share/classes/java/time/Period.java ! test/java/time/test/java/time/TestPeriod.java Changeset: 22094a2641cc Author: scolebourne Date: 2013-01-24 19:02 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/22094a2641cc Create TCKPeriod using elements from TestPeriod + test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/test/java/time/TestPeriod.java Changeset: 1b374e7eab79 Author: scolebourne Date: 2013-01-24 19:03 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1b374e7eab79 Merge - src/share/classes/java/time/OffsetDate.java - test/java/time/tck/java/time/TCKOffsetDate.java - test/java/time/test/java/time/TestOffsetDate.java From scolebourne at joda.org Thu Jan 24 12:00:20 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 24 Jan 2013 20:00:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130124200053.844B54752D@hg.openjdk.java.net> Changeset: f70556339660 Author: scolebourne Date: 2013-01-24 19:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f70556339660 Add Javadoc to emphasise ISO nature of range() Fixes #199 ! src/share/classes/java/time/temporal/ChronoField.java Changeset: cec788cfce9b Author: scolebourne Date: 2013-01-24 19:59 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/cec788cfce9b Enhance Period.between() Javadoc and tests ! src/share/classes/java/time/Period.java ! test/java/time/test/java/time/TestPeriod.java From dunschtig at gmx.net Thu Jan 24 14:58:46 2013 From: dunschtig at gmx.net (Sascha Freitag) Date: Thu, 24 Jan 2013 23:58:46 +0100 Subject: [threeten-dev] A test case to consider In-Reply-To: <50FF54ED.8080606@Oracle.com> References: <50FEC0FC.9090301@oracle.com> <50FF54ED.8080606@Oracle.com> Message-ID: <5101BCA6.8060702@gmx.net> Hi this blog http://javaremarkables.blogspot.ch/2013/01/javautiltimezone.html entry describes an effect for which it would be valuable, to have a test case in the threeten suite from my point of view. Cheers Sascha From Roger.Riggs at oracle.com Thu Jan 24 15:03:27 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 24 Jan 2013 18:03:27 -0500 Subject: [threeten-dev] Rough draft of TemporalAmount Message-ID: <5101BDBF.4070301@oracle.com> Here's a rough draft of the java.time.temporal.TemporalAmount interface to unify Duration, Period, and SimplePeriod. It replaces TemporalAdder and TemporalSubtractor. The Temporal.plus and minus methods are modified to accept a TemporalAmount. The prose javadoc will need some elaboration in spots. Javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-temporalamount/ Webrev: http://cr.openjdk.java.net/~rriggs/webrev-temporalamount/ -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From yoshito_umaoka at us.ibm.com Thu Jan 24 15:15:22 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Thu, 24 Jan 2013 18:15:22 -0500 Subject: [threeten-dev] CLDR Islamic calendar types Message-ID: As I mentioned earlier, we're trying to define ids for Islamic calendar variants in CLDR. I did some investigation based on inputs including Dan's request, and posted the proposal for review here - http://cldr.unicode.org/development/development-process/design-proposals/islamic-calendar-types I requested CLDR technical committee members to review the proposal and we're planning to conclude this topic next week. If there are any objections or suggestions from three-ten community, please let me know. Thanks, Yoshito From scolebourne at joda.org Thu Jan 24 16:20:26 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 00:20:26 +0000 Subject: [threeten-dev] A test case to consider In-Reply-To: <5101BCA6.8060702@gmx.net> References: <50FEC0FC.9090301@oracle.com> <50FF54ED.8080606@Oracle.com> <5101BCA6.8060702@gmx.net> Message-ID: The equivalent class ZoneId is immutable. If you try to create one with an invalid ID, then an exception is thrown. This is tested for ;-) Stephen On 24 January 2013 22:58, Sascha Freitag wrote: > Hi > > this blog http://javaremarkables.blogspot.ch/2013/01/javautiltimezone.html > entry describes an effect for which it would be valuable, to have a test > case in the threeten suite from my point of view. > > Cheers Sascha > From scolebourne at joda.org Thu Jan 24 16:37:37 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 00:37:37 +0000 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: References: Message-ID: On 24 January 2013 23:15, wrote: > As I mentioned earlier, we're trying to define ids for Islamic calendar > variants in CLDR. > I did some investigation based on inputs including Dan's request, and > posted the proposal for review here - > > http://cldr.unicode.org/development/development-process/design-proposals/islamic-calendar-types > > I requested CLDR technical committee members to review the proposal and > we're planning to conclude this topic next week. > > If there are any objections or suggestions from three-ten community, > please let me know. My primary feedback is that LDML should include a clear definition of what each variation is. Ideally this would be detailed enough so someone could implement the calendar algorithm from the LDML document, but clear references to other documents would be a second best. Otherwise, this will be a good addition. Stephen From xueming.shen at oracle.com Thu Jan 24 17:40:15 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 24 Jan 2013 17:40:15 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> Message-ID: <5101E27F.9030604@oracle.com> The webrev has been changed to add an appendZoneText(style, String[] preferredZones) method to the builder. It works as expected so far. http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/ The disadvantage is that the pattern formatter can't take advantage of this. I'm not sure if this "preferred zones" should go into formatter/parsecontext. -Sherman From xueming.shen at oracle.com Thu Jan 24 18:45:53 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 24 Jan 2013 18:45:53 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: <5101E27F.9030604@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> <5101E27F.9030604@oracle.com> Message-ID: <5101F1E1.3000207@oracle.com> The cache definitely needs re-work. It's just getting messy. On 01/24/2013 05:40 PM, Xueming Shen wrote: > The webrev has been changed to add an appendZoneText(style, String[] preferredZones) > method to the builder. It works as expected so far. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/ > > The disadvantage is that the pattern formatter can't take advantage of this. I'm not > sure if this "preferred zones" should go into formatter/parsecontext. > > -Sherman From masayoshi.okutsu at oracle.com Thu Jan 24 23:29:46 2013 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Fri, 25 Jan 2013 07:29:46 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added getCalendarProperties to sun.util.calendar.CalendarSystem to get a Message-ID: <20130125073015.14CEB47552@hg.openjdk.java.net> Changeset: b623c5b7ee55 Author: okutsu Date: 2013-01-25 16:28 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b623c5b7ee55 Added getCalendarProperties to sun.util.calendar.CalendarSystem to get a Properties from lib/calendars.properties. ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java From xueming.shen at oracle.com Fri Jan 25 00:08:53 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 00:08:53 -0800 Subject: [threeten-dev] default ZoneRulesProvider and the system property for it. Message-ID: <51023D95.7030907@oracle.com> Stephen, Here is the webrev to define the default zone-rule provider and introduce in the system property java.time.zone.DefaultZoneRulesProvider. http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider -sherman From scolebourne at joda.org Fri Jan 25 03:34:49 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 11:34:49 +0000 Subject: [threeten-dev] zidtext parser In-Reply-To: <5101E27F.9030604@oracle.com> References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> <5101E27F.9030604@oracle.com> Message-ID: Typo - "America/New_Work" -> America/New_York The argument should not be an array (310 doesn't use arrays in APIs). A Set looks more appropriate. Since you validate all the strings anyway, it looks like it would be best to pass in a Set? The internal variable in ZoneTextPrinterParser for the Set should be final for immutability. I tend to include the name of the data provider in the name of the method in the test case. So data_preferredZones() rather than provider_text() Stephen On 25 January 2013 01:40, Xueming Shen wrote: > The webrev has been changed to add an appendZoneText(style, String[] > preferredZones) > method to the builder. It works as expected so far. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/ > > The disadvantage is that the pattern formatter can't take advantage of this. > I'm not > sure if this "preferred zones" should go into formatter/parsecontext. > > -Sherman From scolebourne at joda.org Fri Jan 25 03:49:06 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 11:49:06 +0000 Subject: [threeten-dev] [threeten-develop] default ZoneRulesProvider and the system property for it. In-Reply-To: <51023D95.7030907@oracle.com> References: <51023D95.7030907@oracle.com> Message-ID: Typo "dfined " -> defined Typo "provoder " -> provider (twice) Can we in theory get rid of the "java.time.zone.tzdbjar" property now as well since the JDK contains the jar? Stephen On 25 January 2013 08:08, Xueming Shen wrote: > Stephen, > > Here is the webrev to define the default zone-rule provider and introduce > in the system property java.time.zone.DefaultZoneRulesProvider. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider > > -sherman > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop From Roger.Riggs at oracle.com Fri Jan 25 06:12:52 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 09:12:52 -0500 Subject: [threeten-dev] default ZoneRulesProvider and the system property for it. In-Reply-To: <51023D95.7030907@oracle.com> References: <51023D95.7030907@oracle.com> Message-ID: <510292E4.6070503@oracle.com> Hi Sherman, Why the use of reflection to instantiate the provider? Isn't class.newInstance() sufficient. Also, is it standard practice to put these inside doPrivileged? It would seem to be a security risk. I would want the constructor to have to do its own doPriv to get elevated access to files, etc. Thanks, Roger On 1/25/2013 3:08 AM, Xueming Shen wrote: > Stephen, > > Here is the webrev to define the default zone-rule provider and introduce > in the system property java.time.zone.DefaultZoneRulesProvider. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider > > -sherman From kurchi.subhra.hazra at oracle.com Wed Jan 16 11:50:27 2013 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Wed, 16 Jan 2013 11:50:27 -0800 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F5F08D.5000008@oracle.com> References: <50F5F08D.5000008@oracle.com> Message-ID: <50F70483.9090202@oracle.com> Hi Sherman, As I was telling you, I had a very minor comment - the javadoc for the enums DayOfWeek and Month shows the days/months in alphabetical order. I am not sure if it is somehow possible to bypass that and show them in the order of their occurrence instead. Thanks, - Kurchi On 15.01.2013 16:13, Xueming Shen wrote: > Hi, > > The Threeten project [1] is planned to be integrated into OpenJDK8 M6 > milestone. > > Here is the webrev > http://cr.openjdk.java.net/~sherman/8003680/webrev > > and the latest javadoc > http://cr.openjdk.java.net/~sherman/8003680/javadoc > > Review comments can be sent to the threeten-dev email list [2] and/or > core-libs-dev email list[3]. > > Thanks, > Sherman > > [1] http://openjdk.java.net/projects/threeten > [2] threeten-dev @ openjdk.java.net > [3] core-libs-dev @ openjdk.java.net > > -- -Kurchi From Roger.Riggs at oracle.com Fri Jan 25 07:00:53 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 10:00:53 -0500 Subject: [threeten-dev] Non-webrev: Patch for int factories, issue #227 In-Reply-To: References: Message-ID: <51029E25.3020301@oracle.com> Hi Stephen, This looks fine. BTW, the OpenJDK mailing lists strip attachments, patches will need to be inlined or posted somewhere and a link provided. Roger On 1/24/2013 8:22 PM, Stephen Colebourne wrote: > Experience has shown me repeatedly that not having int factories makes > some coding, notably tests, significantly worse. > > This patch adds one int-based factory to each of OT/ODT/ZDT. This > satisfies the testing needs without exploding the method count. > > Stephen > (patch attached, hopefully its received) From misterm at gmail.com Fri Jan 25 07:07:02 2013 From: misterm at gmail.com (Michael Nascimento) Date: Fri, 25 Jan 2013 13:07:02 -0200 Subject: [threeten-dev] Non-webrev: Patch for int factories, issue #227 In-Reply-To: <51029E25.3020301@oracle.com> References: <51029E25.3020301@oracle.com> Message-ID: On Fri, Jan 25, 2013 at 1:00 PM, Roger Riggs wrote: > BTW, the OpenJDK mailing lists strip attachments, patches will need to be > inlined > or posted somewhere and a link provided. I got the attachment, is the problem maybe your corporate email? Regards, Michael From scolebourne at joda.org Fri Jan 25 07:10:31 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 15:10:31 +0000 Subject: [threeten-dev] Non-webrev: Patch for int factories, issue #227 In-Reply-To: References: <51029E25.3020301@oracle.com> Message-ID: I moderated it through to the sourceforge list. The openjdk list is the problem, but not while we have sourceforge... Stephen On 25 January 2013 15:07, Michael Nascimento wrote: > On Fri, Jan 25, 2013 at 1:00 PM, Roger Riggs wrote: >> BTW, the OpenJDK mailing lists strip attachments, patches will need to be >> inlined >> or posted somewhere and a link provided. > > I got the attachment, is the problem maybe your corporate email? > > Regards, > Michael From Roger.Riggs at oracle.com Fri Jan 25 07:21:26 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 10:21:26 -0500 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> Message-ID: <5102A2F6.5040009@oracle.com> Hi, On 1/25/2013 10:02 AM, Stephen Colebourne wrote: > On 25 January 2013 14:48, Roger Riggs wrote: >> On 1/24/2013 7:31 PM, Stephen Colebourne wrote: >> The Amount interface has two different kinds of tag on >> addTo/subtractFrom. >> >> I didn't see the difference, these are retained from adder/subtractor > Looks like they are both

but the output Javadoc shows them > differently. Weird. No too puzzling, I generated the javadoc using the custom stylesheet.css that we/you modified to highlight the implementation notes. The SE 8 javadoc has done a revamp of the stylesheet. I'll revert the handy ant javadoc creator task to use the default stylesheet and remove the custom one.. >> I think its an interesting question as to whether the units of period are >> y/m/d/h/m/s/n or y/m/d/nanos. The latter is the minimum set of data, and >> better describes the internals, but might make a formatter harder to write. >> I guess a user might assume h/m/s/n, so maybe its OK how it is. >> >> Period provides methods for all of those components and it seems >> reasonable that >> the same would be available as fields. For example, MICROS, MILLIS, >> HALF_DAYS; >> but for some units it would need to define rounding/truncation. >> The plus and minus methods go further and support any timeunit that is >> not estimated. If plus/minus are going to support the richer set of >> units perhaps >> get should also. But then at the moment a simpler is better (quicker). >> >> It is possible to convert to any arbitrary extensible unit through the use >> of TemporalUnit.getDuration. Though this would apply only to SimplePeriod. > I think that the conversions lead us to implement more code now, code > that we don't really know enough about. For example Duration would > also have to support MILLIS/MICROS etc. > > So, the simplest option is > Duration = SECONDS + NANOS > Period + YEARS + MONTHS + DAYS + NANOS The javadoc for Period describes itself has supporting the most commonly used units including "time units with an exact duration". To be consistent get(unit) should follow that pattern. The Period supplying y/m/d/h/m/s/n is trivial and already implemented and tested. Roger > We can add additional conversions in JDK 1.9 if the javadoc is careful. > > Stephen > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From scolebourne at joda.org Fri Jan 25 07:54:06 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 15:54:06 +0000 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: <5102A2F6.5040009@oracle.com> References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> <5102A2F6.5040009@oracle.com> Message-ID: On 25 January 2013 15:21, Roger Riggs wrote: > So, the simplest option is > Duration = SECONDS + NANOS > Period + YEARS + MONTHS + DAYS + NANOS > > The javadoc for Period describes itself has supporting the most commonly > used units > including "time units with an exact duration". To be consistent get(unit) > should follow > that pattern. I think that we need to require that the combination of getUnits() and get() returns the complete state of the object. A Period is an amount, created by adding the total of years, months days and time (in nanos). A user querying the period should be able to get the total "amount". If hours/minutes/seconds are supported, then get(HOURS)+get(MINUTES)+get(SECONDS)+get(NANOS) should be the total amount, and all other units would be an error. The alternate model for the interface is that it is just a "friendly" get, like Temporal, that returns as much as it can. But we don't have the rest of the infrastructure to do that in terms of converting a user type of HALF_YEARS from the provided type of YEARS. Given that there are multiple choices this gets tricky. (I note again that adding this interface is risky because we don't have the use cases to validate it. Adder and Subtractor are safe and cannot be wrong. This interface may well not be what we really need, forcing a TemporalAmount2 in the future) I would say that these models: Period = YEARS + MONTHS + DAYS + NANOS Period = YEARS + MONTHS + DAYS + HOURS + MINUTES(excluding hours) + SECONDS(excl hr/min) + NANOS(excl hr/min/sec) provides sufficient data for later default interface methods. (ie. where only the above units can be queried.) The former is a more accurate representation of the state of the class and easier for framework code to work with. The latter is more designed for human code. The choice of providing a general conversion mechanism using durations in get(Unit) may be nice for users, but it would be non-extensible in future JDKs (default interface methods would have insufficient information to work with). Given all this, I think Period = YEARS + MONTHS + DAYS + NANOS is the simplest model. But since its not very user friendly, it may be best to return it as a Map, or to rename get(Unit) to something less attractive. Stephen From xueming.shen at oracle.com Fri Jan 25 08:07:54 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 08:07:54 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> <5101E27F.9030604@oracle.com> Message-ID: <5102ADDA.5080800@oracle.com> On 1/25/13 3:34 AM, Stephen Colebourne wrote: > Typo - "America/New_Work" -> America/New_York > > The argument should not be an array (310 doesn't use arrays in APIs). > A Set looks more appropriate. > > Since you validate all the strings anyway, it looks like it would be > best to pass in a Set? It was Set at my first round, but I changed to String[] when I realized you have to write something like new HashMapArrays.asList(new String[]{...})) for the test case. Guess a straightforward String[] may be preferred. But, yes I can switched back to Set if it fits the rest of 310 well. > > The internal variable in ZoneTextPrinterParser for the Set should be > final for immutability. > > I tend to include the name of the data provider in the name of the > method in the test case. So data_preferredZones() rather than > provider_text() > > Stephen > > > On 25 January 2013 01:40, Xueming Shen wrote: >> The webrev has been changed to add an appendZoneText(style, String[] >> preferredZones) >> method to the builder. It works as expected so far. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/ >> >> The disadvantage is that the pattern formatter can't take advantage of this. >> I'm not >> sure if this "preferred zones" should go into formatter/parsecontext. >> >> -Sherman From xueming.shen at oracle.com Fri Jan 25 08:09:25 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 08:09:25 -0800 Subject: [threeten-dev] [threeten-develop] default ZoneRulesProvider and the system property for it. In-Reply-To: References: <51023D95.7030907@oracle.com> Message-ID: <5102AE35.4030202@oracle.com> On 1/25/13 3:49 AM, Stephen Colebourne wrote: > Typo "dfined " -> defined > Typo "provoder " -> provider (twice) > > Can we in theory get rid of the "java.time.zone.tzdbjar" property now > as well since the JDK contains the jar? Yes, it can and should go away, if you guys no longer need it for testing outside of JDK. I put it there for the convenience of using the ant script to test... > > Stephen > > > On 25 January 2013 08:08, Xueming Shen wrote: >> Stephen, >> >> Here is the webrev to define the default zone-rule provider and introduce >> in the system property java.time.zone.DefaultZoneRulesProvider. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >> >> -sherman >> >> ------------------------------------------------------------------------------ >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >> MVPs and experts. ON SALE this month only -- learn more at: >> http://p.sf.net/sfu/learnnow-d2d >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop From Roger.Riggs at oracle.com Fri Jan 25 08:11:57 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 11:11:57 -0500 Subject: [threeten-dev] [threeten-develop] default ZoneRulesProvider and the system property for it. In-Reply-To: <5102AE35.4030202@oracle.com> References: <51023D95.7030907@oracle.com> <5102AE35.4030202@oracle.com> Message-ID: <5102AECD.6040706@oracle.com> Removing the override property is fine with me. On 1/25/2013 11:09 AM, Xueming Shen wrote: > On 1/25/13 3:49 AM, Stephen Colebourne wrote: >> ... >> >> Can we in theory get rid of the "java.time.zone.tzdbjar" property now >> as well since the JDK contains the jar? > Yes, it can and should go away, if you guys no longer need it for > testing outside of > JDK. I put it there for the convenience of using the ant script to > test... > >> >> Stephen >> >> >> On 25 January 2013 08:08, Xueming Shen wrote: >>> Stephen, >>> >>> Here is the webrev to define the default zone-rule provider and >>> introduce >>> in the system property java.time.zone.DefaultZoneRulesProvider. >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >>> >>> -sherman >>> From douglas.surber at oracle.com Fri Jan 25 08:14:58 2013 From: douglas.surber at oracle.com (Douglas Surber) Date: Fri, 25 Jan 2013 08:14:58 -0800 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> <5102A2F6.5040009@oracle.com> Message-ID: <6.2.5.6.2.20130125081102.050b1a30@oracle.com> ANSI SQL specifies INTERVAL DAY to have the fields hours, minutes, second including fractional seconds. Since one of the major use cases for Period is to support JDBC/SQL that suggests that Period should be defined as h/m/s/n. While not strictly necessary, it would be more consonant with the expectations of JDBC users. Douglas At 07:54 AM 1/25/2013, Stephen Colebourne wrote: >On 25 January 2013 15:21, Roger Riggs >wrote: > > So, the simplest option is > > Duration = SECONDS + NANOS > > Period + YEARS + MONTHS + DAYS + NANOS > > > > The javadoc for Period describes itself has supporting the most > commonly > > used units > > including "time units with an exact duration". To be consistent > get(unit) > > should follow > > that pattern. > >I think that we need to require that the combination of getUnits() >and >get() returns the complete state of the object. > >A Period is an amount, created by adding the total of years, months >days and time (in nanos). A user querying the period should be able >to >get the total "amount". If hours/minutes/seconds are supported, then >get(HOURS)+get(MINUTES)+get(SECONDS)+get(NANOS) should be the total >amount, and all other units would be an error. > >The alternate model for the interface is that it is just a >"friendly" >get, like Temporal, that returns as much as it can. But we don't >have >the rest of the infrastructure to do that in terms of converting a >user type of HALF_YEARS from the provided type of YEARS. > >Given that there are multiple choices this gets tricky. > >(I note again that adding this interface is risky because we don't >have the use cases to validate it. Adder and Subtractor are safe and >cannot be wrong. This interface may well not be what we really need, >forcing a TemporalAmount2 in the future) > >I would say that these models: > Period = YEARS + MONTHS + DAYS + NANOS > Period = YEARS + MONTHS + DAYS + HOURS + MINUTES(excluding hours) > + >SECONDS(excl hr/min) + NANOS(excl hr/min/sec) >provides sufficient data for later default interface methods. (ie. >where only the above units can be queried.) The former is a more >accurate representation of the state of the class and easier for >framework code to work with. The latter is more designed for human >code. > >The choice of providing a general conversion mechanism using >durations >in get(Unit) may be nice for users, but it would be non-extensible >in >future JDKs (default interface methods would have insufficient >information to work with). > > >Given all this, I think Period = YEARS + MONTHS + DAYS + NANOS is >the >simplest model. But since its not very user friendly, it may be best >to return it as a Map, or to rename get(Unit) to >something >less attractive. > >Stephen > >------------------------------------------------------------------------------ >Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >MVC, Windows 8 Apps, JavaScript and much more. Keep your skills >current >with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >MVPs and experts. ON SALE this month only -- learn more at: >http://p.sf.net/sfu/learnnow-d2d >_______________________________________________ >threeten-develop mailing list >threeten-develop at lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/threeten-develop From scolebourne at joda.org Fri Jan 25 08:25:48 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Fri, 25 Jan 2013 16:25:48 +0000 Subject: [threeten-dev] [threeten-develop] default ZoneRulesProvider and the system property for it. In-Reply-To: <5102AECD.6040706@oracle.com> References: <51023D95.7030907@oracle.com> <5102AE35.4030202@oracle.com> <5102AECD.6040706@oracle.com> Message-ID: Fine by me. My tests run in IntelliJ without the override flag. Stephen On 25 January 2013 16:11, Roger Riggs wrote: > Removing the override property is fine with me. > > > On 1/25/2013 11:09 AM, Xueming Shen wrote: >> >> On 1/25/13 3:49 AM, Stephen Colebourne wrote: >>> >>> ... >>> >>> >>> Can we in theory get rid of the "java.time.zone.tzdbjar" property now >>> as well since the JDK contains the jar? >> >> Yes, it can and should go away, if you guys no longer need it for testing >> outside of >> JDK. I put it there for the convenience of using the ant script to test... >> >>> >>> Stephen >>> >>> >>> On 25 January 2013 08:08, Xueming Shen wrote: >>>> >>>> Stephen, >>>> >>>> Here is the webrev to define the default zone-rule provider and >>>> introduce >>>> in the system property java.time.zone.DefaultZoneRulesProvider. >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >>>> >>>> -sherman >>>> > From scolebourne at joda.org Fri Jan 25 08:33:31 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 25 Jan 2013 16:33:31 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130125163520.D8B6047560@hg.openjdk.java.net> Changeset: 4fd5db040e3d Author: scolebourne Date: 2013-01-25 15:58 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4fd5db040e3d Add int-based factory methods for OT/ODT/ZDT This makes testing code much clearer Fixes #227 ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZonedDateTime.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java Changeset: 520fc6220e41 Author: scolebourne Date: 2013-01-25 16:24 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/520fc6220e41 Remove OffsetDateTIme.of(ZonedDateTime) Fixes #230 ! src/share/classes/java/time/OffsetDateTime.java ! test/java/time/test/java/util/TestFormatter.java From scolebourne at joda.org Fri Jan 25 09:25:20 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 25 Jan 2013 17:25:20 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Add ZonedDateTime.of(LD, LT, ZI) Message-ID: <20130125172555.929D24756C@hg.openjdk.java.net> Changeset: 54e1dd6df096 Author: scolebourne Date: 2013-01-25 17:24 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/54e1dd6df096 Add ZonedDateTime.of(LD,LT,ZI) Balances with similar method on ODT and makes some user code easier Fixes #225 ! src/share/classes/java/time/ZonedDateTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java From scolebourne at joda.org Fri Jan 25 10:24:26 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 25 Jan 2013 18:24:26 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130125182529.1A4E947572@hg.openjdk.java.net> Changeset: 90336ff31c9c Author: scolebourne Date: 2013-01-25 18:08 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/90336ff31c9c Add LocalDate.atTime(OffsetTime) A useful combination that should be provided See #224 ! src/share/classes/java/time/LocalDate.java ! test/java/time/tck/java/time/TCKLocalDate.java Changeset: 9da2f38b6229 Author: scolebourne Date: 2013-01-25 18:10 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9da2f38b6229 Add Period.with(Duration) Works with toDuration() and of(Duration) See #223 ! src/share/classes/java/time/Period.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/test/java/time/TestPeriod.java From xueming.shen at oracle.com Fri Jan 25 12:24:33 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 12:24:33 -0800 Subject: [threeten-dev] zidtext parser In-Reply-To: References: <50E5F132.7000302@oracle.com> <50E70B5E.1050904@oracle.com> <50EF7C71.4020508@oracle.com> <50F3532B.90807@oracle.com> <5101E27F.9030604@oracle.com> Message-ID: <5102EA01.4010404@oracle.com> Webrev has been updated accordingly. It appears the most efficient place for the cache for the combination of is the formatter itself? Most of the caching complicity come from the combination of which are the fixed status for a particular formatter. The impl now does not clone the printerparser list for withXXXXX() though, so the printerparser-s get shared...we can address this one later. -Sherman On 01/25/2013 03:34 AM, Stephen Colebourne wrote: > Typo - "America/New_Work" -> America/New_York > > The argument should not be an array (310 doesn't use arrays in APIs). > A Set looks more appropriate. > > Since you validate all the strings anyway, it looks like it would be > best to pass in a Set? > > The internal variable in ZoneTextPrinterParser for the Set should be > final for immutability. > > I tend to include the name of the data provider in the name of the > method in the test case. So data_preferredZones() rather than > provider_text() > > Stephen > > > On 25 January 2013 01:40, Xueming Shen wrote: >> The webrev has been changed to add an appendZoneText(style, String[] >> preferredZones) >> method to the builder. It works as expected so far. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/ztext_parser/ >> >> The disadvantage is that the pattern formatter can't take advantage of this. >> I'm not >> sure if this "preferred zones" should go into formatter/parsecontext. >> >> -Sherman From Roger.Riggs at oracle.com Fri Jan 25 13:12:19 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 16:12:19 -0500 Subject: [threeten-dev] Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50F70483.9090202@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F70483.9090202@oracle.com> Message-ID: <5102F533.9020503@oracle.com> Hi Kuchi, Javadoc always alphabetizes the summary sections. But if you scroll down you'll see them in declaration order. Roger On 1/16/2013 2:50 PM, Kurchi Hazra wrote: > Hi Sherman, > > As I was telling you, I had a very minor comment - the javadoc for the > enums DayOfWeek and Month shows the days/months in alphabetical order. > I am not sure if it is somehow possible to bypass that and show them > in the order of their occurrence instead. > > Thanks, > - Kurchi > > On 15.01.2013 16:13, Xueming Shen wrote: >> Hi, >> >> The Threeten project [1] is planned to be integrated into OpenJDK8 M6 >> milestone. >> >> Here is the webrev >> http://cr.openjdk.java.net/~sherman/8003680/webrev >> >> and the latest javadoc >> http://cr.openjdk.java.net/~sherman/8003680/javadoc >> >> Review comments can be sent to the threeten-dev email list [2] and/or >> core-libs-dev email list[3]. >> >> Thanks, >> Sherman >> >> [1] http://openjdk.java.net/projects/threeten >> [2] threeten-dev @ openjdk.java.net >> [3] core-libs-dev @ openjdk.java.net >> >> > -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From xueming.shen at oracle.com Fri Jan 25 14:31:21 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 14:31:21 -0800 Subject: [threeten-dev] default ZoneRulesProvider and the system property for it. In-Reply-To: <510292E4.6070503@oracle.com> References: <51023D95.7030907@oracle.com> <510292E4.6070503@oracle.com> Message-ID: <510307B9.2060402@oracle.com> webrev has been updated (1) used class.newInstance() directly (2) added a check for the possible duplicated provider installation, such as the provider jar is either in the extension dir or the classpath, and it is being specified via -Djava.time.zone.DefaultZoneRulesProvider (it appears the "loaded" was an empty list, never got updated in old code) (3) took out the java.time.zone.tzdbjar property support, as agreed. The the specified provider is still being loaded inside doPrivileged block for now. There is an ongoing discussion on this one, may take it out of the block later. -Sherman On 1/25/13 6:12 AM, Roger Riggs wrote: > Hi Sherman, > > Why the use of reflection to instantiate the provider? Isn't > class.newInstance() sufficient. > > Also, is it standard practice to put these inside doPrivileged? It > would seem > to be a security risk. I would want the constructor to have to do its > own doPriv > to get elevated access to files, etc. > > Thanks, Roger > > > On 1/25/2013 3:08 AM, Xueming Shen wrote: >> Stephen, >> >> Here is the webrev to define the default zone-rule provider and >> introduce >> in the system property java.time.zone.DefaultZoneRulesProvider. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >> >> -sherman > From Roger.Riggs at oracle.com Fri Jan 25 14:45:31 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Fri, 25 Jan 2013 17:45:31 -0500 Subject: [threeten-dev] default ZoneRulesProvider and the system property for it. In-Reply-To: <510307B9.2060402@oracle.com> References: <51023D95.7030907@oracle.com> <510292E4.6070503@oracle.com> <510307B9.2060402@oracle.com> Message-ID: <51030B0B.6040204@oracle.com> Hi Sherman, In TzdbZoneRulesProvider.java can you remove this, it looks ineffective since the libDir is not saved or re-used and is not updated if an exception occurs. 159: "try { libDir = FileSystems.getDefault().getPath(libDir).toRealPath().toString(); } catch(Exception e) {}" The rest looks fine. Roger On 1/25/2013 5:31 PM, Xueming Shen wrote: > webrev has been updated > > (1) used class.newInstance() directly > (2) added a check for the possible duplicated provider installation, such > as the provider jar is either in the extension dir or the > classpath, and > it is being specified via -Djava.time.zone.DefaultZoneRulesProvider > (it appears the "loaded" was an empty list, never got updated in old > code) > (3) took out the java.time.zone.tzdbjar property support, as agreed. > > The the specified provider is still being loaded inside doPrivileged > block > for now. There is an ongoing discussion on this one, may take it out > of the block later. > > -Sherman > > On 1/25/13 6:12 AM, Roger Riggs wrote: >> Hi Sherman, >> >> Why the use of reflection to instantiate the provider? Isn't >> class.newInstance() sufficient. >> >> Also, is it standard practice to put these inside doPrivileged? It >> would seem >> to be a security risk. I would want the constructor to have to do >> its own doPriv >> to get elevated access to files, etc. >> >> Thanks, Roger >> >> >> On 1/25/2013 3:08 AM, Xueming Shen wrote: >>> Stephen, >>> >>> Here is the webrev to define the default zone-rule provider and >>> introduce >>> in the system property java.time.zone.DefaultZoneRulesProvider. >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >>> >>> -sherman >> > -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From dan.chiba at oracle.com Fri Jan 25 14:50:53 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Fri, 25 Jan 2013 14:50:53 -0800 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: References: Message-ID: <51030C4D.60008@oracle.com> The proposal looks great. We updated the variant ID for Umm Al-Qura from "uaq" to "umalqura" to match your proposal. May I ask why there is a padding on "sa" for Saudi Arabia and it becomes "cv-sa0"? I agree with Stephen that ideally each variant should have a full specification. I wonder if LDML could simply say the cv value should be one of the externally defined standard formal variant identifiers. And then there could be a separate registry that assigns the formal ID and specifies the variants or provides reference. I think this may take some time to establish and we can manually maintain the formal values for the time being. Regards, -Dan On 1/24/2013 4:37 PM, Stephen Colebourne wrote: > On 24 January 2013 23:15, wrote: >> As I mentioned earlier, we're trying to define ids for Islamic calendar >> variants in CLDR. >> I did some investigation based on inputs including Dan's request, and >> posted the proposal for review here - >> >> http://cldr.unicode.org/development/development-process/design-proposals/islamic-calendar-types >> >> I requested CLDR technical committee members to review the proposal and >> we're planning to conclude this topic next week. >> >> If there are any objections or suggestions from three-ten community, >> please let me know. > My primary feedback is that LDML should include a clear definition of > what each variation is. Ideally this would be detailed enough so > someone could implement the calendar algorithm from the LDML document, > but clear references to other documents would be a second best. > > Otherwise, this will be a good addition. > > Stephen From xueming.shen at oracle.com Fri Jan 25 14:54:24 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 25 Jan 2013 14:54:24 -0800 Subject: [threeten-dev] default ZoneRulesProvider and the system property for it. In-Reply-To: <51030B0B.6040204@oracle.com> References: <51023D95.7030907@oracle.com> <510292E4.6070503@oracle.com> <510307B9.2060402@oracle.com> <51030B0B.6040204@oracle.com> Message-ID: <51030D20.5010303@oracle.com> Done! webrev updated. On 1/25/13 2:45 PM, Roger Riggs wrote: > Hi Sherman, > > In TzdbZoneRulesProvider.java can you remove this, it looks > ineffective since > the libDir is not saved or re-used and is not updated if an exception > occurs. > > 159: "try { > libDir = > FileSystems.getDefault().getPath(libDir).toRealPath().toString(); > } catch(Exception e) {}" > > > The rest looks fine. > > Roger > > > > > On 1/25/2013 5:31 PM, Xueming Shen wrote: >> webrev has been updated >> >> (1) used class.newInstance() directly >> (2) added a check for the possible duplicated provider installation, >> such >> as the provider jar is either in the extension dir or the >> classpath, and >> it is being specified via -Djava.time.zone.DefaultZoneRulesProvider >> (it appears the "loaded" was an empty list, never got updated in old >> code) >> (3) took out the java.time.zone.tzdbjar property support, as agreed. >> >> The the specified provider is still being loaded inside doPrivileged >> block >> for now. There is an ongoing discussion on this one, may take it out >> of the block later. >> >> -Sherman >> >> On 1/25/13 6:12 AM, Roger Riggs wrote: >>> Hi Sherman, >>> >>> Why the use of reflection to instantiate the provider? Isn't >>> class.newInstance() sufficient. >>> >>> Also, is it standard practice to put these inside doPrivileged? It >>> would seem >>> to be a security risk. I would want the constructor to have to do >>> its own doPriv >>> to get elevated access to files, etc. >>> >>> Thanks, Roger >>> >>> >>> On 1/25/2013 3:08 AM, Xueming Shen wrote: >>>> Stephen, >>>> >>>> Here is the webrev to define the default zone-rule provider and >>>> introduce >>>> in the system property java.time.zone.DefaultZoneRulesProvider. >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/zrProvider >>>> >>>> -sherman >>> >> > From xueming.shen at oracle.com Fri Jan 25 15:00:39 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 25 Jan 2013 23:00:39 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Added support for zone text parser Message-ID: <20130125230103.2808547584@hg.openjdk.java.net> Changeset: 616fc59438c2 Author: sherman Date: 2013-01-25 15:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/616fc59438c2 Added support for zone text parser Added support for system proerty java.time.zone.DefaultZoneRulesProvider ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/ZoneName.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/format/ZoneName.java From Roger.Riggs at oracle.com Sat Jan 26 11:10:37 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Sat, 26 Jan 2013 14:10:37 -0500 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> <5102A2F6.5040009@oracle.com> Message-ID: <51042A2D.2040901@oracle.com> Hi, Some revisions and comments inline: javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-temporalamount/ webrev: http://cr.openjdk.java.net/~rriggs/webrev-temporalamount/ On 1/25/2013 10:54 AM, Stephen Colebourne wrote: > On 25 January 2013 15:21, Roger Riggs wrote: >> So, the simplest option is >> Duration = SECONDS + NANOS >> Period + YEARS + MONTHS + DAYS + NANOS >> >> The javadoc for Period describes itself has supporting the most commonly >> used units >> including "time units with an exact duration". To be consistent get(unit) >> should follow >> that pattern. > I think that we need to require that the combination of getUnits() and > get() returns the complete state of the object. > > A Period is an amount, created by adding the total of years, months > days and time (in nanos). A user querying the period should be able to > get the total "amount". If hours/minutes/seconds are supported, then > get(HOURS)+get(MINUTES)+get(SECONDS)+get(NANOS) should be the total > amount, and all other units would be an error. right > > The alternate model for the interface is that it is just a "friendly" > get, like Temporal, that returns as much as it can. But we don't have > the rest of the infrastructure to do that in terms of converting a > user type of HALF_YEARS from the provided type of YEARS. All Units have a Duration, sometimes estimated that can be used for conversions if deemed necessary. > > Given that there are multiple choices this gets tricky. > > (I note again that adding this interface is risky because we don't > have the use cases to validate it. Adder and Subtractor are safe and > cannot be wrong. This interface may well not be what we really need, > forcing a TemporalAmount2 in the future) > > I would say that these models: > Period = YEARS + MONTHS + DAYS + NANOS > Period = YEARS + MONTHS + DAYS + HOURS + MINUTES(excluding hours) + > SECONDS(excl hr/min) + NANOS(excl hr/min/sec) > provides sufficient data for later default interface methods. (ie. > where only the above units can be queried.) The former is a more > accurate representation of the state of the class and easier for > framework code to work with. The latter is more designed for human > code. Period is defined to be the 7 values that make up the amount and with the Units and Durations the caller can convert to any desired Unit. > > The choice of providing a general conversion mechanism using durations > in get(Unit) may be nice for users, but it would be non-extensible in > future JDKs (default interface methods would have insufficient > information to work with). The methods getUnits and get(unit) provide a complete picture of the TemporalAmount (as long as there is no overlap between the units) any caller can iterate over the supported Units and get the total value. And the missing information is? For example, the default method for addTo(Temporal) might be: Temporal plus(Temporal t) { Temporal accum = t; for (TemporalUnit unit: this.getUnits()) { long v = this.get(unit); if (v != 0) { accum = accum.plus(v, unit); } } return accum; } Changing getUnits to return List and returning them in decreasing duration will allow predicable use and results. > > > Given all this, I think Period = YEARS + MONTHS + DAYS + NANOS is the > simplest model. But since its not very user friendly, it may be best > to return it as a Map, or to rename get(Unit) to something > less attractive. The TemporalAmount is already effectively a Map. Roger From scolebourne at joda.org Sat Jan 26 14:45:20 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sat, 26 Jan 2013 22:45:20 +0000 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: <51042A2D.2040901@oracle.com> References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> <5102A2F6.5040009@oracle.com> <51042A2D.2040901@oracle.com> Message-ID: On 26 January 2013 19:10, Roger Riggs wrote: > Some revisions and comments inline: > > javadoc: > http://cr.openjdk.java.net/~rriggs/javadoc-temporalamount/ > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-temporalamount/ SimplePeriod getUnits should use Collections.singletonList Duration.getUnits() should use a nested class, like in Integer (IntegerCache). The first Javadoc change in Period is wrong. The proposed default implementation of addTo() makes sense and is the goal I want to achieve. I'm happy enough with a list of units (defined as largest to smallest), accessible via get(Unit). This definition will correctly scale for future JDK releases. We shouldn't preclude adding addition conversions into the get(Unit) method with the initial Javadoc. ie. in JDK 1.8 get(MILLIS) -> exception, but in JDK 1.9 it returns get(NANOS)/1,000,000 Stephen > On 1/25/2013 10:54 AM, Stephen Colebourne wrote: >> On 25 January 2013 15:21, Roger Riggs wrote: >>> So, the simplest option is >>> Duration = SECONDS + NANOS >>> Period + YEARS + MONTHS + DAYS + NANOS >>> >>> The javadoc for Period describes itself has supporting the most commonly >>> used units >>> including "time units with an exact duration". To be consistent get(unit) >>> should follow >>> that pattern. >> I think that we need to require that the combination of getUnits() and >> get() returns the complete state of the object. >> >> A Period is an amount, created by adding the total of years, months >> days and time (in nanos). A user querying the period should be able to >> get the total "amount". If hours/minutes/seconds are supported, then >> get(HOURS)+get(MINUTES)+get(SECONDS)+get(NANOS) should be the total >> amount, and all other units would be an error. > right >> >> The alternate model for the interface is that it is just a "friendly" >> get, like Temporal, that returns as much as it can. But we don't have >> the rest of the infrastructure to do that in terms of converting a >> user type of HALF_YEARS from the provided type of YEARS. > All Units have a Duration, sometimes estimated that can be used for > conversions > if deemed necessary. >> >> Given that there are multiple choices this gets tricky. >> >> (I note again that adding this interface is risky because we don't >> have the use cases to validate it. Adder and Subtractor are safe and >> cannot be wrong. This interface may well not be what we really need, >> forcing a TemporalAmount2 in the future) >> >> I would say that these models: >> Period = YEARS + MONTHS + DAYS + NANOS >> Period = YEARS + MONTHS + DAYS + HOURS + MINUTES(excluding hours) + >> SECONDS(excl hr/min) + NANOS(excl hr/min/sec) >> provides sufficient data for later default interface methods. (ie. >> where only the above units can be queried.) The former is a more >> accurate representation of the state of the class and easier for >> framework code to work with. The latter is more designed for human >> code. > Period is defined to be the 7 values that make up the amount and with > the Units and Durations the caller can convert to any desired Unit. >> >> The choice of providing a general conversion mechanism using durations >> in get(Unit) may be nice for users, but it would be non-extensible in >> future JDKs (default interface methods would have insufficient >> information to work with). > The methods getUnits and get(unit) provide a complete picture of the > TemporalAmount > (as long as there is no overlap between the units) any caller can > iterate over the > supported Units and get the total value. > > And the missing information is? > > For example, the default method for addTo(Temporal) might be: > Temporal plus(Temporal t) { > Temporal accum = t; > for (TemporalUnit unit: this.getUnits()) { > long v = this.get(unit); > if (v != 0) { > accum = accum.plus(v, unit); > } > } > return accum; > } > > Changing getUnits to return List and returning them > in decreasing duration will allow predicable use and results. >> >> >> Given all this, I think Period = YEARS + MONTHS + DAYS + NANOS is the >> simplest model. But since its not very user friendly, it may be best >> to return it as a Map, or to rename get(Unit) to something >> less attractive. > The TemporalAmount is already effectively a Map. > > Roger > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop From scolebourne at joda.org Sat Jan 26 16:22:34 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 27 Jan 2013 00:22:34 +0000 Subject: [threeten-dev] DateTimeBuilder Message-ID: I've made the first set of changes to DateTimeBuilder. I pushed them directly as they should be pretty uncontroversial. They change the public API of DateTimeFormatter to only refer to TemporalAccessor, rather than DateTimeBuilder. This mostly involved test changes. I also ensured that parsing a weird string with the same field twice (like the month twice) will report a problem at the parsing stage rather than at the resolving stage. I intend to continue work on the TemporalField API to remove builder there if possible, and to see if there is a better way to code the builder internally. Stephen From Roger.Riggs at oracle.com Sun Jan 27 12:38:26 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Sun, 27 Jan 2013 15:38:26 -0500 Subject: [threeten-dev] Review of webrev for #215 Remove rethowIOException method Message-ID: <51059042.2070702@oracle.com> Please review the webrev to resolve issue #215: Remove DateTimePrintException.rethrowIOException method This method may not provide the semantics of exception handling needed by the developer and is rarely discovered in the API. Removing it is one less thing to maintain. http://cr.openjdk.java.net/~rriggs/webrev-rethrow-215/ Thanks, Roger From scolebourne at joda.org Sun Jan 27 12:45:01 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 27 Jan 2013 20:45:01 +0000 Subject: [threeten-dev] [threeten-develop] Review of webrev for #215 Remove rethowIOException method In-Reply-To: <51059042.2070702@oracle.com> References: <51059042.2070702@oracle.com> Message-ID: +1 to push Stephen On 27 January 2013 20:38, Roger Riggs wrote: > Please review the webrev to resolve issue #215: > Remove DateTimePrintException.rethrowIOException method > > This method may not provide the semantics of exception handling needed > by the developer and is rarely discovered in the API. > Removing it is one less thing to maintain. > > http://cr.openjdk.java.net/~rriggs/webrev-rethrow-215/ > > Thanks, Roger > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From roger.riggs at oracle.com Sun Jan 27 12:49:23 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Sun, 27 Jan 2013 20:49:23 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Remove DateTimePrintException.rethrowIOException method Message-ID: <20130127204958.A8106475A8@hg.openjdk.java.net> Changeset: e7e24027ac2d Author: rriggs Date: 2013-01-27 15:48 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e7e24027ac2d Remove DateTimePrintException.rethrowIOException method See issue #215 ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimePrintException.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/test/java/time/format/MockIOExceptionAppendable.java - test/java/time/test/java/time/format/TestDateTimePrintException.java From scolebourne at joda.org Sun Jan 27 13:06:05 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Sun, 27 Jan 2013 21:06:05 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 6 new changesets Message-ID: <20130127210714.28EBD475A9@hg.openjdk.java.net> Changeset: a58fedac3421 Author: scolebourne Date: 2013-01-26 14:40 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a58fedac3421 Modernize DateTimeBuilder Remove references to calendrical ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/temporal/JulianFields.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java Changeset: b705ed194f2a Author: scolebourne Date: 2013-01-26 16:05 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b705ed194f2a Enhance/simplify parse context and add TemporalAccessor ! src/share/classes/java/time/format/DateTimeParseContext.java Changeset: 2aad491aab84 Author: scolebourne Date: 2013-01-27 00:08 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2aad491aab84 Remove DateTimeBuilder from DateTimeFormatter API Use TemporalAccessor instead Tighten what happens with dumb patterns like 'd-d' Tighten/fix classic format behaviour Adjust tests See #195 ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestTextParser.java ! test/java/time/test/java/time/format/TestZoneIdParser.java ! test/java/time/test/java/time/format/TestZoneOffsetParser.java Changeset: 6d72320061f0 Author: scolebourne Date: 2013-01-27 11:02 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6d72320061f0 Update JulianFields Make internal class into an enum (same as IsoFields) Make TCK/non-TCK tests ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/TemporalField.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/test/java/time/temporal/TestJulianFields.java Changeset: 085acbd5c131 Author: scolebourne Date: 2013-01-27 20:46 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/085acbd5c131 Update IsoFields Minor tidy up ! src/share/classes/java/time/temporal/IsoFields.java Changeset: 1be163fd70ad Author: scolebourne Date: 2013-01-27 20:52 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1be163fd70ad Merge ! src/share/classes/java/time/format/DateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java - test/java/time/test/java/time/format/MockIOExceptionAppendable.java - test/java/time/test/java/time/format/TestDateTimePrintException.java From scolebourne at joda.org Sun Jan 27 13:07:22 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 27 Jan 2013 21:07:22 +0000 Subject: [threeten-dev] DateTimeBuilder In-Reply-To: References: Message-ID: These commits are actually pushed now... Stephen On 27 January 2013 00:22, Stephen Colebourne wrote: > I've made the first set of changes to DateTimeBuilder. I pushed them > directly as they should be pretty uncontroversial. > > They change the public API of DateTimeFormatter to only refer to > TemporalAccessor, rather than DateTimeBuilder. This mostly involved > test changes. > > I also ensured that parsing a weird string with the same field twice > (like the month twice) will report a problem at the parsing stage > rather than at the resolving stage. > > I intend to continue work on the TemporalField API to remove builder > there if possible, and to see if there is a better way to code the > builder internally. > > Stephen From richard.warburton at gmail.com Sun Jan 27 15:02:29 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Sun, 27 Jan 2013 23:02:29 +0000 Subject: [threeten-dev] Apparent test failure Message-ID: Hey, When running the 310 tests under jtreg I appear to get a failure. Failure trace listed at: http://cr.openjdk.java.net/~rwarburton/TestFormatter.jtr This is using 6829:1be163fd70ad of threeten/jdk repo (ie current HEAD). I was running make test TEST="jdk_time" in order to run the tests. Can someone else confirm that this is a general problem, and not an artefact on my configuration or a mistake on my behalf? regards, Richard Warburton http://insightfullogic.com @RichardWarburto From scolebourne at joda.org Sun Jan 27 15:25:19 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Sun, 27 Jan 2013 23:25:19 +0000 Subject: [threeten-dev] Apparent test failure In-Reply-To: References: Message-ID: Looks like that test fails for me. Don't know for how long. (its not a test I've generally run with my setup) Stephen On 27 January 2013 23:02, Richard Warburton wrote: > Hey, > > When running the 310 tests under jtreg I appear to get a failure. Failure > trace listed at: > > http://cr.openjdk.java.net/~rwarburton/TestFormatter.jtr > > This is using 6829:1be163fd70ad of threeten/jdk repo (ie current HEAD). I > was running make test TEST="jdk_time" in order to run the tests. Can > someone else confirm that this is a general problem, and not an artefact on > my configuration or a mistake on my behalf? > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto From xueming.shen at oracle.com Sun Jan 27 15:38:35 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Sun, 27 Jan 2013 15:38:35 -0800 Subject: [threeten-dev] Apparent test failure In-Reply-To: References: Message-ID: <5105BA7B.7030207@oracle.com> It passes in my env with jtreg. But Alan once mentioned that he saw the same failure in his env wiht jtreg. I will take a look -Sherman On 01/27/2013 03:02 PM, Richard Warburton wrote: > Hey, > > When running the 310 tests under jtreg I appear to get a failure. Failure > trace listed at: > > http://cr.openjdk.java.net/~rwarburton/TestFormatter.jtr > > This is using 6829:1be163fd70ad of threeten/jdk repo (ie current HEAD). I > was running make test TEST="jdk_time" in order to run the tests. Can > someone else confirm that this is a general problem, and not an artefact on > my configuration or a mistake on my behalf? > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto From richard.warburton at gmail.com Sun Jan 27 15:44:57 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Sun, 27 Jan 2013 23:44:57 +0000 Subject: [threeten-dev] Apparent test failure In-Reply-To: <5105BA7B.7030207@oracle.com> References: <5105BA7B.7030207@oracle.com> Message-ID: > > It passes in my env with jtreg. But Alan once mentioned that > he saw the same failure in his env wiht jtreg. I will take a look > For reference it fails semi non-deterministically for me - ie it always fails, but a different number of cases fail. regards, Richard Warburton http://insightfullogic.com @RichardWarburto From richard.warburton at gmail.com Sun Jan 27 16:03:13 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Mon, 28 Jan 2013 00:03:13 +0000 Subject: [threeten-dev] Webrev Review Message-ID: Are people ok with this move? http://cr.openjdk.java.net/~rwarburton/webrev-tck-1/ I left actually fixing the failing cases, since Sherman said he was looking into it. This should also be considered a check that I'm using the webrev process correctly. regards, Richard Warburton http://insightfullogic.com @RichardWarburto From scolebourne at joda.org Sun Jan 27 16:08:06 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 00:08:06 +0000 Subject: [threeten-dev] Apparent test failure In-Reply-To: References: <5105BA7B.7030207@oracle.com> Message-ID: I also had a case earlier today of an infinite loop. I left my laptop for over an hour and the test suite had not finished. I don't know what test was the problem as I can't reproduce it. Stephen On 27 January 2013 23:44, Richard Warburton wrote: >> >> It passes in my env with jtreg. But Alan once mentioned that >> he saw the same failure in his env wiht jtreg. I will take a look >> > > For reference it fails semi non-deterministically for me - ie it always > fails, but a different number of cases fail. > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto From scolebourne at joda.org Sun Jan 27 16:09:27 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 00:09:27 +0000 Subject: [threeten-dev] Webrev Review In-Reply-To: References: Message-ID: This is a weird test class, as it is java.util, not JSR-310. Up to Sherman as to what happens with it. Stephen On 28 January 2013 00:03, Richard Warburton wrote: > Are people ok with this move? > > http://cr.openjdk.java.net/~rwarburton/webrev-tck-1/ > > I left actually fixing the failing cases, since Sherman said he was looking > into it. This should also be considered a check that I'm using the webrev > process correctly. > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto From scolebourne at joda.org Sun Jan 27 16:41:51 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 00:41:51 +0000 Subject: [threeten-dev] Apparent test failure In-Reply-To: References: <5105BA7B.7030207@oracle.com> Message-ID: I think it is LocalDate.parse(text, dtf); in test_parse_textLocalDate() in TCKLocalizedFieldParser which I changed recently. Infiite loop is non-deterministic. Stephen On 28 January 2013 00:08, Stephen Colebourne wrote: > I also had a case earlier today of an infinite loop. I left my laptop > for over an hour and the test suite had not finished. I don't know > what test was the problem as I can't reproduce it. > > Stephen > > > On 27 January 2013 23:44, Richard Warburton wrote: >>> >>> It passes in my env with jtreg. But Alan once mentioned that >>> he saw the same failure in his env wiht jtreg. I will take a look >>> >> >> For reference it fails semi non-deterministically for me - ie it always >> fails, but a different number of cases fail. >> >> regards, >> >> Richard Warburton >> >> http://insightfullogic.com >> @RichardWarburto From scolebourne at joda.org Sun Jan 27 17:14:53 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 01:14:53 +0000 Subject: [threeten-dev] Non-webrev: Removing builder Message-ID: This is the start of a patch to remove DateTimeBuilder. It isn't complete but can be applied and does work without changing behaviour. I believe the old resolve method on TemporalField will be able to be removed. This is for info and to indicate a direction of travel rather than for full review. Stephen From misterm at gmail.com Sun Jan 27 17:16:30 2013 From: misterm at gmail.com (Michael Nascimento) Date: Sun, 27 Jan 2013 23:16:30 -0200 Subject: [threeten-dev] Non-webrev: Removing builder In-Reply-To: References: Message-ID: I got no attachment this time, Stephen. Regards, Michael From scolebourne at joda.org Sun Jan 27 17:19:40 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 01:19:40 +0000 Subject: [threeten-dev] Non-webrev: Removing builder In-Reply-To: References: Message-ID: Ask me off-list if you want a copy forwarded to you. Michael, I sent yours. Stephen On 28 January 2013 01:16, Michael Nascimento wrote: > I got no attachment this time, Stephen. > > Regards, > Michael From Roger.Riggs at oracle.com Mon Jan 28 06:12:17 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 28 Jan 2013 09:12:17 -0500 Subject: [threeten-dev] Webrev Review In-Reply-To: References: Message-ID: <51068741.4080401@oracle.com> Hi Richard, I recall a similar comment but it was proposed that the test should be in the java.util test directory, not in java/time/... Sherman proposed to leave it in java.time for now to keep it together with the other tests so it would be more likely to be maintained. (The move from the tck hierarchy to the test hierarchy is file). Roger On 1/27/2013 7:03 PM, Richard Warburton wrote: > Are people ok with this move? > > http://cr.openjdk.java.net/~rwarburton/webrev-tck-1/ > > I left actually fixing the failing cases, since Sherman said he was looking > into it. This should also be considered a check that I'm using the webrev > process correctly. > > regards, > > Richard Warburton > > http://insightfullogic.com > @RichardWarburto -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From roger.riggs at oracle.com Mon Jan 28 07:49:22 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Mon, 28 Jan 2013 15:49:22 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130128154959.58C26475B8@hg.openjdk.java.net> Changeset: 006a15252fcc Author: rriggs Date: 2013-01-28 10:31 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/006a15252fcc Implement TemporalAmount interface instead of TemporalAdder and TemporalSubtractor Updates Duration, Period, SimplePeriod to implement TemporalAmount interface Updates to tests and new tests. Issue #190 ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java - src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAmount.java - src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/package-info.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendars/CopticDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/MockSimplePeriod.java Changeset: 95ac77b9e9ea Author: rriggs Date: 2013-01-28 10:48 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/95ac77b9e9ea Merge ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZonedDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKZonedDateTime.java - test/java/time/test/java/time/format/MockIOExceptionAppendable.java - test/java/time/test/java/time/format/TestDateTimePrintException.java From richard.warburton at gmail.com Mon Jan 28 08:33:21 2013 From: richard.warburton at gmail.com (Richard Warburton) Date: Mon, 28 Jan 2013 16:33:21 +0000 Subject: [threeten-dev] Webrev Review In-Reply-To: <51068741.4080401@oracle.com> References: <51068741.4080401@oracle.com> Message-ID: > > I recall a similar comment but it was proposed that the test should be > in the java.util test directory, not in java/time/... > > Sherman proposed to leave it in java.time for now to keep it together with > the other tests so it would be more likely to be maintained. > > (The move from the tck hierarchy to the test hierarchy is file). > Yeah - I mean if the changes to java.util.Formatter are spec'd outside of the JSR-310 spec then it doesn't make sense to put it there, so I'll just drop the proposal. regards, Richard Warburton http://insightfullogic.com @RichardWarburto From douglas.surber at oracle.com Mon Jan 28 09:08:21 2013 From: douglas.surber at oracle.com (Douglas Surber) Date: Mon, 28 Jan 2013 09:08:21 -0800 Subject: [threeten-dev] [threeten-develop] Rough draft of TemporalAmount In-Reply-To: <51042A2D.2040901@oracle.com> References: <5101BDBF.4070301@oracle.com> <51029B38.9060905@oracle.com> <5102A2F6.5040009@oracle.com> <51042A2D.2040901@oracle.com> Message-ID: <6.2.5.6.2.20130128090741.04af43d0@oracle.com> The JavaDoc for Period.getUnit says it returns a Set, not a List. Douglas At 11:10 AM 1/26/2013, Roger Riggs wrote: >Hi, > >Some revisions and comments inline: > >javadoc: > http://cr.openjdk.java.net/~rriggs/javadoc-temporalamount/ > >webrev: > http://cr.openjdk.java.net/~rriggs/webrev-temporalamount/ > >On 1/25/2013 10:54 AM, Stephen Colebourne wrote: > > On 25 January 2013 15:21, Roger > Riggs wrote: > >> So, the simplest option is > >> Duration = SECONDS + NANOS > >> Period + YEARS + MONTHS + DAYS + NANOS > >> > >> The javadoc for Period describes itself has supporting the most > commonly > >> used units > >> including "time units with an exact duration". To be consistent > get(unit) > >> should follow > >> that pattern. > > I think that we need to require that the combination of > getUnits() and > > get() returns the complete state of the object. > > > > A Period is an amount, created by adding the total of years, > months > > days and time (in nanos). A user querying the period should be > able to > > get the total "amount". If hours/minutes/seconds are supported, > then > > get(HOURS)+get(MINUTES)+get(SECONDS)+get(NANOS) should be the > total > > amount, and all other units would be an error. >right > > > > The alternate model for the interface is that it is just a > "friendly" > > get, like Temporal, that returns as much as it can. But we don't > have > > the rest of the infrastructure to do that in terms of converting > a > > user type of HALF_YEARS from the provided type of YEARS. >All Units have a Duration, sometimes estimated that can be used for >conversions >if deemed necessary. > > > > Given that there are multiple choices this gets tricky. > > > > (I note again that adding this interface is risky because we > don't > > have the use cases to validate it. Adder and Subtractor are safe > and > > cannot be wrong. This interface may well not be what we really > need, > > forcing a TemporalAmount2 in the future) > > > > I would say that these models: > > Period = YEARS + MONTHS + DAYS + NANOS > > Period = YEARS + MONTHS + DAYS + HOURS + MINUTES(excluding > hours) + > > SECONDS(excl hr/min) + NANOS(excl hr/min/sec) > > provides sufficient data for later default interface methods. > (ie. > > where only the above units can be queried.) The former is a more > > accurate representation of the state of the class and easier for > > framework code to work with. The latter is more designed for > human > > code. >Period is defined to be the 7 values that make up the amount and >with >the Units and Durations the caller can convert to any desired Unit. > > > > The choice of providing a general conversion mechanism using > durations > > in get(Unit) may be nice for users, but it would be > non-extensible in > > future JDKs (default interface methods would have insufficient > > information to work with). >The methods getUnits and get(unit) provide a complete picture of the > >TemporalAmount >(as long as there is no overlap between the units) any caller can >iterate over the >supported Units and get the total value. > >And the missing information is? > >For example, the default method for addTo(Temporal) might be: > Temporal plus(Temporal t) { > Temporal accum = t; > for (TemporalUnit unit: this.getUnits()) { > long v = this.get(unit); > if (v != 0) { > accum = accum.plus(v, unit); > } > } > return accum; > } > >Changing getUnits to return List and returning them >in decreasing duration will allow predicable use and results. > > > > > > Given all this, I think Period = YEARS + MONTHS + DAYS + NANOS > is the > > simplest model. But since its not very user friendly, it may be > best > > to return it as a Map, or to rename get(Unit) to > something > > less attractive. >The TemporalAmount is already effectively a Map. > >Roger > > >------------------------------------------------------------------------------ >Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >MVC, Windows 8 Apps, JavaScript and much more. Keep your skills >current >with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >MVPs and experts. ON SALE this month only -- learn more at: >http://p.sf.net/sfu/learnnow-d2d >_______________________________________________ >threeten-develop mailing list >threeten-develop at lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/threeten-develop From yoshito_umaoka at us.ibm.com Mon Jan 28 09:40:05 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Mon, 28 Jan 2013 12:40:05 -0500 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: <51030C4D.60008@oracle.com> References: <51030C4D.60008@oracle.com> Message-ID: > May I ask why there is a padding on "sa" for Saudi Arabia and it becomes > "cv-sa0"? BCP47 u locale extensions reserve two letter subtag for keys (such as ca for calendar, co for collation). Extension values (such as islamic, gregory, ...) must be at least 3 characters, up to 8 characters (max 8 comes from the BCP 47 subtag syntax restriction). I mentioned regional variant of non-algorithmic Islamic calendar might be identified by country code based subtag, but I want to hold this one for now, because of several reasons as I mentioned in the proposal document - 1) country might not be right level of grouping 2) such syntax based value may explode possible subtag values unnecessarily 3) in most case, region subtag in BCP 47 may sufficient 4) sighting based calendar might not be suited for open data interchange. I'm happy to collect review feedback on this point and make a final decision in CLDR TC. Do you think such syntax is necessary? > I agree with Stephen that ideally each variant should have a full > specification. I wonder if LDML could simply say the cv value should be > one of the externally defined standard formal variant identifiers. And > then there could be a separate registry that assigns the formal ID and > specifies the variants or provides reference. I think this may take some > time to establish and we can manually maintain the formal values for the > time being. > The u locale extension is officially maintained by the CLDR project and the set of available subtags are included in bcp47/*.xml in each CLDR release. These XML files contains at least short description of the meaning of each subtag. Like other type of BCP 47 subtags, the process is open for everyone. And the CLDR project accepts reasonable requests in reasonable turn around time, as I did this time. (Of course, some modifications might be done based on some research and technical review.) In general, private extension can be included in BCP 47 x- subtag. The u extension name space may also define a syntax for private extension for a certain purpose, but I'm not sure it's really a good idea for calendar (ca) and its variants (cv). -Yoshito From Roger.Riggs at oracle.com Mon Jan 28 11:55:14 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 28 Jan 2013 14:55:14 -0500 Subject: [threeten-dev] Review for #232 Rename Queries.chrono() to Queries.chronology() Message-ID: <5106D7A2.2060406@oracle.com> Please review: http://cr.openjdk.java.net/~rriggs/webrev-chrono-232/ Resolving Issue 232: https://github.com/ThreeTen/threeten/issues/232 Thanks, Roger From scolebourne at joda.org Mon Jan 28 12:07:27 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 20:07:27 +0000 Subject: [threeten-dev] [threeten-develop] Review for #232 Rename Queries.chrono() to Queries.chronology() In-Reply-To: <5106D7A2.2060406@oracle.com> References: <5106D7A2.2060406@oracle.com> Message-ID: Changes look fine, +1 to merge/push Stephen On 28 January 2013 19:55, Roger Riggs wrote: > Please review: > > http://cr.openjdk.java.net/~rriggs/webrev-chrono-232/ > > Resolving Issue 232: https://github.com/ThreeTen/threeten/issues/232 > > Thanks, Roger > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From scolebourne at joda.org Mon Jan 28 12:05:38 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Mon, 28 Jan 2013 20:05:38 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 5 new changesets Message-ID: <20130128200720.3F4E8475C9@hg.openjdk.java.net> Changeset: 7c19e9af4a51 Author: scolebourne Date: 2013-01-28 16:26 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7c19e9af4a51 Make DateTimeBuilder.resolve into a default method ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/TemporalField.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java Changeset: fdf54bc06e99 Author: scolebourne Date: 2013-01-28 16:35 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/fdf54bc06e99 Use private method in formatter to avoid casts See #195 ! src/share/classes/java/time/format/DateTimeFormatter.java Changeset: 4b932dc38b04 Author: scolebourne Date: 2013-01-28 17:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4b932dc38b04 Enhance WeekFields tests See #195 ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java Changeset: f8b96be20bd0 Author: scolebourne Date: 2013-01-28 19:39 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f8b96be20bd0 Remove DateTimeBuilder from TemporalField Fix implementations, improve tests See #195 ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/WeekFields.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java Changeset: 5810c8080832 Author: scolebourne Date: 2013-01-28 19:59 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5810c8080832 Merge - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java From scolebourne at joda.org Mon Jan 28 12:11:23 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 20:11:23 +0000 Subject: [threeten-dev] Non-webrev: Removing builder In-Reply-To: References: Message-ID: I've pushed the main change here, which removes builder from the public API of TemporalField. There is still more work to do, but this code was worth pushing anyway. (Normally I'd use a personal branch, but that option isn't available in OpenJDK hg) This code also fixes a non-deterministic infinite loop in WeekFields. The remaining work is to remove builder from the special cases in LocalDate and LocalTime, then make the class non-public or remove it. Ideally, I'd like to replace parseUnresolved by something more hidden but I may not have time for that. Stephen On 28 January 2013 01:14, Stephen Colebourne wrote: > This is the start of a patch to remove DateTimeBuilder. It isn't > complete but can be applied and does work without changing behaviour. > I believe the old resolve method on TemporalField will be able to be > removed. > > This is for info and to indicate a direction of travel rather than for > full review. > > Stephen From dan.chiba at oracle.com Mon Jan 28 13:31:45 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Mon, 28 Jan 2013 13:31:45 -0800 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: References: <51030C4D.60008@oracle.com> Message-ID: <5106EE41.4020007@oracle.com> Yoshito-san, On 1/28/2013 9:40 AM, yoshito_umaoka at us.ibm.com wrote: > > May I ask why there is a padding on "sa" for Saudi Arabia and it > becomes > > "cv-sa0"? > > BCP47 u locale extensions reserve two letter subtag for keys (such as > ca for calendar, co for collation). Extension values (such as islamic, > gregory, ...) must be at least 3 characters, up to 8 characters (max 8 > comes from the BCP 47 subtag syntax restriction). > Ok, I was only aware of BCP47: extension = singleton 1*("-" (2*8alphanum)) Is it correct that the Unicode extension tightens this rule to 3 to 8 letters (in RFC6067 section 2.1, first bullet)? I fixed the 310 description to 3 to 8: https://github.com/ThreeTen/threeten/issues/118#issuecomment-12301195 > I mentioned regional variant of non-algorithmic Islamic calendar might > be identified by country code based subtag, but I want to hold this > one for now, because of several reasons as I mentioned in the proposal > document - 1) country might not be right level of grouping The idea was not using an ISO country code as is, but using the BCP47 region subtags; I totally agree with (3) below. > 2) such syntax based value may explode possible subtag values > unnecessarily > 3) in most case, region subtag in BCP 47 may sufficient Yes, this is precisely the intent. > 4) sighting based calendar might not be suited for open data interchange. There should be no problem as far as the variant is unambiguously identified and its definition is properly managed. Our intent is enabling interchange of Islamic dates for major variants. > > > I'm happy to collect review feedback on this point and make a final > decision in CLDR TC. Do you think such syntax is necessary? Yes, I think this is helpful, although currently we only plan to support "sa0" for this kind. > > > > I agree with Stephen that ideally each variant should have a full > > specification. I wonder if LDML could simply say the cv value should be > > one of the externally defined standard formal variant identifiers. And > > then there could be a separate registry that assigns the formal ID and > > specifies the variants or provides reference. I think this may take > some > > time to establish and we can manually maintain the formal values for > the > > time being. > > > > The u locale extension is officially maintained by the CLDR project > and the set of available subtags are included in bcp47/*.xml in each > CLDR release. These XML files contains at least short description of > the meaning of each subtag. > > Like other type of BCP 47 subtags, the process is open for everyone. > And the CLDR project accepts reasonable requests in reasonable turn > around time, as I did this time. (Of course, some modifications might > be done based on some research and technical review.) > > In general, private extension can be included in BCP 47 x- subtag. The > u extension name space may also define a syntax for private extension > for a certain purpose, but I'm not sure it's really a good idea for > calendar (ca) and its variants (cv). > I think it is great if CLDR can define cv values in bcp47/*.xml. Would it be reasonable to have a longer description as well, so more information can be added? If this long description field can carry a reference to the full specification, no external registry would be necessary. Regards, -Dan > -Yoshito From xueming.shen at oracle.com Mon Jan 28 14:05:09 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 28 Jan 2013 14:05:09 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind Message-ID: <5106F615.6050204@oracle.com> Stephen, While working on the "j.u.TimeZone uses tzdb.jar" code [1], I just realized the "supposedly to be the optimization helper" BoundProvider actually stands in the way of performance. It forces the rules to be loaded eagerly, with hundreds of BoundProvider objects flying in the startup stage. It basically disables any lazy-loading design/impl and possible provider hashing mechanism by eagerly loading the rules into ZoneRulesProvider level. Interestingly, the spec suggests that "this is suitable for providers that cann't change their contents during the lifetime of the JVM", exactly what the TzdbZoneRuleProvider is supposed to be, but "can't not change their contents during lifetime" does not necessarily mean "have to eagerly loading everything at start", given in most use scenario, only limited zones are used, it's really not a good strategy. Given its only benefit appears to replace two hash mapping lookups by one (also, I don't think it's a good idea for the spi abstract class to get into the business of how the individual provider takes care of their zoneid->rules implementation). I would suggest we just remove the mechanism. Here is webrev that (1) disabled the mechanism (I hope you agree to simply remove it) (2) replaced the id->index->byte[]/rules lookup to id -> byte[]/rules (least, we don't have to do binary search ) http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider/ -Sherman [1] http://cr.openjdk.java.net/~sherman/jdk8_threeten/tz_share/ From Roger.Riggs at oracle.com Mon Jan 28 14:25:05 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Mon, 28 Jan 2013 17:25:05 -0500 Subject: [threeten-dev] DateTimeFormatters factory consolidation #210 Message-ID: <5106FAC1.403@oracle.com> Please review: webrev: http://cr.openjdk.java.net/~rriggs/webrev-factory-210/ javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-factory-210/ The factory methods are merged from DateTimeFormatters to DateTimeFormatter and renamed as per conventions. Thanks, Roger From yoshito_umaoka at us.ibm.com Mon Jan 28 14:25:49 2013 From: yoshito_umaoka at us.ibm.com (yoshito_umaoka at us.ibm.com) Date: Mon, 28 Jan 2013 17:25:49 -0500 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: <5106EE41.4020007@oracle.com> References: <51030C4D.60008@oracle.com> <5106EE41.4020007@oracle.com> Message-ID: > Ok, I was only aware of BCP47: > extension = singleton 1*("-" (2*8alphanum)) Yes, this is the BCP 47 base syntax. > Is it correct that the Unicode extension tightens this rule to 3 to > 8 letters (in RFC6067 section 2.1, first bullet)? Complete syntax definition for u (and t) extension is found at section 3 in the LDML specification: http://www.unicode.org/reports/tr35/#Unicode_Language_and_Locale_Identifiers The Unicode locale extension may consist from attributes and keywords. Each keyword consists from key and optional type. We want to support well-formedness check without having complete subtag repository, we decided to limit keys to be always 2 letter code, and attributes and type subtags to be 3 to 8 characters. For example, following language tag is well-formed (but not valid because of subtags are not registered in the locale extension registry). en-u-abc-xyz-aa-bbb-ccc-dd-ee-fff Above is parsed into - language: en Unicode extension: attribute: abc attribute: xyz keyword: key=aa / value=bbb-ccc keyword: key=dd keyword: key=ee / value=fff As you many know, the parser is implemented in java.util.Locale class in JDK 7. > Yes, I think this is helpful, although currently we only plan to > support "sa0" for this kind. I'm wondering what is the implication of Islamic Calendar based on sighting used in Saudi Arabia in the context of JSR-310. There is no good way to calculate future dates with this - of course, it might be still valid for past dates (as long as Java is providing updates when new month is officially determined in Saudi Arabia). How would you implement this as a chronology in the JSR-310 framework? In my honest opinion, I'm not sure it is worth distinguishing one sighting based dates used at region A from another sighting based dates used at region B. Neither of them is predictable by software. Isn't it better to just put them into one bucket as - sighting based/religious calendar? > I think it is great if CLDR can define cv values in bcp47/*.xml. Of course, when they are added into the registry, some explanation of the types should be provided. > Would it be reasonable to have a longer description as well, so more > information can be added? If this long description field can carry a > reference to the full specification, no external registry would be necessary. It's obviously impossible to spell out the complete algorithm there. Of course, we try to eliminate ambiguity as much as possible, in short description. For example, the registry does not try to explain what is Gregorian calendar. -Yoshito From scolebourne at joda.org Mon Jan 28 15:03:39 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Mon, 28 Jan 2013 23:03:39 +0000 Subject: [threeten-dev] [threeten-develop] DateTimeFormatters factory consolidation #210 In-Reply-To: <5106FAC1.403@oracle.com> References: <5106FAC1.403@oracle.com> Message-ID: On DateTimeFormatter you changed "This class is immutable and thread-safe." to "All returned formatters are immutable and thread-safe." In fact, both statements are true, but the first is probably more true. (Given that SimpleDateFormat is not thread-safe, this one is important to get right) It might be worth having an inner class lazy load for some/all of the constants. The RFC constant will be slow to create with its maps and rarely used. The other constants might be better having their startup delayed as well. Rest of the change looks fine. Stephen On 28 January 2013 22:25, Roger Riggs wrote: > Please review: > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-factory-210/ > > javadoc: > http://cr.openjdk.java.net/~rriggs/javadoc-factory-210/ > > The factory methods are merged from DateTimeFormatters to DateTimeFormatter > and renamed as per conventions. > > Thanks, Roger > > > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From scolebourne at joda.org Mon Jan 28 16:04:48 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 00:04:48 +0000 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <5106F615.6050204@oracle.com> References: <5106F615.6050204@oracle.com> Message-ID: On 28 January 2013 22:05, Xueming Shen wrote: > While working on the "j.u.TimeZone uses tzdb.jar" code [1], I just > realized the "supposedly to be the optimization helper" BoundProvider > actually stands in the way of performance. It forces the rules to be > loaded eagerly, with hundreds of BoundProvider objects flying in > the startup stage. It basically disables any lazy-loading design/impl > and possible provider hashing mechanism by eagerly loading the > rules into ZoneRulesProvider level. Interestingly, the spec suggests > that "this is suitable for providers that cann't change their contents > during the lifetime of the JVM", exactly what the TzdbZoneRuleProvider > is supposed to be, but "can't not change their contents during lifetime" > does not necessarily mean "have to eagerly loading everything at > start", given in most use scenario, only limited zones are used, it's > really not a good strategy. Its certainly wrong that it creates the rules object for everything at startup. > Given its only benefit appears to replace two hash mapping lookups > by one (also, I don't think it's a good idea for the spi abstract class > to get into the business of how the individual provider takes care of > their zoneid->rules implementation). I would suggest we just remove > the mechanism. > > Here is webrev that > (1) disabled the mechanism (I hope you agree to simply remove it) > (2) replaced the id->index->byte[]/rules lookup to id -> byte[]/rules > (least, we don't have to do binary search ) I would have said that the binary search would be faster. It certainly should be smaller in memory than a ConcurrentHashMap. I you have shown it to be faster, then removing the index lookup is OK. It would make sense for the JDK implementation to not have Version. The JDK will only supply one version of the data, so it would be faster/smaller to not have a class and hash lookup for the version. I suggest the file format stays the same, and the loading code simply loads the latest version. I suspect that the "bind" approach makes less sense because it isn't integrated into ZoneRegion as I thought it was (perhaps an unfinished change of mine). The problem if you have many versions is that you have to find the latest version. This can slow things down. I think my intention was that ZoneRegion should store the provider, not the rules, and that the bound provider was added so that the net effect would be negligible. This needs more thinking than is possible at midnight... Stephen From xueming.shen at oracle.com Mon Jan 28 17:39:32 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 28 Jan 2013 17:39:32 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: References: <5106F615.6050204@oracle.com> Message-ID: <51072854.1090702@oracle.com> On 1/28/13 4:04 PM, Stephen Colebourne wrote: > It would make sense for the JDK implementation to not have Version. > The JDK will only supply one version of the data, so it would be > faster/smaller to not have a class and hash lookup for the version. I > suggest the file format stays the same, and the loading code simply > loads the latest version. Yes, if take a look at the code I'm preparing for the j.u.Timezone. I'am only catching the last version. Since now the ZoneRuleProvider now provide the mechanism of replacing the "default provider". I would assume it would be also OK for you that I update the tzdb compiler, which is mainly for tzdb.jar for JDK, that also only works for on the single version? Any multi-version support will be via a customized ZoneRulesProvider. -Sherman From dan.chiba at oracle.com Mon Jan 28 17:54:47 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Mon, 28 Jan 2013 17:54:47 -0800 Subject: [threeten-dev] CLDR Islamic calendar types In-Reply-To: References: <51030C4D.60008@oracle.com> <5106EE41.4020007@oracle.com> Message-ID: <51072BE7.3010009@oracle.com> On 1/28/2013 2:25 PM, yoshito_umaoka at us.ibm.com wrote: > > Ok, I was only aware of BCP47: > > extension = singleton 1*("-" (2*8alphanum)) > > Yes, this is the BCP 47 base syntax. > > > Is it correct that the Unicode extension tightens this rule to 3 to > > 8 letters (in RFC6067 section 2.1, first bullet)? > > Complete syntax definition for u (and t) extension is found at section > 3 in the LDML specification: > > http://www.unicode.org/reports/tr35/#Unicode_Language_and_Locale_Identifiers > > > The Unicode locale extension may consist from attributes and keywords. > Each keyword consists from key and optional type. > > We want to support well-formedness check without having complete > subtag repository, we decided to limit keys to be always 2 letter > code, and attributes and type subtags to be 3 to 8 characters. For > example, following language tag is well-formed (but not valid because > of subtags are not registered in the locale extension registry). > Thank you; I was not fully aware of this. > en-u-abc-xyz-aa-bbb-ccc-dd-ee-fff > > Above is parsed into - > > language: en > > Unicode extension: > attribute: abc > attribute: xyz > keyword: key=aa / value=bbb-ccc > keyword: key=dd > keyword: key=ee / value=fff > > As you many know, the parser is implemented in java.util.Locale class > in JDK 7. > > > Yes, I think this is helpful, although currently we only plan to > > support "sa0" for this kind. > > I'm wondering what is the implication of Islamic Calendar based on > sighting used in Saudi Arabia in the context of JSR-310. > There is no good way to calculate future dates with this - of course, > it might be still valid for past dates (as long as Java is providing > updates when new month is officially determined in Saudi Arabia). How > would you implement this as a chronology in the JSR-310 framework? > All future dates are valid, it's just that their mappings to other calendars may change. And a 30th day of the month may be removed, if starting a new month (becomes the first day of the next month) is announced. > In my honest opinion, I'm not sure it is worth distinguishing one > sighting based dates used at region A from another sighting based > dates used at region B. Neither of them is predictable by software. > Isn't it better to just put them into one bucket as - sighting > based/religious calendar? Distinguishing is required to not confuse distinct variants. The same date in different variants may actually be different dates so they are not interchangeable. JSR-310 intends to enable reliably exchanging islamic date information by identifying the variant unambiguously. If different variants are put in the same bucket, applications can confuse the variants and result in an unexpected behavior. Despite the characteristic to make software unable to predict the deviations, sighting is still in use. > > > > I think it is great if CLDR can define cv values in bcp47/*.xml. > > Of course, when they are added into the registry, some explanation of > the types should be provided. > > > Would it be reasonable to have a longer description as well, so more > > information can be added? If this long description field can carry a > > reference to the full specification, no external registry would be > necessary. > > It's obviously impossible to spell out the complete algorithm there. > Of course, we try to eliminate ambiguity as much as possible, in short > description. > For example, the registry does not try to explain what is Gregorian > calendar. > May I request inclusion of "umalqura" and "sa0"? The description can be the "Umm Al-Qura calendar" and "the islamic calendar based on the announcement by the High Judiciary Council of Saudi Arabia", respectively. Regards, -Dan > -Yoshito > From xueming.shen at oracle.com Mon Jan 28 22:26:32 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 28 Jan 2013 22:26:32 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: References: <5106F615.6050204@oracle.com> Message-ID: <51076B98.2050105@oracle.com> On 01/28/2013 04:04 PM, Stephen Colebourne wrote: > >> Here is webrev that >> (1) disabled the mechanism (I hope you agree to simply remove it) >> (2) replaced the id->index->byte[]/rules lookup to id -> byte[]/rules >> (least, we don't have to do binary search ) > I would have said that the binary search would be faster. It certainly > should be smaller in memory than a ConcurrentHashMap. > I you have shown it to be faster, then removing the index lookup is OK. > Given it's a 600+ array, I don't think the binary search has any chance to win the race:-) except couple hot spots that may get hit the first try. Attached is a non-scientific test case to measure the average performance of these two, hashmap is the "new", binary search is the "old". The "new" vs "old" is at 1300 : 9000 range. -Sherman From xueming.shen at oracle.com Mon Jan 28 23:54:09 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Mon, 28 Jan 2013 23:54:09 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <51076B98.2050105@oracle.com> References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> Message-ID: <51078021.8040002@oracle.com> A slim down version of the tzdbProvider.java http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider -Sherman On 1/28/2013 10:26 PM, Xueming Shen wrote: > On 01/28/2013 04:04 PM, Stephen Colebourne wrote: >> >>> Here is webrev that >>> (1) disabled the mechanism (I hope you agree to simply remove it) >>> (2) replaced the id->index->byte[]/rules lookup to id -> byte[]/rules >>> (least, we don't have to do binary search ) >> I would have said that the binary search would be faster. It certainly >> should be smaller in memory than a ConcurrentHashMap. >> I you have shown it to be faster, then removing the index lookup is OK. >> > > Given it's a 600+ array, I don't think the binary search has > any chance to win the race:-) except couple hot spots that > may get hit the first try. > > Attached is a non-scientific test case to measure the average > performance of these two, hashmap is the "new", binary search > is the "old". The "new" vs "old" is at 1300 : 9000 range. > > -Sherman > From scolebourne at joda.org Tue Jan 29 02:30:12 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 10:30:12 +0000 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <51078021.8040002@oracle.com> References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> Message-ID: On 29 January 2013 07:54, Xueming Shen wrote: > A slim down version of the tzdbProvider.java > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider There should be a blank line before the constructor. The "Specification for implementors" section is irrelevent on a non-public class. The class is also not immutable. The map of versions shoud use Collections.singletonMap or emptyMap (note that this requires changing the specification in ZoneRulesProvider) I think that the version should probably be added to the toString() - "TZDB[2013a]" A comment should be added noting that only the latest version is being used. In general, this is a good simplification. Stephen From roger.riggs at oracle.com Tue Jan 29 06:37:33 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 29 Jan 2013 14:37:33 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130129143813.1892F47649@hg.openjdk.java.net> Changeset: e98cded96ef7 Author: rriggs Date: 2013-01-28 15:37 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e98cded96ef7 Inconsistent Chrono vs Chronology Rename Queries.chrono to Queries.chronology. See issue #232 ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendars/CopticEra.java Changeset: a30bc8fe0801 Author: rriggs Date: 2013-01-28 17:25 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a30bc8fe0801 Merge ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java From Roger.Riggs at oracle.com Tue Jan 29 06:53:46 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 29 Jan 2013 09:53:46 -0500 Subject: [threeten-dev] [threeten-develop] DateTimeFormatters factory consolidation #210 In-Reply-To: References: <5106FAC1.403@oracle.com> Message-ID: <5107E27A.90506@oracle.com> Thanks for the review. On 1/28/2013 6:03 PM, Stephen Colebourne wrote: > On DateTimeFormatter you changed "This class is immutable and > thread-safe." to "All returned formatters are immutable and > thread-safe." In fact, both statements are true, but the first is > probably more true. (Given that SimpleDateFormat is not thread-safe, > this one is important to get right) fixed (I had merged the specification for implementors from the DateTimeFormatters class). > > It might be worth having an inner class lazy load for some/all of the > constants. The RFC constant will be slow to create with its maps and > rarely used. The other constants might be better having their startup > delayed as well. I would agree about delaying the initialization if possible but with static variables, I don't think the initialization can be lazy. It might be possible for the implementation to instantiate a DateTimeFormatter instance with only an enum of its format but not initialize the fields. I'll take a look at that after other tasks. It also occurs to me that some folks would benefit of documentation of the pattern used. It might provoke better recognition in addition to the name. But it is not always possible. Thing for a future doc update perhaps. Thanks, Roger > > Rest of the change looks fine. > > Stephen > > > On 28 January 2013 22:25, Roger Riggs wrote: >> Please review: >> >> webrev: >> http://cr.openjdk.java.net/~rriggs/webrev-factory-210/ >> >> javadoc: >> http://cr.openjdk.java.net/~rriggs/javadoc-factory-210/ >> >> The factory methods are merged from DateTimeFormatters to DateTimeFormatter >> and renamed as per conventions. >> >> Thanks, Roger >> >> From scolebourne at joda.org Tue Jan 29 07:01:38 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 15:01:38 +0000 Subject: [threeten-dev] [threeten-develop] DateTimeFormatters factory consolidation #210 In-Reply-To: <5107E27A.90506@oracle.com> References: <5106FAC1.403@oracle.com> <5107E27A.90506@oracle.com> Message-ID: On 29 January 2013 14:53, Roger Riggs wrote: > On 1/28/2013 6:03 PM, Stephen Colebourne wrote: > It might be worth having an inner class lazy load for some/all of the > constants. The RFC constant will be slow to create with its maps and > rarely used. The other constants might be better having their startup > delayed as well. > > I would agree about delaying the initialization if possible but > with static variables, I don't think the initialization can be lazy. True. We'll have to test startup and other performance at some point, but hopefully this won't be a big issue. > It might be possible for the implementation to instantiate a > DateTimeFormatter instance > with only an enum of its format but not initialize the fields. I'll take a > look at that after > other tasks. It could be done like the week or localized printer/parser using package-scoped methods. Whether it is worth worrying about is another matter. > It also occurs to me that some folks would benefit of documentation of the > pattern > used. It might provoke better recognition in addition to the name. But it > is not always > possible. Thing for a future doc update perhaps. I took the pattern letter style documentation out as the pattern letters were not totally clear. They could be added back as guidance rather than spec. Stephen From xueming.shen at oracle.com Tue Jan 29 08:15:46 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 29 Jan 2013 08:15:46 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> Message-ID: <5107F5B2.2040103@oracle.com> Heads up. I'm adding an additional "alias mapping" section at the end of the tzdb.jar for the j.u.TimeZone migration (to use tzdb.jar). There are internal jdk classes need the real alias mapping table to get all those "names" for those alias time zones. (JSR310 may also prefer to have the alias info somewhere, like the tz text parsing, but I'm not exposing it right now) http://cr.openjdk.java.net/~sherman/jdk8_threeten/tz_share/make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java.sdiff.html http://cr.openjdk.java.net/~sherman/jdk8_threeten/tz_share/src/share/classes/sun/util/calendar/ZoneInfoFile.java.html I still keep the alias names in the regionId array, only add the indexing table at the end, so we don't have to add those alias names into the region list and jsr310 loader can probably just ignore the rest. There are about 140+ aliases. -Sherman On 1/29/13 2:30 AM, Stephen Colebourne wrote: > On 29 January 2013 07:54, Xueming Shen wrote: >> A slim down version of the tzdbProvider.java >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider > There should be a blank line before the constructor. > > The "Specification for implementors" section is irrelevent on a > non-public class. The class is also not immutable. > > The map of versions shoud use Collections.singletonMap or emptyMap > (note that this requires changing the specification in > ZoneRulesProvider) > > I think that the version should probably be added to the toString() - > "TZDB[2013a]" > > A comment should be added noting that only the latest version is being used. > > > In general, this is a good simplification. > > Stephen From roger.riggs at oracle.com Tue Jan 29 08:26:04 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 29 Jan 2013 16:26:04 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130129162641.5727E47653@hg.openjdk.java.net> Changeset: e15337b961fc Author: rriggs Date: 2013-01-29 10:58 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e15337b961fc #210: DateTimeFormatters factories, print method name, etc. Move the factories for the formatters to DateTimeFormatter. Remove the DateTimeFormatters class. Convert the methods returning Iso and RFC formatters with public static final constants. Rename the pattern* and localized* methods as factory methods starting with "of" ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendars/HijrahDeviationReader.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java - src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/package-info.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java Changeset: 28a6c02588ea Author: rriggs Date: 2013-01-29 11:25 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/28a6c02588ea Merge ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestZoneIdParser.java From scolebourne at joda.org Tue Jan 29 08:32:10 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 16:32:10 +0000 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <5107F5B2.2040103@oracle.com> References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> <5107F5B2.2040103@oracle.com> Message-ID: Adding an alias section is a Good Thing in my view. It should really be expressed in 310 if it is visible in the old code. Stephen On 29 January 2013 16:15, Xueming Shen wrote: > Heads up. > > I'm adding an additional "alias mapping" section at the end of the tzdb.jar > for > the j.u.TimeZone migration (to use tzdb.jar). There are internal jdk classes > need > the real alias mapping table to get all those "names" for those alias time > zones. > (JSR310 may also prefer to have the alias info somewhere, like the tz text > parsing, > but I'm not exposing it right now) > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tz_share/make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java.sdiff.html > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tz_share/src/share/classes/sun/util/calendar/ZoneInfoFile.java.html > > I still keep the alias names in the regionId array, only add the indexing > table > at the end, so we don't have to add those alias names into the region list > and > jsr310 loader can probably just ignore the rest. There are about 140+ > aliases. > > -Sherman > > > On 1/29/13 2:30 AM, Stephen Colebourne wrote: >> >> On 29 January 2013 07:54, Xueming Shen wrote: >>> >>> A slim down version of the tzdbProvider.java >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider >> >> There should be a blank line before the constructor. >> >> The "Specification for implementors" section is irrelevent on a >> non-public class. The class is also not immutable. >> >> The map of versions shoud use Collections.singletonMap or emptyMap >> (note that this requires changing the specification in >> ZoneRulesProvider) >> >> I think that the version should probably be added to the toString() - >> "TZDB[2013a]" >> >> A comment should be added noting that only the latest version is being >> used. >> >> >> In general, this is a good simplification. >> >> Stephen > > From xueming.shen at oracle.com Tue Jan 29 08:47:30 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 29 Jan 2013 08:47:30 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> Message-ID: <5107FD22.9060301@oracle.com> On 1/29/13 2:30 AM, Stephen Colebourne wrote: > On 29 January 2013 07:54, Xueming Shen wrote: >> A slim down version of the tzdbProvider.java >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider > There should be a blank line before the constructor. > > The "Specification for implementors" section is irrelevent on a > non-public class. The class is also not immutable. > > The map of versions shoud use Collections.singletonMap or emptyMap > (note that this requires changing the specification in > ZoneRulesProvider) Thought about that last night, then decided not to touch the spec for now. We will need to go through the ZoneRulesProvider to decide if the returned map should be immutable or not all together, the getAvailableZoneId as well. It probably should never hit the emptyMap, given it's id->provider->versions(id) invocation. The webrev has been updated with other suggestions. -Sherman > > I think that the version should probably be added to the toString() - > "TZDB[2013a]" > > A comment should be added noting that only the latest version is being used. > > > In general, this is a good simplification. > > Stephen From scolebourne at joda.org Tue Jan 29 09:50:35 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 29 Jan 2013 17:50:35 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 5 new changesets Message-ID: <20130129175133.7733647657@hg.openjdk.java.net> Changeset: 0337fb23fe1c Author: scolebourne Date: 2013-01-29 12:53 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0337fb23fe1c Tidy Queries class; Move to lambdas ! src/share/classes/java/time/temporal/Queries.java Changeset: 6820aca16ab4 Author: scolebourne Date: 2013-01-29 15:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6820aca16ab4 Add Queries.localDate() and localTime() See #222 ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/temporal/Queries.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java Changeset: 41939bf40c4a Author: scolebourne Date: 2013-01-29 17:10 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/41939bf40c4a Make DateTimeBuilder non-public Implementation is not improved to handle chrono yet, but is simpler See #195 ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/format/DateTimeBuilder.java Changeset: 44f1dba34e2c Author: scolebourne Date: 2013-01-29 17:33 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/44f1dba34e2c Merge ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/temporal/Queries.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java Changeset: e02909a36b0e Author: scolebourne Date: 2013-01-29 17:47 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e02909a36b0e Fix merge ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/ZonedDateTime.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java From scolebourne at joda.org Tue Jan 29 09:54:42 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 17:54:42 +0000 Subject: [threeten-dev] DateTimeBuilder In-Reply-To: References: Message-ID: DateTimeBuilder is now non-public. The latest commits added Queries for localDate() and localTime() to make it work. There is more work to do making the builder work with chrono. Stephen On 27 January 2013 21:07, Stephen Colebourne wrote: > These commits are actually pushed now... > Stephen > > > On 27 January 2013 00:22, Stephen Colebourne wrote: >> I've made the first set of changes to DateTimeBuilder. I pushed them >> directly as they should be pretty uncontroversial. >> >> They change the public API of DateTimeFormatter to only refer to >> TemporalAccessor, rather than DateTimeBuilder. This mostly involved >> test changes. >> >> I also ensured that parsing a weird string with the same field twice >> (like the month twice) will report a problem at the parsing stage >> rather than at the resolving stage. >> >> I intend to continue work on the TemporalField API to remove builder >> there if possible, and to see if there is a better way to code the >> builder internally. >> >> Stephen From scolebourne at joda.org Tue Jan 29 10:43:25 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 29 Jan 2013 18:43:25 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Rename "do" methods on TemporalField and TemporalUnit Message-ID: <20130129184348.631AB4766A@hg.openjdk.java.net> Changeset: dc2749ab296d Author: scolebourne Date: 2013-01-29 18:17 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/dc2749ab296d Rename "do" methods on TemporalField and TemporalUnit Fixes #206 ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendars/HijrahDate.java ! src/share/classes/java/time/calendars/HijrahEra.java ! src/share/classes/java/time/calendars/JapaneseDate.java ! src/share/classes/java/time/calendars/MinguoDate.java ! src/share/classes/java/time/calendars/MinguoEra.java ! src/share/classes/java/time/calendars/ThaiBuddhistDate.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/WeekFields.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/calendars/CopticDate.java ! test/java/time/tck/java/time/calendars/CopticEra.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java From scolebourne at joda.org Tue Jan 29 11:17:04 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 29 Jan 2013 19:17:04 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Fix calculation of period between in quarters Message-ID: <20130129191716.835C54766C@hg.openjdk.java.net> Changeset: da446a5befc9 Author: scolebourne Date: 2013-01-29 18:59 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/da446a5befc9 Fix calculation of period between in quarters Fixes #231 ! src/share/classes/java/time/temporal/IsoFields.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java From xueming.shen at oracle.com Tue Jan 29 11:20:36 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 29 Jan 2013 11:20:36 -0800 Subject: [threeten-dev] old US time-zone names Message-ID: <51082104.9080300@oracle.com> Stephen, I'm comparing the "older" US time-zone names defined in ZoneId and in jdk's make/sun/javazic/tzdata_jdk/jdk11_backward. It appears the EST and MST are being mapped to different city name. jdk11_backward picks the "golden" city name, which seems reasonable. Is there any reference for ZoneId's pick? Just wonder whether we can consolidate these two. jdk11_backward: EST America/New_York MST America/Denver ZoneId: EST America/Indianapolis MST America/Phoenix There are other two, the Kolkats vs Calcutta and Saigon vs Ho_Chi_Minh, the jdk11_backward picks the "old" names, which is being linked back to the new names in backward file, so these two are not an issue. -Sherman From scolebourne at joda.org Tue Jan 29 11:20:42 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 19:20:42 +0000 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <5107FD22.9060301@oracle.com> References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> <5107FD22.9060301@oracle.com> Message-ID: Are you awaiting a review on this? Please re-send links if you want a review. Stephen On 29 January 2013 16:47, Xueming Shen wrote: > On 1/29/13 2:30 AM, Stephen Colebourne wrote: >> >> On 29 January 2013 07:54, Xueming Shen wrote: >>> >>> A slim down version of the tzdbProvider.java >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider >> >> There should be a blank line before the constructor. >> >> The "Specification for implementors" section is irrelevent on a >> non-public class. The class is also not immutable. >> >> The map of versions shoud use Collections.singletonMap or emptyMap >> (note that this requires changing the specification in >> ZoneRulesProvider) > > > Thought about that last night, then decided not to touch the spec for now. > We will need to go through the ZoneRulesProvider to decide if the returned > map should be immutable or not all together, the getAvailableZoneId as well. > It probably should never hit the emptyMap, given it's > id->provider->versions(id) > invocation. > > The webrev has been updated with other suggestions. > > -Sherman > > > >> >> I think that the version should probably be added to the toString() - >> "TZDB[2013a]" >> >> A comment should be added noting that only the latest version is being >> used. >> >> >> In general, this is a good simplification. >> >> Stephen > > From xueming.shen at oracle.com Tue Jan 29 11:24:03 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 29 Jan 2013 11:24:03 -0800 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> <5107FD22.9060301@oracle.com> Message-ID: <510821D3.9060603@oracle.com> The webrev has been updated. http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider On 01/29/2013 11:20 AM, Stephen Colebourne wrote: > Are you awaiting a review on this? Please re-send links if you want a review. > Stephen > > On 29 January 2013 16:47, Xueming Shen wrote: >> On 1/29/13 2:30 AM, Stephen Colebourne wrote: >>> On 29 January 2013 07:54, Xueming Shen wrote: >>>> A slim down version of the tzdbProvider.java >>>> >>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider >>> There should be a blank line before the constructor. >>> >>> The "Specification for implementors" section is irrelevent on a >>> non-public class. The class is also not immutable. >>> >>> The map of versions shoud use Collections.singletonMap or emptyMap >>> (note that this requires changing the specification in >>> ZoneRulesProvider) >> >> Thought about that last night, then decided not to touch the spec for now. >> We will need to go through the ZoneRulesProvider to decide if the returned >> map should be immutable or not all together, the getAvailableZoneId as well. >> It probably should never hit the emptyMap, given it's >> id->provider->versions(id) >> invocation. >> >> The webrev has been updated with other suggestions. >> >> -Sherman >> >> >> >>> I think that the version should probably be added to the toString() - >>> "TZDB[2013a]" >>> >>> A comment should be added noting that only the latest version is being >>> used. >>> >>> >>> In general, this is a good simplification. >>> >>> Stephen >> From scolebourne at joda.org Tue Jan 29 11:37:01 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 19:37:01 +0000 Subject: [threeten-dev] old US time-zone names In-Reply-To: <51082104.9080300@oracle.com> References: <51082104.9080300@oracle.com> Message-ID: No reason not to agree with the old JDK code here AFAICT. On 29 January 2013 19:20, Xueming Shen wrote: > Stephen, > > I'm comparing the "older" US time-zone names defined in ZoneId and > in jdk's make/sun/javazic/tzdata_jdk/jdk11_backward. It appears the > EST and MST are being mapped to different city name. jdk11_backward > picks the "golden" city name, which seems reasonable. Is there any > reference for ZoneId's pick? Just wonder whether we can consolidate > these two. > > jdk11_backward: > EST America/New_York > MST America/Denver > > ZoneId: > EST America/Indianapolis > MST America/Phoenix > > There are other two, the Kolkats vs Calcutta and Saigon vs Ho_Chi_Minh, > the jdk11_backward picks the "old" names, which is being linked back > to the new names in backward file, so these two are not an issue. > > -Sherman From scolebourne at joda.org Tue Jan 29 11:41:46 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 19:41:46 +0000 Subject: [threeten-dev] TzdbZonRulesProvider and providerBind In-Reply-To: <510821D3.9060603@oracle.com> References: <5106F615.6050204@oracle.com> <51076B98.2050105@oracle.com> <51078021.8040002@oracle.com> <5107FD22.9060301@oracle.com> <510821D3.9060603@oracle.com> Message-ID: Looks good to me. It would be OK to remove line 129, the first line of provideRules(String zoneId) that checks for null, as the map lookup will throw NPE anyway being a ConcurrentHashMap. Stephen On 29 January 2013 19:24, Xueming Shen wrote: > The webrev has been updated. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider > > > > On 01/29/2013 11:20 AM, Stephen Colebourne wrote: >> >> Are you awaiting a review on this? Please re-send links if you want a >> review. >> Stephen >> >> On 29 January 2013 16:47, Xueming Shen wrote: >>> >>> On 1/29/13 2:30 AM, Stephen Colebourne wrote: >>>> >>>> On 29 January 2013 07:54, Xueming Shen wrote: >>>>> >>>>> A slim down version of the tzdbProvider.java >>>>> >>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdbProvider >>>> >>>> There should be a blank line before the constructor. >>>> >>>> The "Specification for implementors" section is irrelevent on a >>>> non-public class. The class is also not immutable. >>>> >>>> The map of versions shoud use Collections.singletonMap or emptyMap >>>> (note that this requires changing the specification in >>>> ZoneRulesProvider) >>> >>> >>> Thought about that last night, then decided not to touch the spec for >>> now. >>> We will need to go through the ZoneRulesProvider to decide if the >>> returned >>> map should be immutable or not all together, the getAvailableZoneId as >>> well. >>> It probably should never hit the emptyMap, given it's >>> id->provider->versions(id) >>> invocation. >>> >>> The webrev has been updated with other suggestions. >>> >>> -Sherman >>> >>> >>> >>>> I think that the version should probably be added to the toString() - >>>> "TZDB[2013a]" >>>> >>>> A comment should be added noting that only the latest version is being >>>> used. >>>> >>>> >>>> In general, this is a good simplification. >>>> >>>> Stephen >>> >>> > From Roger.Riggs at oracle.com Tue Jan 29 12:02:42 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 29 Jan 2013 15:02:42 -0500 Subject: [threeten-dev] Review for #221 Clock has too many abstract methods Message-ID: <51082AE2.9040908@oracle.com> Please review fix for #221 Clock as too many abstract methods Webrev: http://cr.openjdk.java.net/~rriggs/webrev-clock-221/ Javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-clock-221/ Thanks, Roger From scolebourne at joda.org Tue Jan 29 12:30:42 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Tue, 29 Jan 2013 20:30:42 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130129203112.1A9AB47670@hg.openjdk.java.net> Changeset: 257308e66a4d Author: scolebourne Date: 2013-01-29 19:52 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/257308e66a4d Fix serialization descriptions ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java Changeset: 7655af44af98 Author: scolebourne Date: 2013-01-29 20:25 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7655af44af98 Remove SimplePeriod Fixes #243 ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendars/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/calendars/CopticDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/test/java/time/temporal/TestChronoUnit.java From scolebourne at joda.org Tue Jan 29 12:37:07 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 20:37:07 +0000 Subject: [threeten-dev] [threeten-develop] Review for #221 Clock has too many abstract methods In-Reply-To: <51082AE2.9040908@oracle.com> References: <51082AE2.9040908@oracle.com> Message-ID: +1 to merge/push Stephen On 29 January 2013 20:02, Roger Riggs wrote: > Please review fix for #221 Clock as too many abstract methods > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-clock-221/ > > Javadoc: > http://cr.openjdk.java.net/~rriggs/javadoc-clock-221/ > > Thanks, Roger > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From roger.riggs at oracle.com Tue Jan 29 12:57:47 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 29 Jan 2013 20:57:47 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130129205809.E577B47671@hg.openjdk.java.net> Changeset: c75c1f021462 Author: rriggs Date: 2013-01-29 15:52 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c75c1f021462 #221 Clock has lots of abstract methods Remove toString() specification Make millis() concrete calling instant() Make instant() abstract to promote it implementation. ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! test/java/time/tck/java/time/TCKClock.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_Tick.java Changeset: 622d2c65b3fd Author: rriggs Date: 2013-01-29 15:57 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/622d2c65b3fd Merge - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/TemporalAmount.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java From Roger.Riggs at oracle.com Tue Jan 29 13:23:52 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Tue, 29 Jan 2013 16:23:52 -0500 Subject: [threeten-dev] Review of fix for #238 rename DateTimeFormatter.print() to format() Message-ID: <51083DE8.4090201@oracle.com> Please review this recommended change to the name of the print method to format to align with the JDK's use for format. javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-format-238/ webrev: http://cr.openjdk.java.net/~rriggs/webrev-format-238/ Thanks, Roger From xueming.shen at oracle.com Tue Jan 29 13:43:52 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 29 Jan 2013 21:43:52 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated TzdbZoneRulesProvider Message-ID: <20130129214411.8340147674@hg.openjdk.java.net> Changeset: f26ed1477563 Author: sherman Date: 2013-01-29 13:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f26ed1477563 Updated TzdbZoneRulesProvider Updated ZoneId's old alias mapping EST and MST ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! test/java/time/test/java/time/TestZoneId.java From scolebourne at joda.org Tue Jan 29 15:01:32 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Tue, 29 Jan 2013 23:01:32 +0000 Subject: [threeten-dev] [threeten-develop] Review of fix for #238 rename DateTimeFormatter.print() to format() In-Reply-To: <51083DE8.4090201@oracle.com> References: <51083DE8.4090201@oracle.com> Message-ID: Conceptually print is better than format, but since the JDK insists on format, this webrev is +1 Stephen On 29 January 2013 21:23, Roger Riggs wrote: > Please review this recommended change to the name of the print method to > format > to align with the JDK's use for format. > > javadoc: > http://cr.openjdk.java.net/~rriggs/javadoc-format-238/ > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-format-238/ > > Thanks, Roger > > > > > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnnow-d2d > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From patrick.zhang at oracle.com Tue Jan 29 22:26:16 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Wed, 30 Jan 2013 14:26:16 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <50FCE5E4.2040007@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> Message-ID: <5108BD08.8000903@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr Description: The new added test cases are used for prolepticYear() and isLeapYear(). 1. As description of HijrahChronology, year 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add test_isLeapYear() to check it. And for leap year, date(prolepticYear, 12, 30) should be equal with dateYearDay(prolepticYear, 355). For non-leap year, date(prolepticYear, 12, 29) should be equal with dateYearDay(prolepticYear, 354). 2. We can get below table from definition of HijrahChronology: ISO prolepticYear 618 619 620 621 622 623 624 ... year of ERA_AH -2 -1 0 1 2 3 4 ... year of ERA_BEFORE_AH 3 2 1 0 -1 -2 -3 ... From above table, then we can get return value of prolepticYear(): prolepticYear(ERA_AH, a) = a; prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = 1; It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. Above logic has been verified in test_prolepticYear() Regards Patrick From patrick.zhang at oracle.com Tue Jan 29 22:46:03 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Wed, 30 Jan 2013 14:46:03 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.JapaneseChronology In-Reply-To: <5108BD08.8000903@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> Message-ID: <5108C1AB.1070000@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/test/java/time/tck/java/time/calendars/TestJapaneseChronology.java.udiff.html test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/TestJapaneseChronology.jtr Description: The new added test cases are used for prolepticYear(), datYearDay and isLeapYear(). 1. As positive test case, some leapYear/02/29 are verified with according ISO date. And as negative test case, some non-leapYear/02/29 are added in "badDates" data provider and it should throw DateTimeException. And we use both dateYearDay(year, doy) and date(era, year, month, dom) to construct same ISO date to confirm it works well. 2. Since prolepticYear of JapaneseChronology is same with ISO calendar system, then for all eras, we can confirm below formula should work: prolepticYear(ear, a) = a + era_diff JapaneseChronology leap year is same with ISO leap year. Then we can confirm isLeapYear(prolepticYear) should return same value with Year.of(prolepticYear).isLeap() safely. Above logic has been verified in test_prolepticYear(). Regards Patrick From patrick.zhang at oracle.com Tue Jan 29 23:12:04 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Wed, 30 Jan 2013 15:12:04 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.MinguoChronology In-Reply-To: <5108C1AB.1070000@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> Message-ID: <5108C7C4.2080903@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr Description: The new added test cases are used for prolepticYear(), datYearDay() and isLeapYear(). 1. As positive test case, some leapYear/02/29 are verified with according ISO date. And we use both dateYearDay(year, doy) and date(era, year, month, dom) to construct same ISO date to confirm it works well. As negative test case, some non-leapYear/02/29 are added in "badDates" data provider and it should throw DateTimeException. 2. According to description of javadoc, we can confirm below formula should work: prolepticYear(ERA_ROC, a) = a prolepticYear(ERA_BEFORE_ROC, a) = 1-a prolepticYear(ERA_ROC, a) = "ISO prolepticYear" - 1911 And we can confirm isLeapYear(prolepticYear) should return same value with Year.of(prolepticYear + 1911).isLeap() safely. Above logic has been verified in test_prolepticYear(). 3. It looks there is one minor typo in javadoc of MinguoChronology: " Dates are aligned such that |0001-01-01 (Minguo)| is |1911-01-01 (ISO)|. " Actually it should be 1912-01-01(ISO), all existing test, and my new added test, obey it. It is only one error in javadoc. Regards Patrick From patrick.zhang at oracle.com Tue Jan 29 23:20:46 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Wed, 30 Jan 2013 15:20:46 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.ThaiBuddhistChronology In-Reply-To: <5108C7C4.2080903@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108C7C4.2080903@oracle.com> Message-ID: <5108C9CE.3000406@oracle.com> Hi Team, Please help to review below new added test case: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/ThaiBuddhistChronology/webrev/ test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/ThaiBuddhistChronology/TestThaiBuddhistChronology.jtr Description: The new added test cases are used for prolepticYear(), datYearDay() and isLeapYear(). 1. As positive test case, some leapYear/02/29 are verified with according ISO date. And we use both dateYearDay(year, doy) and date(era, year, month, dom) to construct same ISO date to confirm it works well. As negative test case, some non-leapYear/02/29 are added in "badDates" data provider and it should throw DateTimeException. 2. According to description of javadoc, we can confirm below formula should work: prolepticYear(ERA_BE, a) = a prolepticYear(ERA_BEFORE_BE, a) = 1-a prolepticYear(ERA_BE, a) = "ISO prolepticYear" + 543 And we can confirm isLeapYear(prolepticYear) should return same value with Year.of(prolepticYear - 543).isLeap() safely. Above logic has been verified in test_prolepticYear(). Regards Patrick From scolebourne at joda.org Wed Jan 30 01:07:49 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 09:07:49 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <5108BD08.8000903@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> Message-ID: There is not a one-to-one mapping from an ISO year to a Hijrah year, because the ISO year is longer than a Hijrah year. Thus, you can't really say that ISO proleptic year 621 "equals" year 1 AH. What you could say is that one date within year 621 "equals" one date in year 1 AH. This does not seem to change your test cases. In the webrev: - you no longer need "groups=tck", as the TCK tests are now a separate directory structure Stephen On 30 January 2013 06:26, Patrick Zhang wrote: > ** > Hi Team, > > Please help to review below new added test case: > > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html > > test result: > > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr > > Description: > The new added test cases are used for prolepticYear() and isLeapYear(). > 1. As description of HijrahChronology, year 2,5,7,10,,13,16,18,21,24,26 > and 29 will be leap years. So add test_isLeapYear() to check it. And for > leap year, date(prolepticYear, 12, 30) should be equal with > dateYearDay(prolepticYear, 355). For non-leap year, date(prolepticYear, 12, > 29) should be equal with dateYearDay(prolepticYear, 354). > > 2. We can get below table from definition of HijrahChronology: ISO > prolepticYear 618 > 619 > 620 > 621 > 622 > 623 > 624 > ... > year of ERA_AH -2 > -1 > 0 > 1 > 2 > 3 > 4 > ... > year of ERA_BEFORE_AH 3 > 2 > 1 > 0 > -1 > -2 > -3 > ... > > From above table, then we can get return value of prolepticYear(): > prolepticYear(ERA_AH, a) = a; > prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = 1; It > means prolepticYear(ERA_BEFORE_AH, a)= 1-a. > > Above logic has been verified in test_prolepticYear() > > > Regards > Patrick > From scolebourne at joda.org Wed Jan 30 01:13:29 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 09:13:29 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.ThaiBuddhistChronology In-Reply-To: <5108C9CE.3000406@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108C7C4.2080903@oracle.com> <5108C9CE.3000406@oracle.com> Message-ID: Looks good to me. Stephen On 30 January 2013 07:20, Patrick Zhang wrote: > > > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/ThaiBuddhistChronology/webrev/ > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/ThaiBuddhistChronology/TestThaiBuddhistChronology.jtr > > Description: > The new added test cases are used for prolepticYear(), datYearDay() and > isLeapYear(). > 1. As positive test case, some leapYear/02/29 are verified with according > ISO date. And we use both dateYearDay(year, doy) and date(era, year, month, > dom) to construct same ISO date to confirm it works well. > As negative test case, some non-leapYear/02/29 are added in "badDates" data > provider and it should throw DateTimeException. > > 2. According to description of javadoc, we can confirm below formula should > work: > prolepticYear(ERA_BE, a) = a > prolepticYear(ERA_BEFORE_BE, a) = 1-a > prolepticYear(ERA_BE, a) = "ISO prolepticYear" + 543 > > And we can confirm isLeapYear(prolepticYear) should return same value with > Year.of(prolepticYear - 543).isLeap() safely. > > Above logic has been verified in test_prolepticYear(). > > Regards > Patrick > > From patrick.zhang at oracle.com Wed Jan 30 01:20:19 2013 From: patrick.zhang at oracle.com (patrick zhang) Date: Wed, 30 Jan 2013 17:20:19 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> Message-ID: <5108E5D3.2070900@oracle.com> Hi Stephen, Thanks. ISO year is 365/366 days and Hijrah year is 354/355 days. So the attached table is only correct in small scopes. I just use it as one sample. :) And I will not add groups=tck for future webrevs. Regards Patrick On 2013-1-30 17:07, Stephen Colebourne wrote: > There is not a one-to-one mapping from an ISO year to a Hijrah year, > because the ISO year is longer than a Hijrah year. Thus, you can't > really say that ISO proleptic year 621 "equals" year 1 AH. What you > could say is that one date within year 621 "equals" one date in year 1 AH. > > This does not seem to change your test cases. > > In the webrev: > - you no longer need "groups=tck", as the TCK tests are now a separate > directory structure > > Stephen > > > On 30 January 2013 06:26, Patrick Zhang > wrote: > > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html > > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr > > > Description: > The new added test cases are used for prolepticYear() and > isLeapYear(). > 1. As description of HijrahChronology, year > 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add > test_isLeapYear() to check it. And for leap year, > date(prolepticYear, 12, 30) should be equal with > dateYearDay(prolepticYear, 355). For non-leap year, > date(prolepticYear, 12, 29) should be equal with > dateYearDay(prolepticYear, 354). > > 2. We can get below table from definition of HijrahChronology: > ISO prolepticYear 618 > 619 > 620 > 621 > 622 > 623 > 624 > ... > year of ERA_AH -2 > -1 > 0 > 1 > 2 > 3 > 4 > ... > year of ERA_BEFORE_AH 3 > 2 > 1 > 0 > -1 > -2 > -3 > ... > > > From above table, then we can get return value of prolepticYear(): > prolepticYear(ERA_AH, a) = a; > prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = > 1; It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. > > Above logic has been verified in test_prolepticYear() > > > Regards > Patrick > > From patrick.zhang at oracle.com Wed Jan 30 01:34:06 2013 From: patrick.zhang at oracle.com (patrick zhang) Date: Wed, 30 Jan 2013 17:34:06 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.JapaneseChronology In-Reply-To: <5108C1AB.1070000@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> Message-ID: <5108E90E.30509@oracle.com> The text of webrev/result link looks good. But it seems it points to incorrect url. Please copy it to browser then open it. Or click below updated link directly. webrev http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/ test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/TestJapaneseChronology.jtr Regards Patrick On 2013-1-30 14:46, Patrick Zhang wrote: > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/test/java/time/tck/java/time/calendars/TestJapaneseChronology.java.udiff.html > > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/TestJapaneseChronology.jtr > > > Description: > The new added test cases are used for prolepticYear(), datYearDay and > isLeapYear(). > 1. As positive test case, some leapYear/02/29 are verified with > according ISO date. And as negative test case, some non-leapYear/02/29 > are added in "badDates" data provider and it should throw > DateTimeException. And we use both dateYearDay(year, doy) and > date(era, year, month, dom) to construct same ISO date to confirm it > works well. > > 2. Since prolepticYear of JapaneseChronology is same with ISO calendar > system, then for all eras, we can confirm below formula should work: > prolepticYear(ear, a) = a + era_diff > > JapaneseChronology leap year is same with ISO leap year. Then we can > confirm isLeapYear(prolepticYear) should return same value with > Year.of(prolepticYear).isLeap() safely. > > Above logic has been verified in test_prolepticYear(). > > Regards > Patrick From patrick.zhang at oracle.com Wed Jan 30 01:35:59 2013 From: patrick.zhang at oracle.com (patrick zhang) Date: Wed, 30 Jan 2013 17:35:59 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.MinguoChronology In-Reply-To: <5108C7C4.2080903@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108C7C4.2080903@oracle.com> Message-ID: <5108E97F.4070404@oracle.com> The text of webrev/result link looks good. But it seems it points to incorrect url. Please copy it to browser then open it. Or click below updated link directly. webrev: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ test result: http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr Regards Patrick On 2013-1-30 15:12, Patrick Zhang wrote: > > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ > > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr > > > Description: > The new added test cases are used for prolepticYear(), datYearDay() > and isLeapYear(). > 1. As positive test case, some leapYear/02/29 are verified with > according ISO date. And we use both dateYearDay(year, doy) and > date(era, year, month, dom) to construct same ISO date to confirm it > works well. > As negative test case, some non-leapYear/02/29 are added in "badDates" > data provider and it should throw DateTimeException. > > 2. According to description of javadoc, we can confirm below formula > should work: > prolepticYear(ERA_ROC, a) = a > prolepticYear(ERA_BEFORE_ROC, a) = 1-a > prolepticYear(ERA_ROC, a) = "ISO prolepticYear" - 1911 > > And we can confirm isLeapYear(prolepticYear) should return same value > with Year.of(prolepticYear + 1911).isLeap() safely. > > Above logic has been verified in test_prolepticYear(). > > 3. It looks there is one minor typo in javadoc of MinguoChronology: > " Dates are aligned such that |0001-01-01 (Minguo)| is |1911-01-01 > (ISO)|. " > Actually it should be 1912-01-01(ISO), all existing test, and my > new added test, obey it. It is only one error in javadoc. > > Regards > Patrick > From scolebourne at joda.org Wed Jan 30 02:37:07 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 10:37:07 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.JapaneseChronology In-Reply-To: <5108E90E.30509@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108E90E.30509@oracle.com> Message-ID: Looks good to me. Stephen On 30 January 2013 09:34, patrick zhang wrote: > The text of webrev/result link looks good. But it seems it points to > incorrect url. Please copy it to browser then open it. Or click below > updated link directly. > > webrev > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/ > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/TestJapaneseChronology.jtr > > Regards > Patrick > > > On 2013-1-30 14:46, Patrick Zhang wrote: > > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/test/java/time/tck/java/time/calendars/TestJapaneseChronology.java.udiff.html > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/JapaneseChronology/TestJapaneseChronology.jtr > > Description: > The new added test cases are used for prolepticYear(), datYearDay and > isLeapYear(). > 1. As positive test case, some leapYear/02/29 are verified with according > ISO date. And as negative test case, some non-leapYear/02/29 are added in > "badDates" data provider and it should throw DateTimeException. And we use > both dateYearDay(year, doy) and date(era, year, month, dom) to construct > same ISO date to confirm it works well. > > 2. Since prolepticYear of JapaneseChronology is same with ISO calendar > system, then for all eras, we can confirm below formula should work: > prolepticYear(ear, a) = a + era_diff > > JapaneseChronology leap year is same with ISO leap year. Then we can confirm > isLeapYear(prolepticYear) should return same value with > Year.of(prolepticYear).isLeap() safely. > > Above logic has been verified in test_prolepticYear(). > > Regards > Patrick From scolebourne at joda.org Wed Jan 30 02:43:52 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 30 Jan 2013 10:43:52 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Fix Javadoc error wrt base year of calendar Message-ID: <20130130104420.312994769A@hg.openjdk.java.net> Changeset: eab8ea7a9612 Author: scolebourne Date: 2013-01-30 10:43 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/eab8ea7a9612 Fix Javadoc error wrt base year of calendar ! src/share/classes/java/time/calendars/MinguoChronology.java From scolebourne at joda.org Wed Jan 30 02:47:44 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 10:47:44 +0000 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.MinguoChronology In-Reply-To: <5108E97F.4070404@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108C7C4.2080903@oracle.com> <5108E97F.4070404@oracle.com> Message-ID: I've fixed the Javadoc error In general you shouldn't put too much in one test. For example @Test(dataProvider="prolepticYear", groups={"tck"}) public void test_prolepticYear(int eraValue, Era era, int yearOfEra, int expectedProlepticYear, boolean isLeapYear) { Era eraObj = MinguoChronology.INSTANCE.eraOf(eraValue) ; assertTrue(MinguoChronology.INSTANCE.eras().contains(eraObj)); assertEquals(eraObj, era); assertEquals(MinguoChronology.INSTANCE.prolepticYear(era, yearOfEra), expectedProlepticYear); assertEquals(MinguoChronology.INSTANCE.isLeapYear(expectedProlepticYear), isLeapYear) ; assertEquals(MinguoChronology.INSTANCE.isLeapYear(expectedProlepticYear), Year.of(expectedProlepticYear + YDIFF).isLeap()) ; } If testing at least three different things - the validity of the era, the proleptic year method and the leap year method. I would recommend in future testing all three separately. The data provider can be re-used in multiple tests if necessary. thanks Stephen On 30 January 2013 09:35, patrick zhang wrote: > The text of webrev/result link looks good. But it seems it points to > incorrect url. Please copy it to browser then open it. Or click below > updated link directly. > > webrev: > > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr > > Regards > Patrick > > On 2013-1-30 15:12, Patrick Zhang wrote: > > > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr > > Description: > The new added test cases are used for prolepticYear(), datYearDay() and > isLeapYear(). > 1. As positive test case, some leapYear/02/29 are verified with according > ISO date. And we use both dateYearDay(year, doy) and date(era, year, month, > dom) to construct same ISO date to confirm it works well. > As negative test case, some non-leapYear/02/29 are added in "badDates" data > provider and it should throw DateTimeException. > > 2. According to description of javadoc, we can confirm below formula should > work: > prolepticYear(ERA_ROC, a) = a > prolepticYear(ERA_BEFORE_ROC, a) = 1-a > prolepticYear(ERA_ROC, a) = "ISO prolepticYear" - 1911 > > And we can confirm isLeapYear(prolepticYear) should return same value with > Year.of(prolepticYear + 1911).isLeap() safely. > > Above logic has been verified in test_prolepticYear(). > > 3. It looks there is one minor typo in javadoc of MinguoChronology: > " Dates are aligned such that 0001-01-01 (Minguo) is 1911-01-01 (ISO). " > Actually it should be 1912-01-01(ISO), all existing test, and my new > added test, obey it. It is only one error in javadoc. > > Regards > Patrick > From patrick.zhang at oracle.com Wed Jan 30 03:01:55 2013 From: patrick.zhang at oracle.com (patrick zhang) Date: Wed, 30 Jan 2013 19:01:55 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.MinguoChronology In-Reply-To: References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <5108C1AB.1070000@oracle.com> <5108C7C4.2080903@oracle.com> <5108E97F.4070404@oracle.com> Message-ID: <5108FDA3.10307@oracle.com> Thanks. I will separate it into 3 different test methods in future webrevs. Regards Patrick On 2013-1-30 18:47, Stephen Colebourne wrote: > I've fixed the Javadoc error > > In general you shouldn't put too much in one test. For example > @Test(dataProvider="prolepticYear", groups={"tck"}) > public void test_prolepticYear(int eraValue, Era > era, int yearOfEra, int expectedProlepticYear, boolean isLeapYear) { > Era eraObj = MinguoChronology.INSTANCE.eraOf(eraValue) ; > assertTrue(MinguoChronology.INSTANCE.eras().contains(eraObj)); > assertEquals(eraObj, era); > assertEquals(MinguoChronology.INSTANCE.prolepticYear(era, > yearOfEra), expectedProlepticYear); > assertEquals(MinguoChronology.INSTANCE.isLeapYear(expectedProlepticYear), > isLeapYear) ; > assertEquals(MinguoChronology.INSTANCE.isLeapYear(expectedProlepticYear), > Year.of(expectedProlepticYear + YDIFF).isLeap()) ; > } > > If testing at least three different things - the validity of the era, > the proleptic year method and the leap year method. > > I would recommend in future testing all three separately. The data > provider can be re-used in multiple tests if necessary. > > thanks > Stephen > > > On 30 January 2013 09:35, patrick zhang wrote: > >> The text of webrev/result link looks good. But it seems it points to >> incorrect url. Please copy it to browser then open it. Or click below >> updated link directly. >> >> webrev: >> >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ >> >> test result: >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr >> >> Regards >> Patrick >> >> On 2013-1-30 15:12, Patrick Zhang wrote: >> >> >> Hi Team, >> >> Please help to review below new added test case: >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/ >> >> test result: >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/MinguoChronology/TestMinguoChronology.jtr >> >> Description: >> The new added test cases are used for prolepticYear(), datYearDay() and >> isLeapYear(). >> 1. As positive test case, some leapYear/02/29 are verified with according >> ISO date. And we use both dateYearDay(year, doy) and date(era, year, month, >> dom) to construct same ISO date to confirm it works well. >> As negative test case, some non-leapYear/02/29 are added in "badDates" data >> provider and it should throw DateTimeException. >> >> 2. According to description of javadoc, we can confirm below formula should >> work: >> prolepticYear(ERA_ROC, a) = a >> prolepticYear(ERA_BEFORE_ROC, a) = 1-a >> prolepticYear(ERA_ROC, a) = "ISO prolepticYear" - 1911 >> >> And we can confirm isLeapYear(prolepticYear) should return same value with >> Year.of(prolepticYear + 1911).isLeap() safely. >> >> Above logic has been verified in test_prolepticYear(). >> >> 3. It looks there is one minor typo in javadoc of MinguoChronology: >> " Dates are aligned such that 0001-01-01 (Minguo) is 1911-01-01 (ISO). " >> Actually it should be 1912-01-01(ISO), all existing test, and my new >> added test, obey it. It is only one error in javadoc. >> >> Regards >> Patrick >> >> From scolebourne at joda.org Wed Jan 30 06:16:37 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 14:16:37 +0000 Subject: [threeten-dev] Hypothetical Period/Duration change Message-ID: Its late in the JDK 1.8 process, so there is no guarantee that this change could actually happen. However, it is worth flagging up as a possibility. Currently we have two classes: - Period = YEARS, MONTHS, DAYS, HOURS, MINUTES, SECONDS, NANOS - Duration = SECONDS, NANOS As well as the difference in the fields they hold, they have different semantics in terms of how they operate at a DST change. A Period of one day will add 23 or 25 hours at a DST change, whereas a Duration of one day will always add 24 hours (because it doesn't actually hold days at all). This model is inherited from Joda-Time, and I've presumed it necessary until recently. However, looking at this right now, it seems that this approach results in a lot of duplication of methods and concepts for perhaps questionable use cases. Do users really need to store both date and time parts in the same object? The hypothetical option would be as follows: - DatePeriod = YEARS, MONTHS, DAYS - TimePeriod = DAYS*, HOURS, MINUTES, SECONDS, NANOS Both classes would be stored fully normalized, so 15 months would always be seen as P1Y3M. Where DatePeriod handles DST change and TimePeriod ignores it. (The DAYS* "field" in TimePeriod would be exactly 24 hours always) This is a relatively radical change conceptually, but is very logical and not that large in the codebase. It mostly involves renaming Period to DatePeriod, Duration to TimePeriod, deleting methods on DatePeriod and adding a few methods to TimePeriod. I've asked around my company OpenGamma, and no-one can think of a use case where it makes sense to store "6 months and 5 hours". If you do want this, then storing both objects or writing your own class is not too much of a hardship. My questioning also revealing a lack of clarity about the meaning of the two classes, again suggestive that change would be desirable. So, **opinions please** on whether this is a good idea or would be a problem. (Ignore the aspect of whether it is too late for the moment). Stephen From misterm at gmail.com Wed Jan 30 06:19:42 2013 From: misterm at gmail.com (Michael Nascimento) Date: Wed, 30 Jan 2013 12:19:42 -0200 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: References: Message-ID: Sounds like a reasonable, worth change to me. Regards, Michael On Wed, Jan 30, 2013 at 12:16 PM, Stephen Colebourne wrote: > Its late in the JDK 1.8 process, so there is no guarantee that this > change could actually happen. However, it is worth flagging up as a > possibility. > > Currently we have two classes: > - Period = YEARS, MONTHS, DAYS, HOURS, MINUTES, SECONDS, NANOS > - Duration = SECONDS, NANOS > > As well as the difference in the fields they hold, they have different > semantics in terms of how they operate at a DST change. A Period of > one day will add 23 or 25 hours at a DST change, whereas a Duration of > one day will always add 24 hours (because it doesn't actually hold > days at all). > > This model is inherited from Joda-Time, and I've presumed it necessary > until recently. > > However, looking at this right now, it seems that this approach > results in a lot of duplication of methods and concepts for perhaps > questionable use cases. Do users really need to store both date and > time parts in the same object? > > The hypothetical option would be as follows: > - DatePeriod = YEARS, MONTHS, DAYS > - TimePeriod = DAYS*, HOURS, MINUTES, SECONDS, NANOS > Both classes would be stored fully normalized, so 15 months would > always be seen as P1Y3M. > > Where DatePeriod handles DST change and TimePeriod ignores it. (The > DAYS* "field" in TimePeriod would be exactly 24 hours always) > > This is a relatively radical change conceptually, but is very logical > and not that large in the codebase. It mostly involves renaming Period > to DatePeriod, Duration to TimePeriod, deleting methods on DatePeriod > and adding a few methods to TimePeriod. > > I've asked around my company OpenGamma, and no-one can think of a use > case where it makes sense to store "6 months and 5 hours". If you do > want this, then storing both objects or writing your own class is not > too much of a hardship. My questioning also revealing a lack of > clarity about the meaning of the two classes, again suggestive that > change would be desirable. > > So, **opinions please** on whether this is a good idea or would be a > problem. (Ignore the aspect of whether it is too late for the moment). > > Stephen From scolebourne at joda.org Wed Jan 30 07:21:46 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 30 Jan 2013 15:21:46 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130130152221.34FF4476A1@hg.openjdk.java.net> Changeset: 23176eef6cd8 Author: scolebourne Date: 2013-01-30 13:24 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/23176eef6cd8 Improve Javadoc of period plus/minus methods ! src/share/classes/java/time/Period.java Changeset: ede7c45557cb Author: scolebourne Date: 2013-01-30 15:10 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ede7c45557cb Add factory methods to match Duration, Remove 2 underused factories Add ofYear() to ofSecond() Remove of(6 ints) in favour of of(7 ints) Remove ofTime(3 ints) in favour of ofTime(4 ints) Test See #223 ! src/share/classes/java/time/Period.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/test/java/time/TestPeriod.java From Roger.Riggs at oracle.com Wed Jan 30 07:25:48 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 30 Jan 2013 10:25:48 -0500 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: References: Message-ID: <51093B7C.7050505@oracle.com> Stephen, The mapping of SQL INTERVAL requires a mapping to a Java type; currently Period fills that function. INTERVAL never mixes years and months with days and time. (Douglas pointed this out in email from 12/7/2012 "Period") If we have two types, the mapping map be difficult for developers to manage though Douglas may be able to see a way. We might take on the restriction from SQL that Period cannot be used simultaneously used for both purposes. Adding the restriction to Period could be simpler, and Duration removed. It would not provide the compile time type difference between machine time and human time. But the difference in behavior and semantics comes from the type the duration/period is applied to. Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all treat Period as a Duration. Only ZonedDateTime has any ability to deal with the TZ data variances and that could be addressed with different methods on ZDT to handle the two cases, adding machine time vs adding human time. Roger On 1/30/2013 9:16 AM, Stephen Colebourne wrote: > Its late in the JDK 1.8 process, so there is no guarantee that this > change could actually happen. However, it is worth flagging up as a > possibility. > > Currently we have two classes: > - Period = YEARS, MONTHS, DAYS, HOURS, MINUTES, SECONDS, NANOS > - Duration = SECONDS, NANOS > > As well as the difference in the fields they hold, they have different > semantics in terms of how they operate at a DST change. A Period of > one day will add 23 or 25 hours at a DST change, whereas a Duration of > one day will always add 24 hours (because it doesn't actually hold > days at all). > > This model is inherited from Joda-Time, and I've presumed it necessary > until recently. > > However, looking at this right now, it seems that this approach > results in a lot of duplication of methods and concepts for perhaps > questionable use cases. Do users really need to store both date and > time parts in the same object? > > The hypothetical option would be as follows: > - DatePeriod = YEARS, MONTHS, DAYS > - TimePeriod = DAYS*, HOURS, MINUTES, SECONDS, NANOS > Both classes would be stored fully normalized, so 15 months would > always be seen as P1Y3M. > > Where DatePeriod handles DST change and TimePeriod ignores it. (The > DAYS* "field" in TimePeriod would be exactly 24 hours always) > > This is a relatively radical change conceptually, but is very logical > and not that large in the codebase. It mostly involves renaming Period > to DatePeriod, Duration to TimePeriod, deleting methods on DatePeriod > and adding a few methods to TimePeriod. > > I've asked around my company OpenGamma, and no-one can think of a use > case where it makes sense to store "6 months and 5 hours". If you do > want this, then storing both objects or writing your own class is not > too much of a hardship. My questioning also revealing a lack of > clarity about the meaning of the two classes, again suggestive that > change would be desirable. > > So, **opinions please** on whether this is a good idea or would be a > problem. (Ignore the aspect of whether it is too late for the moment). > > Stephen -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From scolebourne at joda.org Wed Jan 30 07:35:44 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 15:35:44 +0000 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: <51093B7C.7050505@oracle.com> References: <51093B7C.7050505@oracle.com> Message-ID: On 30 January 2013 15:25, Roger Riggs wrote: > The mapping of SQL INTERVAL requires a mapping to a Java type; > currently Period fills that function. INTERVAL never mixes years and > months > with days and time. (Douglas pointed this out in email from 12/7/2012 > "Period") > > If we have two types, the mapping map be difficult for developers to > manage > though Douglas may be able to see a way. My understanding is that this change would be beneficial to SQL/JDBC. Their YEAR/MONTH concept would map to DatePeriod. Their DAY-TIME concept would map to TimePeriod. This change is dependent on JDBC agreeing to this. > We might take on the restriction from SQL that Period cannot be used > simultaneously > used for both purposes. Adding the restriction to Period could be simpler, > and Duration removed. Having two classes is not the problem here. Having two classes where it is unclear as to the purpose of each class is. Restricting the state of the current Period class in weird ways that are difficult to describe is not something I find appealing. > It would not provide the compile time type difference between machine time > and human time. But the difference in behavior and semantics comes > from the type the duration/period is applied to. > Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all treat Period > as > a Duration. Only ZonedDateTime has any ability to deal with the TZ data > variances and that could be addressed with different methods on ZDT to > handle the two cases, adding machine time vs adding human time. This is sort of correct, but Duration cannot hold year or month. We've arrived at the TemporalAmount interface, and I think we should stick with that now. It will scale OK with two implementations. Having two methods to do different things is less flexible than using the interface. Stephen From Roger.Riggs at oracle.com Wed Jan 30 07:39:48 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 30 Jan 2013 10:39:48 -0500 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <5108BD08.8000903@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> Message-ID: <51093EC4.9000604@oracle.com> Hi Patrick, The data for these tests may need to change; we are expecting to replace the default Hijrah calendar with one defined by the Saudi government (Umm al-Qura). Also there will be another variant as well. The structure of the test is good and it will be easy to update. Thanks, Roger On 1/30/2013 1:26 AM, Patrick Zhang wrote: > Hi Team, > > Please help to review below new added test case: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html > > test result: > http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr > > Description: > The new added test cases are used for prolepticYear() and isLeapYear(). > 1. As description of HijrahChronology, year > 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add > test_isLeapYear() to check it. And for leap year, date(prolepticYear, > 12, 30) should be equal with dateYearDay(prolepticYear, 355). For > non-leap year, date(prolepticYear, 12, 29) should be equal with > dateYearDay(prolepticYear, 354). > > 2. We can get below table from definition of HijrahChronology: > ISO prolepticYear 618 > 619 > 620 > 621 > 622 > 623 > 624 > ... > year of ERA_AH -2 > -1 > 0 > 1 > 2 > 3 > 4 > ... > year of ERA_BEFORE_AH 3 > 2 > 1 > 0 > -1 > -2 > -3 > ... > > > From above table, then we can get return value of prolepticYear(): > prolepticYear(ERA_AH, a) = a; > prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = 1; > It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. > > Above logic has been verified in test_prolepticYear() > > > Regards > Patrick -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From Lance.Andersen at oracle.com Wed Jan 30 08:02:05 2013 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Wed, 30 Jan 2013 11:02:05 -0500 Subject: [threeten-dev] [threeten-develop] Hypothetical Period/Duration change In-Reply-To: References: <51093B7C.7050505@oracle.com> Message-ID: <36DC7CD9-F2B7-4551-B845-2F3CAE75CFC7@oracle.com> It is too late for JDBC 4.2 to make any additional changes for INTERVAL given how late we are in the Java SE 8 schedule. INTERVAL in SQL is defined as: year-month Intervals date-time Intervals Now not all vendors support Intervals and not all follow the SQL Standard exactly Here is a pointer to the Oracle docs http://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements003.htm Thought has to be given as to how these would map for example with DatePeriod and it including days and I have not looked to see if there are any issues with SQL Interval precision as of yet On Jan 30, 2013, at 10:35 AM, Stephen Colebourne wrote: > On 30 January 2013 15:25, Roger Riggs wrote: >> The mapping of SQL INTERVAL requires a mapping to a Java type; >> currently Period fills that function. INTERVAL never mixes years and >> months >> with days and time. (Douglas pointed this out in email from 12/7/2012 >> "Period") >> >> If we have two types, the mapping map be difficult for developers to >> manage >> though Douglas may be able to see a way. > > My understanding is that this change would be beneficial to SQL/JDBC. > > Their YEAR/MONTH concept would map to DatePeriod. > Their DAY-TIME concept would map to TimePeriod. > > This change is dependent on JDBC agreeing to this. > >> We might take on the restriction from SQL that Period cannot be used >> simultaneously >> used for both purposes. Adding the restriction to Period could be simpler, >> and Duration removed. > > Having two classes is not the problem here. Having two classes where > it is unclear as to the purpose of each class is. > > Restricting the state of the current Period class in weird ways that > are difficult to describe is not something I find appealing. > >> It would not provide the compile time type difference between machine time >> and human time. But the difference in behavior and semantics comes >> from the type the duration/period is applied to. >> Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all treat Period >> as >> a Duration. Only ZonedDateTime has any ability to deal with the TZ data >> variances and that could be addressed with different methods on ZDT to >> handle the two cases, adding machine time vs adding human time. > > This is sort of correct, but Duration cannot hold year or month. > > We've arrived at the TemporalAmount interface, and I think we should > stick with that now. It will scale OK with two implementations. Having > two methods to do different things is less flexible than using the > interface. > > Stephen > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop -------------- next part -------------- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From scolebourne at joda.org Wed Jan 30 08:08:18 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 16:08:18 +0000 Subject: [threeten-dev] [threeten-develop] Hypothetical Period/Duration change In-Reply-To: <36DC7CD9-F2B7-4551-B845-2F3CAE75CFC7@oracle.com> References: <51093B7C.7050505@oracle.com> <36DC7CD9-F2B7-4551-B845-2F3CAE75CFC7@oracle.com> Message-ID: Lance, can you provide the sections of the JDBC spec that are affected? It would be useful to be able to determine if we would actually be breaking your spec. Stephen On 30 January 2013 16:02, Lance Andersen - Oracle wrote: > > It is too late for JDBC 4.2 to make any additional changes for INTERVAL given how late we are in the Java SE 8 schedule. > > > INTERVAL in SQL is defined as: > > year-month Intervals > date-time Intervals > > > Now not all vendors support Intervals and not all follow the SQL Standard exactly > > Here is a pointer to the Oracle docs http://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements003.htm > > > Thought has to be given as to how these would map for example with DatePeriod and it including days and I have not looked to see if there are any issues with SQL Interval precision as of yet > > On Jan 30, 2013, at 10:35 AM, Stephen Colebourne wrote: > >> On 30 January 2013 15:25, Roger Riggs wrote: >>> The mapping of SQL INTERVAL requires a mapping to a Java type; >>> currently Period fills that function. INTERVAL never mixes years and >>> months >>> with days and time. (Douglas pointed this out in email from 12/7/2012 >>> "Period") >>> >>> If we have two types, the mapping map be difficult for developers to >>> manage >>> though Douglas may be able to see a way. >> >> My understanding is that this change would be beneficial to SQL/JDBC. >> >> Their YEAR/MONTH concept would map to DatePeriod. >> Their DAY-TIME concept would map to TimePeriod. >> >> This change is dependent on JDBC agreeing to this. >> >>> We might take on the restriction from SQL that Period cannot be used >>> simultaneously >>> used for both purposes. Adding the restriction to Period could be simpler, >>> and Duration removed. >> >> Having two classes is not the problem here. Having two classes where >> it is unclear as to the purpose of each class is. >> >> Restricting the state of the current Period class in weird ways that >> are difficult to describe is not something I find appealing. >> >>> It would not provide the compile time type difference between machine time >>> and human time. But the difference in behavior and semantics comes >>> from the type the duration/period is applied to. >>> Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all treat Period >>> as >>> a Duration. Only ZonedDateTime has any ability to deal with the TZ data >>> variances and that could be addressed with different methods on ZDT to >>> handle the two cases, adding machine time vs adding human time. >> >> This is sort of correct, but Duration cannot hold year or month. >> >> We've arrived at the TemporalAmount interface, and I think we should >> stick with that now. It will scale OK with two implementations. Having >> two methods to do different things is less flexible than using the >> interface. >> >> Stephen >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_jan >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop > > > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > Lance.Andersen at oracle.com > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop > From scolebourne at joda.org Wed Jan 30 08:16:15 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 16:16:15 +0000 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: References: Message-ID: On 30 January 2013 14:16, Stephen Colebourne wrote: > Its late in the JDK 1.8 process, so there is no guarantee that this > change could actually happen. However, it is worth flagging up as a > possibility. > > Currently we have two classes: > - Period = YEARS, MONTHS, DAYS, HOURS, MINUTES, SECONDS, NANOS > - Duration = SECONDS, NANOS > > As well as the difference in the fields they hold, they have different > semantics in terms of how they operate at a DST change. A Period of > one day will add 23 or 25 hours at a DST change, whereas a Duration of > one day will always add 24 hours (because it doesn't actually hold > days at all). > > This model is inherited from Joda-Time, and I've presumed it necessary > until recently. > > However, looking at this right now, it seems that this approach > results in a lot of duplication of methods and concepts for perhaps > questionable use cases. Do users really need to store both date and > time parts in the same object? > > The hypothetical option would be as follows: > - DatePeriod = YEARS, MONTHS, DAYS > - TimePeriod = DAYS*, HOURS, MINUTES, SECONDS, NANOS > Both classes would be stored fully normalized, so 15 months would > always be seen as P1Y3M. > > Where DatePeriod handles DST change and TimePeriod ignores it. (The > DAYS* "field" in TimePeriod would be exactly 24 hours always) > > This is a relatively radical change conceptually, but is very logical > and not that large in the codebase. It mostly involves renaming Period > to DatePeriod, Duration to TimePeriod, deleting methods on DatePeriod > and adding a few methods to TimePeriod. > > I've asked around my company OpenGamma, and no-one can think of a use > case where it makes sense to store "6 months and 5 hours". If you do > want this, then storing both objects or writing your own class is not > too much of a hardship. My questioning also revealing a lack of > clarity about the meaning of the two classes, again suggestive that > change would be desirable. > > So, **opinions please** on whether this is a good idea or would be a > problem. (Ignore the aspect of whether it is too late for the moment). > > Stephen I've attached what a DatePeriod might look like. Stephen From Lance.Andersen at oracle.com Wed Jan 30 08:21:21 2013 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Wed, 30 Jan 2013 11:21:21 -0500 Subject: [threeten-dev] [threeten-develop] Hypothetical Period/Duration change In-Reply-To: References: <51093B7C.7050505@oracle.com> <36DC7CD9-F2B7-4551-B845-2F3CAE75CFC7@oracle.com> Message-ID: <0DCE0C8F-1C91-4D18-9165-91CA5A489CCA@oracle.com> Hi Stephen There is nothing in the JDBC spec which covers Interval specifically today. The SQL99 and above specifications are where we would look for guidance. We had talked about adding support for Intervals in the past in JDBC but decided to wait until 310 was finalized to revisit this. The generic setter/getter methods would allow a vendor if they choose to support a non-mandated datatype, but it may not be portable in how they do it We also would probably want methods on the Period classes, or elsewhere in JDBC which would be something like: XXXPeriod valueOf(java.lang.String val) throws java.sql.SQLException Creates a XXXPeriod object from a String which is in JDBC year-month interval escape format INTERVAL [ ] 'value' interval-qualifier ? The string contains a integer value for every field that is implied by the interval-qualifier ? If the interval-qualifer is YEAR to MONTH, the year and month fields are separated by a '-'. ? The leading field may specify a precision which is enclosed in parentheses. ? Only the leading field may be more than two digits long and no longer than the leading field precision ? If the precision is not specified, it defaults to two digits Example: INTERVAL '100-11' YEAR(3) TO MONTH INTERVAL '50' YEAR(4) INTERVAL '250' MONTH(4) INTERVAL -'100-11' YEAR(3) TO MONTH I would need to go back and review the proposed 310 class with the JDBC EG members and gain a bit of consensus before it could be standardized. We are just about out of runway for Java SE 8 and Intervals are something that can wait until Java SE 9 to standardize vs rush it right now. Best Lance On Jan 30, 2013, at 11:08 AM, Stephen Colebourne wrote: > Lance, can you provide the sections of the JDBC spec that are > affected? It would be useful to be able to determine if we would > actually be breaking your spec. > > Stephen > > > On 30 January 2013 16:02, Lance Andersen - Oracle > wrote: >> >> It is too late for JDBC 4.2 to make any additional changes for INTERVAL given how late we are in the Java SE 8 schedule. >> >> >> INTERVAL in SQL is defined as: >> >> year-month Intervals >> date-time Intervals >> >> >> Now not all vendors support Intervals and not all follow the SQL Standard exactly >> >> Here is a pointer to the Oracle docs http://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements003.htm >> >> >> Thought has to be given as to how these would map for example with DatePeriod and it including days and I have not looked to see if there are any issues with SQL Interval precision as of yet >> >> On Jan 30, 2013, at 10:35 AM, Stephen Colebourne wrote: >> >>> On 30 January 2013 15:25, Roger Riggs wrote: >>>> The mapping of SQL INTERVAL requires a mapping to a Java type; >>>> currently Period fills that function. INTERVAL never mixes years and >>>> months >>>> with days and time. (Douglas pointed this out in email from 12/7/2012 >>>> "Period") >>>> >>>> If we have two types, the mapping map be difficult for developers to >>>> manage >>>> though Douglas may be able to see a way. >>> >>> My understanding is that this change would be beneficial to SQL/JDBC. >>> >>> Their YEAR/MONTH concept would map to DatePeriod. >>> Their DAY-TIME concept would map to TimePeriod. >>> >>> This change is dependent on JDBC agreeing to this. >>> >>>> We might take on the restriction from SQL that Period cannot be used >>>> simultaneously >>>> used for both purposes. Adding the restriction to Period could be simpler, >>>> and Duration removed. >>> >>> Having two classes is not the problem here. Having two classes where >>> it is unclear as to the purpose of each class is. >>> >>> Restricting the state of the current Period class in weird ways that >>> are difficult to describe is not something I find appealing. >>> >>>> It would not provide the compile time type difference between machine time >>>> and human time. But the difference in behavior and semantics comes >>>> from the type the duration/period is applied to. >>>> Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all treat Period >>>> as >>>> a Duration. Only ZonedDateTime has any ability to deal with the TZ data >>>> variances and that could be addressed with different methods on ZDT to >>>> handle the two cases, adding machine time vs adding human time. >>> >>> This is sort of correct, but Duration cannot hold year or month. >>> >>> We've arrived at the TemporalAmount interface, and I think we should >>> stick with that now. It will scale OK with two implementations. Having >>> two methods to do different things is less flexible than using the >>> interface. >>> >>> Stephen >>> >>> ------------------------------------------------------------------------------ >>> Everyone hates slow websites. So do we. >>> Make your web apps faster with AppDynamics >>> Download AppDynamics Lite for free today: >>> http://p.sf.net/sfu/appdyn_d2d_jan >>> _______________________________________________ >>> threeten-develop mailing list >>> threeten-develop at lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/threeten-develop >> >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> Lance.Andersen at oracle.com >> >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_jan >> _______________________________________________ >> threeten-develop mailing list >> threeten-develop at lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/threeten-develop >> > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop -------------- next part -------------- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From roger.riggs at oracle.com Wed Jan 30 08:25:31 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Wed, 30 Jan 2013 16:25:31 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130130162605.A88CE476A5@hg.openjdk.java.net> Changeset: de08845af2c7 Author: rriggs Date: 2013-01-30 10:50 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/de08845af2c7 #238 DateTimeFormatter.print should be named format ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendars/HijrahEra.java ! src/share/classes/java/time/calendars/MinguoEra.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! test/java/time/tck/java/time/calendars/CopticEra.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java Changeset: 81b483c9d626 Author: rriggs Date: 2013-01-30 11:24 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/81b483c9d626 Merge ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/test/java/time/format/TestCharLiteralPrinter.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralPrinter.java ! test/java/time/test/java/time/format/TestTextPrinter.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java From scolebourne at joda.org Wed Jan 30 08:39:07 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 16:39:07 +0000 Subject: [threeten-dev] [threeten-develop] Hypothetical Period/Duration change In-Reply-To: <0DCE0C8F-1C91-4D18-9165-91CA5A489CCA@oracle.com> References: <51093B7C.7050505@oracle.com> <36DC7CD9-F2B7-4551-B845-2F3CAE75CFC7@oracle.com> <0DCE0C8F-1C91-4D18-9165-91CA5A489CCA@oracle.com> Message-ID: On 30 January 2013 16:21, Lance Andersen - Oracle wrote: > There is nothing in the JDBC spec which covers Interval specifically today. The SQL99 and above specifications are where we would look for guidance. > > We had talked about adding support for Intervals in the past in JDBC but decided to wait until 310 was finalized to revisit this. OK. So, since JDBC is not handling INTERVALS in JDK1.8, it makes no difference if we change the Period/Duration class. > We also would probably want methods on the Period classes, or elsewhere in JDBC which would be something like: > > XXXPeriod valueOf(java.lang.String val) throws java.sql.SQLException > > Creates a XXXPeriod object from a String which is in JDBC year-month interval escape format > INTERVAL [ ] 'value' interval-qualifier > > ? The string contains a integer value for every field that is implied by the interval-qualifier > ? If the interval-qualifer is YEAR to MONTH, the year and month fields are separated by a '-'. > ? The leading field may specify a precision which is enclosed in parentheses. > ? Only the leading field may be more than two digits long and no longer than the leading field precision > ? If the precision is not specified, it defaults to two digits > Example: > INTERVAL '100-11' YEAR(3) TO MONTH > INTERVAL '50' YEAR(4) > INTERVAL '250' MONTH(4) > INTERVAL -'100-11' YEAR(3) TO MONTH > > I would need to go back and review the proposed 310 class with the JDBC EG members and gain a bit of consensus before it could be standardized. We are just about out of runway for Java SE 8 and Intervals are something that can wait until Java SE 9 to standardize vs rush it right now. Thats absolutely fine. It decouples our work on Period/Duration from yours. Any extra methods to handle intervals could be added in JDK1.9 to a JSR-310 update. Stephen From douglas.surber at oracle.com Wed Jan 30 09:06:35 2013 From: douglas.surber at oracle.com (Douglas Surber) Date: Wed, 30 Jan 2013 09:06:35 -0800 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: References: <51093B7C.7050505@oracle.com> Message-ID: <6.2.5.6.2.20130130083522.065718a8@oracle.com> Duration and TimePeriod seem different to me. Let N be a ZonedDateTime for noon March 9, 2013 Americas/Los Angeles. N.plus(aDurationOf24Hours) would result in a ZDT of 13:00 March 10 while N.plus(aPeriodOfOneDay) would be noon March 10. Duration is physical time, a number of SI* seconds. Period, and by extension TimePeriod is field based and divorced from physical time. Using a single class TimePeriod for both concepts--one day and 86,400 SI seconds--seems confusing. WRT JDBC, ANSI SQL has two INTERVAL types, YEAR MONTH and DAY SECOND. Values of those types are normalized to have 60 seconds/minute, 60 minutes/hour, 24 hours/day and 12 months/year. So an INTERVAL DAY SECOND is a number of SI seconds and appears to match Duration pretty well. INTERVAL YEAR MONTH doesn't have days so doesn't exactly match DatePeriod. Personally I'm not concerned about an exact match between Java and SQL types. My vision for using Period in JDBC was to do a copy between the INTERVAL fields and the Period fields. It would be an error to write a Period where the fields were not in canonical form or contained an unsupported combination of non-zero fields. This approach works equally well for DatePeriod/TimePeriod. I'd prefer to leave things as they are. Douglas At 07:35 AM 1/30/2013, Stephen Colebourne wrote: >On 30 January 2013 15:25, Roger Riggs >wrote: > > The mapping of SQL INTERVAL requires a mapping to a Java type; > > currently Period fills that function. INTERVAL never mixes years > and > > months > > with days and time. (Douglas pointed this out in email from > 12/7/2012 > > "Period") > > > > If we have two types, the mapping map be difficult for developers > to > > manage > > though Douglas may be able to see a way. > >My understanding is that this change would be beneficial to >SQL/JDBC. > >Their YEAR/MONTH concept would map to DatePeriod. >Their DAY-TIME concept would map to TimePeriod. > >This change is dependent on JDBC agreeing to this. > > > We might take on the restriction from SQL that Period cannot be > used > > simultaneously > > used for both purposes. Adding the restriction to Period could be > simpler, > > and Duration removed. > >Having two classes is not the problem here. Having two classes where >it is unclear as to the purpose of each class is. > >Restricting the state of the current Period class in weird ways that >are difficult to describe is not something I find appealing. > > > It would not provide the compile time type difference between > machine time > > and human time. But the difference in behavior and semantics > comes > > from the type the duration/period is applied to. > > Instant, LocalDate, LocalTime, OffsetTime, OffsetDateTime all > treat Period > > as > > a Duration. Only ZonedDateTime has any ability to deal with the > TZ data > > variances and that could be addressed with different methods on > ZDT to > > handle the two cases, adding machine time vs adding human time. > >This is sort of correct, but Duration cannot hold year or month. > >We've arrived at the TemporalAmount interface, and I think we should >stick with that now. It will scale OK with two implementations. >Having >two methods to do different things is less flexible than using the >interface. > >Stephen From scolebourne at joda.org Wed Jan 30 09:11:34 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 30 Jan 2013 17:11:34 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130130171217.DCB3C476A8@hg.openjdk.java.net> Changeset: b8b942d2d8bf Author: scolebourne Date: 2013-01-30 16:32 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b8b942d2d8bf Remove era methods that are defaulted in the Era interface ! src/share/classes/java/time/calendars/HijrahEra.java ! src/share/classes/java/time/calendars/MinguoEra.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java ! src/share/classes/java/time/chrono/IsoEra.java ! test/java/time/tck/java/time/calendars/CopticEra.java Changeset: 97da41f94645 Author: scolebourne Date: 2013-01-30 16:53 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/97da41f94645 Rename getText() to getDisplayName() See #237 ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/test/java/time/TestZoneId.java Changeset: 45bf4c9103a7 Author: scolebourne Date: 2013-01-30 17:10 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/45bf4c9103a7 Merge ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/calendars/HijrahEra.java ! src/share/classes/java/time/calendars/MinguoEra.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoEra.java ! test/java/time/tck/java/time/calendars/CopticEra.java From scolebourne at joda.org Wed Jan 30 09:24:07 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 30 Jan 2013 17:24:07 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Move removal of resolved field Message-ID: <20130130172419.EF8C4476AA@hg.openjdk.java.net> Changeset: 79e88bad66cd Author: scolebourne Date: 2013-01-30 17:23 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/79e88bad66cd Move removal of resolved field See #195 ! src/share/classes/java/time/format/DateTimeParseContext.java From xueming.shen at oracle.com Wed Jan 30 12:14:02 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 30 Jan 2013 12:14:02 -0800 Subject: [threeten-dev] print Era with Chronology overriding Message-ID: <51097F0A.7040405@oracle.com> Two issues here. (1) It appears the print/parse context is not passing the possible overriding chronology to the printerparser, so DTF.withChronology() does have impact the print/parse result when a specified chronology is preferred. This is particular an issue when the era name is different in the non-iso chronology, Japanese for example. (2) We are not getting "short" style era text from the provider, it is printed as a numeric value now. The attached webrev fixed the printing side of the issue(1) + (2). The era parsing is still TBD for now:-0 http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra The attached test case generates following output, which I would assume is expected. (Masayoshi, Naoto?) sherman at sherman-linux:~/Workspace/310/text$ java FmtText310 Locale = [en] ------Month--------- AD January A Jan A 1 AD February A Feb A 2 AD March A Mar A 3 AD April A Apr A 4 AD May A May A 5 AD June A Jun A 6 AD July A Jul A 7 AD August A Aug A 8 AD September A Sep A 9 AD October A Oct A 10 AD November A Nov A 11 AD December A Dec A 12 ------Month cld--------- Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 Heisei January H Jan H 1 ------Month with(JapaneseChronology)--------- Heisei January H Jan H 1 Heisei February H Feb H 2 Heisei March H Mar H 3 Heisei April H Apr H 4 Heisei May H May H 5 Heisei June H Jun H 6 Heisei July H Jul H 7 Heisei August H Aug H 8 Heisei September H Sep H 9 Heisei October H Oct H 10 Heisei November H Nov H 11 Heisei December H Dec H 12 ------Week---------- Monday Mon M Tuesday Tue T Wednesday Wed W Thursday Thu T Friday Fri F Saturday Sat S Sunday Sun S ------AmPm---------- AM AM 0 PM PM 1 Locale = [ja] ------Month--------- ?? 1? A 1 A 1 ?? 2? A 2 A 2 ?? 3? A 3 A 3 ?? 4? A 4 A 4 ?? 5? A 5 A 5 ?? 6? A 6 A 6 ?? 7? A 7 A 7 ?? 8? A 8 A 8 ?? 9? A 9 A 9 ?? 10? A 10 A 10 ?? 11? A 11 A 11 ?? 12? A 12 A 12 ------Month cld--------- ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ?? 1? H 1 H 1 ------Month with(JapaneseChronology)--------- ?? 1? H 1 H 1 ?? 2? H 2 H 2 ?? 3? H 3 H 3 ?? 4? H 4 H 4 ?? 5? H 5 H 5 ?? 6? H 6 H 6 ?? 7? H 7 H 7 ?? 8? H 8 H 8 ?? 9? H 9 H 9 ?? 10? H 10 H 10 ?? 11? H 11 H 11 ?? 12? H 12 H 12 ------Week---------- ??? ? ? ??? ? ? ??? ? ? ??? ? ? ??? ? ? ??? ? ? ??? ? ? ------AmPm---------- ?? ?? 0 ?? ?? 1 From xueming.shen at oracle.com Wed Jan 30 12:43:35 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 30 Jan 2013 12:43:35 -0800 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: <51097F0A.7040405@oracle.com> References: <51097F0A.7040405@oracle.com> Message-ID: <510985F7.8090907@oracle.com> It also appears it is still DTF.withChrono(...), instead of DTF.withChronology(), so I updated it in the same patch as well. On 01/30/2013 12:14 PM, Xueming Shen wrote: > Two issues here. > > (1) It appears the print/parse context is not passing the possible > overriding chronology to the printerparser, so DTF.withChronology() > does have impact the print/parse result when a specified chronology > is preferred. This is particular an issue when the era name is different > in the non-iso chronology, Japanese for example. > > (2) We are not getting "short" style era text from the provider, it > is printed as a numeric value now. > > The attached webrev fixed the printing side of the issue(1) + (2). > The era parsing is still TBD for now:-0 > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra > > The attached test case generates following output, which I would > assume is expected. (Masayoshi, Naoto?) > > sherman at sherman-linux:~/Workspace/310/text$ java FmtText310 > Locale = [en] > ------Month--------- > AD January A Jan A 1 > AD February A Feb A 2 > AD March A Mar A 3 > AD April A Apr A 4 > AD May A May A 5 > AD June A Jun A 6 > AD July A Jul A 7 > AD August A Aug A 8 > AD September A Sep A 9 > AD October A Oct A 10 > AD November A Nov A 11 > AD December A Dec A 12 > ------Month cld--------- > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > Heisei January H Jan H 1 > ------Month with(JapaneseChronology)--------- > Heisei January H Jan H 1 > Heisei February H Feb H 2 > Heisei March H Mar H 3 > Heisei April H Apr H 4 > Heisei May H May H 5 > Heisei June H Jun H 6 > Heisei July H Jul H 7 > Heisei August H Aug H 8 > Heisei September H Sep H 9 > Heisei October H Oct H 10 > Heisei November H Nov H 11 > Heisei December H Dec H 12 > ------Week---------- > Monday Mon M > Tuesday Tue T > Wednesday Wed W > Thursday Thu T > Friday Fri F > Saturday Sat S > Sunday Sun S > ------AmPm---------- > AM AM 0 > PM PM 1 > Locale = [ja] > ------Month--------- > ?? 1? A 1 A 1 > ?? 2? A 2 A 2 > ?? 3? A 3 A 3 > ?? 4? A 4 A 4 > ?? 5? A 5 A 5 > ?? 6? A 6 A 6 > ?? 7? A 7 A 7 > ?? 8? A 8 A 8 > ?? 9? A 9 A 9 > ?? 10? A 10 A 10 > ?? 11? A 11 A 11 > ?? 12? A 12 A 12 > ------Month cld--------- > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ?? 1? H 1 H 1 > ------Month with(JapaneseChronology)--------- > ?? 1? H 1 H 1 > ?? 2? H 2 H 2 > ?? 3? H 3 H 3 > ?? 4? H 4 H 4 > ?? 5? H 5 H 5 > ?? 6? H 6 H 6 > ?? 7? H 7 H 7 > ?? 8? H 8 H 8 > ?? 9? H 9 H 9 > ?? 10? H 10 H 10 > ?? 11? H 11 H 11 > ?? 12? H 12 H 12 > ------Week---------- > ??? ? ? > ??? ? ? > ??? ? ? > ??? ? ? > ??? ? ? > ??? ? ? > ??? ? ? > ------AmPm---------- > ?? ?? 0 > ?? ?? 1 > From scolebourne at joda.org Wed Jan 30 13:44:56 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 21:44:56 +0000 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: <51097F0A.7040405@oracle.com> References: <51097F0A.7040405@oracle.com> Message-ID: On 30 January 2013 20:14, Xueming Shen wrote: > (1) It appears the print/parse context is not passing the possible > overriding chronology to the printerparser, so DTF.withChronology() > does have impact the print/parse result when a specified chronology > is preferred. This is particular an issue when the era name is different > in the non-iso chronology, Japanese for example. The DateTimePrintContext adjust() method should be handling this already. The approach you've taken doesn't work as it doesn't convert a class like LocalDate to the correct ChronoLocalDate. It is possible that adjust() doesn't work correctly of course... Stephen From Roger.Riggs at oracle.com Wed Jan 30 14:22:07 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Wed, 30 Jan 2013 17:22:07 -0500 Subject: [threeten-dev] [threeten] Reinstate toLocalDate() and friends (#224) In-Reply-To: References: Message-ID: <51099D0F.30101@oracle.com> Doing a pre-flight on this potential change, please take a look at the revised javadoc and comment. http://cr.openjdk.java.net/~rriggs/javadoc-tolocal-224/ The changes are: * rename ChronoLocalDateTime.getDate/getTime/getDateTime to toLocalDate()/toLocalTime()/toLocalDateTime() * rename the corresponding methods in LocalDateTime, OffsetDateTime, ZonedDateTime I note that some obviously meaningful methods on ChronoLocalDateTime are missing in the javadoc, for example get(field); getLong(field), isSupported(field); that's a factor of the javadoc not documenting inherited methods. On 1/30/2013 5:06 PM, Stephen Colebourne wrote: > > I would leave the get methods you mentioned there alone. > > The model to follow is that "get" methods are used for those items > that get the state of the type you are working with. Thus, > OffsetDateTime has state of offset and the 8 fields, whereas LDT just > has the 8 fields. > > The "to" methods are for converting between the basic types ODT to LD, > LDT or LT. > > So, why draw the boundary there? Well, an offset is clearly part of > the state of an ODT, so a "get" method is definitely applicable, and > it would be wrong to be other. But the date and time is more interesting. > > If we didn't have any field-based methods on LDT/ODT/OT/ZDT, then it > would be correct to have getDate/getTime. But that isn't the model we > adopt in the API. Instead, we expose the fields as the primary > representation of date and time (with lots of get/with/plus/minus > methods). Thus, it is the field-based methods that stay as "get". > > (This is a Java language limitation. In > psuedo-other-wonderful-language, you would write zdt.{date.year = 6} > and it would return a ZDT, not a LD) > > The second part of the explanation is around how developers use the > types. Changing from using one type to using another type is an > important choice, and one we want to actively make developers aware > of. (These types we refer to here are LDT/LD/LT/ODT/OT/ZDT, not > Offset/ZoneId). As a developer if I have a ZDT and I want a LD, I'm > making a very specific conversion, where the LD object will be used > for a different purpose to the original ZDT. By contrast, the > Offset/Zone are just subsidiary parts of the whole, not carrying any > date-time informationto convert to. > > Finally, toMonth and toDayOfWeek could seem appealing, but they would > be out of place wrt the other getters. We need to actively encourage > developer to use the enums to make their code more readable, and > getters are needed for that. > > ? > Reply to this email directly or view it on GitHub > . > -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From xueming.shen at oracle.com Wed Jan 30 14:29:59 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 30 Jan 2013 14:29:59 -0800 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: References: <51097F0A.7040405@oracle.com> Message-ID: <51099EE7.6070500@oracle.com> Yes, you are correct. It appears the adjust() is buggy, the chronology is from the original temporal, instead of the adjusted date. webrev has been updated accordingly. http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra/ -Sherman On 01/30/2013 01:44 PM, Stephen Colebourne wrote: > On 30 January 2013 20:14, Xueming Shen wrote: >> (1) It appears the print/parse context is not passing the possible >> overriding chronology to the printerparser, so DTF.withChronology() >> does have impact the print/parse result when a specified chronology >> is preferred. This is particular an issue when the era name is different >> in the non-iso chronology, Japanese for example. > The DateTimePrintContext adjust() method should be handling this > already. The approach you've taken doesn't work as it doesn't convert > a class like LocalDate to the correct ChronoLocalDate. It is possible > that adjust() doesn't work correctly of course... > > Stephen From scolebourne at joda.org Wed Jan 30 14:34:20 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 22:34:20 +0000 Subject: [threeten-dev] [threeten] Reinstate toLocalDate() and friends (#224) In-Reply-To: References: Message-ID: Looks good to me Stephen On 30 January 2013 22:22, Roger Riggs wrote: > Doing a pre-flight on this potential change, please take a look at the > revised javadoc and comment. > > http://cr.openjdk.java.net/~rriggs/javadoc-tolocal-224/ > > The changes are: > > * rename ChronoLocalDateTime.getDate/getTime/getDateTime to > toLocalDate()/toLocalTime()/toLocalDateTime() > * rename the corresponding methods in LocalDateTime, OffsetDateTime, > ZonedDateTime > > > I note that some obviously meaningful methods on ChronoLocalDateTime > are missing in the javadoc, for example get(field); getLong(field), > isSupported(field); > that's a factor of the javadoc not documenting inherited methods. > > > > On 1/30/2013 5:06 PM, Stephen Colebourne wrote: > > > > I would leave the get methods you mentioned there alone. > > > > The model to follow is that "get" methods are used for those items > > that get the state of the type you are working with. Thus, > > OffsetDateTime has state of offset and the 8 fields, whereas LDT just > > has the 8 fields. > > > > The "to" methods are for converting between the basic types ODT to LD, > > LDT or LT. > > > > So, why draw the boundary there? Well, an offset is clearly part of > > the state of an ODT, so a "get" method is definitely applicable, and > > it would be wrong to be other. But the date and time is more interesting. > > > > If we didn't have any field-based methods on LDT/ODT/OT/ZDT, then it > > would be correct to have getDate/getTime. But that isn't the model we > > adopt in the API. Instead, we expose the fields as the primary > > representation of date and time (with lots of get/with/plus/minus > > methods). Thus, it is the field-based methods that stay as "get". > > > > (This is a Java language limitation. In > > psuedo-other-wonderful-language, you would write zdt.{date.year = 6} > > and it would return a ZDT, not a LD) > > > > The second part of the explanation is around how developers use the > > types. Changing from using one type to using another type is an > > important choice, and one we want to actively make developers aware > > of. (These types we refer to here are LDT/LD/LT/ODT/OT/ZDT, not > > Offset/ZoneId). As a developer if I have a ZDT and I want a LD, I'm > > making a very specific conversion, where the LD object will be used > > for a different purpose to the original ZDT. By contrast, the > > Offset/Zone are just subsidiary parts of the whole, not carrying any > > date-time informationto convert to. > > > > Finally, toMonth and toDayOfWeek could seem appealing, but they would > > be out of place wrt the other getters. We need to actively encourage > > developer to use the enums to make their code more readable, and > > getters are needed for that. > > > > ? > > Reply to this email directly or view it on GitHub > > . > > > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > > ? > Reply to this email directly or view it on GitHub. > > From scolebourne at joda.org Wed Jan 30 14:38:31 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 22:38:31 +0000 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: <51099EE7.6070500@oracle.com> References: <51097F0A.7040405@oracle.com> <51099EE7.6070500@oracle.com> Message-ID: You should just be able to return date.getChronology(), which will perform better. Stephen On 30 January 2013 22:29, Xueming Shen wrote: > Yes, you are correct. It appears the adjust() is buggy, the chronology is > from the original temporal, instead of the adjusted date. > > webrev has been updated accordingly. > > http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra/ > > -Sherman > > > On 01/30/2013 01:44 PM, Stephen Colebourne wrote: >> >> On 30 January 2013 20:14, Xueming Shen wrote: >>> >>> (1) It appears the print/parse context is not passing the possible >>> overriding chronology to the printerparser, so DTF.withChronology() >>> does have impact the print/parse result when a specified chronology >>> is preferred. This is particular an issue when the era name is different >>> in the non-iso chronology, Japanese for example. >> >> The DateTimePrintContext adjust() method should be handling this >> already. The approach you've taken doesn't work as it doesn't convert >> a class like LocalDate to the correct ChronoLocalDate. It is possible >> that adjust() doesn't work correctly of course... >> >> Stephen > > From xueming.shen at oracle.com Wed Jan 30 14:59:07 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 30 Jan 2013 14:59:07 -0800 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: References: <51097F0A.7040405@oracle.com> <51099EE7.6070500@oracle.com> Message-ID: <5109A5BB.60807@oracle.com> good point. thanks! webrev has been updated accordingly. On 01/30/2013 02:38 PM, Stephen Colebourne wrote: > You should just be able to return date.getChronology(), which will > perform better. > Stephen > > On 30 January 2013 22:29, Xueming Shen wrote: >> Yes, you are correct. It appears the adjust() is buggy, the chronology is >> from the original temporal, instead of the adjusted date. >> >> webrev has been updated accordingly. >> >> http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra/ >> >> -Sherman >> >> >> On 01/30/2013 01:44 PM, Stephen Colebourne wrote: >>> On 30 January 2013 20:14, Xueming Shen wrote: >>>> (1) It appears the print/parse context is not passing the possible >>>> overriding chronology to the printerparser, so DTF.withChronology() >>>> does have impact the print/parse result when a specified chronology >>>> is preferred. This is particular an issue when the era name is different >>>> in the non-iso chronology, Japanese for example. >>> The DateTimePrintContext adjust() method should be handling this >>> already. The approach you've taken doesn't work as it doesn't convert >>> a class like LocalDate to the correct ChronoLocalDate. It is possible >>> that adjust() doesn't work correctly of course... >>> >>> Stephen >> From scolebourne at joda.org Wed Jan 30 15:15:34 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Wed, 30 Jan 2013 23:15:34 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Remove DateTimePrintException Message-ID: <20130130231547.205C1476C3@hg.openjdk.java.net> Changeset: 43cc5ec4f412 Author: scolebourne Date: 2013-01-30 23:15 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/43cc5ec4f412 Remove DateTimePrintException Fixes #242 ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java - src/share/classes/java/time/format/DateTimePrintException.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java From scolebourne at joda.org Wed Jan 30 15:26:20 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 23:26:20 +0000 Subject: [threeten-dev] print Era with Chronology overriding In-Reply-To: <5109A5BB.60807@oracle.com> References: <51097F0A.7040405@oracle.com> <51099EE7.6070500@oracle.com> <5109A5BB.60807@oracle.com> Message-ID: +1 to push Stephen On 30 January 2013 22:59, Xueming Shen wrote: > good point. thanks! webrev has been updated accordingly. > > > On 01/30/2013 02:38 PM, Stephen Colebourne wrote: >> >> You should just be able to return date.getChronology(), which will >> perform better. >> Stephen >> >> On 30 January 2013 22:29, Xueming Shen wrote: >>> >>> Yes, you are correct. It appears the adjust() is buggy, the chronology is >>> from the original temporal, instead of the adjusted date. >>> >>> webrev has been updated accordingly. >>> >>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/fmtEra/ >>> >>> -Sherman >>> >>> >>> On 01/30/2013 01:44 PM, Stephen Colebourne wrote: >>>> >>>> On 30 January 2013 20:14, Xueming Shen wrote: >>>>> >>>>> (1) It appears the print/parse context is not passing the possible >>>>> overriding chronology to the printerparser, so DTF.withChronology() >>>>> does have impact the print/parse result when a specified chronology >>>>> is preferred. This is particular an issue when the era name is >>>>> different >>>>> in the non-iso chronology, Japanese for example. >>>> >>>> The DateTimePrintContext adjust() method should be handling this >>>> already. The approach you've taken doesn't work as it doesn't convert >>>> a class like LocalDate to the correct ChronoLocalDate. It is possible >>>> that adjust() doesn't work correctly of course... >>>> >>>> Stephen >>> >>> > From xueming.shen at oracle.com Wed Jan 30 15:42:39 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 30 Jan 2013 15:42:39 -0800 Subject: [threeten-dev] hg: threeten/threeten/jdk: Remove DateTimePrintException In-Reply-To: <20130130231547.205C1476C3@hg.openjdk.java.net> References: <20130130231547.205C1476C3@hg.openjdk.java.net> Message-ID: <5109AFEF.9090308@oracle.com> Two more files? test/java/time/tck/java/time/format/TCKDateTimeFormatter.java:90 test/java/time/test/java/time/format/TestReducedPrinter.java:167: On 01/30/2013 03:15 PM, scolebourne at joda.org wrote: > Changeset: 43cc5ec4f412 > Author: scolebourne > Date: 2013-01-30 23:15 +0000 > URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/43cc5ec4f412 > > Remove DateTimePrintException > > Fixes #242 > > ! src/share/classes/java/time/format/DateTimeFormatter.java > ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java > - src/share/classes/java/time/format/DateTimePrintException.java > ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java > - test/java/time/tck/java/time/format/TCKDateTimePrintException.java > ! test/java/time/test/java/time/format/TestNumberPrinter.java > ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java > From xueming.shen at oracle.com Wed Jan 30 15:48:23 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 30 Jan 2013 23:48:23 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Updated DateTimePrintContext to work correctly with chronology Message-ID: <20130130234843.E2442476C9@hg.openjdk.java.net> Changeset: c857aaed8531 Author: sherman Date: 2013-01-30 15:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c857aaed8531 Updated DateTimePrintContext to work correctly with chronology Updated DateTimeTextProvider to support short form of era name ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestTextPrinter.java From scolebourne at joda.org Wed Jan 30 15:50:13 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Wed, 30 Jan 2013 23:50:13 +0000 Subject: [threeten-dev] Hypothetical Period/Duration change In-Reply-To: <6.2.5.6.2.20130130083522.065718a8@oracle.com> References: <51093B7C.7050505@oracle.com> <6.2.5.6.2.20130130083522.065718a8@oracle.com> Message-ID: On 30 January 2013 17:06, Douglas Surber wrote: > Duration and TimePeriod seem different to me. Let N be a ZonedDateTime for > noon March 9, 2013 Americas/Los Angeles. N.plus(aDurationOf24Hours) would > result in a ZDT of 13:00 March 10 while N.plus(aPeriodOfOneDay) would be > noon March 10. Duration is physical time, a number of SI* seconds. Period, > and by extension TimePeriod is field based and divorced from physical time. > Using a single class TimePeriod for both concepts--one day and 86,400 SI > seconds--seems confusing. Agreed that two classes are needed, one that is DST-aware and one that is not. But this difference primarily applies to days, not hours/mins. > WRT JDBC, ANSI SQL has two INTERVAL types, YEAR MONTH and DAY SECOND. Values > of those types are normalized to have 60 seconds/minute, 60 minutes/hour, 24 > hours/day and 12 months/year. So an INTERVAL DAY SECOND is a number of SI > seconds and appears to match Duration pretty well. INTERVAL YEAR MONTH > doesn't have days so doesn't exactly match DatePeriod. Personally I'm not > concerned about an exact match between Java and SQL types. My vision for > using Period in JDBC was to do a copy between the INTERVAL fields and the > Period fields. It would be an error to write a Period where the fields were > not in canonical form or contained an unsupported combination of non-zero > fields. This approach works equally well for DatePeriod/TimePeriod. > > I'd prefer to leave things as they are. I'm currently exploring the simplest option, removing the time fields from Period, and adding some additional methods to Duraton. Current class names to remain. This has knock on simplifications elsewhere, which is why it is being pursued. INTERVAL YEAR-MONTH would map to Period, DAY SECOND to Duration. Stephen From scolebourne at joda.org Wed Jan 30 16:34:21 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Thu, 31 Jan 2013 00:34:21 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 3 new changesets Message-ID: <20130131003458.67501476CB@hg.openjdk.java.net> Changeset: e1b275dcaffe Author: scolebourne Date: 2013-01-31 00:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e1b275dcaffe Avoid unchecked generics warnings ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/calendars/HijrahDeviationReader.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java Changeset: e8dc73ea9d75 Author: scolebourne Date: 2013-01-31 00:32 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e8dc73ea9d75 Merge Changeset: 30caba6af20c Author: scolebourne Date: 2013-01-31 00:34 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/30caba6af20c Avoid unchecked generics warnings ! src/share/classes/java/time/format/DateTimePrintContext.java From Roger.Riggs at Oracle.com Wed Jan 30 18:10:19 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Wed, 30 Jan 2013 21:10:19 -0500 Subject: [threeten-dev] Review for #236 Chrono.ofLocale doesn't work. Message-ID: <5109D28B.2040105@Oracle.com> Review for #236 Chrono.ofLocale doesn't work. Make sure the cache has been initialized if the requested calendar is not found. http://cr.openjdk.java.net/~rriggs/webrev-oflocale-236 [Other parts of #236 have not yet been addressed] Roger From patrick.zhang at oracle.com Wed Jan 30 21:27:57 2013 From: patrick.zhang at oracle.com (Patrick Zhang) Date: Thu, 31 Jan 2013 13:27:57 +0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <51093EC4.9000604@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <51093EC4.9000604@oracle.com> Message-ID: <510A00DD.9050606@oracle.com> Hi Roger, Thanks for update. Is the new change only for Hijrah calendar? Or I need to change test data for JapaneseChronology, MinguoChronology and ThaiBuddhistChronology also? If not, is it ok to push webrev for JapaneseChronology, MinguoChronology and ThaiBuddhistChronology into threeten repo firstly? Regards Patrick On 1/30/13 11:39 PM, Roger Riggs wrote: > Hi Patrick, > > The data for these tests may need to change; we are expecting > to replace the default Hijrah calendar with one defined by the Saudi > government > (Umm al-Qura). > Also there will be another variant as well. > > The structure of the test is good and it will be easy to update. > > Thanks, Roger > > > > On 1/30/2013 1:26 AM, Patrick Zhang wrote: >> Hi Team, >> >> Please help to review below new added test case: >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html >> >> >> test result: >> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr >> >> >> Description: >> The new added test cases are used for prolepticYear() and isLeapYear(). >> 1. As description of HijrahChronology, year >> 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add >> test_isLeapYear() to check it. And for leap year, date(prolepticYear, >> 12, 30) should be equal with dateYearDay(prolepticYear, 355). For >> non-leap year, date(prolepticYear, 12, 29) should be equal with >> dateYearDay(prolepticYear, 354). >> >> 2. We can get below table from definition of HijrahChronology: >> ISO prolepticYear 618 >> 619 >> 620 >> 621 >> 622 >> 623 >> 624 >> ... >> year of ERA_AH -2 >> -1 >> 0 >> 1 >> 2 >> 3 >> 4 >> ... >> year of ERA_BEFORE_AH 3 >> 2 >> 1 >> 0 >> -1 >> -2 >> -3 >> ... >> >> >> From above table, then we can get return value of prolepticYear(): >> prolepticYear(ERA_AH, a) = a; >> prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = 1; >> It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. >> >> Above logic has been verified in test_prolepticYear() >> >> >> Regards >> Patrick > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > From scolebourne at joda.org Thu Jan 31 01:34:30 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 31 Jan 2013 09:34:30 +0000 Subject: [threeten-dev] [threeten-develop] Review for #236 Chrono.ofLocale doesn't work. In-Reply-To: <5109D28B.2040105@Oracle.com> References: <5109D28B.2040105@Oracle.com> Message-ID: +1 to push. Stephen On 31 January 2013 02:10, Roger Riggs wrote: > Review for #236 Chrono.ofLocale doesn't work. > Make sure the cache has been initialized if the requested calendar is > not found. > > http://cr.openjdk.java.net/~rriggs/webrev-oflocale-236 > > [Other parts of #236 have not yet been addressed] > > Roger > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > _______________________________________________ > threeten-develop mailing list > threeten-develop at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/threeten-develop From Roger.Riggs at oracle.com Thu Jan 31 05:54:11 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 31 Jan 2013 08:54:11 -0500 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <510A00DD.9050606@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <51093EC4.9000604@oracle.com> <510A00DD.9050606@oracle.com> Message-ID: <510A7783.1060704@oracle.com> Hi Patrick, Yes it is only Hijrah that will be updated. Please push (or Sherman or I can push) all of your changes. Roger On 1/31/2013 12:27 AM, Patrick Zhang wrote: > Hi Roger, > > Thanks for update. Is the new change only for Hijrah calendar? > Or I need to change test data for JapaneseChronology, MinguoChronology > and ThaiBuddhistChronology also? > > If not, is it ok to push webrev for JapaneseChronology, > MinguoChronology and ThaiBuddhistChronology into threeten repo firstly? > > Regards > Patrick > > On 1/30/13 11:39 PM, Roger Riggs wrote: >> Hi Patrick, >> >> The data for these tests may need to change; we are expecting >> to replace the default Hijrah calendar with one defined by the Saudi >> government >> (Umm al-Qura). >> Also there will be another variant as well. >> >> The structure of the test is good and it will be easy to update. >> >> Thanks, Roger >> >> >> >> On 1/30/2013 1:26 AM, Patrick Zhang wrote: >>> Hi Team, >>> >>> Please help to review below new added test case: >>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html >>> >>> >>> test result: >>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr >>> >>> >>> Description: >>> The new added test cases are used for prolepticYear() and isLeapYear(). >>> 1. As description of HijrahChronology, year >>> 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add >>> test_isLeapYear() to check it. And for leap year, >>> date(prolepticYear, 12, 30) should be equal with >>> dateYearDay(prolepticYear, 355). For non-leap year, >>> date(prolepticYear, 12, 29) should be equal with >>> dateYearDay(prolepticYear, 354). >>> >>> 2. We can get below table from definition of HijrahChronology: >>> ISO prolepticYear 618 >>> 619 >>> 620 >>> 621 >>> 622 >>> 623 >>> 624 >>> ... >>> year of ERA_AH -2 >>> -1 >>> 0 >>> 1 >>> 2 >>> 3 >>> 4 >>> ... >>> year of ERA_BEFORE_AH 3 >>> 2 >>> 1 >>> 0 >>> -1 >>> -2 >>> -3 >>> ... >>> >>> >>> From above table, then we can get return value of prolepticYear(): >>> prolepticYear(ERA_AH, a) = a; >>> prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = 1; >>> It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. >>> >>> Above logic has been verified in test_prolepticYear() >>> >>> >>> Regards >>> Patrick >> >> -- >> Thanks, Roger >> >> Oracle Java Platform Group >> >> Green Oracle Oracle is committed >> to developing practices and products that help protect the environment >> -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From roger.riggs at oracle.com Thu Jan 31 06:10:33 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 31 Jan 2013 14:10:33 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 2 new changesets Message-ID: <20130131141153.78A7D476E5@hg.openjdk.java.net> Changeset: 39bc75fb12f7 Author: rriggs Date: 2013-01-31 09:04 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/39bc75fb12f7 #236 Chrono.ofLocale doesn't work Update to perform the cache initialization once if the requested calendar is not found ! src/share/classes/java/time/chrono/Chronology.java Changeset: 2174cddf00e6 Author: rriggs Date: 2013-01-31 09:09 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2174cddf00e6 Merge - src/share/classes/java/time/format/DateTimePrintException.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java From scolebourne at joda.org Thu Jan 31 09:24:09 2013 From: scolebourne at joda.org (Stephen Colebourne) Date: Thu, 31 Jan 2013 17:24:09 +0000 Subject: [threeten-dev] Duration/Period change Message-ID: The proposed changes has been described in more detail on the issue: https://github.com/ThreeTen/threeten/issues/248 Basically, it removes the time-fields from Period, and extends the usabaility of Duration without changing its underlying nature or class names. This is a simplification that seems beneficial in the codebase. Javdoc for (most of) the proposed change is here: http://threeten.github.com/threeten/dev/periodduration/ Stephen From roger.riggs at oracle.com Thu Jan 31 11:51:26 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 31 Jan 2013 19:51:26 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: #224 Reinstate ToLocalDate() and friends Message-ID: <20130131195148.D04E5476F6@hg.openjdk.java.net> Changeset: 2d00ff379ff2 Author: rriggs Date: 2013-01-31 14:14 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2d00ff379ff2 #224 Reinstate ToLocalDate() and friends ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendars/TestMinguoChronology.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/test/java/time/TestLocalDateTime.java ! test/java/time/test/java/time/TestOffsetDateTime.java ! test/java/time/test/java/time/TestOffsetDateTime_instants.java ! test/java/time/test/java/util/TestFormatter.java From dan.chiba at oracle.com Thu Jan 31 15:13:50 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Thu, 31 Jan 2013 15:13:50 -0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <510A7783.1060704@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <51093EC4.9000604@oracle.com> <510A00DD.9050606@oracle.com> <510A7783.1060704@oracle.com> Message-ID: <510AFAAE.4010208@oracle.com> Hi Roger, Finally got an update from the SA presales team about the ETA of variants' data/spec: "The person we were directed to was on leave. I have left him several voice messages and following up. I believe we will have some feedback within two weeks max. Is this within the time frame for Rel 8?" I told them CCC request is due 2/4, merge is 2/13 so if we don't receive it soon, we may jeopardize the quality or even availability of Hijrah calendar support in the Java 8 release. As far as the default variant (Umm Al-Qura) goes, the data we currently have is very likely to be correct (from Microsoft implementation). I am not sure if the range is fine (currently 1900 through 2080 Gregorian years) but I think this is a reasonable coverage. Can I just ask them to rush it asap and say we'll do our best to make the release? I asked specifically if there is any legal process is required, so we'll be less likely to run out of time. Anything else you suggest to be clear to them? Patrick, You could get the updated mapping of the Hijrah default variant and ISO dates here: https://stbeehive.oracle.com/content/dav/st/SGT/Public%20Documents/sgtc/projects/J2SE/JSR-310/HijrahData/umalqura.txt Regards, -Dan On 1/31/2013 5:54 AM, Roger Riggs wrote: > Hi Patrick, > > Yes it is only Hijrah that will be updated. > > Please push (or Sherman or I can push) all of your changes. > > Roger > > > On 1/31/2013 12:27 AM, Patrick Zhang wrote: >> Hi Roger, >> >> Thanks for update. Is the new change only for Hijrah calendar? >> Or I need to change test data for JapaneseChronology, >> MinguoChronology and ThaiBuddhistChronology also? >> >> If not, is it ok to push webrev for JapaneseChronology, >> MinguoChronology and ThaiBuddhistChronology into threeten repo firstly? >> >> Regards >> Patrick >> >> On 1/30/13 11:39 PM, Roger Riggs wrote: >>> Hi Patrick, >>> >>> The data for these tests may need to change; we are expecting >>> to replace the default Hijrah calendar with one defined by the Saudi >>> government >>> (Umm al-Qura). >>> Also there will be another variant as well. >>> >>> The structure of the test is good and it will be easy to update. >>> >>> Thanks, Roger >>> >>> >>> >>> On 1/30/2013 1:26 AM, Patrick Zhang wrote: >>>> Hi Team, >>>> >>>> Please help to review below new added test case: >>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html >>>> >>>> >>>> >>>> test result: >>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr >>>> >>>> >>>> >>>> Description: >>>> The new added test cases are used for prolepticYear() and >>>> isLeapYear(). >>>> 1. As description of HijrahChronology, year >>>> 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add >>>> test_isLeapYear() to check it. And for leap year, >>>> date(prolepticYear, 12, 30) should be equal with >>>> dateYearDay(prolepticYear, 355). For non-leap year, >>>> date(prolepticYear, 12, 29) should be equal with >>>> dateYearDay(prolepticYear, 354). >>>> >>>> 2. We can get below table from definition of HijrahChronology: >>>> ISO prolepticYear 618 >>>> 619 >>>> 620 >>>> 621 >>>> 622 >>>> 623 >>>> 624 >>>> ... >>>> year of ERA_AH -2 >>>> -1 >>>> 0 >>>> 1 >>>> 2 >>>> 3 >>>> 4 >>>> ... >>>> year of ERA_BEFORE_AH 3 >>>> 2 >>>> 1 >>>> 0 >>>> -1 >>>> -2 >>>> -3 >>>> ... >>>> >>>> >>>> From above table, then we can get return value of prolepticYear(): >>>> prolepticYear(ERA_AH, a) = a; >>>> prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = >>>> 1; It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. >>>> >>>> Above logic has been verified in test_prolepticYear() >>>> >>>> >>>> Regards >>>> Patrick >>> >>> -- >>> Thanks, Roger >>> >>> Oracle Java Platform Group >>> >>> Green Oracle Oracle is committed >>> to developing practices and products that help protect the environment >>> > From Roger.Riggs at oracle.com Thu Jan 31 15:17:13 2013 From: Roger.Riggs at oracle.com (Roger Riggs) Date: Thu, 31 Jan 2013 18:17:13 -0500 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <510AFAAE.4010208@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <51093EC4.9000604@oracle.com> <510A00DD.9050606@oracle.com> <510A7783.1060704@oracle.com> <510AFAAE.4010208@oracle.com> Message-ID: <510AFB79.8040301@oracle.com> Hi Dan, We can make it work, there are ample opportunities to fix up any problems for SE 8. The legal aspect is the only one that I'd worry about. Thanks, Roger On 1/31/2013 6:13 PM, Dan Chiba wrote: > Hi Roger, > > Finally got an update from the SA presales team about the ETA of > variants' data/spec: > > "The person we were directed to was on leave. I have left him several > voice messages and following up. I believe we will have some feedback > within two weeks max. Is this within the time frame for Rel 8?" > > I told them CCC request is due 2/4, merge is 2/13 so if we don't > receive it soon, we may jeopardize the quality or even availability of > Hijrah calendar support in the Java 8 release. > > As far as the default variant (Umm Al-Qura) goes, the data we > currently have is very likely to be correct (from Microsoft > implementation). I am not sure if the range is fine (currently 1900 > through 2080 Gregorian years) but I think this is a reasonable coverage. > > Can I just ask them to rush it asap and say we'll do our best to make > the release? I asked specifically if there is any legal process is > required, so we'll be less likely to run out of time. Anything else > you suggest to be clear to them? > > Patrick, > > You could get the updated mapping of the Hijrah default variant and > ISO dates here: > https://stbeehive.oracle.com/content/dav/st/SGT/Public%20Documents/sgtc/projects/J2SE/JSR-310/HijrahData/umalqura.txt > > > Regards, > -Dan > > On 1/31/2013 5:54 AM, Roger Riggs wrote: >> Hi Patrick, >> >> Yes it is only Hijrah that will be updated. >> >> Please push (or Sherman or I can push) all of your changes. >> >> Roger >> >> >> On 1/31/2013 12:27 AM, Patrick Zhang wrote: >>> Hi Roger, >>> >>> Thanks for update. Is the new change only for Hijrah calendar? >>> Or I need to change test data for JapaneseChronology, >>> MinguoChronology and ThaiBuddhistChronology also? >>> >>> If not, is it ok to push webrev for JapaneseChronology, >>> MinguoChronology and ThaiBuddhistChronology into threeten repo firstly? >>> >>> Regards >>> Patrick >>> >>> On 1/30/13 11:39 PM, Roger Riggs wrote: >>>> Hi Patrick, >>>> >>>> The data for these tests may need to change; we are expecting >>>> to replace the default Hijrah calendar with one defined by the >>>> Saudi government >>>> (Umm al-Qura). >>>> Also there will be another variant as well. >>>> >>>> The structure of the test is good and it will be easy to update. >>>> >>>> Thanks, Roger >>>> >>>> >>>> >>>> On 1/30/2013 1:26 AM, Patrick Zhang wrote: >>>>> Hi Team, >>>>> >>>>> Please help to review below new added test case: >>>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html >>>>> >>>>> >>>>> >>>>> test result: >>>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr >>>>> >>>>> >>>>> >>>>> Description: >>>>> The new added test cases are used for prolepticYear() and >>>>> isLeapYear(). >>>>> 1. As description of HijrahChronology, year >>>>> 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add >>>>> test_isLeapYear() to check it. And for leap year, >>>>> date(prolepticYear, 12, 30) should be equal with >>>>> dateYearDay(prolepticYear, 355). For non-leap year, >>>>> date(prolepticYear, 12, 29) should be equal with >>>>> dateYearDay(prolepticYear, 354). >>>>> >>>>> 2. We can get below table from definition of HijrahChronology: >>>>> ISO prolepticYear 618 >>>>> 619 >>>>> 620 >>>>> 621 >>>>> 622 >>>>> 623 >>>>> 624 >>>>> ... >>>>> year of ERA_AH -2 >>>>> -1 >>>>> 0 >>>>> 1 >>>>> 2 >>>>> 3 >>>>> 4 >>>>> ... >>>>> year of ERA_BEFORE_AH 3 >>>>> 2 >>>>> 1 >>>>> 0 >>>>> -1 >>>>> -2 >>>>> -3 >>>>> ... >>>>> >>>>> >>>>> From above table, then we can get return value of prolepticYear(): >>>>> prolepticYear(ERA_AH, a) = a; >>>>> prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = >>>>> 1; It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. >>>>> >>>>> Above logic has been verified in test_prolepticYear() >>>>> >>>>> >>>>> Regards >>>>> Patrick >>>> >>>> -- >>>> Thanks, Roger >>>> >>>> Oracle Java Platform Group >>>> >>>> Green Oracle Oracle is committed >>>> to developing practices and products that help protect the environment >>>> >> -- Thanks, Roger Oracle Java Platform Group Green Oracle Oracle is committed to developing practices and products that help protect the environment From scolebourne at joda.org Thu Jan 31 16:08:06 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 01 Feb 2013 00:08:06 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Fix bug in DateTimeBuilder Message-ID: <20130201000827.7AD8047716@hg.openjdk.java.net> Changeset: dd8ac4ab790b Author: scolebourne Date: 2013-02-01 00:07 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/dd8ac4ab790b Fix bug in DateTimeBuilder Resolved date/time wasn't being picked up for TemporalAccessor ! src/share/classes/java/time/format/DateTimeBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java From dan.chiba at oracle.com Thu Jan 31 16:52:44 2013 From: dan.chiba at oracle.com (Dan Chiba) Date: Thu, 31 Jan 2013 16:52:44 -0800 Subject: [threeten-dev] Please help to review new test code for java.time.calendars.HijrahChronology In-Reply-To: <510AFB79.8040301@oracle.com> References: <50EFCCF6.50300@oracle.com> <50F3C896.6050503@oracle.com> <50FB8F50.1030004@oracle.com> <50FCE5E4.2040007@oracle.com> <5108BD08.8000903@oracle.com> <51093EC4.9000604@oracle.com> <510A00DD.9050606@oracle.com> <510A7783.1060704@oracle.com> <510AFAAE.4010208@oracle.com> <510AFB79.8040301@oracle.com> Message-ID: <510B11DC.9060809@oracle.com> Thank you Roger, I'll tell them we would like to figure out the applicable legal process soon. Regards, -Dan On 1/31/2013 3:17 PM, Roger Riggs wrote: > Hi Dan, > > We can make it work, there are ample opportunities to fix up any > problems for SE 8. > > The legal aspect is the only one that I'd worry about. > > Thanks, Roger > > > On 1/31/2013 6:13 PM, Dan Chiba wrote: >> Hi Roger, >> >> Finally got an update from the SA presales team about the ETA of >> variants' data/spec: >> >> "The person we were directed to was on leave. I have left him several >> voice messages and following up. I believe we will have some feedback >> within two weeks max. Is this within the time frame for Rel 8?" >> >> I told them CCC request is due 2/4, merge is 2/13 so if we don't >> receive it soon, we may jeopardize the quality or even availability >> of Hijrah calendar support in the Java 8 release. >> >> As far as the default variant (Umm Al-Qura) goes, the data we >> currently have is very likely to be correct (from Microsoft >> implementation). I am not sure if the range is fine (currently 1900 >> through 2080 Gregorian years) but I think this is a reasonable coverage. >> >> Can I just ask them to rush it asap and say we'll do our best to make >> the release? I asked specifically if there is any legal process is >> required, so we'll be less likely to run out of time. Anything else >> you suggest to be clear to them? >> >> Patrick, >> >> You could get the updated mapping of the Hijrah default variant and >> ISO dates here: >> https://stbeehive.oracle.com/content/dav/st/SGT/Public%20Documents/sgtc/projects/J2SE/JSR-310/HijrahData/umalqura.txt >> >> >> Regards, >> -Dan >> >> On 1/31/2013 5:54 AM, Roger Riggs wrote: >>> Hi Patrick, >>> >>> Yes it is only Hijrah that will be updated. >>> >>> Please push (or Sherman or I can push) all of your changes. >>> >>> Roger >>> >>> >>> On 1/31/2013 12:27 AM, Patrick Zhang wrote: >>>> Hi Roger, >>>> >>>> Thanks for update. Is the new change only for Hijrah calendar? >>>> Or I need to change test data for JapaneseChronology, >>>> MinguoChronology and ThaiBuddhistChronology also? >>>> >>>> If not, is it ok to push webrev for JapaneseChronology, >>>> MinguoChronology and ThaiBuddhistChronology into threeten repo >>>> firstly? >>>> >>>> Regards >>>> Patrick >>>> >>>> On 1/30/13 11:39 PM, Roger Riggs wrote: >>>>> Hi Patrick, >>>>> >>>>> The data for these tests may need to change; we are expecting >>>>> to replace the default Hijrah calendar with one defined by the >>>>> Saudi government >>>>> (Umm al-Qura). >>>>> Also there will be another variant as well. >>>>> >>>>> The structure of the test is good and it will be easy to update. >>>>> >>>>> Thanks, Roger >>>>> >>>>> >>>>> >>>>> On 1/30/2013 1:26 AM, Patrick Zhang wrote: >>>>>> Hi Team, >>>>>> >>>>>> Please help to review below new added test case: >>>>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/test/java/time/tck/java/time/calendars/TestHijrahChronology.java.udiff.html >>>>>> >>>>>> >>>>>> >>>>>> test result: >>>>>> http://cr.openjdk.java.net/~pzhang/JSR310/java/time/calendars/HijrahChronology/TestHijrahChronology.jtr >>>>>> >>>>>> >>>>>> >>>>>> Description: >>>>>> The new added test cases are used for prolepticYear() and >>>>>> isLeapYear(). >>>>>> 1. As description of HijrahChronology, year >>>>>> 2,5,7,10,,13,16,18,21,24,26 and 29 will be leap years. So add >>>>>> test_isLeapYear() to check it. And for leap year, >>>>>> date(prolepticYear, 12, 30) should be equal with >>>>>> dateYearDay(prolepticYear, 355). For non-leap year, >>>>>> date(prolepticYear, 12, 29) should be equal with >>>>>> dateYearDay(prolepticYear, 354). >>>>>> >>>>>> 2. We can get below table from definition of HijrahChronology: >>>>>> ISO prolepticYear 618 >>>>>> 619 >>>>>> 620 >>>>>> 621 >>>>>> 622 >>>>>> 623 >>>>>> 624 >>>>>> ... >>>>>> year of ERA_AH -2 >>>>>> -1 >>>>>> 0 >>>>>> 1 >>>>>> 2 >>>>>> 3 >>>>>> 4 >>>>>> ... >>>>>> year of ERA_BEFORE_AH 3 >>>>>> 2 >>>>>> 1 >>>>>> 0 >>>>>> -1 >>>>>> -2 >>>>>> -3 >>>>>> ... >>>>>> >>>>>> >>>>>> From above table, then we can get return value of prolepticYear(): >>>>>> prolepticYear(ERA_AH, a) = a; >>>>>> prolepticYear(ERA_BEFORE_AH, a) + prolepticYear(ERA_AH, a) = >>>>>> 1; It means prolepticYear(ERA_BEFORE_AH, a)= 1-a. >>>>>> >>>>>> Above logic has been verified in test_prolepticYear() >>>>>> >>>>>> >>>>>> Regards >>>>>> Patrick >>>>> >>>>> -- >>>>> Thanks, Roger >>>>> >>>>> Oracle Java Platform Group >>>>> >>>>> Green Oracle Oracle is >>>>> committed to developing practices and products that help protect >>>>> the environment >>>>> >>> > > -- > Thanks, Roger > > Oracle Java Platform Group > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > From scolebourne at joda.org Thu Jan 31 18:05:52 2013 From: scolebourne at joda.org (scolebourne at joda.org) Date: Fri, 01 Feb 2013 02:05:52 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: Make padding formatter element handle case insenstive and lenient Message-ID: <20130201020604.8D7DE47722@hg.openjdk.java.net> Changeset: 9b2f291c81d6 Author: scolebourne Date: 2013-02-01 02:03 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9b2f291c81d6 Make padding formatter element handle case insenstive and lenient Simplified behavior slightly wrt weird edge cases Fixes #235 ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKPadPrinterParser.java - test/java/time/test/java/time/format/TestPadParserDecorator.java From roger.riggs at oracle.com Thu Jan 31 19:49:45 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:49:45 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxws: Added tag jdk8-b74 for changeset 12db3c5a3393 Message-ID: <20130201034952.A8B2D4772F@hg.openjdk.java.net> Changeset: 966bf9f3c41a Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxws/rev/966bf9f3c41a Added tag jdk8-b74 for changeset 12db3c5a3393 ! .hgtags From roger.riggs at oracle.com Thu Jan 31 19:51:07 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:51:07 +0000 Subject: [threeten-dev] hg: threeten/threeten/corba: Added tag jdk8-b74 for changeset 2132845cf5f7 Message-ID: <20130201035108.DA19747732@hg.openjdk.java.net> Changeset: d4e68ce17795 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/corba/rev/d4e68ce17795 Added tag jdk8-b74 for changeset 2132845cf5f7 ! .hgtags From roger.riggs at oracle.com Thu Jan 31 19:50:24 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:50:24 +0000 Subject: [threeten-dev] hg: threeten/threeten: 25 new changesets Message-ID: <20130201035026.507F347730@hg.openjdk.java.net> Changeset: 50307da0149e Author: jqzuo Date: 2012-12-31 14:52 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/50307da0149e 8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo builds Reviewed-by: paulk, billyh ! make/install-rules.gmk Changeset: e5664599a127 Author: cgruszka Date: 2013-01-02 14:54 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/e5664599a127 Merge Changeset: 75634cbeab47 Author: cgruszka Date: 2013-01-04 13:11 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/75634cbeab47 Merge Changeset: 61d7e2971723 Author: cgruszka Date: 2013-01-14 14:40 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/61d7e2971723 Merge Changeset: f9163f9cb1da Author: cgruszka Date: 2013-01-23 08:50 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/f9163f9cb1da Merge Changeset: 5a5e97f9ac0a Author: erikj Date: 2013-01-18 09:58 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/5a5e97f9ac0a 8006520: build-infra: Fix sparkle-framework configure parameter Reviewed-by: tbell, ohair ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: edad83acbd46 Author: erikj Date: 2013-01-18 16:48 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/edad83acbd46 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: c3bf62746a80 Author: tbell Date: 2013-01-23 13:30 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/c3bf62746a80 8006797: build-infra JPRT builds need JPRT_ARCHIVE_INSTALL_BUNDLE in common/makefiles/Jprt.gmk Reviewed-by: ohair ! common/makefiles/Jprt.gmk Changeset: b43aa5bd8ca5 Author: katleman Date: 2013-01-23 15:40 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/b43aa5bd8ca5 Merge Changeset: cd2fa0d0ed3d Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/cd2fa0d0ed3d Added tag jdk8-b74 for changeset b43aa5bd8ca5 ! .hgtags Changeset: 1129fb75f611 Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/1129fb75f611 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: cecfba251e4a Author: lana Date: 2013-01-16 11:58 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/cecfba251e4a Merge Changeset: 2e12a508d7ae Author: lana Date: 2013-01-20 23:35 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2e12a508d7ae Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/makefiles/javadoc/Javadoc.gmk Changeset: 8209c91b751d Author: sherman Date: 2013-01-22 21:02 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/8209c91b751d 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! common/makefiles/javadoc/CORE_PKGS.gmk ! make/jprt.properties ! test/Makefile Changeset: 039783b67959 Author: lana Date: 2013-01-26 18:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/039783b67959 Merge Changeset: e28985c549aa Author: raginip Date: 2013-01-18 11:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/e28985c549aa 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! common/bin/compare_exceptions.sh.incl Changeset: db46b1c27a93 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/db46b1c27a93 Merge - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl Changeset: 8baaaba2ee6b Author: lana Date: 2013-01-29 20:16 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/8baaaba2ee6b Merge Changeset: 0d4b0a13adb2 Author: erikj Date: 2013-01-23 11:37 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/0d4b0a13adb2 8005855: build-infra: Remove -R flag when cross compiling Reviewed-by: dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: ea6379d4624f Author: erikj Date: 2013-01-23 11:41 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/ea6379d4624f 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh Reviewed-by: tbell ! common/bin/compare.sh Changeset: 0d46733cfffb Author: erikj Date: 2013-01-23 11:42 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/0d46733cfffb 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER Reviewed-by: ohrstrom, dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: 9e5847257731 Author: erikj Date: 2013-01-24 09:17 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/rev/9e5847257731 Merge Changeset: 2a713921952c Author: katleman Date: 2013-01-30 13:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/2a713921952c Merge ! common/autoconf/generated-configure.sh Changeset: 5b19cef637a6 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags Changeset: a61007e284e8 Author: rriggs Date: 2013-01-31 20:26 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/rev/a61007e284e8 Merge From roger.riggs at oracle.com Thu Jan 31 19:50:36 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:50:36 +0000 Subject: [threeten-dev] hg: threeten/threeten/jaxp: 5 new changesets Message-ID: <20130201035100.64D3847731@hg.openjdk.java.net> Changeset: 69bc57b1ebdd Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/69bc57b1ebdd Added tag jdk8-b74 for changeset 2087e24a4357 ! .hgtags Changeset: 47738fa4d411 Author: dbuck Date: 2013-01-10 20:26 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/47738fa4d411 8003147: port fix for BCEL bug 39695 Summary: Added support for Local Variable Type Table so that BCEL library can be used to modify methods with generics-related debug data without violating class file format Reviewed-by: lancea ! src/com/sun/org/apache/bcel/internal/Constants.java ! src/com/sun/org/apache/bcel/internal/classfile/Attribute.java ! src/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java ! src/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java + src/com/sun/org/apache/bcel/internal/classfile/LocalVariableTypeTable.java ! src/com/sun/org/apache/bcel/internal/classfile/Visitor.java ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java Changeset: 06827097cdd3 Author: lana Date: 2013-01-16 12:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/06827097cdd3 Merge Changeset: 4e049aa2495f Author: lana Date: 2013-01-20 23:37 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/4e049aa2495f Merge Changeset: ff0b73a6b3f6 Author: lana Date: 2013-01-26 18:25 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jaxp/rev/ff0b73a6b3f6 Merge From roger.riggs at oracle.com Thu Jan 31 19:52:06 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:52:06 +0000 Subject: [threeten-dev] hg: threeten/threeten/hotspot: 65 new changesets Message-ID: <20130201035540.A178147733@hg.openjdk.java.net> Changeset: 89fc17e8d808 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/89fc17e8d808 Added tag jdk8-b74 for changeset 1a3e54283c54 ! .hgtags Changeset: d58b7b43031b Author: amurillo Date: 2013-01-11 02:02 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d58b7b43031b 8006034: new hotspot build - hs25-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adc176e95bf2 Author: acorn Date: 2013-01-09 11:39 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/adc176e95bf2 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests Summary: Fix verifier for new interface access flags Reviewed-by: acorn, kvn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: dd7248d3e151 Author: zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search path Reviewed-by: dcubed, sla ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp Changeset: 97ee8abd6ab2 Author: zgu Date: 2013-01-09 12:10 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/97ee8abd6ab2 Merge Changeset: aefb345d3f5e Author: acorn Date: 2013-01-10 17:38 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/aefb345d3f5e 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow Summary: Reduce scope of placeholder table entries to improve cleanup Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/utilities/exceptions.hpp Changeset: 91bf7da5c609 Author: mikael Date: 2013-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/91bf7da5c609 8004747: Remove last_entry from VM_STRUCT macros Summary: Instead of passing in last_entry to all the VM_ macros just expand it in the main vmStructs.cpp file. Reviewed-by: dholmes, sspitsyn, minqi ! src/cpu/sparc/vm/vmStructs_sparc.hpp ! src/cpu/x86/vm/vmStructs_x86.hpp ! src/cpu/zero/vm/vmStructs_zero.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c1c8479222cd Author: dholmes Date: 2013-01-10 21:00 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c1c8479222cd 8005921: Memory leaks in vmStructs.cpp Reviewed-by: dholmes, mikael, rasbold Contributed-by: Jeremy Manson ! src/share/vm/runtime/vmStructs.cpp Changeset: e0cf9af8978e Author: zgu Date: 2013-01-11 12:30 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e0cf9af8978e 8005936: PrintNMTStatistics doesn't work for normal JVM exit Summary: Moved NMT shutdown code to JVM exit handler to ensure NMT statistics is printed when PrintNMTStatistics is enabled Reviewed-by: acorn, dholmes, coleenp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 90a92d5bca17 Author: zgu Date: 2013-01-11 09:53 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/90a92d5bca17 Merge Changeset: 4a916f2ce331 Author: jwilhelm Date: 2013-01-14 15:17 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4a916f2ce331 8003985: Support @Contended Annotation - JEP 142 Summary: HotSpot changes to support @Contended annotation. Reviewed-by: coleenp, kvn, jrose Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f9eb431c3efe Author: coleenp Date: 2013-01-14 11:01 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f9eb431c3efe 8006005: Fix constant pool index validation and alignment trap for method parameter reflection Summary: This patch addresses an alignment trap due to the storage format of method parameters data in constMethod. It also adds code to validate constant pool indexes for method parameters data. Reviewed-by: jrose, dholmes Contributed-by: eric.mccorkle at oracle.com ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/reflection.cpp Changeset: 5b6a231e5a86 Author: coleenp Date: 2013-01-14 08:37 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/5b6a231e5a86 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: fe1472c87a27 Author: mikael Date: 2013-01-14 11:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/fe1472c87a27 8005592: ClassLoaderDataGraph::_unloading incorrectly defined as nonstatic in vmStructs Summary: Added assertion to catch problem earlier and removed the unused field Reviewed-by: dholmes, acorn ! src/share/vm/runtime/vmStructs.cpp Changeset: c793367610c1 Author: coleenp Date: 2013-01-15 17:05 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c793367610c1 8005467: CDS size information is incorrect and unfriendly Summary: Changed words to bytes, and added usage percentage information Reviewed-by: coleenp, twisti Contributed-by: ioi.lam at oracle.com ! src/share/vm/memory/metaspaceShared.cpp Changeset: 92d4b5d8dde4 Author: acorn Date: 2013-01-16 18:23 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/92d4b5d8dde4 Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 337e1dd9d902 Author: jiangli Date: 2013-01-11 16:55 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/337e1dd9d902 8005895: Inefficient InstanceKlass field packing wasts memory. Summary: Pack _misc_has_default_methods into the _misc_flags, move _idnum_allocated_count. Reviewed-by: coleenp, shade ! src/share/vm/oops/instanceKlass.hpp Changeset: 94fa3c4e7643 Author: vladidan Date: 2013-01-14 13:44 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/94fa3c4e7643 8005639: Move InlineSynchronizedMethods flag from develop to product Summary: Move InlineSynchronizedMethods flag from develop to product Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/c1/c1_globals.hpp Changeset: 9deda4d8e126 Author: vladidan Date: 2013-01-14 13:52 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/9deda4d8e126 8005204: Code Cache Reduction: command line options implementation Summary: Adding more detailed output on CodeCache usage Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 212c5b9c38e7 Author: dlong Date: 2013-01-17 01:27 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/212c5b9c38e7 Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: a3f92e6c0274 Author: twisti Date: 2013-01-11 14:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a3f92e6c0274 8006031: LibraryCallKit::inline_array_copyOf disabled unintentionally with 7172640 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: f9bda35f4226 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f9bda35f4226 8005816: Shark: fix volatile float field access Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkBlock.cpp Changeset: c566b81b3323 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c566b81b3323 8005817: Shark: implement deoptimization support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/sharkFrame_zero.hpp ! src/share/vm/shark/sharkInvariants.hpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: c095a7f289aa Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c095a7f289aa 8005818: Shark: fix OSR for non-empty incoming stack Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkFunction.cpp ! src/share/vm/shark/sharkInvariants.hpp Changeset: 606eada1bf86 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/606eada1bf86 8005820: Shark: enable JSR292 support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkCompiler.hpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkInliner.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: 6d1f5516534e Author: twisti Date: 2013-01-11 20:01 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/6d1f5516534e 8006127: remove printing code added with 8006031 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: d92fa52a5d03 Author: vlivanov Date: 2013-01-14 08:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d92fa52a5d03 8006095: C1: SIGSEGV w/ -XX:+LogCompilation Summary: avoid printing inlining decision when compilation fails Reviewed-by: kvn, roland ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f1de9dbc914e Author: twisti Date: 2013-01-15 12:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f1de9dbc914e 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types Reviewed-by: kvn ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciType.hpp ! src/share/vm/opto/doCall.cpp Changeset: 5b8548391bf3 Author: kvn Date: 2013-01-15 14:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/5b8548391bf3 8005821: C2: -XX:+PrintIntrinsics is broken Summary: Check all print inlining flags when processing inlining list. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! src/share/vm/opto/compile.cpp Changeset: bf623b2d5508 Author: kvn Date: 2013-01-16 14:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/bf623b2d5508 8006204: please JTREGify test/compiler/7190310/Test7190310.java Summary: Add proper jtreg annotations in the preceding comment, including an explicit timeout. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! test/compiler/7190310/Test7190310.java Changeset: eab4f9ed602c Author: kvn Date: 2013-01-17 18:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/eab4f9ed602c Merge ! src/share/vm/compiler/compileBroker.cpp Changeset: 689e1218d7fe Author: brutisso Date: 2013-01-14 09:58 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/689e1218d7fe 8004018: Remove old initialization flags Reviewed-by: dholmes, stefank Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: a30e7b564541 Author: brutisso Date: 2013-01-14 21:30 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a30e7b564541 8005972: ParNew should not update the tenuring threshold when promotion failed has occurred Reviewed-by: ysr, johnc, jwilhelm ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp Changeset: ed6154d7d259 Author: stefank Date: 2013-01-15 13:32 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ed6154d7d259 8005590: java_lang_Class injected field resolved_constructor appears unused Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ff0a7943fd29 Author: stefank Date: 2013-01-15 10:09 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/ff0a7943fd29 8005994: Method annotations are allocated unnecessarily during class file parsing Summary: Also reviewed by: vitalyd at gmail.com Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jvm.cpp Changeset: 4967eb4f67a9 Author: johnc Date: 2013-01-15 12:32 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/4967eb4f67a9 8001425: G1: Change the default values for certain G1 specific flags Summary: Changes to default and ergonomic flag values recommended by performance team. Changes were also reviewed by Monica Beckwith . Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 2dce7c34c564 Author: stefank Date: 2013-01-17 11:39 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2dce7c34c564 8006513: Null pointer in DefaultMethods::generate_default_methods when merging annotations Reviewed-by: brutisso, jfranck ! src/share/vm/classfile/defaultMethods.cpp Changeset: 59a58e20dc60 Author: jmasa Date: 2013-01-17 19:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/59a58e20dc60 8006537: Assert when dumping archive with default methods Reviewed-by: coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metadataFactory.hpp Changeset: f422634e5828 Author: brutisso Date: 2013-01-18 11:03 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f422634e5828 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 70c89bd6b895 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/70c89bd6b895 Merge Changeset: 2b878edabfc0 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2b878edabfc0 Added tag hs25-b16 for changeset 70c89bd6b895 ! .hgtags Changeset: 46e60405583b Author: amurillo Date: 2013-01-18 05:33 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/46e60405583b 8006511: new hotspot build - hs25-b17 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e94ed1591b42 Author: sla Date: 2013-01-16 16:30 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/e94ed1591b42 8006403: Regression: jstack failed due to the FieldInfo regression in SA Reviewed-by: sla, dholmes Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 557bda927cc2 Author: sla Date: 2013-01-18 14:15 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/557bda927cc2 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: 617b18aadb33 Author: sla Date: 2013-01-18 19:13 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/617b18aadb33 Merge Changeset: 203f64878aab Author: hseigel Date: 2013-01-17 10:25 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/203f64878aab 7102489: RFE: cleanup jlong typedef on __APPLE__and _LLP64 systems. Summary: Define jlong as long on all LP64 platforms and add JLONG_FORMAT macro. Reviewed-by: dholmes, coleenp, mikael, kvn ! src/cpu/x86/vm/jni_x86.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/java_md.h ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/launcher/java_md.c ! src/os/windows/launcher/java_md.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/tools/launcher/java.c ! src/share/tools/launcher/java.h ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/aprofiler.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/taskqueue.cpp Changeset: b14da2e6f2dc Author: coleenp Date: 2013-01-17 13:40 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b14da2e6f2dc 7174978: NPG: Fix bactrace builder for class redefinition Summary: Remove Method* from backtrace but save version so redefine classes doesn't give inaccurate line numbers. Removed old Merlin API with duplicate code. Reviewed-by: dholmes, sspitsyn ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: b5f6465019f6 Author: coleenp Date: 2013-01-17 22:11 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b5f6465019f6 8006548: version wrong in new constantPool code Summary: fix increment problem with saved_version Reviewed-by: dholmes ! src/share/vm/oops/constantPool.hpp Changeset: c07c102cbad7 Author: brutisso Date: 2013-01-21 09:00 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c07c102cbad7 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large Summary: Use HW_MEMSIZE instead of HW_USERMEM to get a 64 bit value of the physical memory on the machine. Also reviewed by vitalyd at gmail.com. Reviewed-by: sla, dholmes, dlong, mikael ! src/os/bsd/vm/os_bsd.cpp Changeset: c73c3f2c5b3b Author: acorn Date: 2013-01-21 16:11 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/c73c3f2c5b3b Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/services/diagnosticArgument.cpp Changeset: f3184f32ce0b Author: dcubed Date: 2013-01-22 05:55 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/f3184f32ce0b 6444286: Possible naked oop related to biased locking revocation safepoint in jni_exit() Summary: Add missing Handle. Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/synchronizer.cpp Changeset: 22ba8c8ce6a6 Author: dcubed Date: 2013-01-22 05:56 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/22ba8c8ce6a6 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/objectMonitor.inline.hpp Changeset: 5ce621176715 Author: dcubed Date: 2013-01-22 05:57 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/5ce621176715 8004903: VMThread::execute() calls Thread::check_for_valid_safepoint_state() on concurrent VM ops Summary: check_for_valid_safepoint_state() only applies to blocking VM ops Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/vmThread.cpp Changeset: edd23b35b1a5 Author: zgu Date: 2013-01-22 14:27 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/edd23b35b1a5 6871190: Don't terminate JVM if it is running in a non-interactive session Summary: Don't handle CTRL_LOGOFF_EVENT event when the process is running in a non-interactive session Reviewed-by: ctornqvi, acorn ! src/os/windows/vm/os_windows.cpp Changeset: 2ef7061f13b4 Author: zgu Date: 2013-01-22 11:54 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/2ef7061f13b4 Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7df93f7c14a5 Author: brutisso Date: 2013-01-16 12:46 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/7df93f7c14a5 8006242: G1: WorkerDataArray::verify() too strict for double calculations Summary: Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, mgerdin ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp Changeset: bf8c2b2c8cfa Author: mgerdin Date: 2013-01-22 13:42 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/bf8c2b2c8cfa 8004147: test/Makefile jtreg_tests target does not work with cygwin Reviewed-by: ctornqvi, brutisso ! test/Makefile Changeset: d754ef7b9352 Author: jmasa Date: 2013-01-24 06:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/d754ef7b9352 Merge Changeset: a7114d3d712e Author: kvn Date: 2013-01-22 11:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/a7114d3d712e 8005055: pass outputStream to more opto debug routines Summary: pass the output stream to node->dump() and everything reachable from there Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/regalloc.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: b30b3c2a0cf2 Author: kvn Date: 2013-01-22 15:34 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b30b3c2a0cf2 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86 Summary: Use SSE4.2 and AVX2 instructions for encodeArray intrinsic. Reviewed-by: roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/6896617/Test6896617.java Changeset: 522c328b8b77 Author: kvn Date: 2013-01-23 15:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/522c328b8b77 8003878: compiler/7196199 test failed on OS X since 8b54, jdk7u12b01 Summary: Limit vectors size to 16 bytes on BSD until the problem is fixed Reviewed-by: twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: 22ead76da3f4 Author: kmo Date: 2013-01-24 02:03 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/22ead76da3f4 8006758: LinkResolver assertion (caused by @Contended changes) Summary: treat anonymous classes as privileged code to restore the special handling for @Compiled during class file parsing Reviewed-by: jrose, coleenp, kvn, dholmes ! src/share/vm/classfile/classFileParser.cpp Changeset: 274a29bf5682 Author: kmo Date: 2013-01-24 09:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/274a29bf5682 Merge Changeset: b4391649e91e Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/b4391649e91e Merge ! .hgtags Changeset: 6778d0b16593 Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/hotspot/rev/6778d0b16593 Added tag hs25-b17 for changeset b4391649e91e ! .hgtags From roger.riggs at oracle.com Thu Jan 31 19:56:13 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 03:56:13 +0000 Subject: [threeten-dev] hg: threeten/threeten/langtools: 35 new changesets Message-ID: <20130201035918.9189947734@hg.openjdk.java.net> Changeset: 54e4ba223319 Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/54e4ba223319 Added tag jdk8-b74 for changeset 56c97aff46bb ! .hgtags Changeset: fc4cb1577ad6 Author: jjg Date: 2013-01-10 19:38 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/fc4cb1577ad6 8004834: Add doclint support into javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/5093723/T5093723.java ! test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testReturnTag/TestReturnTag.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javadoc/6958836/Test.java ! test/tools/javadoc/6964914/Test.java ! test/tools/javadoc/6964914/TestStdDoclet.java ! test/tools/javadoc/MaxWarns.java ! test/tools/javadoc/T6551367.java + test/tools/javadoc/doclint/DocLintTest.java Changeset: 9f42a06a49c0 Author: jfranck Date: 2013-01-14 19:52 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/9f42a06a49c0 7193719: Support repeating annotations in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/Element.java Changeset: df694c775e8a Author: jjg Date: 2013-01-14 13:50 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/df694c775e8a 8006119: update javac to follow latest spec for repeatable annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/BasicRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/CheckTargets.java ! test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java ! test/tools/javac/annotations/repeatingAnnotations/ContainerHasRepeatedContained.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.out ! test/tools/javac/annotations/repeatingAnnotations/DefaultCasePresent.java ! test/tools/javac/annotations/repeatingAnnotations/DelayRepeatedContainer.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InvalidTarget.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.out - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.java ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.out ! test/tools/javac/annotations/repeatingAnnotations/MultiLevelRepeatableAnno.java ! test/tools/javac/annotations/repeatingAnnotations/MultipleAnnoMixedOrder.java ! test/tools/javac/annotations/repeatingAnnotations/NestedContainers.java ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out ! test/tools/javac/annotations/repeatingAnnotations/RepMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepSelfMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingAndContainerPresent.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/annotations/repeatingAnnotations/SelfRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/SingleRepeatingAndContainer.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java + test/tools/javac/annotations/repeatingAnnotations/UseWrongRepeatable.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.out ! test/tools/javac/annotations/repeatingAnnotations/combo/BasicSyntaxCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DeprecatedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DocumentedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/InheritedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/RetentionAnnoCombo.java ! test/tools/javac/diags/examples.not-yet.txt - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java ! test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java + test/tools/javac/diags/examples/RepeatableDocumentedMismatch.java + test/tools/javac/diags/examples/RepeatableInheritedMismatch.java + test/tools/javac/diags/examples/RepeatableNoValue.java + test/tools/javac/diags/examples/RepeatableNonDefault.java + test/tools/javac/diags/examples/RepeatableRetentionMismatch.java + test/tools/javac/diags/examples/RepeatableTargetMismatch.java + test/tools/javac/diags/examples/RepeatableWrongValueType.java ! test/tools/javac/diags/examples/RepeatingAnnotationAndContainer.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java Changeset: d54b4a091450 Author: jjg Date: 2013-01-14 14:17 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/d54b4a091450 8006241: Test DocRootSlash.java fails Reviewed-by: darcy ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java Changeset: f805b5e3c9d1 Author: chegar Date: 2013-01-15 20:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f805b5e3c9d1 8006344: Broken javadoc link in javax.lang.model.element.Element Reviewed-by: lancea, alanb, jfranck ! src/share/classes/javax/lang/model/element/Element.java Changeset: bc1023e0e533 Author: jjg Date: 2013-01-15 13:03 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/bc1023e0e533 8006224: Doclint NPE for attribute with no value Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/AnchorTest.java + test/tools/doclint/AnchorTest.out Changeset: f785dcac17b7 Author: mcimadamore Date: 2013-01-16 16:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f785dcac17b7 8005854: Add support for array constructor references Summary: Support constructor references of the kind int[]::new Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/MethodReference59.java + test/tools/javac/lambda/MethodReference60.java + test/tools/javac/lambda/MethodReference60.out Changeset: 7aa2025bbb7b Author: mcimadamore Date: 2013-01-16 16:30 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7aa2025bbb7b 8005299: Add FunctionalInterface checking to javac Summary: Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadFunctionalIntfAnno.java ! test/tools/javac/lambda/BadConv03.out ! test/tools/javac/lambda/BadLambdaPos.out ! test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/FunctionalInterfaceAnno.java + test/tools/javac/lambda/FunctionalInterfaceAnno.out ! test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaConv09.out ! test/tools/javac/lambda/LambdaExpr10.out ! test/tools/javac/lambda/MethodReference04.out ! test/tools/javac/lambda/TargetType17.out ! test/tools/javac/lambda/TargetType43.out ! test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM3.out ! test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out ! test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out Changeset: 1afdf1f1472b Author: mcimadamore Date: 2013-01-16 17:40 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/1afdf1f1472b 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure Summary: Wrong implementation of ResolveError.access in AmbiguityError Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 6b6311a8c9cc Author: jjg Date: 2013-01-16 10:29 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/6b6311a8c9cc 8006236: doclint: structural issue hidden Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/EndTagsTest.java + test/tools/doclint/EndTagsTest.out Changeset: 63b20bde7cd6 Author: lana Date: 2013-01-16 12:14 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/63b20bde7cd6 Merge Changeset: 8b749558767b Author: darcy Date: 2013-01-16 13:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/8b749558767b 8006283: Change to Class.cast() in javax.lang.model implementation for repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java Changeset: 916143318f10 Author: jjg Date: 2013-01-16 20:41 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/916143318f10 8006228: Doclint doesn't detect {@code nested inline} Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/LiteralTest.java + test/tools/doclint/LiteralTest.out Changeset: 2d2b2be57c78 Author: mcimadamore Date: 2013-01-17 18:15 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/lambda/LambdaParserTest.java Changeset: 22e417cdddee Author: ohrstrom Date: 2013-01-18 00:16 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/22e417cdddee 8004658: Add internal smart javac wrapper to solve JEP 139 Reviewed-by: jjg ! make/build.properties ! make/build.xml + src/share/classes/com/sun/tools/sjavac/BuildState.java + src/share/classes/com/sun/tools/sjavac/CleanProperties.java + src/share/classes/com/sun/tools/sjavac/CompileChunk.java + src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java + src/share/classes/com/sun/tools/sjavac/CompileProperties.java + src/share/classes/com/sun/tools/sjavac/CopyFile.java + src/share/classes/com/sun/tools/sjavac/JavacState.java + src/share/classes/com/sun/tools/sjavac/Log.java + src/share/classes/com/sun/tools/sjavac/Main.java + src/share/classes/com/sun/tools/sjavac/Module.java + src/share/classes/com/sun/tools/sjavac/Package.java + src/share/classes/com/sun/tools/sjavac/ProblemException.java + src/share/classes/com/sun/tools/sjavac/Source.java + src/share/classes/com/sun/tools/sjavac/Transformer.java + src/share/classes/com/sun/tools/sjavac/Util.java + src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java + src/share/classes/com/sun/tools/sjavac/comp/JavaCompilerWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java + src/share/classes/com/sun/tools/sjavac/comp/ResolveWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileManager.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileObject.java + src/share/classes/com/sun/tools/sjavac/comp/SmartWriter.java + src/share/classes/com/sun/tools/sjavac/server/CompilerPool.java + src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java + src/share/classes/com/sun/tools/sjavac/server/JavacServer.java + src/share/classes/com/sun/tools/sjavac/server/PortFile.java + src/share/classes/com/sun/tools/sjavac/server/SysInfo.java + test/tools/sjavac/SJavac.java Changeset: 3d84ae209919 Author: mcimadamore Date: 2013-01-18 15:38 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/UnderscoreAsIdentifier.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.out Changeset: 4a3cfc970c6f Author: jjg Date: 2013-01-21 10:00 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/4a3cfc970c6f 8006263: Supplementary test cases needed for doclint Reviewed-by: mcimadamore Contributed-by: peter.jensen at oracle.com ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Entity.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java + test/tools/doclint/CoverageExtras.java ! test/tools/doclint/DocLintTester.java + test/tools/doclint/html/EntitiesTest.java + test/tools/doclint/html/EntitiesTest.out + test/tools/doclint/tool/HelpTest.java + test/tools/doclint/tool/HelpTest.out + test/tools/doclint/tool/MaxDiagsTest.java + test/tools/doclint/tool/MaxDiagsTest.out + test/tools/doclint/tool/PathsTest.java + test/tools/doclint/tool/RunTest.java + test/tools/doclint/tool/StatsTest.java + test/tools/doclint/tool/StatsTest.out Changeset: 967052c425a1 Author: jjg Date: 2013-01-21 10:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/967052c425a1 8006251: doclint: incorrect position for diagnostic for illegal text in tags Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/html/BlockTagsTest.java + test/tools/doclint/html/InlineTagsTest.java + test/tools/doclint/html/ListTagsTest.java + test/tools/doclint/html/OtherTagsTest.java + test/tools/doclint/html/OtherTagsTest.out + test/tools/doclint/html/TableTagsTest.java + test/tools/doclint/html/TagNotAllowed.java + test/tools/doclint/html/TagNotAllowed.out + test/tools/doclint/html/TextNotAllowed.java + test/tools/doclint/html/TextNotAllowed.out ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/TextNotAllowed.out Changeset: b450959b42ff Author: lana Date: 2013-01-20 23:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/b450959b42ff Merge Changeset: 1985e35e97b2 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/1985e35e97b2 Merge Changeset: 7873d37f5b37 Author: mcimadamore Date: 2013-01-21 20:13 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/Diagnostics/6722234/T6722234d_1.out ! test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java ! test/tools/javac/diags/examples/WhereIntersection.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg10.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference25.out ! test/tools/javac/lambda/MethodReference26.java - test/tools/javac/lambda/MethodReference26.out ! test/tools/javac/lambda/MethodReference43.java ! test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType01.out ! test/tools/javac/lambda/TargetType06.java - test/tools/javac/lambda/TargetType06.out ! test/tools/javac/lambda/TargetType10.out ! test/tools/javac/lambda/TargetType11.java - test/tools/javac/lambda/TargetType11.out ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out ! test/tools/javac/lambda/TargetType26.out ! test/tools/javac/lambda/TargetType27.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType39.out ! test/tools/javac/lambda/TargetType45.java - test/tools/javac/lambda/TargetType45.out ! test/tools/javac/lambda/TargetType50.out + test/tools/javac/lambda/TargetType51.java + test/tools/javac/lambda/TargetType52.java + test/tools/javac/lambda/TargetType52.out ! test/tools/javac/lambda/VoidCompatibility.java - test/tools/javac/lambda/VoidCompatibility.out ! test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReference/SamConversionComboTest.java ! test/tools/javac/lambda/typeInference/InferenceTest_neg5.out ! test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java Changeset: c7c41a044e7c Author: mcimadamore Date: 2013-01-21 20:14 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/c7c41a044e7c 8006566: Remove transient lambda-related guards from JavacParser Summary: Remove transitional internal flag for allowing intersection types in cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/cast/intersection/IntersectionTypeParserTest.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java ! test/tools/javac/lambda/Intersection01.java ! test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: b12ffdfa1341 Author: mcimadamore Date: 2013-01-21 20:15 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/b12ffdfa1341 8005851: Remove support for synchronized interface methods Summary: Synchronized default methods are no longer supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: cf84b07a82db Author: mcimadamore Date: 2013-01-21 20:19 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/cf84b07a82db 8005166: Add support for static interface methods Summary: Support public static interface methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/static/Static01.java + test/tools/javac/defaultMethods/static/Static02.java + test/tools/javac/defaultMethods/static/Static02.out + test/tools/javac/defaultMethods/static/hiding/InterfaceMethodHidingTest.java + test/tools/javac/defaultMethods/static/import/StaticImport1.java + test/tools/javac/defaultMethods/static/import/StaticImport2.java + test/tools/javac/defaultMethods/static/import/StaticImport2.out + test/tools/javac/defaultMethods/static/import/StaticImport3.java + test/tools/javac/defaultMethods/static/import/StaticImport3.out + test/tools/javac/defaultMethods/static/import/pkg/A.java + test/tools/javac/defaultMethods/static/import/pkg/B.java + test/tools/javac/defaultMethods/static/import/pkg/C.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/IllegalStaticIntfMethCall.java + test/tools/javac/diags/examples/StaticIntfMethodNotSupported.java Changeset: be443002e970 Author: mcimadamore Date: 2013-01-22 16:23 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/be443002e970 8006673: TargetType52 fails because of bad golden file Summary: Fix golden file in negative test Reviewed-by: jjg ! test/tools/javac/lambda/TargetType52.out Changeset: b61e5f801f7c Author: mcimadamore Date: 2013-01-22 16:39 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/b61e5f801f7c 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack Summary: Lambda desugaring generates spurious references to 'this' in static contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaExpr21.java Changeset: 8943b4213f59 Author: jjg Date: 2013-01-22 18:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/8943b4213f59 8006723: sjavac test fails to compile on clean build Reviewed-by: ksrini ! test/tools/sjavac/SJavac.java + test/tools/sjavac/SJavacWrapper.java Changeset: f5b70712e0d5 Author: jjg Date: 2013-01-22 19:06 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/f5b70712e0d5 8006728: temporarily workaround jtreg problems for doclint tests in othervm Reviewed-by: jjh + test/tools/doclint/html/AAA.java + test/tools/doclint/tidy/AAA.java + test/tools/doclint/tool/AAA.java Changeset: 385828dd5604 Author: jjg Date: 2013-01-22 19:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/385828dd5604 Merge Changeset: 97bd5e7151bc Author: mcimadamore Date: 2013-01-23 15:08 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8006692/T8006692.java Changeset: 5c956be64b9e Author: vromero Date: 2013-01-23 20:57 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! test/Makefile ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 71f35e4b93a5 Author: jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mernst at cs.washington.edu, wmdietl at cs.washington.edu, mpapi at csail.mit.edu, mahmood at notnoop.com + src/share/classes/com/sun/javadoc/AnnotatedType.java ! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java ! src/share/classes/com/sun/javadoc/Type.java ! src/share/classes/com/sun/javadoc/TypeVariable.java + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java + src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java + src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! src/share/classes/javax/lang/model/SourceVersion.java + src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java + test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java + test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java + test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java + test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref ! test/tools/javac/T6873845.java + test/tools/javac/T6985181.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.java + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.out + test/tools/javac/annotations/typeAnnotations/InnerClass.java + test/tools/javac/annotations/typeAnnotations/MultipleTargets.java + test/tools/javac/annotations/typeAnnotations/TargetTypes.java + test/tools/javac/annotations/typeAnnotations/TypeParameterTarget.java + test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java + test/tools/javac/annotations/typeAnnotations/TypeUseTarget.java + test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java + test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java + test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java + test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java + test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java + test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java + test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out + test/tools/javac/annotations/typeAnnotations/failures/BadCast.java + test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out + test/tools/javac/annotations/typeAnnotations/failures/LintCast.java + test/tools/javac/annotations/typeAnnotations/failures/LintCast.out + test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.out + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/TypeAndField.java + test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.java + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.out + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.out + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.out + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.java + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.out + test/tools/javac/annotations/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/ConstructorTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Expressions.java + test/tools/javac/annotations/typeAnnotations/newlocations/Fields.java + test/tools/javac/annotations/typeAnnotations/newlocations/LocalVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodReturnType.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/newlocations/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/newlocations/Parameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Receivers.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out + test/tools/javac/annotations/typeAnnotations/newlocations/ResourceVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/Throws.java + test/tools/javac/annotations/typeAnnotations/newlocations/TopLevelBlocks.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java + test/tools/javac/annotations/typeAnnotations/newlocations/Wildcards.java + test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java ! test/tools/javac/api/EndPositions.java ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateStaticClass.java + test/tools/javac/diags/examples/IncorrectReceiverType.java + test/tools/javac/diags/examples/NoAnnotationsOnDotClass.java + test/tools/javac/diags/examples/ThisAsIdentifier.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/processing/6994946/SemanticErrorTest.2.out ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.ref ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java + test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.ref ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/tree/TreePosTest.java + test/tools/javac/treeannotests/AnnoTreeTests.java ! test/tools/javac/treeannotests/TestProcessor.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out + test/tools/javap/typeAnnotations/JSR175Annotations.java + test/tools/javap/typeAnnotations/NewArray.java + test/tools/javap/typeAnnotations/Presence.java + test/tools/javap/typeAnnotations/PresenceInner.java + test/tools/javap/typeAnnotations/T6855990.java + test/tools/javap/typeAnnotations/TypeCasts.java + test/tools/javap/typeAnnotations/Visibility.java + test/tools/javap/typeAnnotations/Wildcards.java Changeset: 09f65aad4759 Author: darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java Changeset: c2e11e2ec4a3 Author: lana Date: 2013-01-26 19:24 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/langtools/rev/c2e11e2ec4a3 Merge - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out From roger.riggs at oracle.com Thu Jan 31 20:15:05 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 01 Feb 2013 04:15:05 +0000 Subject: [threeten-dev] hg: threeten/threeten/jdk: 104 new changesets Message-ID: <20130201044435.EA78A47736@hg.openjdk.java.net> Changeset: 6d849e883c40 Author: yhuang Date: 2013-01-13 18:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6d849e883c40 7114053: [sq] Inproper tanslation for iso lanugage of Albanian Reviewed-by: naoto ! src/share/classes/sun/util/resources/sq/LocaleNames_sq.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 2de23975ee10 Author: yhuang Date: 2013-01-15 19:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/2de23975ee10 Merge Changeset: 68fc838d5e89 Author: yhuang Date: 2013-01-16 19:05 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/68fc838d5e89 Merge Changeset: 595baf3cc781 Author: yhuang Date: 2013-01-16 23:08 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/595baf3cc781 Merge Changeset: 478d8354285a Author: erikj Date: 2013-01-18 16:44 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/478d8354285a 8006567: jre/lib/applet missing from Mac JDK installation Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: 92d8880d5406 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/92d8880d5406 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip Reviewed-by: tbell ! makefiles/GensrcSwing.gmk Changeset: a9839ed93340 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a9839ed93340 Merge Changeset: 506bf3d23f06 Author: erikj Date: 2013-01-21 14:58 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/506bf3d23f06 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Reviewed-by: tbell ! makefiles/CopyFiles.gmk Changeset: 57d5d9544628 Author: erikj Date: 2013-01-22 09:01 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/57d5d9544628 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable Reviewed-by: dholmes, ohrstrom ! makefiles/GensrcX11Wrappers.gmk + src/solaris/classes/sun/awt/X11/generator/sizes.32 + src/solaris/classes/sun/awt/X11/generator/sizes.64 Changeset: ef592aceb40e Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ef592aceb40e Added tag jdk8-b74 for changeset 57d5d9544628 ! .hgtags Changeset: c6e8a518c3cd Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c6e8a518c3cd 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! make/docs/Makefile Changeset: c9308137ad9e Author: jjg Date: 2013-01-10 19:37 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c9308137ad9e Merge - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 86c563dc70ca Author: darcy Date: 2013-01-10 21:12 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/86c563dc70ca 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo Reviewed-by: jjg ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java Changeset: 0ca2e39a110d Author: alanb Date: 2013-01-11 12:27 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0ca2e39a110d 8005566: (fs) test/java/nio/file/Files/Misc.java failing (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! test/java/nio/file/Files/Misc.java Changeset: 7da291690aa0 Author: alanb Date: 2013-01-11 20:19 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7da291690aa0 8005978: shell tests need to use the $COMPILEJDK for javac, jar and other tools Reviewed-by: chegar ! test/ProblemList.txt ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/getEnclosingClass/build.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh ! test/java/lang/Thread/UncaughtExceptions.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/instrument/AppendToBootstrapClassPathSetUp.sh ! test/java/lang/instrument/AppendToClassPathSetUp.sh ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/MakeJAR.sh ! test/java/lang/instrument/MakeJAR2.sh ! test/java/lang/instrument/MakeJAR3.sh ! test/java/lang/instrument/MakeJAR4.sh ! test/java/lang/instrument/ManifestTest.sh ! test/java/lang/instrument/ParallelTransformerLoader.sh ! test/java/lang/instrument/PremainClass/NoPremainAgent.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineClassWithNativeMethod.sh ! test/java/lang/instrument/RedefineMethodAddInvoke.sh ! test/java/lang/instrument/RedefineSetUp.sh ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/charset/spi/basic.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Formatter/Basic.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/PrefsSpi.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/script/CommonSetup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/security/krb5/config/dns.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Oid/S11N.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/ClassPathWildCard.sh ! test/tools/launcher/MultipleJRE.sh Changeset: bc1f16f5566f Author: darcy Date: 2013-01-11 15:39 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bc1f16f5566f 7131459: [Fmt-De] DecimalFormat produces wrong format() results when close to a tie Reviewed-by: darcy Contributed-by: olivier.lagneau at oracle.com ! src/share/classes/java/text/DigitList.java ! src/share/classes/sun/misc/FloatingDecimal.java + test/java/text/Format/DecimalFormat/TieRoundingTest.java Changeset: 6f6246aced89 Author: sherman Date: 2013-01-11 22:43 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6f6246aced89 8005466: JAR file entry hash table uses too much memory (zlib_util.c) Summary: realign the fields of jzcell struct Reviewed-by: sherman Contributed-by: ioi.lam at oracle.com ! src/share/native/java/util/zip/zip_util.h Changeset: 8009c7e3899e Author: sherman Date: 2013-01-11 22:45 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8009c7e3899e Merge Changeset: 7db04ae3378f Author: chegar Date: 2013-01-13 22:09 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7db04ae3378f 8006153: HTTP protocol handler authenication should use Base64 API Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 1109bfff4e92 Author: dholmes Date: 2013-01-13 19:57 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1109bfff4e92 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seperate ReflectionData object to reduce dynamic footprint. Reviewed-by: dholmes, mchung, shade Contributed-by: Peter Levart ! src/share/classes/java/lang/Class.java Changeset: 1d7a6adf499f Author: naoto Date: 2013-01-14 11:09 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1d7a6adf499f 7162007: Clean up i18n related caches Reviewed-by: okutsu, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/zh/CollationData_zh_HK.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_HK.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/CollatorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + src/share/classes/sun/util/locale/provider/ResourceBundleBasedAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_SG.java ! src/share/classes/sun/util/resources/zh/LocaleNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_HK.java ! test/java/util/PluggableLocale/BreakIteratorProviderTest.java ! test/java/util/PluggableLocale/CollatorProviderTest.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/DateFormatProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/NumberFormatProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java Changeset: dcb64d498d5b Author: ksrini Date: 2013-01-14 15:46 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/dcb64d498d5b 8005252: pack200 should support MethodParameters Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/ProblemList.txt ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: edb7e34a0531 Author: xuelei Date: 2013-01-14 18:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/edb7e34a0531 8006265: Add test SSLEngineDeadlock.java to ProblemList Reviewed-by: weijun ! test/ProblemList.txt Changeset: a40052a54801 Author: uta Date: 2013-01-15 14:26 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a40052a54801 8005250: Downgrade normative references to ${java.home}/lib folder from Java client code. Summary: Javadoc was changed in accordance with CCC-8005250 request. Reviewed-by: alanb, amenkov ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/javax/imageio/spi/IIORegistry.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/swing/UIManager.java Changeset: 4b012af44f24 Author: chegar Date: 2013-01-15 11:44 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4b012af44f24 8005406: HTTP server implementation should use Base64 API Reviewed-by: khazra, alanb, chegar Contributed-by: Mark Sheppard ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java Changeset: 44d6cabc9a3f Author: robm Date: 2013-01-15 19:58 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/44d6cabc9a3f 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java Changeset: 9d8ef6174cfd Author: dl Date: 2013-01-16 10:14 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9d8ef6174cfd 8005926: Merge ThreadLocalRandom state into java.lang.Thread Reviewed-by: shade, chegar ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: a546d8897e0d Author: dl Date: 2013-01-16 12:09 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a546d8897e0d 8001666: Add lambda-compatible atomics and accumulators to the ActomicXXX classes Reviewed-by: dl, chegar, darcy, goetz Contributed-by: dl at cs.oswego.edu, chris.hegarty at oracle.com ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: c7d54f93d3e5 Author: juh Date: 2013-01-16 09:51 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c7d54f93d3e5 8005389: Backout fix for JDK-6500133 Reviewed-by: mullan ! src/share/classes/sun/security/x509/URIName.java ! test/sun/security/x509/URIName/Parse.java Changeset: f7f77bdf248b Author: juh Date: 2013-01-16 13:35 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f7f77bdf248b 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present Reviewed-by: mullan, weijun ! test/sun/security/x509/X509CRLImpl/Verify.java ! test/sun/security/x509/X509CertImpl/Verify.java Changeset: 9fed48caac80 Author: lana Date: 2013-01-16 12:07 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9fed48caac80 Merge Changeset: 787c7c1c210f Author: sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java ! test/ProblemList.txt Changeset: e8414d69692c Author: khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vitalyd at gmail.com, schlosna at gmail.com Reviewed-by: chegar ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java Changeset: 79fed1733d4a Author: jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number of ports in the reserved range Reviewed-by: mduigou ! test/java/rmi/testlibrary/TestLibrary.java Changeset: f88e963960ae Author: jzavgren Date: 2013-01-18 17:34 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c ! src/share/transport/socket/sysSocket.h ! src/solaris/transport/socket/socket_md.c ! src/windows/transport/socket/socket_md.c Changeset: 06da87777d0e Author: alanb Date: 2013-01-18 18:48 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/06da87777d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java Changeset: 33d0175ea8d9 Author: msheppar Date: 2013-01-19 08:39 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/33d0175ea8d9 8006568: HTTP protocol handler NLTM Authentication should use Base64 API Reviewed-by: chegar, alanb ! src/solaris/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! test/sun/net/www/protocol/http/ProxyTunnelServer.java Changeset: 78514544980d Author: lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Changeset: d3da0d29d7cd Author: lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: bb2ed83676d2 Author: chegar Date: 2013-01-20 09:37 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bb2ed83676d2 8006560: java/net/ipv6tests/B6521014.java fails intermittently Reviewed-by: khazra, wetmore ! test/java/net/ipv6tests/B6521014.java Changeset: 6ca6b6f07653 Author: okutsu Date: 2013-01-21 12:04 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/6ca6b6f07653 4745761: (cal) RFE: Support builder for constructing Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java + test/java/util/Calendar/Builder/BuilderTest.java ! test/java/util/Calendar/CalendarTypeTest.java Changeset: 3c1a440a1e12 Author: okutsu Date: 2013-01-21 15:41 +0900 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3c1a440a1e12 8004489: Add support for Minguo and Hijrah calendars to CalendarNameProvider SPI 8006509: Add more calendar symbol names from CLDR Reviewed-by: peytoia ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/util/Calendar/CldrFormatNamesTest.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: bb940b2107bd Author: juh Date: 2013-01-21 15:05 +0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bb940b2107bd 8006092: SecurityPermission: printIdentity doesn't exist Reviewed-by: weijun ! test/sun/security/tools/policytool/UpdatePermissions.html Changeset: f21a3c273fb2 Author: dl Date: 2013-01-21 13:50 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f21a3c273fb2 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder Reviewed-by: chegar, darcy, goetz ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java + src/share/classes/java/util/concurrent/atomic/DoubleAdder.java + src/share/classes/java/util/concurrent/atomic/LongAccumulator.java + src/share/classes/java/util/concurrent/atomic/LongAdder.java + src/share/classes/java/util/concurrent/atomic/Striped64.java + test/java/util/concurrent/atomic/DoubleAdderDemo.java + test/java/util/concurrent/atomic/LongAdderDemo.java Changeset: de30e46250c5 Author: lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java Changeset: 8b1857409159 Author: lana Date: 2013-01-20 23:38 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8b1857409159 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 7f4e3da76ec1 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7f4e3da76ec1 Merge Changeset: 8ee6d45348ba Author: vinnie Date: 2013-01-22 23:32 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/8ee6d45348ba 6263419: No way to clean the memory for a java.security.Key Reviewed-by: mullan ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java ! src/share/classes/javax/security/auth/Destroyable.java + test/javax/security/auth/Destroyable/KeyDestructionTest.java Changeset: c18f28312c49 Author: smarks Date: 2013-01-22 18:30 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c18f28312c49 8005646: TEST_BUG: java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves process running Reviewed-by: mchung ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/rmid.security.policy Changeset: 919afffa70b0 Author: sherman Date: 2013-01-22 20:59 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/919afffa70b0 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! make/docs/CORE_PKGS.gmk ! make/java/Makefile + make/java/time/Makefile ! make/jprt.properties ! make/sun/Makefile + make/sun/tzdb/Makefile ! make/tools/Makefile + make/tools/src/build/tools/tzdb/ChronoField.java + make/tools/src/build/tools/tzdb/DateTimeException.java + make/tools/src/build/tools/tzdb/LocalDate.java + make/tools/src/build/tools/tzdb/LocalDateTime.java + make/tools/src/build/tools/tzdb/LocalTime.java + make/tools/src/build/tools/tzdb/TimeDefinition.java + make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/tools/src/build/tools/tzdb/Utils.java + make/tools/src/build/tools/tzdb/ZoneOffset.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/tools/src/build/tools/tzdb/ZoneRules.java + make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java + make/tools/tzdb/Makefile ! makefiles/CreateJars.gmk + makefiles/GendataTZDB.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk + src/share/classes/java/time/Clock.java + src/share/classes/java/time/DateTimeException.java + src/share/classes/java/time/DayOfWeek.java + src/share/classes/java/time/Duration.java + src/share/classes/java/time/Instant.java + src/share/classes/java/time/LocalDate.java + src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/LocalTime.java + src/share/classes/java/time/Month.java + src/share/classes/java/time/Period.java + src/share/classes/java/time/PeriodParser.java + src/share/classes/java/time/Ser.java + src/share/classes/java/time/ZoneId.java + src/share/classes/java/time/ZoneOffset.java + src/share/classes/java/time/ZoneRegion.java + src/share/classes/java/time/ZonedDateTime.java + src/share/classes/java/time/calendar/ChronoDateImpl.java + src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahDate.java + src/share/classes/java/time/calendar/HijrahDeviationReader.java + src/share/classes/java/time/calendar/HijrahEra.java + src/share/classes/java/time/calendar/JapaneseChrono.java + src/share/classes/java/time/calendar/JapaneseDate.java + src/share/classes/java/time/calendar/JapaneseEra.java + src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoDate.java + src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendar/Ser.java + src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistDate.java + src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/format/DateTimeBuilder.java + src/share/classes/java/time/format/DateTimeFormatStyleProvider.java + src/share/classes/java/time/format/DateTimeFormatSymbols.java + src/share/classes/java/time/format/DateTimeFormatter.java + src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/DateTimeFormatters.java + src/share/classes/java/time/format/DateTimeParseContext.java + src/share/classes/java/time/format/DateTimeParseException.java + src/share/classes/java/time/format/DateTimePrintContext.java + src/share/classes/java/time/format/DateTimePrintException.java + src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/SignStyle.java + src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package-info.java + src/share/classes/java/time/overview.html + src/share/classes/java/time/package-info.java + src/share/classes/java/time/temporal/Adjusters.java + src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/temporal/ChronoField.java + src/share/classes/java/time/temporal/ChronoLocalDate.java + src/share/classes/java/time/temporal/ChronoLocalDateTime.java + src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/temporal/ChronoUnit.java + src/share/classes/java/time/temporal/ChronoZonedDateTime.java + src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/temporal/Era.java + src/share/classes/java/time/temporal/ISOChrono.java + src/share/classes/java/time/temporal/ISOEra.java + src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/JulianFields.java + src/share/classes/java/time/temporal/MonthDay.java + src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/temporal/OffsetDateTime.java + src/share/classes/java/time/temporal/OffsetTime.java + src/share/classes/java/time/temporal/Queries.java + src/share/classes/java/time/temporal/Ser.java + src/share/classes/java/time/temporal/SimplePeriod.java + src/share/classes/java/time/temporal/Temporal.java + src/share/classes/java/time/temporal/TemporalAccessor.java + src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalField.java + src/share/classes/java/time/temporal/TemporalQuery.java + src/share/classes/java/time/temporal/TemporalSubtractor.java + src/share/classes/java/time/temporal/TemporalUnit.java + src/share/classes/java/time/temporal/ValueRange.java + src/share/classes/java/time/temporal/WeekFields.java + src/share/classes/java/time/temporal/Year.java + src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java + src/share/classes/java/time/zone/Ser.java + src/share/classes/java/time/zone/TzdbZoneRulesProvider.java + src/share/classes/java/time/zone/ZoneOffsetTransition.java + src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java + src/share/classes/java/time/zone/ZoneRules.java + src/share/classes/java/time/zone/ZoneRulesException.java + src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package-info.java ! src/share/classes/java/util/Formatter.java ! test/Makefile + test/java/time/META-INF/services/java.time.temporal.Chrono + test/java/time/TEST.properties + test/java/time/tck/java/time/AbstractDateTimeTest.java + test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_Fixed.java + test/java/time/tck/java/time/TCKClock_Offset.java + test/java/time/tck/java/time/TCKClock_System.java + test/java/time/tck/java/time/TCKClock_Tick.java + test/java/time/tck/java/time/TCKDayOfWeek.java + test/java/time/tck/java/time/TCKDuration.java + test/java/time/tck/java/time/TCKInstant.java + test/java/time/tck/java/time/TCKLocalDate.java + test/java/time/tck/java/time/TCKLocalDateTime.java + test/java/time/tck/java/time/TCKLocalTime.java + test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKZoneId.java + test/java/time/tck/java/time/TCKZoneOffset.java + test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticDate.java + test/java/time/tck/java/time/calendar/CopticEra.java + test/java/time/tck/java/time/calendar/TestChronoLocalDate.java + test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java + test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestServiceLoader.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java + test/java/time/tck/java/time/format/TCKDateTimeFormatter.java + test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKDateTimeFormatters.java + test/java/time/tck/java/time/format/TCKDateTimePrintException.java + test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java + test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java + test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java + test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/TCKMonthDay.java + test/java/time/tck/java/time/temporal/TCKOffsetDate.java + test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/temporal/TCKOffsetTime.java + test/java/time/tck/java/time/temporal/TCKSimplePeriod.java + test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/TCKYear.java + test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/tck/java/time/temporal/TestChrono.java + test/java/time/tck/java/time/temporal/TestChronoLocalDate.java + test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java + test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java + test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/zone/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java + test/java/time/test/java/time/AbstractTest.java + test/java/time/test/java/time/MockSimplePeriod.java + test/java/time/test/java/time/TestClock_Fixed.java + test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_System.java + test/java/time/test/java/time/TestClock_Tick.java + test/java/time/test/java/time/TestDuration.java + test/java/time/test/java/time/TestInstant.java + test/java/time/test/java/time/TestLocalDate.java + test/java/time/test/java/time/TestLocalDateTime.java + test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/TestZoneOffset.java + test/java/time/test/java/time/TestZonedDateTime.java + test/java/time/test/java/time/format/AbstractTestPrinterParser.java + test/java/time/test/java/time/format/MockIOExceptionAppendable.java + test/java/time/test/java/time/format/TestCharLiteralParser.java + test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java + test/java/time/test/java/time/format/TestDateTimeFormatter.java + test/java/time/test/java/time/format/TestDateTimeFormatters.java + test/java/time/test/java/time/format/TestDateTimePrintException.java + test/java/time/test/java/time/format/TestDateTimeTextProvider.java + test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNumberParser.java + test/java/time/test/java/time/format/TestNumberPrinter.java + test/java/time/test/java/time/format/TestPadParserDecorator.java + test/java/time/test/java/time/format/TestPadPrinterDecorator.java + test/java/time/test/java/time/format/TestReducedParser.java + test/java/time/test/java/time/format/TestReducedPrinter.java + test/java/time/test/java/time/format/TestSettingsParser.java + test/java/time/test/java/time/format/TestStringLiteralParser.java + test/java/time/test/java/time/format/TestStringLiteralPrinter.java + test/java/time/test/java/time/format/TestTextParser.java + test/java/time/test/java/time/format/TestTextPrinter.java + test/java/time/test/java/time/format/TestZoneIdParser.java + test/java/time/test/java/time/format/TestZoneOffsetParser.java + test/java/time/test/java/time/format/TestZoneOffsetPrinter.java + test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/temporal/MockFieldNoValue.java + test/java/time/test/java/time/temporal/MockFieldValue.java + test/java/time/test/java/time/temporal/TestChronoUnit.java + test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java + test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java + test/java/time/test/java/time/temporal/TestDateTimeValueRange.java + test/java/time/test/java/time/temporal/TestISOChronoImpl.java + test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestMonthDay.java + test/java/time/test/java/time/temporal/TestOffsetDate.java + test/java/time/test/java/time/temporal/TestOffsetDateTime.java + test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java + test/java/time/test/java/time/temporal/TestOffsetTime.java + test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java + test/java/time/test/java/time/temporal/TestYear.java + test/java/time/test/java/time/temporal/TestYearMonth.java + test/java/time/test/java/time/zone/TestFixedZoneRules.java + test/java/time/test/java/util/TestFormatter.java Changeset: 71691b9d45ab Author: vinnie Date: 2013-01-23 09:49 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java Changeset: 01b36b400145 Author: uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb, anthony ! src/windows/native/java/lang/java_props_md.c Changeset: bf2a14ebb6e9 Author: chegar Date: 2013-01-23 14:45 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java Changeset: 53064bbaeec5 Author: alanb Date: 2013-01-23 15:12 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk Changeset: c9eb1d3ef37f Author: robm Date: 2013-01-23 17:54 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c9eb1d3ef37f 8004729: Add java.lang.reflect.Parameter and related changes for parameter reflection Reviewed-by: darcy, forax, psandoz, dholmes, tbell ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java + src/share/classes/java/lang/reflect/Parameter.java ! src/share/javavm/export/jvm.h + src/share/native/java/lang/reflect/Executable.c + test/java/lang/reflect/Parameter/WithParameters.java + test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e0552f13f4a2 Author: sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipFile/FinalizeZipFile.java Changeset: 87f5569effdd Author: sherman Date: 2013-01-23 10:31 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/87f5569effdd Merge Changeset: 0c86df653029 Author: vinnie Date: 2013-01-23 21:25 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/java/security/KeyStore/PBETest.java Changeset: 1da93663f8f3 Author: vinnie Date: 2013-01-23 23:13 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/pkcs12/StorePasswordTest.java + test/sun/security/pkcs12/StoreSecretKeyTest.java + test/sun/security/pkcs12/StoreTrustedCertTest.java + test/sun/security/pkcs12/trusted.pem Changeset: 89f37f7188df Author: mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: b68ac92d0b2a Author: alanb Date: 2013-01-24 09:47 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b68ac92d0b2a 8006524: JSR-3: Allows java.beans to be optional Reviewed-by: dfuchs, mchung ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/monitor/package.html Changeset: 943af87e0269 Author: vinnie Date: 2013-01-24 16:44 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/943af87e0269 8006855: PKCS12 test failures due to unsupported algorithm Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java Changeset: 1fd613016ad9 Author: ksrini Date: 2013-01-24 09:34 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1fd613016ad9 8006850: [pack200] disable pack200 tests until JSR-308 is implemented Reviewed-by: alanb ! test/ProblemList.txt Changeset: b3f0e0c79bcc Author: vinnie Date: 2013-01-24 18:21 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b3f0e0c79bcc 8006863: javadoc cleanup for 8005408 Reviewed-by: alanb ! src/share/classes/java/security/PKCS12Attribute.java Changeset: 4d3c05cc21d5 Author: darcy Date: 2013-01-24 16:54 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4d3c05cc21d5 8006895: Clarify that FunctionalInferface is only informative Reviewed-by: briangoetz ! src/share/classes/java/lang/FunctionalInterface.java Changeset: 4c9fcb5cbc07 Author: dingxmin Date: 2013-01-25 17:00 +0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4c9fcb5cbc07 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource() Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/sun/misc/URLClassPath/JarLoaderTest.java Changeset: 4a4b97f7f83b Author: alanb Date: 2013-01-25 13:09 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4a4b97f7f83b 8006565: java.lang.instrument specification should make it clear that -javaagent is optional Reviewed-by: sla, dcubed, mchung ! src/share/classes/java/lang/instrument/package.html Changeset: c6ea84a629db Author: vinnie Date: 2013-01-25 16:19 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/c6ea84a629db 8006946: PKCS12 test failure due to incorrect alias name Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 117491dd58c2 Author: vinnie Date: 2013-01-25 17:47 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/117491dd58c2 8006951: Avoid storing duplicate PKCS12 attributes Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 77bde15bc6a9 Author: khazra Date: 2013-01-25 11:52 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/77bde15bc6a9 7017962: Obsolete link is used in URL class level spec Summary: Change the link to an archived document Reviewed-by: chegar, mduigou ! src/share/classes/java/net/URL.java Changeset: 4209b3936a7f Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4209b3936a7f 8005632: Extend java.util.Logger to use Supplier for messages Reviewed-by: briangoetz, mduigou Contributed-by: henry.jen at oracle.com ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerSupplierAPIsTest.java Changeset: 1d918647332e Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1d918647332e 8004201: Add static utility methods to primitives to be used for redution operations. Reviewed-by: darcy, mduigou, briangoetz, dholmes Contributed-by: akhil.arora at oracle.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java + test/java/lang/PrimitiveSumMinMaxTest.java Changeset: 86a5b435c928 Author: jgish Date: 2013-01-22 11:14 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/86a5b435c928 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java Changeset: e96577d82cbb Author: alanb Date: 2013-01-26 16:57 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e96577d82cbb 8006503: JVM_PrintStackTrace is not used in JDK Reviewed-by: alanb, darcy Contributed-by: eric.mccorkle at oracle.com ! src/share/javavm/export/jvm.h Changeset: 57561ea851d2 Author: lana Date: 2013-01-26 19:22 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/57561ea851d2 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 4faaaf5027a5 Author: alexsch Date: 2013-01-14 08:32 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4faaaf5027a5 7166409: bug4331515.java fail with NullPointerException on ubuntu10.04-x86 for JDK8 Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java Changeset: 9c6ca265b4a1 Author: alexsch Date: 2013-01-15 12:49 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9c6ca265b4a1 8003978: closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx Reviewed-by: serb, leonidr ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/sun/swing/SwingUtilities2.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java Changeset: 1b886bd5e5bf Author: serb Date: 2013-01-15 21:57 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/1b886bd5e5bf 7124525: [macosx] No animation on certain Swing components in Aqua LaF Reviewed-by: alexsch, swingler ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/classes/com/apple/laf/ImageCache.java Changeset: 7ea1372be2fe Author: mcherkas Date: 2013-01-16 17:26 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7ea1372be2fe 8005492: Reduce number of warnings in sun/awt/* classes Reviewed-by: art, anthony ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/sun/awt/image/SurfaceManager.java Changeset: 23f9955ae34a Author: lana Date: 2013-01-16 15:57 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/23f9955ae34a Merge Changeset: 47243a4efb8b Author: kshefov Date: 2013-01-17 15:08 +0000 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/47243a4efb8b 7124209: [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] Reviewed-by: serb, alexsch + test/javax/swing/SpringLayout/4726194/bug4726194.java Changeset: 035f87fc9f74 Author: anthony Date: 2013-01-18 14:17 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/035f87fc9f74 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Summary: Allow one to start AWT on the main thread w/o exceptions Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 5309fed435b5 Author: serb Date: 2013-01-18 18:17 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/5309fed435b5 7179050: [macosx] Make LWAWT be able to run on AppKit thread Summary: Removed irrelevant assertions from the LWAWT native methods Reviewed-by: serb, anthony Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/ApplicationDelegate.m ! src/macosx/native/sun/awt/CClipboard.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CDesktopPeer.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! src/macosx/native/sun/awt/CImage.m ! src/macosx/native/sun/awt/CInputMethod.m ! src/macosx/native/sun/awt/CMenu.m ! src/macosx/native/sun/awt/CMenuComponent.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/CPopupMenu.m ! src/macosx/native/sun/awt/CTrayIcon.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/JavaComponentAccessibility.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: 112c08b41ca2 Author: alitvinov Date: 2013-01-18 18:34 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/112c08b41ca2 8006417: JComboBox.showPopup(), hidePopup() fails in JRE 1.7 on OS X Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/javax/swing/JComboBox/ShowPopupAfterHidePopupTest/ShowPopupAfterHidePopupTest.java Changeset: b4131358120a Author: raginip Date: 2013-01-18 11:33 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/b4131358120a 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk Changeset: f55d869052dd Author: alexsch Date: 2013-01-21 17:55 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f55d869052dd 8004298: NPE in WindowsTreeUI.ensureRowsAreVisible Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java + test/javax/swing/JTree/8004298/bug8004298.java Changeset: dd7e1cc4253c Author: alexp Date: 2013-01-24 15:26 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/dd7e1cc4253c 7147078: [macosx] Echo char set in TextField doesn't prevent word jumping Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 04d2005fa178 Author: alexp Date: 2013-01-24 15:52 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/04d2005fa178 7132793: [macosx] setWheelScrollEnabled action reversed Reviewed-by: serb, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWScrollPanePeer.java Changeset: 40a45a72a120 Author: serb Date: 2013-01-24 15:55 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/40a45a72a120 8005997: [macosx] Printer Dialog opens an additional title bar Reviewed-by: anthony, art Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: fab11b21ee6e Author: kizune Date: 2013-01-24 16:09 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/fab11b21ee6e 7143768: [macosx] Unexpected NullPointerException and java.io.IOException during DnD Reviewed-by: alexp ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java Changeset: 7dd1896b37c8 Author: malenkov Date: 2013-01-24 17:26 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7dd1896b37c8 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser Reviewed-by: alexsch ! src/share/classes/sun/swing/WindowsPlacesBar.java + test/javax/swing/JFileChooser/6817933/Test6817933.java Changeset: f8526b99b825 Author: serb Date: 2013-01-24 17:50 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f8526b99b825 8003173: [macosx] Fullscreen on Mac leaves an empty rectangle Reviewed-by: anthony, alexsch ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java Changeset: 32721a1a8da8 Author: malenkov Date: 2013-01-24 17:57 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/32721a1a8da8 8005138: test/java/beans/Introspector/TestTypeResolver.java fails Reviewed-by: alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 7cda96a78260 Author: malenkov Date: 2013-01-24 18:06 +0400 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/7cda96a78260 8003400: JTree scrolling problem when using large model in WindowsLookAndFeel Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003400/Test8003400.java Changeset: e616c28c5120 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e616c28c5120 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: a1a55db02f34 Author: lana Date: 2013-01-29 20:19 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/a1a55db02f34 Merge ! makefiles/CreateJars.gmk Changeset: 9d5c43050210 Author: dl Date: 2013-01-11 16:50 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/9d5c43050210 8006123: Support @Contended Annotation - JEP 142 (jdk part) Summary: jdk changes for 8003895. Reviewed-by: darcy, jrose, coleenp, dholmes, kvn Contributed-by: Aleksey Shipilev + src/share/classes/sun/misc/Contended.java Changeset: 739351a0a7a1 Author: kvn Date: 2013-01-23 11:47 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/739351a0a7a1 8006799: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() (jdk part of 6896617) Summary: Move hot loop in ISO_8859_1$Encode.encodeArrayLoop() into separate method encodeISOArray() to be replaced by JVM JIT compiler with optimized intrinsic code. Reviewed-by: alanb, sherman ! src/share/classes/sun/nio/cs/ISO_8859_1.java Changeset: e9d00d30fcca Author: amurillo Date: 2013-01-25 03:02 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/e9d00d30fcca Merge Changeset: ac286bf65242 Author: amurillo Date: 2013-01-30 10:18 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/ac286bf65242 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: 3c499051a5df Author: erikj Date: 2013-01-29 16:35 +0100 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/3c499051a5df 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Reviewed-by: alanb, tbell ! makefiles/CopyFiles.gmk Changeset: 4a67fdb752b7 Author: katleman Date: 2013-01-30 13:04 -0800 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/4a67fdb752b7 Merge ! makefiles/CopyFiles.gmk Changeset: 44873dba5470 Author: rriggs Date: 2013-01-31 22:31 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/44873dba5470 Merge ! .hgtags ! make/docs/CORE_PKGS.gmk ! make/java/time/Makefile ! make/netbeans/threeten/build.xml ! make/sun/tzdb/Makefile ! make/tools/Makefile ! make/tools/src/build/tools/tzdb/LocalDate.java ! make/tools/src/build/tools/tzdb/LocalDateTime.java ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! make/tools/src/build/tools/tzdb/Utils.java ! make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java ! make/tools/src/build/tools/tzdb/ZoneRules.java ! make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java ! makefiles/GendataTZDB.gmk ! makefiles/Tools.gmk ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/PeriodParser.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/calendars/ChronoDateImpl.java ! src/share/classes/java/time/calendars/HijrahChronology.java ! src/share/classes/java/time/calendars/HijrahDate.java ! src/share/classes/java/time/calendars/HijrahDeviationReader.java ! src/share/classes/java/time/calendars/HijrahEra.java ! src/share/classes/java/time/calendars/JapaneseChronology.java ! src/share/classes/java/time/calendars/JapaneseDate.java ! src/share/classes/java/time/calendars/JapaneseEra.java ! src/share/classes/java/time/calendars/MinguoChronology.java ! src/share/classes/java/time/calendars/MinguoDate.java ! src/share/classes/java/time/calendars/MinguoEra.java ! src/share/classes/java/time/calendars/Ser.java ! src/share/classes/java/time/calendars/ThaiBuddhistChronology.java ! src/share/classes/java/time/calendars/ThaiBuddhistDate.java ! src/share/classes/java/time/calendars/ThaiBuddhistEra.java ! src/share/classes/java/time/calendars/package-info.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java ! src/share/classes/java/time/temporal/Adjusters.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Queries.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/time/zone/package-info.java ! src/share/classes/java/util/Formatter.java ! test/Makefile - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/time/META-INF/services/java.time.chrono.Chronology ! test/java/time/TEST.properties ! test/java/time/tck/java/time/AbstractDateTimeTest.java ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/TCKClock.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/TestChronology.java ! test/java/time/tck/java/time/TestIsoChronology.java ! test/java/time/tck/java/time/calendars/CopticChronology.java ! test/java/time/tck/java/time/calendars/CopticDate.java ! test/java/time/tck/java/time/calendars/CopticEra.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDate.java ! test/java/time/tck/java/time/calendars/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/calendars/TestHijrahChronology.java ! test/java/time/tck/java/time/calendars/TestJapaneseChronology.java ! test/java/time/tck/java/time/calendars/TestMinguoChronology.java ! test/java/time/tck/java/time/calendars/TestServiceLoader.java ! test/java/time/tck/java/time/calendars/TestThaiBuddhistChronology.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java ! test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java ! test/java/time/test/java/time/AbstractTest.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/TestClock_Fixed.java ! test/java/time/test/java/time/TestClock_Offset.java ! test/java/time/test/java/time/TestClock_System.java ! test/java/time/test/java/time/TestClock_Tick.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/TestInstant.java ! test/java/time/test/java/time/TestLocalDate.java ! test/java/time/test/java/time/TestLocalDateTime.java ! test/java/time/test/java/time/TestLocalTime.java ! test/java/time/test/java/time/TestMonthDay.java ! test/java/time/test/java/time/TestOffsetDateTime.java ! test/java/time/test/java/time/TestOffsetDateTime_instants.java ! test/java/time/test/java/time/TestOffsetTime.java ! test/java/time/test/java/time/TestPeriod.java ! test/java/time/test/java/time/TestPeriodParser.java ! test/java/time/test/java/time/TestYear.java ! test/java/time/test/java/time/TestYearMonth.java ! test/java/time/test/java/time/TestZoneId.java ! test/java/time/test/java/time/TestZoneOffset.java ! test/java/time/test/java/time/TestZonedDateTime.java ! test/java/time/test/java/time/chrono/TestIsoChronoImpl.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestCharLiteralPrinter.java ! test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestStringLiteralPrinter.java ! test/java/time/test/java/time/format/TestTextParser.java ! test/java/time/test/java/time/format/TestTextPrinter.java ! test/java/time/test/java/time/format/TestZoneIdParser.java ! test/java/time/test/java/time/format/TestZoneOffsetParser.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java ! test/java/time/test/java/time/temporal/TestChronoUnit.java ! test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java ! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java ! test/java/time/test/java/time/zone/TestFixedZoneRules.java ! test/java/time/test/java/util/TestFormatter.java Changeset: f501137e4bbf Author: rriggs Date: 2013-01-31 23:08 -0500 URL: http://hg.openjdk.java.net/threeten/threeten/jdk/rev/f501137e4bbf Merge ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java - test/java/time/test/java/time/format/TestPadParserDecorator.java From Roger.Riggs at Oracle.com Thu Jan 31 21:08:06 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Fri, 01 Feb 2013 00:08:06 -0500 Subject: [threeten-dev] Threeten repository resync'ed with JDK8 Message-ID: <510B4DB6.1040002@Oracle.com> Hi, The Threeten repository has been updated with the updates from the JDK8 repositories. I have not had a chance to do an incremental build but with changes from every component a clean build is recommended. The top level get_source.sh script will pull in all the updates. I'd recommend re-running configure and then make. The compiler and runtime should support static methods in interfaces. Roger