[threeten-dev] Review fixes for issue #192
Michael Nascimento
misterm at gmail.com
Wed Jan 2 12:49:17 PST 2013
LGTM.
Unrelated style question: why do we use public for default methods in
interfaces but don't use public for non-default ones?
Regards,
Michael
On Wed, Jan 2, 2013 at 6:30 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Please review fixes for https://github.com/ThreeTen/threeten/issues/192
>
> Added minimal javadoc to trigger the inclusion of the @throws javadoc
> in classes that inherit documentation from interfaces.
>
> Fixed a couple of typos, missing @Overrides and added TODO's about
> missing spec's for what fields are needed to make some computations work.
>
> http://cr.openjdk.java.net/~rriggs/webrev-exceptions/
>
> --
> Thanks, Roger
>
> Oracle Java Platform Group
>
> Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
> developing practices and products that help protect the environment
>
More information about the threeten-dev
mailing list