[threeten-dev] Review for #198 Chrono Initialization and Service Loader

[Roger Riggs]

The Webrev has been updated:
http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/ 
<http://cr.openjdk.java.net/%7Erriggs/webrev-serviceloader/>

The choice about whether the extra calendars are loaded with the 
ServiceLoader
is not yet resolved.  For now, the code treats the calendars as built-in.
We can switch later when the choice has been made.

Roger



On 1/9/2013 1:42 PM, Roger Riggs wrote:
> ok, I'll use the ServiceLoader for all but ISOChrono so the 
> profiles/modularity work is easier.
>
> Roger
>
>
> On 1/9/2013 12:12 PM, Stephen Colebourne wrote:
>> You are hard coding the registration of alternate calendar systems, 
>> but surely that won't work in an embeded environment?
>>
>> I would write the constructors with no code as having {} on two lines.
>>
>> Stephen
>>
>>
>>
>> On 9 January 2013 17:03, Roger Riggs <Roger.Riggs at oracle.com 
>> <mailto:Roger.Riggs at oracle.com>> wrote:
>>
>>     Please review this fix for the issue with Chronology
>>     initialization and the ServiceLoader.
>>
>>     http://cr.openjdk.java.net/~rriggs/webrev-serviceloader/
>>     <http://cr.openjdk.java.net/%7Erriggs/webrev-serviceloader/>
>>
>>     The initialization of the lists of Chronologies is deferred until
>>     it is needed
>>     for the list of available Chronologies or to get a Chronology by
>>     name.
>>
>>     The change exposed an issue with caching calendars that may be
>>     thread context
>>     specific which is not yet resolved. To support extended Calendars
>>     from application specific
>>     classloaders, caching should be limited to those in the
>>     bootclassloader.
>>     Additional code will be needed in the Chrono.of() and
>>     Chrono.getAvailableChronologies()
>>     methods to use the Thread's context and look for additional
>>     Chronologies.
>>     For client runtimes, this may be not necessary or useful but for
>>     server use
>>     the application server runtime may need to be able to support
>>     application specific
>>     calendar implementations.
>>
>>     Tests for the serviceloader and extensible calendars have been
>>     added using the
>>     Coptic calendar as a test calendar.
>>
>>     Opinions?
>>
>>     -- 
>>     Thanks, Roger
>>
>>     Oracle Java Platform Group
>>
>>     Green Oracle <http://www.oracle.com/commitment> Oracle is
>>     committed to developing practices and products that help protect
>>     the environment
>>
>>
>>     ------------------------------------------------------------------------------
>>     Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript,
>>     jQuery
>>     and much more. Keep your Java skills current with LearnJavaNow -
>>     200+ hours of step-by-step video tutorials by Java experts.
>>     SALE $49.99 this month only -- learn more at:
>>     http://p.sf.net/sfu/learnmore_122612
>>     _______________________________________________
>>     threeten-develop mailing list
>>     threeten-develop at lists.sourceforge.net
>>     <mailto:threeten-develop at lists.sourceforge.net>
>>     https://lists.sourceforge.net/lists/listinfo/threeten-develop
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
>> and much more. Keep your Java skills current with LearnJavaNow -
>> 200+ hours of step-by-step video tutorials by Java experts.
>> SALE $49.99 this month only -- learn more at:
>> http://p.sf.net/sfu/learnmore_122612  
>>
>>
>> _______________________________________________
>> threeten-develop mailing list
>> threeten-develop at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>
> -- 
> Thanks, Roger
>
> Oracle Java Platform Group
>
> Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
> developing practices and products that help protect the environment
>

-- 
Thanks, Roger

Oracle Java Platform Group

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment