[threeten-dev] zidtext parser
Stephen Colebourne
scolebourne at joda.org
Mon Jan 14 02:24:27 PST 2013
On 14 January 2013 00:36, Xueming Shen <xueming.shen at oracle.com> wrote:
> I don't see the necessity of exposing the metazone info to the users, at
> least for now.
> It's a combination of the alias/link from the tzdb and the metazone from
> the cldr. I would expect we will/should get the metazone from the utility
> class we currently get those zone name info (the jdk cldr code currently
> reads metaZone.xml already, just need to read a little more). It's hard
> coded for now simply because I can't get it from those utilities. It's
> tricky
> to handle the alias/link info. It's in the tzdb already, just need a way to
> access it via the provider.
I have debated whether the alias should be publicly visible. I decided
most users don't care which is the "correct" version of an alised zone
ID. If you need to expose it in the provider, that is fine by me.
> Another issue is getAvailableZoneId(). We are not using the "size" to
> decide whether or not there is no ids installed. Does it have to return
> a "modified" map? It just appears to be too expensive to invoke this
> method everything we need to parse a zoneid.
It does not need to expose a modifiable map. If you change it to be an
immutable map, then you should ensure that all similar methods in the
same class behave in the same way.
Stephen
More information about the threeten-dev
mailing list