[threeten-dev] hg: threeten/threeten/jdk: 2 new changesets

[roger.riggs at oracle.com]

Changeset: 10297f08a70e
Author:    rriggs
Date:      2013-01-18 14:13 -0500
URL:       http://hg.openjdk.java.net/threeten/threeten/jdk/rev/10297f08a70e

Corrections to issues raised in the review

> - java/time/ZoneOffset.java
>
> Line 214: @SuppressWarnings("fallthrough")?
intentionally; warnings fixed with @SuppressWarnings

>
> - java/time/calendar/JapaneseChrono.java
>
> Line 166-172: How come it includes "Keio"? Isn't the era before "Meiji" "Seireki"?
Those resources are unused and should be removed.
The Era names are provided by the JapaneseEra class.

>
> - java/time/calendar/MinguoDate.java
>
> Is it OK to NOT serialize "isoDate"? JapaneseDate.java has @serial on this field.
The @serial and readObject in JapaneseDate is out of date,
the serialized form for all of ChronoLocalDates use writeReplace
to put an instance of "Ser" in the stream.


>
> - java/time/format/DateTimeFormatter.java
>
> Line 411: DateTimeException needs to be described, as it is thrown in this method.
added
>
> Line 486: The DateTimeException needs to be on @throws clause.
added

>
> - java/time/temporal/Chrono.java
>
> Line 102: "minguoDate" -> "thaiDate"
fixed
>
> Line 212: The comment is kind of cryptic. Looks like not "removing" but "registering"
Corrected.

! src/share/classes/java/time/ZoneOffset.java
! src/share/classes/java/time/calendar/JapaneseChrono.java
! src/share/classes/java/time/calendar/JapaneseDate.java
! src/share/classes/java/time/format/DateTimeFormatter.java
! src/share/classes/java/time/temporal/Chrono.java

Changeset: d1ca600668c7
Author:    rriggs
Date:      2013-01-18 14:23 -0500
URL:       http://hg.openjdk.java.net/threeten/threeten/jdk/rev/d1ca600668c7

Merge

! src/share/classes/java/time/ZoneOffset.java
! src/share/classes/java/time/calendar/JapaneseChrono.java
! src/share/classes/java/time/calendar/JapaneseDate.java
! src/share/classes/java/time/format/DateTimeFormatter.java
! src/share/classes/java/time/temporal/Chrono.java