[threeten-dev] tzdb compiler on boot-jdk

[Stephen Colebourne]

Looks like your last webrev doesn't show files as being moved, just
deleted and re-created.
Otherwise, I've no problems with pushing if the functionality matches,
although I am sad to lose the leap seconds.
Stephen

On 18 January 2013 20:39, Xueming Shen <xueming.shen at oracle.com> wrote:
> webrev has been updated, with some minor changes. Fully tested,
> ready to go.
>
> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2
>
> -sherman
>
>
> On 01/18/2013 12:09 PM, Xueming Shen wrote:
>>
>> A simple TzdbDiff tzdb1.jar tzdb2.jar suggests the tzdb.jar generated
>> by the new version matches the previous one. So I'm confident now
>> to go:-)
>>
>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/TzdbDiff.java
>>
>> -Sherman
>>
>> On 01/18/2013 10:32 AM, Xueming Shen wrote:
>>>
>>> Yes, they can be further consolidated, if given more time:-)
>>>
>>> On 01/18/2013 10:08 AM, Stephen Colebourne wrote:
>>>>
>>>> This looks like a reasonable approach. Ultimately, these classes could
>>>> be slimmed down more, but that isn't vital now.
>>>> Stephen
>>>>
>>>> On 18 January 2013 17:51, Xueming Shen<xueming.shen at oracle.com>  wrote:
>>>>>
>>>>> Current approach to build tzdb data is a no-go from build and embedded
>>>>> team.
>>>>>
>>>>> Here is the webrev that to have the tzdb compiler works with a set of
>>>>> strip-down
>>>>> JSR310 class to generate the tzdb.jar on the boot_jdk, which is assumed
>>>>> to
>>>>> be
>>>>> a early jdk release that does not have any jdk8 feature. I also remove
>>>>> the
>>>>> leak
>>>>> second from tool and the date.
>>>>>
>>>>> The code probably need further clean-up.  But I will spend most of the
>>>>> time
>>>>> today
>>>>> to make sure the correctness of the output (the tests are all past, but
>>>>> I
>>>>> will verify
>>>>> the output is identical to the output from the "normal" version)
>>>>>
>>>>> http://cr.openjdk.java.net/~sherman/jdk8_threeten/tzdb_v2/
>>>>>
>>>>> -Sherman
>>>
>>>
>>
>