[threeten-dev] Please help to review new test code for java.time.Period

Patrick Zhang patrick.zhang at oracle.com
Sat Jan 19 22:31:44 PST 2013


Hi Team,

Please help to review below new added test case:
http://cr.openjdk.java.net/~sherman/jdk8_threeten/patrick/period/webrev/test/java/time/test/java/time/TestPeriod.java.udiff.html

Description:
1. Use minusYears(amount) to rewrite existing test about minus(amout, 
YEARS). plusYears(amout) has been covered and we do not touch it. And we 
do same thing to other TemporalUnit, for example, MONTHS, DAYS, HOURS, 
MINUTES, SECONDS and NANOS.
Then below missed methods are covered:
minusYears(amount)
minusMonths(amount)
minusDays(amount)
minusHourss(amount)
minusMinutess(amount)
minusSeconds(amount)
minusNanos(amount)

2. Add one new data provider and related test case for toDateOnly() and 
toTimeOnly().

Regards
Patrick


More information about the threeten-dev mailing list