[threeten-dev] [threeten-develop] DateTimeFormatters factory consolidation #210

[Stephen Colebourne]

On DateTimeFormatter you changed "This class is immutable and
thread-safe." to "All returned formatters are immutable and
thread-safe." In fact, both statements are true, but the first is
probably more true. (Given that SimpleDateFormat is not thread-safe,
this one is important to get right)

It might be worth having an inner class lazy load for some/all of the
constants. The RFC constant will be slow to create with its maps and
rarely used. The other constants might be better having their startup
delayed as well.

Rest of the change looks fine.

Stephen


On 28 January 2013 22:25, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Please review:
>
> webrev:
>     http://cr.openjdk.java.net/~rriggs/webrev-factory-210/
>
> javadoc:
>     http://cr.openjdk.java.net/~rriggs/javadoc-factory-210/
>
> The factory methods are merged from DateTimeFormatters to DateTimeFormatter
> and renamed as per conventions.
>
> Thanks, Roger
>
>
>
>
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnnow-d2d
> _______________________________________________
> threeten-develop mailing list
> threeten-develop at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/threeten-develop
>